makepkg-conf (#141)

Reviewed-on: #141
Co-authored-by: Artoo <artoo@artixlinux.org>
Co-committed-by: Artoo <artoo@artixlinux.org>

config/makepkg/x86_64.conf

@@ -43,17 +43,16 @@ CHOST="x86_64-pc-linux-gnu"
 CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security \
         -fstack-clash-protection -fcf-protection"
+        # -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer"
 CXXFLAGS="$CFLAGS -Wp,-D_GLIBCXX_ASSERTIONS"
 LDFLAGS="-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now \
          -Wl,-z,pack-relative-relocs"
 LTOFLAGS="-flto=auto"
-RUSTFLAGS=""
 #-- Make Flags: change this for DistCC/SMP systems
 #MAKEFLAGS="-j2"
 #-- Debugging flags
 DEBUG_CFLAGS="-g"
 DEBUG_CXXFLAGS="$DEBUG_CFLAGS"
-DEBUG_RUSTFLAGS="-C debuginfo=2"
 
 #########################################################################
 # BUILD ENVIRONMENT
@@ -82,7 +81,7 @@ BUILDENV=(!distcc color !ccache check !sign)
 #   These are default values for the options=() settings
 #########################################################################
 #
-# Makepkg defaults: OPTIONS=(!strip docs libtool staticlibs emptydirs !zipman !purge !debug !lto)
+# Makepkg defaults: OPTIONS=(!strip docs libtool staticlibs emptydirs !zipman !purge !debug !lto !autodeps)
 #  A negated option will do the opposite of the comments below.
 #
 #-- strip:      Strip symbols from binaries/libraries
@@ -94,6 +93,7 @@ BUILDENV=(!distcc color !ccache check !sign)
 #-- purge:      Remove files specified by PURGE_TARGETS
 #-- debug:      Add debugging flags as specified in DEBUG_* variables
 #-- lto:        Add compile flags for building with link time optimization
+#-- autodeps:   Automatically add depends/provides
 #
 OPTIONS=(strip docs !libtool !staticlibs emptydirs zipman purge !debug lto)
 
@@ -113,6 +113,8 @@ DOC_DIRS=(usr/{,local/}{,share/}{doc,gtk-doc} opt/*/{doc,gtk-doc})
 PURGE_TARGETS=(usr/{,share}/info/dir .packlist *.pod)
 #-- Directory to store source code in for debug packages
 DBGSRCDIR="/usr/src/debug"
+#-- Prefix and directories for library autodeps
+LIB_DIRS=('lib:usr/lib' 'lib32:usr/lib32')
 
 #########################################################################
 # PACKAGE OUTPUT

config/pacman/galaxy-goblins-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/galaxy-gremlins-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/galaxy-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/iso-goblins-x86_64.conf

@@ -35,6 +35,8 @@ Color
 CheckSpace
 VerbosePkgLists
 ParallelDownloads = 10
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/iso-gremlins-x86_64.conf

@@ -35,6 +35,8 @@ Color
 CheckSpace
 VerbosePkgLists
 ParallelDownloads = 10
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/iso-x86_64.conf

@@ -35,6 +35,8 @@ Color
 CheckSpace
 VerbosePkgLists
 ParallelDownloads = 10
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/lib32-goblins-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/lib32-gremlins-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/lib32-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/system-goblins-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/system-gremlins-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/system-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/world-goblins-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/world-gremlins-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

config/pacman/world-x86_64.conf

@@ -36,6 +36,8 @@ NoProgressBar
 #CheckSpace
 VerbosePkgLists
 ParallelDownloads = 5
+DownloadUser = alpm
+#DisableSandbox
 
 # By default, pacman accepts packages signed by keys that its local keyring
 # trusts (see pacman-key and its man page), as well as unsigned packages.

contrib/completion/bash/artixpkg.in

@@ -8,6 +8,14 @@ _artixpkg_pkgbase() {
     ls -1 "${TREE_DIR_ARTIX}" | tr '\n' ' '
 }
 
+_artixpkg_remotepkgbase() {
+    curl -s "https://checkupdates.artixlinux.org/api/1.0/packages?startswith=$1"
+}
+
+_artixpkg_maintainers() {
+    curl -s "https://checkupdates.artixlinux.org/api/1.0/maintainers"
+}
+
 _artixpkg_completion() {
     local cur prev comps comps_all repos autorepos teams agents cwords comp_cword_exflag
     source "${LIBDIR}"/pkg/db/db.sh 2>/dev/null
@@ -147,12 +155,15 @@ _artixpkg_completion() {
                         "-t"|"--team")
                             COMPREPLY=($(compgen -W "$teams" -- ${cur}))
                             ;;
-                        "-m"|"--maintainer"|"-s"|"--search"|"-t"|"--team"|"-j"|"--jobs")
+                        "-m"|"--maintainer")
+                            COMPREPLY=($(compgen -W "$(_artixpkg_maintainers)" -- ${cur}))
+                            ;;
+                        "-s"|"--search"|"-j"|"--jobs")
                             # these flags expect a parameter
                             COMPREPLY=()
                             ;;
                         *)
-                            COMPREPLY=($(compgen -W "-m --maintainer --protocol -s --search -t --team -a --agent -j --jobs --all -h --help" -- ${cur}))
+                            COMPREPLY=($(compgen -W "-m --maintainer --protocol -s --search -t --team -a --agent -j --jobs --all -h --help $(_artixpkg_remotepkgbase ${cur})" -- ${cur}))
                             ;;
                     esac
                     ;;
@@ -185,7 +196,10 @@ _artixpkg_completion() {
                     ;;
                 "artixpkg git pull"*)
                     case "${prev}" in
-                        "-t"|"--topic"|"-m"|"--maintainer"|"-j"|"--jobs")
+                        "-m"|"--maintainer")
+                            COMPREPLY=($(compgen -W "$(_artixpkg_maintainers)" -- ${cur}))
+                            ;;
+                        "-t"|"--topic"|"-j"|"--jobs")
                             # these flags expect a parameter
                             COMPREPLY=()
                             ;;
@@ -203,7 +217,10 @@ _artixpkg_completion() {
                     ;;
                 "artixpkg git push"*)
                     case "${prev}" in
-                        "-m"|"--maintainer"|"-t"|"--topic"|"-j"|"--jobs")
+                        "-m"|"--maintainer")
+                            COMPREPLY=($(compgen -W "$(_artixpkg_maintainers)" -- ${cur}))
+                            ;;
+                        "-t"|"--topic"|"-j"|"--jobs")
                             # this flag expects a parameter
                             COMPREPLY=()
                             ;;
@@ -234,7 +251,10 @@ _artixpkg_completion() {
                     ;;
                 "artixpkg admin query"*)
                     case "${prev}" in
-                        "-m"|"--maintainer"|"-t"|"--topic")
+                        "-m"|"--maintainer")
+                            COMPREPLY=($(compgen -W "$(_artixpkg_maintainers)" -- ${cur}))
+                            ;;
+                        "-t"|"--topic")
                             # this flag expects a parameter
                             COMPREPLY=()
                             ;;

src/lib/pkg/admin/maintainer.sh

@@ -5,8 +5,6 @@
 [[ -z ${ARTOOLS_INCLUDE_ADMIN_MAINTAINER_SH:-} ]] || return 0
 ARTOOLS_INCLUDE_ADMIN_MAINTAINER_SH=1
 
-# shellcheck source=src/lib/pkg/packager.sh
-source "${LIBDIR}"/pkg/packager.sh
 
 set -e
 
@@ -81,7 +79,9 @@ artixpkg_admin_maintainer() {
 
     pkgbases+=("$@")
 
-    load_makepkg_config
+    # shellcheck source=src/lib/pkg/packager.sh
+    source "${LIBDIR}"/pkg/packager.sh
+
     if [[ -n ${PACKAGER} ]]; then
         if ! packager_name=$(get_packager_name "${PACKAGER}") || \
             ! packager_email=$(get_packager_email "${PACKAGER}"); then
@@ -90,9 +90,11 @@ artixpkg_admin_maintainer() {
         if ! is_packager_name_valid "${packager_name}"; then
             die "invalid PACKAGER '${PACKAGER}' in makepkg.conf"
         fi
+        if is_packager_email_official "${packager_email}"; then
+            maintainer="maintainer-${packager_name}"
+        fi
     fi
 
-    maintainer="maintainer-${packager_name}"
 
     if [[ -n ${GIT_TOKEN} ]]; then
 

src/lib/pkg/git/config.sh

@@ -5,9 +5,6 @@
 [[ -z ${ARTOOLS_INCLUDE_GIT_CONFIG_SH:-} ]] || return 0
 ARTOOLS_INCLUDE_GIT_CONFIG_SH=1
 
-# shellcheck source=src/lib/pkg/packager.sh
-source "${LIBDIR}"/pkg/packager.sh
-
 set -e
 
 
@@ -91,8 +88,10 @@ artixpkg_git_config() {
 
     # Load makepkg.conf variables to be available for packager identity
     msg "Collecting packager identity from makepkg.conf"
-    # shellcheck source=config/makepkg/x86_64.conf
+
-    load_makepkg_config
+    # shellcheck source=src/lib/pkg/packager.sh
+    source "${LIBDIR}"/pkg/packager.sh
+
     if [[ -n ${PACKAGER} ]]; then
         if ! packager_name=$(get_packager_name "${PACKAGER}") || \
             ! packager_email=$(get_packager_email "${PACKAGER}"); then

src/lib/pkg/git/push.sh

@@ -16,14 +16,12 @@ artixpkg_git_push_usage() {
     OPTIONS
         -m, --maintainer NAME      Push all packages of the named maintainer
         -t, --topic NAME           Push all packages of the named topic
-        -j, --jobs N               Run up to N jobs in parallel (default: $(nproc))
         -h, --help                 Show this help text
 
     EXAMPLES
         $ ${COMMAND} libfoo linux libbar
         $ ${COMMAND} --maintainer tux
         $ ${COMMAND} --topic mytopic
-        $ ${COMMAND} -j 8 --topic mytopic
 _EOF_
 }
 
@@ -38,11 +36,6 @@ artixpkg_git_push() {
     # options
     local MAINTAINER=
     local TOPIC=
-    local CONFIGURE_OPTIONS=()
-    local jobs=
-    jobs=$(nproc)
-
-    local command=${_ARTOOLS_COMMAND:-${BASH_SOURCE[0]##*/}}
 
     while (( $# )); do
         case $1 in
@@ -60,11 +53,6 @@ artixpkg_git_push() {
                 TOPIC="$2"
                 shift 2
             ;;
-            -j|--jobs)
-                (( $# <= 1 )) && die "missing argument for %s" "$1"
-                jobs=$2
-                shift 2
-            ;;
             --)
                 shift
                 break
@@ -90,19 +78,6 @@ artixpkg_git_push() {
         mapfile -t pkgbases < <(search_topic "${TOPIC}" | yq -P -r '.data | .[].name' | sort)
     fi
 
-    # parallelization
-    if [[ ${jobs} != 1 ]] && (( ${#pkgbases[@]} > 1 )); then
-        # force colors in parallel if parent process is colorized
-        if [[ -n ${BOLD} ]]; then
-            export ARTOOLS_COLOR=always
-        fi
-        if ! parallel --bar --jobs "${jobs}" "${command}" ::: "${pkgbases[@]}"; then
-            die 'Failed to push some packages, please check the output'
-            exit 1
-        fi
-        exit 0
-    fi
-
     for pkgbase in "${pkgbases[@]}"; do
         if [[ -d ${pkgbase} ]]; then
             ( cd "${pkgbase}" || return

src/lib/pkg/packager.sh

@@ -49,3 +49,6 @@ is_packager_email_official() {
     fi
     return 1
 }
+
+# shellcheck source=config/makepkg/x86_64.conf
+load_makepkg_config

src/lib/pkg/repo.sh

@@ -11,6 +11,8 @@ source "${LIBDIR}"/pkg/db/db.sh
 set -e
 
 
+load_makepkg_config
+
 has_remote_changes() {
     local status
     msg "Checking for remote changes ..."

src/lib/pkg/repo/import.sh

@@ -9,6 +9,12 @@ set -e
 
 PATCHDIR=${PATCHDIR:-"${WORKSPACE_DIR}/artix-patches"}
 
+declare -A arch_map=(
+    ["archlinux-mirrorlist"]="pacman-mirrorlist"
+    ["artix-rebuild-order"]="arch-rebuild-order"
+    ["virtualbox-host-modules-artix"]="virtualbox-host-modules-arch"
+)
+
 update_patches(){
     if [[ ! -d "${PATCHDIR}" ]]; then
         # ${GIT_ORG}
@@ -25,10 +31,7 @@ update_patches(){
 patch_pkgbase(){
     local name="$1"
     local patches="${PATCHDIR}/patches/${name}"
-    sed -e 's|https://www.archlinux.org/|https://www.artixlinux.org/|' \
+    sed -e 's|arch-meson|artix-meson|' -i PKGBUILD
-        -e 's|(Arch Linux)|(Artix Linux)|' \
-        -e 's|arch-meson|artix-meson|' \
-        -i PKGBUILD
 
     if "${PATCH_MAINTAINER}" && [ -n "${PACKAGER}" ]; then
         sed -e 's|# Maintainer:|# Contributor:|' -i PKGBUILD
@@ -146,9 +149,11 @@ artixpkg_repo_import() {
             fi
             ( cd "${pkgbase}" || return
 
+                upstream="${arch_map["$pkgbase"]:-$pkgbase}"
+
                 stat_busy "Checking for upstream url"
                 if ! git config --local --get remote.upstream.url &>/dev/null; then
-                    git remote add upstream "${GIT_UPSTREAM_URL}/${pkgbase}".git
+                    git remote add upstream "${GIT_UPSTREAM_URL}/${upstream}".git
                 fi
                 stat_done
 

src/pkg/artixpkg.in

@@ -41,8 +41,6 @@ export _ARTOOLS_COMMAND='artixpkg'
 # shellcheck source=src/lib/pkg/util.sh
 source "${LIBDIR}"/pkg/util.sh
 
-load_makepkg_config
-
 cd "${TREE_DIR_ARTIX}"
 
 # command checking

src/pkg/checkpkg.in

@@ -9,8 +9,6 @@ source "${LIBDIR}"/base/message.sh
 # shellcheck source=src/lib/pkg/diff.sh
 source "${LIBDIR}"/pkg/diff.sh
 
-load_makepkg_config
-
 usage() {
     cat <<- _EOF_
         Usage: ${BASH_SOURCE[0]##*/} [OPTIONS]