update ChangeLog

We do not need to care about the path on the shebang line of a service
script as long as the shebang line ends with "openrc-run".
This fixes #119 and #120.

ChangeLog

@@ -1,100 +1,4 @@
-commit 0e3f8720984d7d5752a78a4135cd268e4f83b3d7
+commit 477e3dd8c13705affe87cc2c0e9286b2653a5688
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    init: send term/kill signals as final step of shutdown
-
-commit 5fd3747b190887d094225547f23007d25e2d9592
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    reword the bugs section of the openrc-init man page
-
-commit 4694900190a9078397bb9083328b68b489af92f4
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    init: fix signal handling
-    
-    The only signals we handle are SIGINT and SIGCHLD, so block all others
-    and unblock them in the child process before we start a rurnlevel.
-
-commit 05738bfce120114037d4f02c67ec740813f94b89
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    init: add re-exec capability
-    
-    This will allow the re-execution of the init process after upgrading
-    OpenRC.
-
-commit 6f88ee4ec6f59e545346a7422facc3e5b6adac04
-Author: i.Dark_Templar <darktemplar@dark-templar-archives.net>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    bootmisc: do not remove ld-elf32.so.hints
-    
-    File /var/run/ld-elf32.so.hints is used on FreeBSD 64bit multilib
-    This fixes #125.
-
-commit cc51bdca3bac963878141da047e92f125772e14f
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    Add attribution to openrc-init.c and openrc-shutdown.c
-
-commit 13ca79856e5836117e469c3edbcfd4bf47b6bab0
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    add init process
-    
-    openrc-init.c and openrc-shutdown.c are based on code which was written by
-    James Hammons <jlhamm@acm.org>, so I would like to publically
-    thank him for his work.
-
-commit 79a9edc73068244ad843f2edbe4206ce696c91c8
-Author: i.Dark_Templar <darktemplar@dark-templar-archives.net>
-Commit: i.Dark_Templar <darktemplar@dark-templar-archives.net>
-
-    Fix make install on FreeBSD: don't try to install /etc/init.d/modules twice
-
-commit 9eb669591e16c5ee0ca07babe058d0b7b2396077
-Author: Austin English <austinenglish@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    start-stop-daemon: warn if calling --start with --retry or --stop with --wait
-    
-    This fixes #122
-
-commit 55a87a30ec845eb725e8a923c8f8eb7aa75baa72
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    init.d/agetty.in: add -prefix keyword
-
-commit a912029462ae988ab4e2a96a0958e54a3c2e822f
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    init.d/mount-ro: change dependency on killprocs and savecache to after
-    
-    killprocs always succeeds and savecache is not required by mount-ro, so
-    we can just start after both of these have run.
-
-commit 1e9078279709df2a3617bf1460890ceb1ddfcf59
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    agetty-guide: typo fix
-
-commit 51a292e09b9362f13d5747d4eedaa521ddf9ce72
-Author: William Hubbs <w.d.hubbs@gmail.com>
-Commit: William Hubbs <w.d.hubbs@gmail.com>
-
-    init.d: add agetty to ignore patterns
-
-commit 50fccf47d4bd2ed6e7ea6ff7f72577c8e7b95d0d
 Author: William Hubbs <w.d.hubbs@gmail.com>
 Commit: William Hubbs <w.d.hubbs@gmail.com>
 
@@ -104,23 +8,25 @@ Commit: William Hubbs <w.d.hubbs@gmail.com>
     script as long as the shebang line ends with "openrc-run".
     This fixes #119 and #120.
 
-commit 9bd63b5d4a16601712a65eb8962214cdd4d26ce5
+commit 678e7adeb237edd080a13e463e5d8c40d2acdea7
 Author: William Hubbs <w.d.hubbs@gmail.com>
 Commit: William Hubbs <w.d.hubbs@gmail.com>
 
-    update dependencies for clock service
+    version 0.24.2
 
-    The clock services had a very long list of "before" dependencies that
+commit b087a751deb06986e0d77873046e08ca4864175c
-    referred to other services within OpenRC. For ease of maintenance,
+Author: William Hubbs <w.d.hubbs@gmail.com>
-    convert these to "after clock" dependencies in the individual services.
+Commit: William Hubbs <w.d.hubbs@gmail.com>
 
-commit 48db17a93f5e60c0d241f8fb06bfbdd01206fb9c
+    update ChangeLog
+
+commit bc05fb75515b3f65f3c63ae5972c749fac00924f
 Author: William Hubbs <w.d.hubbs@gmail.com>
 Commit: William Hubbs <w.d.hubbs@gmail.com>
 
     update news file
 
-commit c333707cba356f4cacfd58a6fcc78f7c073dddcd
+commit e5c2a378f3000cd20826ec6b59ecca15d31190ae
 Author: William Hubbs <w.d.hubbs@gmail.com>
 Commit: William Hubbs <w.d.hubbs@gmail.com>
 
@@ -132,7 +38,7 @@ Commit: William Hubbs <w.d.hubbs@gmail.com>
     
     This is the first stage of moving this direction.
 
-commit 5f5b1f7cbefd0bc14352e86a9c33260266f98d9b
+commit 3c1a71bd9db50fd410eb64e715a99911c8fad978
 Author: William Hubbs <w.d.hubbs@gmail.com>
 Commit: William Hubbs <w.d.hubbs@gmail.com>
 
@@ -144,11 +50,11 @@ Commit: William Hubbs <w.d.hubbs@gmail.com>
     Since Failing to mount efivarfs is not critical, we silence the error
     message from mount.
 
-commit cfdf56475e600f79a433cd721cadf39114c6c58d
+commit fcb826a45137fec589bf945fe23deeba55879a34
 Author: William Hubbs <w.d.hubbs@gmail.com>
 Commit: William Hubbs <w.d.hubbs@gmail.com>
 
-    version 0.25
+    version 0.24.1
 
 commit fde3902d069dfdce9c59555186a5541d6d99c8aa
 Author: William Hubbs <w.d.hubbs@gmail.com>
@@ -1414,3 +1320,28 @@ Commit: William Hubbs <w.d.hubbs@gmail.com>
     Now both localmount and netmount support a critical_mounts setting. If
     mount points listed in this setting fail to mount, localmount and
     netmount will fail.
+
+commit 1c3c2cf6d8cb060d03919297f5fe706f6027a4c6
+Author: William Hubbs <w.d.hubbs@gmail.com>
+Commit: William Hubbs <w.d.hubbs@gmail.com>
+
+    netmount: fix mounting on Linux
+    
+    Before this commit, on Linux, we were always trying to mount file
+    systems marked with _netdev, even when the previous mount command
+    failed. Now, we do not run the second mount if the first fails.
+    
+    X-Gentoo-Bug: 579876
+    X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=579876
+
+commit 171e856ec8a0a64504b4b4a47ab6181d37fc3dbe
+Author: Mike Gilbert <floppym@gentoo.org>
+Commit: William Hubbs <w.d.hubbs@gmail.com>
+
+    start-stop-daemon: Allow group read/write when creating output files
+    
+    This allows for better interaction with inherited ACL entries.
+    This fixes #84.
+    
+    X-Gentoo-Bug: 577362
+    X-Gentoo-Bug-URL: https://bugs.gentoo.org/577362

Makefile.inc

@@ -1,3 +1,3 @@
 NAME=		openrc
-VERSION=	0.25
+VERSION=	0.24.2
 PKG=		${NAME}-${VERSION}

NEWS.md

@@ -3,13 +3,6 @@
 This file will contain a list of notable changes for each release. Note
 the information in this file is in reverse order.
 
-## OpenRC-0.25
-
-This version contains an OpenRC-specific implementation of init for
-Linux which can be used in place of sysvinit or any other init process.
-For information on its usage, see the man pages for openrc-init (8) and
-openrc-shutdown (8).
-
 ## OpenRC-0.24.1
 
 This version starts cleaning up the dependencies so that rc_parallel

agetty-guide.md

@@ -5,9 +5,10 @@ getty, using agetty, on Linux. To use this method, make sure you aren't
 spawning a getty manager for this port some other way (such as through
 sysvinit/inittab), then run the following commands as root.
 
-Note that [port] refers to the port you are spawning the getty on, for
+Note that [port] refers to the port you are spawning the getty on, and
-example, tty1 or ttyS0. The full path to it, for example, /dev/tty1
+not the full path to it. For example, tty0 or ttyS0instead of /dev/tty0
-should not be used.
+or /dev/ttyS0.
+tty0 or ttyS0, not the full path to it (for example, tty0 or ttyS0 and
 
 ```
 # cd /etc/init.d

etc/rc.conf

@@ -178,11 +178,6 @@
 # "xenU"           - XenU Domain (Linux and NetBSD)
 #rc_sys=""
 
-# if  you use openrc-init, which is currently only available on Linux,
-# this is the default runlevel to activate after "sysinit" and "boot"
-# when booting.
-#rc_default_runlevel="default"
-
 # on Linux and Hurd, this is the number of ttys allocated for logins
 # It is used in the consolefont, keymaps, numlock and termencoding
 # service scripts.

init.d/.gitignore

@@ -1,4 +1,3 @@
-agetty
 binfmt
 modules-load
 bootmisc

init.d/Makefile

@@ -19,7 +19,7 @@ SRCS-FreeBSD=	hostid.in modules.in moused.in newsyslog.in pf.in rarpd.in \
 		rc-enabled.in rpcbind.in savecore.in syslogd.in
 # These are FreeBSD specific
 SRCS-FreeBSD+=	adjkerntz.in devd.in dumpon.in encswap.in ipfw.in \
-		modules-load.in mixer.in nscd.in powerd.in syscons.in
+		modules.in modules-load.in mixer.in nscd.in powerd.in syscons.in
 
 SRCS-Linux=	agetty.in binfmt.in devfs.in dmesg.in hwclock.in consolefont.in \
 	keymaps.in killprocs.in modules.in modules-load.in mount-ro.in mtab.in \

init.d/adjkerntz.in

@@ -23,7 +23,6 @@ fi
 
 depend()
 {
-	after swclock
 	provide clock
 	# BSD adjkerntz needs to be able to write to /etc
 	if [ "$clock" = "UTC" -a -e /etc/wall_cmos_clock ] ||

init.d/agetty.in

@@ -19,7 +19,6 @@ pidfile="/run/${RC_SVCNAME}.pid"
 
 depend() {
 	after local
-	keyword -prefix
 }
 
 start_pre() {

init.d/binfmt.in

@@ -13,7 +13,7 @@ description="Register misc binary format handlers"
 
 depend()
 {
-	after clock procfs
+	after procfs
 	use modules devfs
 	keyword -docker -lxc -openvz -prefix -systemd-nspawn -vserver
 }

init.d/bootmisc.in

@@ -71,8 +71,7 @@ cleanup_var_run_dir()
 	ebegin "Cleaning /var/run"
 	for x in $(find /var/run ! -type d ! -name utmp \
 		! -name random-seed ! -name dev.db \
-		! -name ld-elf.so.hints ! -name ld-elf32.so.hints \
+		! -name ld-elf.so.hints ! -name ld.so.hints);
-		! -name ld.so.hints);
 	do
 		# Clean stale sockets
 		if [ -S "$x" ]; then

init.d/devdb.in

@@ -13,7 +13,6 @@ description="Creates the dev database"
 
 depend()
 {
-	after clock
 	need localmount
 }
 

init.d/dumpon.in

@@ -12,7 +12,6 @@
 description="Configures a specific kernel dump device."
 
 depend() {
-	after clock
 	need swap
 	keyword -jail -prefix
 }

init.d/fsck.in

@@ -15,7 +15,6 @@ _IFS="
 
 depend()
 {
-	after clock
 	use dev clock modules
 	keyword -docker -jail -lxc -openvz -prefix -systemd-nspawn -timeout -vserver -uml
 }

init.d/hostid.in

@@ -15,7 +15,6 @@ extra_commands="reset"
 depend()
 {
 	use root
-	after clock
 	before devd net
 	keyword -jail -prefix
 }

init.d/hostname.in

@@ -12,7 +12,6 @@
 description="Sets the hostname of the machine."
 
 depend() {
-	after clock
 	keyword -docker -lxc -prefix -systemd-nspawn
 }
 

init.d/hwclock.in

@@ -33,6 +33,9 @@ depend()
 	want modules
 	if yesno $clock_adjfile; then
 		use root
+	else
+		before binfmt bootmisc fsck hostname keymaps localmount loopback mtab
+		before procfs root swap sysctl termencoding urandom
 	fi
 	keyword -docker -lxc -openvz -prefix -systemd-nspawn -uml -vserver -xenu
 }

init.d/keymaps.in

@@ -14,7 +14,7 @@ description="Applies a keymap for the consoles."
 depend()
 {
 	need localmount termencoding
-	after bootmisc clock
+	after bootmisc
 	keyword -docker -lxc -openvz -prefix -systemd-nspawn -uml -vserver -xenu
 }
 

init.d/localmount.in

@@ -15,7 +15,7 @@ depend()
 {
 	need fsck
 	use lvm modules mtab root
-	after clock lvm modules root
+	after lvm modules root
 	keyword -docker -jail -lxc -prefix -systemd-nspawn -vserver
 }
 

init.d/loopback.in

@@ -13,7 +13,6 @@ description="Configures the loopback interface."
 
 depend()
 {
-	after clock
 	keyword -jail -prefix -systemd-nspawn -vserver
 }
 

init.d/mount-ro.in

@@ -13,7 +13,7 @@ description="Re-mount filesytems read-only for a clean reboot."
 
 depend()
 {
-	after killprocs savecache
+	need killprocs savecache
 	keyword -docker -lxc -openvz -prefix -systemd-nspawn -vserver
 }
 

init.d/mtab.in

@@ -13,7 +13,6 @@ description="Update /etc/mtab to match what the kernel knows about"
 
 depend()
 {
-	after clock
 	need root
 	keyword -prefix -systemd-nspawn
 }

init.d/network.in

@@ -18,7 +18,7 @@ __nl="
 depend()
 {
 	need localmount
-	after bootmisc clock
+	after bootmisc
 	if [ -n "$(interfaces)" ]; then
 		provide net
 	fi

init.d/newsyslog.in

@@ -13,7 +13,6 @@ required_files="/etc/newsyslog.conf"
 
 depend()
 {
-	after clock
 	need localmount
 	keyword -prefix
 }

init.d/procfs.in

@@ -13,7 +13,6 @@ description="Mounts misc filesystems in /proc."
 
 depend()
 {
-	after clock
 	use devfs
 	want modules
 	need localmount

init.d/root.in

@@ -13,7 +13,6 @@ description="Mount the root fs read/write"
 
 depend()
 {
-	after clock
 	need fsck
 	keyword -docker -jail -lxc -openvz -prefix -systemd-nspawn -vserver
 }

init.d/savecore.in

@@ -14,7 +14,6 @@ description="Saves a kernel dump."
 depend()
 {
 	need dumpon localmount
-	after clock
 	before encswap
 	keyword -jail -prefix
 }

init.d/staticroute.in

@@ -1,4 +1,4 @@
-S#!@BINDIR@/openrc-run
+#!@SBINDIR@/openrc-run
 # Copyright (c) 2009-2015 The OpenRC Authors.
 # See the Authors file at the top-level directory of this distribution and
 # https://github.com/OpenRC/openrc/blob/master/AUTHORS
@@ -14,9 +14,9 @@ S#!@BINDIR@/openrc-run
 description="Configures static routes."
 __nl="
 "
+
 depend()
 {
-	after clock
 	provide net
 	use network
 	keyword -jail -prefix -vserver

init.d/swap-blk.in

@@ -11,7 +11,6 @@
 
 depend()
 {
-	after clock
 	before fsck
 	keyword -jail -prefix
 }

init.d/swap.in

@@ -11,7 +11,6 @@
 
 depend()
 {
-	after clock
 	before localmount
 	keyword -docker -jail -lxc -openvz -prefix -systemd-nspawn -vserver
 }

init.d/swclock.in

@@ -13,6 +13,10 @@ description="Sets the local clock to the mtime of a given file."
 
 depend()
 {
+	before adjkerntz binfmt bootmisc devdb dumpon fsck hostid hostname keymaps
+	before localmount loopback modules mtab network newsyslog procfs root
+	before savecore staticroute swap swap-blk syscons sysctl syslogd
+	before termencoding ttys urandom wscons
 	provide clock
 	keyword -docker -lxc -openvz -prefix -systemd-nspawn -uml -vserver -xenu
 }

init.d/syscons.in

@@ -10,7 +10,6 @@
 # except according to the terms contained in the LICENSE file.
 
 depend() {
-	after clock
 	need localmount
 	keyword -jail -prefix
 }

init.d/sysctl.in

@@ -11,7 +11,6 @@
 
 depend()
 {
-	after clock
 	before bootmisc logger
 	keyword -prefix -systemd-nspawn -vserver
 }

init.d/syslogd.in

@@ -22,6 +22,6 @@ depend()
 	provide logger
 	use net newsyslog
 	need localmount
-	after bootmisc clock
+	after bootmisc
 	keyword -prefix
 }

init.d/termencoding.in

@@ -18,7 +18,7 @@ depend()
 {
 	keyword -docker -lxc -openvz -prefix -systemd-nspawn -uml -vserver -xenu
 	use root
-	after bootmisc clock
+	after bootmisc
 }
 
 start()

init.d/ttys.in

@@ -11,7 +11,7 @@
 
 depend()
 {
-	after clock fsck
+	after fsck
 	keyword -prefix
 }
 

init.d/urandom.in

@@ -14,7 +14,6 @@ description="Initializes the random number generator."
 
 depend()
 {
-	after clock
 	need localmount
 	keyword -docker -jail -lxc -openvz -prefix -systemd-nspawn
 }

init.d/wscons.in

@@ -11,7 +11,6 @@
 
 depend()
 {
-	after clock
 	need localmount
 	keyword -prefix
 }

man/Makefile

@@ -9,7 +9,7 @@ MAN8=		rc-service.8 rc-status.8 rc-update.8 openrc.8 openrc-run.8 \
 		service.8 start-stop-daemon.8 supervise-daemon.8
 
 ifeq (${OS},Linux)
-MAN8 += rc-sstat.8 openrc-init.8 openrc-shutdown.8
+MAN8 += rc-sstat.8
 endif
 
 # Handy macro to create symlinks

man/openrc-init.8

@@ -1,46 +0,0 @@
-.\" Copyright (c) 2017 The OpenRC Authors.
-.\" See the Authors file at the top-level directory of this distribution and
-.\" https://github.com/OpenRC/openrc/blob/master/AUTHORS
-.\"
-.\" This file is part of OpenRC. It is subject to the license terms in
-.\" the LICENSE file found in the top-level directory of this
-.\" distribution and at https://github.com/OpenRC/openrc/blob/master/LICENSE
-.\" This file may not be copied, modified, propagated, or distributed
-.\"    except according to the terms contained in the LICENSE file.
-.\"
-.Dd April 6, 2017
-.Dt openrc-init 8 SMM
-.Os OpenRC
-.Sh NAME
-.Nm openrc-init
-.Nd the parent of all processes
-.Sh SYNOPSIS
-.Nm
-.Sh DESCRIPTION
-.Nm
-is an init process which can be an alternative to sysvinit or any other
-init process.
-.Pp
-To use
-.Nm
-configure your boot loader to invoke it or symlink it to /sbin/init.
-Also, you will need to use
-.Xr openrc-shutdown 8 ,
-to halt, reboot or poweroff the system.
-.Pp
-The default runlevel is read from the init command line, the
-rc_default_runlevel setting in rc.conf, the kernel command line, or it is
-assumed to be "default" if it is not set in any of these places.
-.Pp
-.Nm
-doesn't manage getty's directly, so you will need to manage them another
-way. For example, you can use the agetty service script as described in
-agetty-guide.md in this distribution.
-.Sh BUGS
-This was first released as part of OpenRC 0.25.
-I do not know of any specific issues. However, since this is the first
-release of openrc-init, please test and report any issues you find.
-.Sh SEE ALSO
-.Xr openrc-shutdown 8 ,
-.Sh AUTHORS
-.An William Hubbs <w.d.hubbs@gmail.com>

man/openrc-shutdown.8

@@ -1,47 +0,0 @@
-.\" Copyright (c) 2017 The OpenRC Authors.
-.\" See the Authors file at the top-level directory of this distribution and
-.\" https://github.com/OpenRC/openrc/blob/master/AUTHORS
-.\"
-.\" This file is part of OpenRC. It is subject to the license terms in
-.\" the LICENSE file found in the top-level directory of this
-.\" distribution and at https://github.com/OpenRC/openrc/blob/master/LICENSE
-.\" This file may not be copied, modified, propagated, or distributed
-.\"    except according to the terms contained in the LICENSE file.
-.\"
-.Dd April 6, 2017
-.Dt openrc-shutdown 8 SMM
-.Os OpenRC
-.Sh NAME
-.Nm openrc-shutdown
-.Nd bring the system down
-.Sh SYNOPSIS
-.Nm
-.Op Fl H , -halt
-.Op Fl k , -kexec
-.Op Fl p , -poweroff
-.Op Fl R , -reexec
-.Op Fl r , -reboot
-.Sh DESCRIPTION
-.Nm
-is the utility that communicates with openrc-init(8) to bring down the
-system or instruct openrc-init to re-execute itself. It supports the
-following options:
-.Bl -tag -width "poweroff"
-.It Fl H , -halt
-Stop all services, kill all remaining processes and halt the system.
-.It Fl k , -kexec
-Stop all services, kill all processes and boot directly into a new
-kernel loaded via kexec(8).
-.It Fl p , -poweroff
-Stop all services, kill all processes and power off the system.
-.It Fl R , -reexec
-instruct openrc-init to re-exec itself. This should be used after an
-upgrade of OpenRC if you are using openrc-init as your init process.
-.It Fl r , -reboot
-Stop all services, kill all processes and reboot the system.
-.El
-.Sh SEE ALSO
-.Xr openrc-init 8 ,
-.Xr kexec 8 ,
-.Sh AUTHORS
-.An William Hubbs <w.d.hubbs@gmail.com>

src/librc/rc.h.in

@@ -39,7 +39,6 @@ extern "C" {
 #define RC_CONFDIR              RC_SYSCONFDIR "/conf.d"
 #define RC_PLUGINDIR            RC_LIBDIR "/plugins"
 
-#define RC_INIT_FIFO RC_SVCDIR"/init.ctl"
 #define RC_PROFILE_ENV     RC_SYSCONFDIR "/profile.env"
 #define RC_SYS_WHITELIST   RC_LIBEXECDIR "/conf.d/env_whitelist"
 #define RC_USR_WHITELIST   RC_SYSCONFDIR "/conf.d/env_whitelist"

src/rc/.gitignore

@@ -59,6 +59,4 @@ mark_service_failed
 rc-abort
 rc
 openrc
-openrc-init
 openrc-run
-openrc-shutdown

src/rc/Makefile

@@ -1,7 +1,3 @@
-include ../../Makefile.inc
-MK=		../../mk
-include ${MK}/os.mk
-
 SRCS=	checkpath.c do_e.c do_mark_service.c do_service.c \
 		do_value.c fstabinfo.c is_newer_than.c is_older_than.c \
 		mountinfo.c openrc-run.c rc-abort.c rc.c \
@@ -13,10 +9,6 @@ ifeq (${MKSELINUX},yes)
 SRCS+=		rc-selinux.c
 endif
 
-ifeq (${OS},Linux)
-SRCS+=		openrc-init.c openrc-shutdown.c
-endif
-
 CLEANFILES=	version.h rc-selinux.o
 
 BINDIR=		${PREFIX}/bin
@@ -42,11 +34,6 @@ RC_SBINPROGS=	mark_service_starting mark_service_started \
 		mark_service_inactive mark_service_wasinactive \
 		mark_service_hotplugged mark_service_failed \
 		rc-abort swclock
-
-ifeq (${OS},Linux)
-SBINPROGS+= openrc-init openrc-shutdown
-endif
-
 ALL_PROGS=	${BINPROGS} ${SBINPROGS} ${RC_BINPROGS} ${RC_SBINPROGS}
 CLEANFILES+=	${ALL_PROGS}
 
@@ -54,6 +41,8 @@ LOCAL_CPPFLAGS=-I../includes -I../librc -I../libeinfo
 LOCAL_LDFLAGS=-L../librc -L../libeinfo
 LDADD+=		-lutil -lrc -leinfo
 
+include ../../Makefile.inc
+MK=		../../mk
 include ${MK}/prog.mk
 include ${MK}/gitver.mk
 include ${MK}/cc.mk
@@ -107,9 +96,6 @@ veinfo vewarn vebegin veend vewend veindent veoutdent: do_e.o rc-misc.o
 fstabinfo: fstabinfo.o _usage.o rc-misc.o
 	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
 
-openrc-init: openrc-init.o
-	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
-
 is_newer_than: is_newer_than.o rc-misc.o
 	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
 
@@ -128,9 +114,6 @@ mountinfo: mountinfo.o _usage.o rc-misc.o
 openrc rc: rc.o rc-logger.o rc-misc.o rc-plugin.o _usage.o
 	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
 
-openrc-shutdown: openrc-shutdown.o _usage.o
-	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
-
 openrc-run runscript: openrc-run.o _usage.o rc-misc.o rc-plugin.o
 ifeq (${MKSELINUX},yes)
 openrc-run runscript: rc-selinux.o

src/rc/openrc-init.c

@@ -1,206 +0,0 @@
-/*
- * openrc-init.c
- * This is the init process (pid 1) for OpenRC.
- *
- * This is based on code written by James Hammons <jlhamm@acm.org>, so
- * I would like to publically thank him for his work.
- */
-
-/*
- * Copyright (c) 2017 The OpenRC Authors.
- * See the Authors file at the top-level directory of this distribution and
- * https://github.com/OpenRC/openrc/blob/master/AUTHORS
- *
- * This file is part of OpenRC. It is subject to the license terms in
- * the LICENSE file found in the top-level directory of this
- * distribution and at https://github.com/OpenRC/openrc/blob/master/LICENSE
- * This file may not be copied, modified, propagated, or distributed
- *    except according to the terms contained in the LICENSE file.
- */
-
-#include <errno.h>
-#include <signal.h>
-#include <stdbool.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <sys/reboot.h>
-#include <sys/wait.h>
-
-#include "helpers.h"
-#include "rc.h"
-#include "version.h"
-
-static const char *rc_default_runlevel = "default";
-
-static pid_t do_openrc(const char *runlevel)
-{
-	pid_t pid;
-	sigset_t signals;
-
-	pid = fork();
-	switch(pid) {
-		case -1:
-			perror("fork");
-			break;
-		case 0:
-			setsid();
-			/* unblock all signals */
-			sigemptyset(&signals);
-			sigprocmask(SIG_SETMASK, &signals, NULL);
-			printf("Starting %s runlevel\n", runlevel);
-			execl("/sbin/openrc", "/sbin/openrc", runlevel, NULL);
-			perror("exec");
-			break;
-		default:
-			break;
-	}
-	return pid;
-}
-
-static void init(const char *default_runlevel)
-{
-	const char *runlevel = NULL;
-	pid_t pid;
-
-	pid = do_openrc("sysinit");
-	waitpid(pid, NULL, 0);
-	pid = do_openrc("boot");
-	waitpid(pid, NULL, 0);
-	if (default_runlevel)
-		runlevel = default_runlevel;
-	else
-		runlevel = rc_conf_value("rc_default_runlevel");
-	if (!runlevel)
-		runlevel = rc_default_runlevel;
-	if (!rc_runlevel_exists(runlevel)) {
-		printf("%s is an invalid runlevel\n", runlevel);
-		runlevel = rc_default_runlevel;
-	}
-	pid = do_openrc(runlevel);
-	waitpid(pid, NULL, 0);
-}
-
-static void handle_reexec(char *my_name)
-{
-	execl(my_name, my_name, "reexec", NULL);
-	return;
-}
-
-static void handle_shutdown(const char *runlevel, int cmd)
-{
-	pid_t pid;
-
-	pid = do_openrc(runlevel);
-	while (waitpid(pid, NULL, 0) != pid);
-	printf("Sending the final term signal\n");
-	kill(-1, SIGTERM);
-	sleep(3);
-	printf("Sending the final kill signal\n");
-	kill(-1, SIGKILL);
-	sync();
-	reboot(cmd);
-}
-
-static void reap_zombies(void)
-{
-	pid_t pid;
-
-	for (;;) {
-		pid = waitpid(-1, NULL, WNOHANG);
-		if (pid == 0)
-			break;
-		else if (pid == -1) {
-			if (errno == ECHILD)
-				break;
-			perror("waitpid");
-			continue;
-		}
-	}
-}
-
-static void signal_handler(int sig)
-{
-	switch(sig) {
-		case SIGINT:
-			handle_shutdown("reboot", RB_AUTOBOOT);
-			break;
-		case SIGCHLD:
-			reap_zombies();
-			break;
-		default:
-			printf("Unknown signal received, %d\n", sig);
-			break;
-	}
-}
-
-int main(int argc, char **argv)
-{
-	char *default_runlevel;
-	char buf[2048];
-	int count;
-	FILE *fifo;
-	bool reexec = false;
-	sigset_t signals;
-	struct sigaction sa;
-
-	if (getpid() != 1)
-		return 1;
-
-	printf("OpenRC init version %s starting\n", VERSION);
-
-	if (argc > 1)
-		default_runlevel = argv[1];
-	else
-		default_runlevel = NULL;
-
-	if (default_runlevel && strcmp(default_runlevel, "reexec") == 0)
-		reexec = true;
-
-	/* block all signals we do not handle */
-	sigfillset(&signals);
-	sigdelset(&signals, SIGCHLD);
-	sigdelset(&signals, SIGINT);
-	sigprocmask(SIG_SETMASK, &signals, NULL);
-
-	/* install signal  handler */
-	memset(&sa, 0, sizeof(sa));
-	sa.sa_handler = signal_handler;
-	sigaction(SIGCHLD, &sa, NULL);
-	sigaction(SIGINT, &sa, NULL);
-	reboot(RB_DISABLE_CAD);
-
-	if (! reexec)
-		init(default_runlevel);
-
-	if (mkfifo(RC_INIT_FIFO, 0600) == -1 && errno != EEXIST)
-		perror("mkfifo");
-
-	for (;;) {
-		/* This will block until a command is sent down the pipe... */
-		fifo = fopen(RC_INIT_FIFO, "r");
-		if (!fifo) {
-			if (errno != EINTR)
-				perror("fopen");
-			continue;
-		}
-		count = fread(buf, 1, 2048, fifo);
-		buf[count] = 0;
-		fclose(fifo);
-		printf("PID1: Received \"%s\" from FIFO...\n", buf);
-		if (strcmp(buf, "halt") == 0)
-			handle_shutdown("shutdown", RB_HALT_SYSTEM);
-		else if (strcmp(buf, "kexec") == 0)
-			handle_shutdown("reboot", RB_KEXEC);
-		else if (strcmp(buf, "poweroff") == 0)
-			handle_shutdown("shutdown", RB_POWER_OFF);
-		else if (strcmp(buf, "reboot") == 0)
-			handle_shutdown("reboot", RB_AUTOBOOT);
-		else if (strcmp(buf, "reexec") == 0)
-			handle_reexec(argv[0]);
-	}
-	return 0;
-}

src/rc/openrc-shutdown.c

@@ -1,132 +0,0 @@
-/*
- * openrc-shutdown.c
- * If you are using OpenRC's provided init, this will shut down or
- * reboot your system.
- *
- * This is based on code written by James Hammons <jlhamm@acm.org>, so
- * I would like to publically thank him for his work.
- */
-
-/*
- * Copyright 2017 The OpenRC Authors.
- * See the Authors file at the top-level directory of this distribution and
- * https://github.com/OpenRC/openrc/blob/master/AUTHORS
- *
- * This file is part of OpenRC. It is subject to the license terms in
- * the LICENSE file found in the top-level directory of this
- * distribution and at https://github.com/OpenRC/openrc/blob/master/LICENSE
- * This file may not be copied, modified, propagated, or distributed
- *    except according to the terms contained in the LICENSE file.
- */
-
-#include <getopt.h>
-#include <signal.h>
-#include <stdbool.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-#include <sys/types.h>
-
-#include "einfo.h"
-#include "rc.h"
-#include "helpers.h"
-#include "_usage.h"
-
-const char *applet = NULL;
-const char *extraopts = NULL;
-const char *getoptstring = "HkpRr" getoptstring_COMMON;
-const struct option longopts[] = {
-	{ "halt",        no_argument, NULL, 'H'},
-	{ "kexec",        no_argument, NULL, 'k'},
-	{ "poweroff",        no_argument, NULL, 'p'},
-	{ "reexec",        no_argument, NULL, 'R'},
-	{ "reboot",        no_argument, NULL, 'r'},
-	longopts_COMMON
-};
-const char * const longopts_help[] = {
-	"halt the system",
-	"reboot the system using kexec",
-	"power off the system",
-	"re-execute init (use after upgrading)",
-	"reboot the system",
-	longopts_help_COMMON
-};
-const char *usagestring = NULL;
-const char *exclusive = "Select one of "
-"--halt, --kexec, --poweroff, --reexec or --reboot";
-
-static void send_cmd(const char *cmd)
-{
-	FILE *fifo;
- 	size_t ignored;
-
-	fifo = fopen(RC_INIT_FIFO, "w");
-
-	if (!fifo) {
-		perror("fopen");
-		return;
-	}
-
-	ignored = fwrite(cmd, 1, strlen(cmd), fifo);
-	if (ignored != strlen(cmd))
-		printf("Error writing to init fifo\n");
-	fclose(fifo);
-}
-
-int main(int argc, char **argv)
-{
-	int opt;
-	int cmd_count = 0;
-	bool do_halt = false;
-	bool do_kexec = false;
-	bool do_poweroff = false;
-	bool do_reboot = false;
-	bool do_reexec = false;
-
-	applet = basename_c(argv[0]);
-if (geteuid() != 0)
-	eerrorx("%s: you must be root\n", applet);
-	while ((opt = getopt_long(argc, argv, getoptstring,
-		    longopts, (int *) 0)) != -1)
-	{
-		switch (opt) {
-		case 'H':
-			do_halt = true;
-			cmd_count++;
-			break;
-		case 'k':
-			do_kexec = true;
-			cmd_count++;
-			break;
-		case 'p':
-			do_poweroff = true;
-			cmd_count++;
-			break;
-		case 'R':
-			do_reexec = true;
-			cmd_count++;
-			break;
-		case 'r':
-			do_reboot = true;
-			cmd_count++;
-			break;
-		case_RC_COMMON_GETOPT
-		}
-	}
-	if (cmd_count != 1) {
-		eerror("%s: %s\n", applet, exclusive);
-		usage(EXIT_FAILURE);
-	}
-	if (do_halt)
-		send_cmd("halt");
-	else if (do_kexec)
-		send_cmd("kexec");
-	else if (do_poweroff)
-		send_cmd("poweroff");
-	else if (do_reboot)
-		send_cmd("reboot");
-	else if (do_reexec)
-		send_cmd("reexec");
-	return 0;
-}

src/rc/start-stop-daemon.c

@@ -960,9 +960,6 @@ int main(int argc, char **argv)
 		if (redirect_stdout || redirect_stderr)
 			eerrorx("%s: --stdout and --stderr are only relevant"
 			    " with --start", applet);
-		if (start_wait)
-			ewarn("using --wait with --stop has no effect,"
-			    " use --retry instead");
 	} else {
 		if (!exec)
 			eerrorx("%s: nothing to start", applet);
@@ -1015,11 +1012,7 @@ int main(int argc, char **argv)
 		eerror("%s: %s does not exist", applet,
 		    *exec_file ? exec_file : exec);
 		exit(EXIT_FAILURE);
-
 	}
-	if (start && retry)
-		ewarn("using --retry with --start has no effect,"
-		    " use --wait instead");
 
 	/* If we don't have a pidfile we should check if it's interpreted
 	 * or not. If it we, we need to pass the interpreter through