feat(commitpkg): Change warning to hard error when licensing information is absent

We originally had this as a warning to allow packagers some time for transitioning.
However, now the gloves come off and we will require all packages to have proper licensing
information.

src/arch-nspawn.in

@@ -61,20 +61,13 @@ nspawn_args=(
 	--directory="$working_dir"
 	--setenv="PATH=/usr/local/sbin:/usr/local/bin:/usr/bin"
 	--register=no
+	--slice="devtools-$(systemd-escape "${SUDO_USER:-$USER}")"
+	--machine="arch-nspawn-$$"
 	--as-pid2
 	--console=autopipe
 	--timezone=off
 )
 
-if [[ ${DEVTOOLS_KEEP_UNIT:-0} == 1 ]]; then
-	nspawn_args+=(--keep-unit)
-else
-	nspawn_args+=(
-		--slice="devtools-$(systemd-escape "${SUDO_USER:-$USER}")"
-		--machine="arch-nspawn-$$"
-	)
-fi
-
 if (( ${#cache_dirs[@]} == 0 )); then
 	mapfile -t cache_dirs < <(pacman-conf --config "${pac_conf:-$working_dir/etc/pacman.conf}" CacheDir)
 fi

src/commitpkg.in

@@ -123,10 +123,9 @@ fi
 needsversioning=()
 
 if [[ ! -e REUSE.toml || ! -e LICENSE || ! -d LICENSES ]]; then
-	# TODO: Make this a hard failure in the future after packagers have had
-	# some time to add licenses to all packages.
-	warning "package doesn't have proper licensing information, set it up using:"
+	error "package doesn't have proper licensing information, set it up using:"
 	msg2 'pkgctl license setup'
+	exit 1
 else
 	pkgctl license check
 	needsversioning+=(REUSE.toml LICENSE LICENSES/*)