wip: diff soname

Normally the default in Arch is that all home directories are private.
However, this may have been changed locally. To make sure we never
expose secrets, lets use a umask of 0077 when writing the config.

Additionally add some temporary fixup code to migrate the file and
directory permissions of already existing paths.

Signed-off-by: Levente Polyak <anthraxx@archlinux.org>

contrib/completion/bash/devtools.in

@@ -2,431 +2,89 @@
 #
 # SPDX-License-Identifier: GPL-3.0-or-later
 
-_DEVTOOLS_LIBRARY_DIR=${_DEVTOOLS_LIBRARY_DIR:-@pkgdatadir@}
+_devtools_compgen() {
-# shellcheck source=src/lib/valid-tags.sh
+  local i r
-source "${_DEVTOOLS_LIBRARY_DIR}"/lib/valid-tags.sh
+  COMPREPLY=($(compgen -W '$*' -- "$cur"))
-# shellcheck source=src/lib/valid-repos.sh
+  for ((i=1; i < ${#COMP_WORDS[@]}-1; i++)); do
-source "${_DEVTOOLS_LIBRARY_DIR}"/lib/valid-repos.sh
+    for r in "${!COMPREPLY[@]}"; do
-
+      if [[ ${COMP_WORDS[i]} = "${COMPREPLY[r]}" ]]; then
-_binary_arch=${_arch[*]:0:-1}
+        unset 'COMPREPLY[r]'; break
-_colors=(never always auto)
-
-
-_makechrootpkg_args=(
-	-h
-	-c
-	-d
-	-D
-	-u
-	-r
-	-I
-	-l
-	-n
-	-T
-	-U
-)
-_makechrootpkg_args_d_opts() { _filedir -d; }
-_makechrootpkg_args_D_opts() { _filedir -d; }
-_makechrootpkg_args_r_opts() { _filedir -d; }
-_makechrootpkg_args_I_opts() { _filedir '*.pkg.tar.*'; }
-_makechrootpkg_args_l_opts() { _filedir -d; }
-_makechrootpkg_args_U_opts() { :; }
-_makechrootpkg() { __devtools_complete _makechrootpkg; }
-complete -F _makechrootpkg makechrootpkg
-
-
-_makerepropkg_args=(
-	-h
-	-d
-	-c
-	-M
-)
-_makerepropkg_args_c_opts() { _filedir -d; }
-_makerepropkg_args_M_opts() { _filedir '*.conf'; }
-_makerepropkg_opts() { _filedir '*.pkg.tar.*'; }
-_makerepropkg() { __devtools_complete _makerepropkg; }
-complete -F _makerepropkg makerepropkg
-
-
-_mkarchroot_args=(
-	-U
-	-C
-	-M
-	-c
-	-h
-)
-_mkarchroot_args_U_opts() { _filedir '*.pkg.tar.*'; }
-_mkarchroot_args_C_opts() { _filedir '*.conf'; }
-_mkarchroot_args_M_opts() { _filedir '*.conf'; }
-_mkarchroot_args_c_opts() { _filedir -d; }
-_mkarchroot_opts() {
-	local args
-	args=$(__pkgctl_word_count_after_subcommand)
-	if (( args == 0 )); then
-		_filedir -d
-	elif (( args >= 1 )); then
-		_devtools_completions_all_packages
-	fi
-}
-_mkarchroot() { __devtools_complete _mkarchroot; }
-complete -F _mkarchroot mkarchroot
-
-
-_arch_nspawn_args=(
-	-C
-	-M
-	-c
-	-f
-	-s
-	-h
-)
-_arch_nspawn_args_C_opts() { _filedir '*.conf'; }
-_arch_nspawn_args_M_opts() { _filedir '*.conf'; }
-_arch_nspawn_args_c_opts() { _filedir -d; }
-_arch_nspawn_args_f_opts() { _filedir; }
-_arch_nspawn_opts() {
-	local args
-	args=$(__pkgctl_word_count_after_subcommand)
-	if (( args == 0 )); then
-		_filedir -d
-	fi
-}
-_arch_nspawn() { __devtools_complete _arch_nspawn; }
-complete -F _arch_nspawn arch-nspawn
-
-
-_sogrep_args=(
-	-v --verbose
-	-r --refresh
-	-h --help
-)
-_sogrep_opts() {
-	local args
-	args=$(__pkgctl_word_count_after_subcommand)
-	if (( args == 0 )); then
-		_devtools_completions_repo all
-	fi
-}
-_sogrep() { __devtools_complete _sogrep; }
-complete -F _sogrep sogrep
-
-
-_offload_build_args=(
-	-r --repo
-	-a --arch
-	-s --server
-	-h --help
-)
-_offload_build_args__repo_opts() { _devtools_completions_build_repo; }
-_offload_build_args_r_opts() { _offload_build_args__repo_opts; }
-_offload_build_args__arch_opts() { _devtools_completions_arch; }
-_offload_build_args_a_opts() { _offload_build_args__arch_opts; }
-_offload_build_args__server_opts() { :; }
-_offload_build_args_s_opts() { _offload_build_args__server_opts; }
-_offload_build() { __devtools_complete _offload_build; }
-complete -F _offload_build offload-build
-
-
-_pkgctl_cmds=(
-	auth
-	build
-	db
-	diff
-	release
-	repo
-	version
-)
-_pkgctl_args=(
-	-V --version
-	-h --help
-)
-
-
-_pkgctl_auth_cmds=(
-	login
-	status
-)
-
-
-_pkgctl_auth_login_args=(
-	-g --gen-access-token
-	-h --help
-)
-
-
-_pkgctl_auth_status_args=(
-	-t --show-token
-	-h --help
-)
-
-
-_pkgctl_build_args=(
-	--arch
-	--repo
-
-	-s --staging
-	-t --testing
-	-o --offload
-	-c --clean
-
-	--pkgver
-	--pkgrel
-	--rebuild
-	-e --edit
-
-	-r --release
-	-m --message
-	-u --db-update
-
-	-h --help
-)
-_pkgctl_build_args__arch_opts() { _devtools_completions_arch; }
-_pkgctl_build_args__repo_opts() { _devtools_completions_repo; }
-_pkgctl_build_args__pkgver_opts() { :; }
-_pkgctl_build_args__pkgrel_opts() { :; }
-_pkgctl_build_args__message_opts() { :; }
-_pkgctl_build_args_m_opts() { _pkgctl_build_args__message_opts; }
-_pkgctl_build_opts() { _filedir -d; }
-
-
-_pkgctl_db_cmds=(
-	move
-	remove
-	update
-)
-
-
-_pkgctl_db_move_args=(
-	-h --help
-)
-_pkgctl_db_move_opts() {
-	local subcommand args
-	subcommand=(db move)
-	args=$(__pkgctl_word_count_after_subcommand "${subcommand[@]}")
-
-	if (( args == 0 )); then
-		_devtools_completions_repo
-	elif (( args == 1 )); then
-		_devtools_completions_repo
-	elif (( args >= 2 )); then
-		_devtools_completions_all_packages
       fi
+    done
+  done
 }
 
-
+_pkgrepo_pkg() {
-_pkgctl_db_remove_args=(
+  _devtools_compgen "$(
-	-a --arch
+      command pacman "-$1"
-	-h --help
+  )"
-)
-_pkgctl_db_remove_opts() {
-	local subcommand args
-	subcommand=(db remove)
-	args=$(__pkgctl_word_count_after_subcommand "${subcommand[@]}")
-
-	if (( args == 0 )); then
-		_devtools_completions_repo
-	elif (( args >= 1 )); then
-		_devtools_completions_all_packages
-	fi
 }
 
-
+_pkgrepo() {
-_pkgctl_db_update_args=(
-	-h --help
-)
-
-
-_pkgctl_release_args=(
-	-m --message
-	-r --repo
-	-s --staging
-	-t --testing
-	-u --db-update
-	-h --help
-)
-_pkgctl_release_args__message_opts() { :; }
-_pkgctl_release_args_m_opts() { _pkgctl_release_args__message_opts; }
-_pkgctl_release_args__repo_opts() { _devtools_completions_repo; }
-_pkgctl_release_args_r_opts() { _pkgctl_release_args__repo_opts; }
-_pkgctl_release_opts() { _filedir -d; }
-
-
-_pkgctl_repo_cmds=(
-	clone
-	configure
-	create
-	web
-)
-
-
-_pkgctl_repo_clone_args=(
-	-m --maintainer
-	-u --unprivileged
-	--universe
-	-h --help
-)
-_pkgctl_repo_clone_args__maintainer_opts() { :; }
-_pkgctl_repo_clone_args_m_opts() { _pkgctl_repo_clone_args__maintainer_opts; }
-_pkgctl_repo_clone_opts() { _devtools_completions_all_packages; }
-
-
-_pkgctl_repo_configure_args=(
-	-h --help
-)
-_pkgctl_repo_configure_opts() { _filedir -d; }
-
-
-_pkgctl_repo_create_args=(
-	-c --clone
-	-h --help
-)
-
-
-_pkgctl_repo_web_args=(
-	-h --help
-)
-_pkgctl_repo_web_opts() { _filedir -d; }
-
-
-_pkgctl_diff_args=(
-	-l --list
-	-d --diffoscope
-	-p --pkginfo
-	-b --buildinfo
-	-m --makepkg-config
-	-u -U --unified
-	-y --side-by-side
-	--color
-	-W --width
-	-P --pool
-	-v --verbose
-	-h --help
-)
-_pkgctl_diff_args__makepkg_config_opts() { _filedir '*.conf'; }
-_pkgctl_diff_args_m_opts() { _pkgctl_diff_args__makepkg_config_opts; }
-_pkgctl_diff_args__width_opts() { :; }
-_pkgctl_diff_args_W_opts() { _pkgctl_diff_args__width_opts; }
-_pkgctl_diff_args__color_opts() { _devtools_completions_color; }
-_pkgctl_diff_args__pool_opts() { _filedir -d; }
-_pkgctl_diff_args_P_opts() { _pkgctl_diff_args__pool_opts; }
-_pkgctl_diff_opts() { _devtools_completions_all_packages; }
-
-
-_pkgctl_version_args=(
-	-h --help
-)
-
-
-_devtools_completions_color() {
-	mapfile -t COMPREPLY < <(compgen -W "${_colors[*]}" -- "$cur")
-}
-_devtools_completions_arch() {
-	mapfile -t COMPREPLY < <(compgen -W "${_arch[*]}" -- "$cur")
-}
-_devtools_completions_repo() {
-	local optional=${1:-}
-	mapfile -t COMPREPLY < <(compgen -W "${optional} ${_repos[*]}" -- "$cur")
-}
-_devtools_completions_build_repo() {
-	mapfile -t COMPREPLY < <(compgen -W "${_build_repos[*]}" -- "$cur")
-}
-_devtools_completions_all_packages() {
-	mapfile -t COMPREPLY < <(compgen -W "$(pacman -Sql)" -- "$cur")
-}
-
-__devtools_complete() {
-	local service=$1
   local cur prev
-
+  COMPREPLY=()
-	# Don't break words at : and =
-	COMP_WORDBREAKS=${COMP_WORDBREAKS//[:=]}
-
   cur=$(_get_cword)
   prev=${COMP_WORDS[COMP_CWORD-1]}
 
-	__pkgctl_handle_subcommands "${service}"
+  _pkgrepo_pkg Slq
+  true
+} &&
+complete -F _pkgrepo pkgrepo
+
+_makechrootpkg() {
+  local cur
+  COMPREPLY=()
+  _get_comp_words_by_ref cur
+
+  case $cur in
+    -*)
+       COMPREPLY=( $( compgen -W '-I -c -h -l -r -u' -- "$cur" ) )
+       ;;
+    *)
+      _filedir
       return 0
-}
+      ;;
+  esac
 
-__pkgctl_has_func() {
+  true
-	declare -f -- "${1}" &>/dev/null
+} &&
-}
+complete -F _makechrootpkg makechrootpkg
 
-__pkgctl_has_array() {
+_mkarchroot() {
-	declare -p -- "${1}" &>/dev/null
+  local cur
-}
+  COMPREPLY=()
+  _get_comp_words_by_ref cur
 
-__pkgctl_is_subcommand() {
+  case $cur in
-	__pkgctl_has_array "${1}"_args || \
+    -*)
-		__pkgctl_has_array "${1}"_cmds
+       COMPREPLY=( $( compgen -W '-C -M -c -h' -- "$cur" ) )
-}
+       ;;
+    *)
+      _filedir
+      return 0
+      ;;
+  esac
 
-__pkgctl_words_after_subcommand() {
+  true
-	local subcommand=("$@")
+} &&
-	local subcommand_idx=0
+complete -F _mkarchroot mkarchroot
-	local word prev_word
-	for ((i = 1; i < ${#COMP_WORDS[@]}; ++i)); do
-		word=${COMP_WORDS[i]}
-		prev_word=${COMP_WORDS[i-1]}
-		# skip options and the current typing
-		if [[ ${word} == -* ]] || [[ ${word} == "${cur}" ]]; then
-			continue
-		fi
-		# skip until we resolved the passed subcommand
-		if (( subcommand_idx < ${#subcommand[@]} )); then
-			if [[ $word == "${subcommand[$subcommand_idx]}" ]]; then
-				subcommand_idx=$(( subcommand_idx + 1 ))
-			fi
-			continue
-		fi
-		# skip previous options as they belong to the argument
-		if [[ ${prev_word} == -* ]] && __pkgctl_has_func "${service_name}_args${prev_word//-/_}_opts"; then
-			continue
-		fi
-		printf "%s\n" "${word}"
-	done
-}
-__pkgctl_word_count_after_subcommand() {
-	local subcommand=("$@")
-	mapfile -t words < <(__pkgctl_words_after_subcommand "${subcommand[@]}")
-	echo "${#words[@]}"
-}
 
-__pkgctl_handle_subcommands() {
+_arch-nspawn() {
-	local service_name=${1}
+  local cur
-	local index=${2:-0}
+  COMPREPLY=()
-	local word ref
+  _get_comp_words_by_ref cur
 
-	# recurse into nested subcommands
+  case $cur in
-	for ((i = index + 1; i < ${#COMP_WORDS[@]}; ++i)); do
+    -*)
-		word=${COMP_WORDS[i]}
+       COMPREPLY=( $( compgen -W '-C -M -c -h' -- "$cur" ) )
-		if [[ ${word} == -* ]] || [[ ${word} == "${cur}" ]]; then
+       ;;
-			continue
+    *)
-		fi
+      _filedir
-		if __pkgctl_is_subcommand "${service_name}_${word}"; then
+      return 0
-			__pkgctl_handle_subcommands "${service_name}_${word}" "${i}"
+      ;;
-			return
+  esac
-		fi
-	done
 
-	# dynamic argument options
+  true
-	if [[ $prev == -* ]] && word=${prev//-/_} && __pkgctl_has_func "${service_name}_args${word}_opts"; then
+} &&
-		"${service_name}_args${word}_opts"
+complete -F _arch-nspawn arch-nspawn
-	# dynamic subcommand options
+# ex:et ts=2 sw=2 ft=sh
-	elif [[ $cur != -* ]] && __pkgctl_has_func "${service_name}_opts"; then
-		"${service_name}_opts"
-	# subcommand argument array
-	elif ( ! __pkgctl_has_array "${service_name}"_cmds || [[ $cur == -* ]] ) && __pkgctl_has_array "${service_name}_args"; then
-		declare -n ref="${service_name}_args"
-		mapfile -t COMPREPLY < <(compgen -W "${ref[*]}" -- "$cur")
-	# subcommand array
-	elif __pkgctl_has_array "${service_name}"_cmds; then
-		declare -n ref="${service_name}_cmds"
-		mapfile -t COMPREPLY < <(compgen -W "${ref[*]}" -- "$cur")
-	fi
-}
-
-
-_pkgctl() { __devtools_complete _pkgctl; }
-complete -F _pkgctl pkgctl
-# ex:noet ts=4 sw=4 ft=sh

contrib/completion/zsh/_devtools.in

@@ -231,16 +231,6 @@ _pkgctl_cmds=(
 	"diff[Compare package files using different modes]"
 	"release[Release step to commit, tag and upload build artifacts]"
 	"repo[Manage Git packaging repositories and their configuration]"
-	"version[Show pkgctl version information]"
-)
-
-_pkgctl_args=(
-	'(-V --version)'{-V,--version}'[Show pkgctl version information]'
-	'(-h --help)'{-h,--help}'[Display usage]'
-)
-
-_pkgctl_version_args=(
-	'(-h --help)'{-h,--help}'[Display usage]'
 )
 
 _pkgctl_diff_args=("${_diffpkg_args[@]}")
@@ -253,13 +243,8 @@ _handle_subcommands() {
 			'*::arg:->args'
 		case $state in
 			cmds)
-				if [[ "${line[-1]}" == -* ]] && typeset -p ${service_name}_args &> /dev/null; then
-					local argname="${service_name}_args[@]"
-					_arguments -s "${(P)argname}"
-				else
 				local service_cmds=${service_name}_cmds[@]
 				_values "${(P)service_cmds}"
-				fi
 				;;
 			args)
 				local service_sub=${service_name}_$line[1]

doc/man/pkgctl-version.1.asciidoc

@@ -1,23 +0,0 @@
-pkgctl-version(1)
-=================
-
-Name
-----
-pkgctl-version - Show pkgctl version information
-
-Synopsis
---------
-pkgctl version [OPTIONS]
-
-Description
------------
-
-Shows the current version information of pkgctl.
-
-Options
--------
-
-*-h, --help*::
-	Show a help text
-
-include::include/footer.asciidoc[]

doc/man/pkgctl.1.asciidoc

@@ -14,15 +14,6 @@ Description
 
 TODO
 
-Options
--------
-
-*-V, --version*::
-	Show pkgctl version information
-
-*-h, --help*::
-	Show a help text
-
 Subcommands
 -----------
 
@@ -44,9 +35,6 @@ pkgctl release::
 pkgctl repo::
 	Manage Git packaging repositories and their configuration
 
-pkgctl version::
-	Show pkgctl version information
-
 See Also
 --------
 
@@ -56,6 +44,5 @@ linkman:pkgctl-db[1]
 linkman:pkgctl-diff[1]
 linkman:pkgctl-release[1]
 linkman:pkgctl-repo[1]
-linkman:pkgctl-version[1]
 
 include::include/footer.asciidoc[]

opts.sh

@@ -1,46 +0,0 @@
-#!/bin/bash
-
-# NOTE: This requires GNU getopt
-if ! ARGS=$(getopt --options vdm:D: \
-		--long verbose,debug,memory:,debugfile: \
-		--name 'pkgctl foo' -- "$@"); then
-	exit 1
-fi
-
-eval set -- "$ARGS"
-
-echo "${ARGS}"
-
-while (( $# )); do
-  case "$1" in
-    -v | --verbose ) echo verbose; shift ;;
-    -d | --debug ) echo debug; shift ;;
-    -m | --memory ) echo "memory=$2"; shift 2 ;;
-    -D | --debugfile ) echo "debugfile=$2"; shift 2 ;;
-	--)
-		echo --
-		shift
-		break
-		;;
-	-*)
-		echo "invalid argument: %s" "$1"
-		exit 1
-		;;
-	*)
-		echo STAR "$1"
-		shift
-		;;
-  esac
-done
-
-echo main
-
-if (( ! $# )); then
-	echo missing positional param: version
-	exit 1
-fi
-version=$1
-shift
-
-echo "version $version"
-echo "$@"

src/diffpkg.in

@@ -5,6 +5,8 @@
 _DEVTOOLS_LIBRARY_DIR=${_DEVTOOLS_LIBRARY_DIR:-@pkgdatadir@}
 # shellcheck source=src/lib/common.sh
 source "${_DEVTOOLS_LIBRARY_DIR}"/lib/common.sh
+# shellcheck source=src/lib/util/util.sh
+source "${_DEVTOOLS_LIBRARY_DIR}"/lib/util/util.sh
 
 
 usage() {
@@ -26,6 +28,8 @@ usage() {
 
 		OPTIONS
 		    -M, --makepkg-config Set an alternate makepkg configuration file
+		    -M, --pacman-config  Set an alternate pacman configuration file
+		    --dbpath             Set an alternate pacman database path
 		    -P, --pool=DIR       Search diff target in pool dir (default '/srv/ftp/pool')
 		    -v, --verbose        Provide more detailed/unfiltered output
 		    -h, --help           Show this help text
@@ -37,12 +41,14 @@ usage() {
 		    -y, --side-by-side   Output in two columns
 		    -W, --width=NUM      Output at most NUM (default 'auto') print columns
 		                         NUM can be 'auto', 'columns' or a number
+		    --summary            Print a summary or warning message on disparity
 
 		MODES
 		    -l, --list           Activate content list diff mode (default)
 		    -d, --diffoscope     Activate diffoscope diff mode
 		    -p, --pkginfo        Activate .PKGINFO diff mode
 		    -b, --buildinfo      Activate .BUILDINFO diff mode
+		    -s, --soname         Activate library SONAME diff mode
 _EOF_
 }
 
@@ -54,11 +60,13 @@ TARLIST=0
 DIFFOSCOPE=0
 PKGINFO=0
 BUILDINFO=0
+SONAME=0
+SUMMARY=0
 
 DIFFMODE=--side-by-side
 DIFFCOLOR=--color=auto
 DIFFWIDTH=--width=auto
-DIFFOPTIONS=(--expand-tabs)
+DIFFOPTIONS=(--expand-tabs --suppress-common-lines)
 
 # option checking
 while (( $# )); do
@@ -88,10 +96,18 @@ while (( $# )); do
 			BUILDINFO=1
 			shift
 			;;
+		-s|--soname)
+			SONAME=1
+			shift
+			;;
 		-v|--verbose)
 			VERBOSE=1
 			shift
 			;;
+		--summary)
+			SUMMARY=1
+			shift
+			;;
 		-u|-U|--unified)
 			DIFFMODE=--unified
 			shift
@@ -135,7 +151,7 @@ while (( $# )); do
 			shift
 			break
 			;;
-		-*|--*)
+		-*)
 			die "invalid argument: %s" "$1"
 			;;
 		*)
@@ -158,6 +174,9 @@ fi
 if [[ $DIFFWIDTH != --width=auto ]]; then
 	DIFFOPTIONS+=("${DIFFWIDTH}")
 fi
+if [[ $DIFFCOLOR == --color=auto ]] && is_tty; then
+	DIFFCOLOR="--color=always"
+fi
 DIFFOPTIONS+=("${DIFFMODE}" "${DIFFCOLOR}")
 
 if ! (( DIFFOSCOPE || TARLIST || PKGINFO || BUILDINFO )); then
@@ -232,23 +251,31 @@ diff_pkgs() {
 		bsdtar xOqf "$newpkg" .BUILDINFO > "$TMPDIR/new"
 	fi
 
-	if (( TARLIST || PKGINFO || BUILDINFO )); then
+	if (( SONAME )); then
+		find-libprovides "$oldpkg" 2>/dev/null | sort > "$TMPDIR/old"
+		find-libprovides "$newpkg" 2>/dev/null | sort > "$TMPDIR/new"
+	fi
+
+	if (( TARLIST || PKGINFO || BUILDINFO || SONAME )); then
 		# Resolve dynamic auto width one we know the content to diff
 		if [[ $DIFFWIDTH == --width=auto ]]; then
 			AUTOLENGTH=$(file_diff_columns "$TMPDIR/old" "$TMPDIR/new")
 			DIFFOPTIONS+=("--width=${AUTOLENGTH}")
 		fi
 
+		if ! output=$(diff "${DIFFOPTIONS[@]}" "$TMPDIR/old" "$TMPDIR/new"); then
 			# Print a header for side-by-side view as it lacks labels
 			if [[ $DIFFMODE == --side-by-side ]]; then
-			printf -- "--- %s\n+++ %s\n" "${oldpkg}" "${newpkg}"
+				printf -- "%s--- %s\n+++ %s%s\n" "${BOLD}" "${oldpkg}" "${newpkg}" "${ALL_OFF}"
+			fi
+			printf "%s\n" "${output}"
+			return 1
 		fi
-
-		diff "${DIFFOPTIONS[@]}" "$TMPDIR/old" "$TMPDIR/new"
 	fi
 
 	if (( DIFFOSCOPE )); then
 		diffoscope "${DIFFCOLOR/--color/--text-color}" "$oldpkg" "$newpkg"
+		return $?
 	fi
 }
 
@@ -277,13 +304,14 @@ fetch_pkg() {
 		fi
 		# Search via pacman database if no pool file exists
 		if [[ ! -f ${pkgurl} ]]; then
-			pkgurl=$(pacman -Spdd --print-format '%l' --noconfirm "$pkg") ||
+			pkgurl=$(pacman -Spdd --print-format '%l' --noconfirm -- "$pkg") ||
 				die "Couldn't download previous package for %s." "$pkg"
+			# TODO: check and download via Swdd so we also do signatures checks before processing
 		fi
 	fi
 
 	pkg=${pkgurl##*/}
-	pkgdest=$(mktemp -t -d "${pkg}-XXXXXX")/${pkg}
+	pkgdest=$(mktemp -t -d -- "${pkg}-XXXXXX")/${pkg}
 
 	if [[ $pkgurl = file://* || ( $pkgurl = /* && -f $pkgurl ) ]]; then
 		ln -sf "${pkgurl#file://}" "$pkgdest"
@@ -313,6 +341,7 @@ if (( $# < 2 )); then
 		CARCH='any'
 	fi
 
+	ret=0
 	for _pkgname in "${pkgname[@]}"; do
 		comparepkg=$_pkgname
 		pkgurl=
@@ -330,10 +359,13 @@ if (( $# < 2 )); then
 		oldpkg=$(fetch_pkg "$comparepkg") || exit 1
 
 		diff_pkgs "$oldpkg" "$pkgfile"
+		ret+=$?
 	done
+	exit $ret
 else
 	file1=$(fetch_pkg "$1") || exit 1
 	file2=$(fetch_pkg "$2") || exit 1
 
 	diff_pkgs "$file1" "$file2"
+	exit $?
 fi

src/lib/build/build.sh

@@ -128,7 +128,7 @@ pkgctl_build() {
 	local WORKER="${USER}-${PTS}"
 
 	# variables
-	local path pkgbase pkgrepo source
+	local path pkgbase pkgrepo source soname_changed=0
 
 	while (( $# )); do
 		case $1 in
@@ -169,8 +169,6 @@ pkgctl_build() {
 				shift
 				;;
 			--rebuild)
-				# shellcheck source=src/lib/util/git.sh
-				source "${_DEVTOOLS_LIBRARY_DIR}"/lib/util/git.sh
 				pkgctl_build_check_option_group_ver '--rebuild' "${PKGVER}" "${PKGREL}" "${REBUILD}"
 				REBUILD=1
 				shift
@@ -268,6 +266,7 @@ pkgctl_build() {
 		. ./PKGBUILD
 		pkgbase=${pkgbase:-$pkgname}
 		pkgrepo=${REPO}
+		soname_changed=0
 		msg "Building ${pkgbase}"
 
 		# auto-detection of build target
@@ -396,6 +395,11 @@ pkgctl_build() {
 
 		# release the build
 		if (( RELEASE )); then
+			if [[ ${pkgrepo} != *-staging ]] && ! diffpkg --soname >/dev/null; then
+				die "abort none staging auto-release: package contains soname differences"
+			fi
+			echo RELEASE, ABORT
+			exit 0
 			pkgctl_release --repo "${pkgrepo}" "${RELEASE_OPTIONS[@]}"
 		fi
 

src/lib/util/util.sh

@@ -0,0 +1,19 @@
+#!/hint/bash
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+[[ -z ${DEVTOOLS_INCLUDE_UTIL_UTIL_SH:-} ]] || return 0
+DEVTOOLS_INCLUDE_UTIL_UTIL_SH=1
+
+_DEVTOOLS_LIBRARY_DIR=${_DEVTOOLS_LIBRARY_DIR:-@pkgdatadir@}
+
+
+is_tty() {
+	if [ ! -t 1 ] || [ -p /dev/stdout ]; then
+		return 1
+	fi
+	if [[ $TERM == dumb ]]; then
+		return 1
+	fi
+	return 0
+}

src/lib/version/version.sh

@@ -1,47 +0,0 @@
-#!/hint/bash
-#
-# SPDX-License-Identifier: GPL-3.0-or-later
-
-[[ -z ${DEVTOOLS_INCLUDE_VERSION_SH:-} ]] || return 0
-DEVTOOLS_INCLUDE_VERSION_SH=1
-
-_DEVTOOLS_LIBRARY_DIR=${_DEVTOOLS_LIBRARY_DIR:-@pkgdatadir@}
-
-source /usr/share/makepkg/util/message.sh
-
-set -e
-
-
-pkgctl_version_usage() {
-	local -r COMMAND=${_DEVTOOLS_COMMAND:-${BASH_SOURCE[0]##*/}}
-    cat <<- _EOF_
-		Usage: ${COMMAND} [OPTIONS]
-
-		Shows the current version information of pkgctl
-
-		OPTIONS
-		    -h, --help    Show this help text
-_EOF_
-}
-
-pkgctl_version_print() {
-	cat <<- _EOF_
-		pkgctl @buildtoolver@
-_EOF_
-}
-
-pkgctl_version() {
-	while (( $# )); do
-		case $1 in
-			-h|--help)
-				pkgctl_version_usage
-				exit 0
-				;;
-			*)
-				die "invalid argument: %s" "$1"
-				;;
-		esac
-	done
-
-	pkgctl_version_print
-}

src/pkgctl.in

@@ -25,7 +25,6 @@ usage() {
 		    diff    Compare package files using different modes
 		    release Release step to commit, tag and upload build artifacts
 		    repo    Manage Git packaging repositories and their configuration
-		    version Show pkgctl version information
 
 		OPTIONS
 		    -h, --help     Show this help text
@@ -94,14 +93,6 @@ while (( $# )); do
 			pkgctl_release "$@"
 			exit 0
 			;;
-		version|--version|-V)
-			_DEVTOOLS_COMMAND+=" $1"
-			shift
-			# shellcheck source=src/lib/version/version.sh
-			source "${_DEVTOOLS_LIBRARY_DIR}"/lib/version/version.sh
-			pkgctl_version "$@"
-			exit 0
-			;;
 		*)
 			die "invalid command: %s" "$1"
 			;;