Merge branch 'version-full-progress' into 'master'

feat(version): enhance version check spinner to progressively update the full pretty output

See merge request archlinux/devtools!313

contrib/completion/bash/devtools.in

@@ -150,6 +150,7 @@ _pkgctl_cmds=(
 	db
 	diff
 	issue
+	license
 	release
 	repo
 	search

src/commitpkg.in

@@ -123,9 +123,10 @@ fi
 needsversioning=()
 
 if [[ ! -e REUSE.toml || ! -e LICENSE || ! -d LICENSES ]]; then
-	error "package doesn't have proper licensing information, set it up using:"
+	# TODO: Make this a hard failure in the future after packagers have had
+	# some time to add licenses to all packages.
+	warning "package doesn't have proper licensing information, set it up using:"
 	msg2 'pkgctl license setup'
-	exit 1
 else
 	pkgctl license check
 	needsversioning+=(REUSE.toml LICENSE LICENSES/*)
@@ -154,7 +155,7 @@ if (( ${#needsversioning[*]} )); then
 		if [[ ! -f "${file}" ]]; then
 			continue
 		fi
-		if ! git ls-files --error-unmatch "$file"; then
+		if ! git ls-files --error-unmatch "$file" >/dev/null; then
 			die "%s is not under version control" "$file"
 		fi
 	done

src/lib/license/setup.sh

@@ -191,7 +191,9 @@ path = [
     ".nvchecker.toml",
     "*.install",
     "*.sysusers",
+    "*sysusers.conf",
     "*.tmpfiles",
+    "*tmpfiles.conf",
     "*.logrotate",
     "*.pam",
     "*.service",

src/lib/version/check.sh

@@ -140,6 +140,32 @@ pkgctl_version_check() {
 		pushd "${path}" >/dev/null
 
 		if [[ ${output_format} == pretty ]]; then
+			# initialize the tmp file for status output
+			section_separator=''
+			printf "" > "${status_dir}/tmp"
+
+			# update the current list of failed packages
+			if (( ${#failure[@]} > 0 )); then
+				exit_code=${PKGCTL_VERSION_CHECK_EXIT_FAILURE}
+				printf "%sFailure%s\n" "${section_separator}${BOLD}${UNDERLINE}" "${ALL_OFF}" >> "${status_dir}/tmp" 2>&1
+				section_separator=$'\n'
+				for result in "${failure[@]}"; do
+					msg_error " ${result}" >> "${status_dir}/tmp" 2>&1
+				done
+			fi
+
+			# update the current list of out-of-date packages
+			if (( ${#out_of_date[@]} > 0 )); then
+				exit_code=${PKGCTL_VERSION_CHECK_EXIT_OUT_OF_DATE}
+				printf "%sOut-of-date%s\n" "${section_separator}${BOLD}${UNDERLINE}" "${ALL_OFF}" >> "${status_dir}/tmp" 2>&1
+				section_separator=$'\n'
+				for result in "${out_of_date[@]}"; do
+					msg_warn " ${result}" >> "${status_dir}/tmp" 2>&1
+				done
+			fi
+
+			printf "%s" "${section_separator}" >> "${status_dir}/tmp"
+
 			# update the current terminal spinner status
 			(( ++current_item ))
 			pkgctl_version_check_spinner \
@@ -217,6 +243,9 @@ pkgctl_version_check() {
 		return 0
 	fi
 
+	# reset the section separator after loop
+	section_separator=''
+
 	if (( verbose )) && (( ${#up_to_date[@]} > 0 )); then
 		printf "%sUp-to-date%s\n" "${section_separator}${BOLD}${UNDERLINE}" "${ALL_OFF}"
 		section_separator=$'\n'
@@ -408,7 +437,7 @@ pkgctl_version_check_spinner() {
 	pkgctl_version_check_summary \
 		"${up_to_date_count}" \
 		"${out_of_date_count}" \
-		"${failure_count}" > "${tmp_file}"
+		"${failure_count}" >> "${tmp_file}"
 
 	# print the progress status
 	printf "📡 Checking: %s/%s [%s] %%spinner%%" \