[partition] Log partition-model lookup failures

[partition] Stub validator for LV name
- An empty LV name isn't allowed, but the create-partition-dialog doesn't check for that.
2021-12-15 13:57:20 +01:00 · 2021-12-15 13:01:58 +01:00 · 2021-12-15 12:19:59 +01:00 · 2021-12-15 00:30:23 +01:00 · 2021-12-15 00:20:23 +01:00 · 2021-12-14 17:52:13 +01:00
61 changed files with 435 additions and 10526 deletions
--- a/CHANGES-3.2
+++ b/CHANGES-3.2
@@ -7,42 +7,22 @@ contributors are listed. Note that Calamares does not have a historical
 changelog -- this log starts with version 3.2.0. The release notes on the
 website will have to do for older versions.

-# 3.2.50 (2022-01-18) #
+# 3.2.50 (unreleased) #

 This release contains contributions from (alphabetically by first name):
- - Anke Boersma
 - Erik Dubois
- - Evan James
- - Johannes Kamprad
- - Taejun Park (new contributor, welcome!)
-
-**Replacement notice:** The *umount* module will be replaced by a C++
-implementation in the next release. The "preserve log file" feature
-will be removed in that release. Use the *preservefiles* module instead.

 ## Core ##
 - No core changes yet

 ## Modules ##
- - *initcpiocfg* mentioned a special kernel-name "all", which did not work,
-   and a special kernel-name "$uname" which cannot work. Fixed the former
-   and removed the "$uname" special key. (Thanks Evan)
- - *luksswaphookcfg* has been converted to a C++ module.
 - *networkcfg* could fail to update the NetworkManager configuration
   if the SSID or username contained non-ASCII characters **and** the
   default Python text-file encoding was set to ASCII. The files are
   now read and written in UTF-8, explicitly. #1848
- - *partition* always sets *bigtime* option on XFS filesystems, if possible.
-   Requires sufficiently-recent xfsprogs. #1874
 - *preservefiles* was missing some necessary features, needed for it
   to replace the deprecated log-file-saving functionality in the *umount*
   module. (Thanks Erik and Joe for testing) #1851
- - *umount* is now marked as an emergency module in the example configuration,
-   since it should **probably** be run as a cleanup. (Thanks Evan)
- - *welcome* and *locale* could be confusing, together, and configure
-   the target system with a language that does not match the installer
-   language, even though the user did not make any explicit choice.
-   (Thanks Taejun) #1864


 # 3.2.49.1 (2021-12-11) #
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -45,7 +45,7 @@ project( CALAMARES
    LANGUAGES C CXX
 )

-set( CALAMARES_VERSION_RC 0 )  # Set to 0 during release cycle, 1 during development
+set( CALAMARES_VERSION_RC 1 )  # Set to 0 during release cycle, 1 during development
 if( CALAMARES_VERSION_RC EQUAL 1 AND CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR )
    message( FATAL_ERROR "Do not build development versions in the source-directory." )
 endif()
@@ -135,15 +135,15 @@ set( CALAMARES_DESCRIPTION_SUMMARY
 # NOTE: update these lines by running `txstats.py`, or for full automation
 #       `txstats.py -e`. See also
 #
-# Total 74 languages
-set( _tx_complete az az_AZ ca de fa fi_FI he hi hr ja ko lt pt_BR
-    pt_PT si sq sv tr_TR uk zh_TW )
-set( _tx_good as be ca@valencia cs_CZ da fr fur it_IT ml nl ru sk
-    tg vi zh_CN )
+# Total 81 languages
+set( _tx_complete az az_AZ ca de fa fi_FI he hr ja ko lt pt_PT si
+    sq tr_TR uk zh_TW )
+set( _tx_good as be ca@valencia cs_CZ da fr fur hi it_IT ml nl
+    pt_BR ru sk sv tg vi zh_CN )
 set( _tx_ok ar ast bg bn el en_GB es es_MX et eu gl hu id is mr nb
    pl ro sl sr sr@latin th )
-set( _tx_incomplete eo es_PR gu ie kk kn lo lv mk ne ne_NP ta_IN te
-    ur zh zh_HK )
+set( _tx_incomplete en_HK en_IN eo es_PE es_PR fr_CH gu hi_IN id_ID
+    ie kk kn ko_KR lo lv mk ne ne_NP te te_IN ur zh zh_HK )

 ### Required versions
 #
--- a/README.md
+++ b/README.md
@@ -8,7 +8,7 @@
 [![Current issue](https://img.shields.io/badge/issue-in_progress-FE9B48)](https://github.com/calamares/calamares/labels/hacking%3A%20in-progress)
 [![GitHub release](https://img.shields.io/github/release/calamares/calamares.svg)](https://github.com/calamares/calamares/releases)
 [![GitHub Build Status](https://img.shields.io/github/workflow/status/calamares/calamares/ci?label=GH%20build)](https://github.com/calamares/calamares/actions?query=workflow%3Aci)
-[![GitHub license](https://img.shields.io/github/license/calamares/calamares.svg)](https://github.com/calamares/calamares/blob/calamares/LICENSES/GPL-3.0-or-later.txt)
+[![GitHub license](https://img.shields.io/github/license/calamares/calamares.svg)](https://github.com/calamares/calamares/blob/calamares/LICENSE)


 | [Report a Bug](https://github.com/calamares/calamares/issues/new) | [Translate](https://www.transifex.com/projects/p/calamares/) | [Contribute](CONTRIBUTING.md) | [Matrix: #calamares:kde.org](https://webchat.kde.org/#/room/%23calamares:kde.org) | [IRC: Libera.Chat #calamares](https://kiwiirc.com/client/irc.libera.chat/#calamares) | [Wiki](https://github.com/calamares/calamares/wiki) |
--- a/lang/calamares_cs_CZ.ts
+++ b/lang/calamares_cs_CZ.ts
@@ -693,27 +693,27 @@ Instalační program bude ukončen a všechny změny ztraceny.</translation>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="259"/>
      <source>Successfully unmounted %1.</source>
-      <translation>Úspěšně odpojeno %1.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="266"/>
      <source>Successfully disabled swap %1.</source>
-      <translation>Úspěšně vypnut swap %1.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="292"/>
      <source>Successfully cleared swap %1.</source>
-      <translation>Úspěšně vyčištěn swap %1.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="306"/>
      <source>Successfully closed mapper device %1.</source>
-      <translation>Úspěšně zavřeno mapper zařízení %1.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="319"/>
      <source>Successfully disabled volume group %1.</source>
-      <translation>Úspěšně vypnuta skupina svazků %1.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="358"/>
--- a/lang/calamares_en_GB.ts
+++ b/lang/calamares_en_GB.ts
@@ -1989,7 +1989,7 @@ The installer will quit and all changes will be lost.</translation>
    <message>
      <location filename="../src/modules/machineid/MachineIdJob.cpp" line="53"/>
      <source>Configuration Error</source>
-      <translation>Configuration  Error </translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/machineid/MachineIdJob.cpp" line="54"/>
--- a/lang/calamares_hi.ts
+++ b/lang/calamares_hi.ts
@@ -689,27 +689,27 @@ The installer will quit and all changes will be lost.</source>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="259"/>
      <source>Successfully unmounted %1.</source>
-      <translation>%1 को माउंट से हटाना सफल।</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="266"/>
      <source>Successfully disabled swap %1.</source>
-      <translation>%1 स्वैप निष्क्रिय करना सफल।</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="292"/>
      <source>Successfully cleared swap %1.</source>
-      <translation>%1 स्वैप रिक्त करना सफल।</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="306"/>
      <source>Successfully closed mapper device %1.</source>
-      <translation>प्रतिचित्रण उपकरण %1 बंद करना सफल।</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="319"/>
      <source>Successfully disabled volume group %1.</source>
-      <translation>वॉल्यूम समूह %1 निष्क्रिय करना सफल।</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="358"/>
--- a/lang/calamares_id.ts
+++ b/lang/calamares_id.ts
@@ -6,7 +6,7 @@
    <message>
      <location filename="../src/modules/partition/jobs/AutoMountManagementJob.cpp" line="22"/>
      <source>Manage auto-mount settings</source>
-      <translation>Kelola pengaturan mount otomatis</translation>
+      <translation type="unfinished"/>
    </message>
  </context>
  <context>
@@ -114,12 +114,12 @@
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="141"/>
      <source>Uploads the session log to the configured pastebin.</source>
-      <translation>Unggah catatan sesi ke pastebin yang telah dikonfigurasi.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="144"/>
      <source>Send Session Log</source>
-      <translation>Kirim Catatan Sesi</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="118"/>
@@ -165,7 +165,7 @@
    <message>
      <location filename="../src/libcalamares/JobExample.cpp" line="30"/>
      <source>Programmed job failure was explicitly requested.</source>
-      <translation>Kegagalan pekerjaan diprogram diminta secara eksplisit. </translation>
+      <translation type="unfinished"/>
    </message>
  </context>
  <context>
@@ -189,7 +189,7 @@
    <message>
      <location filename="../src/libcalamares/ProcessJob.cpp" line="43"/>
      <source>Run command '%1' in target system.</source>
-      <translation>Jalankan perintah '%1' pada sistem target.</translation>
+      <translation>Jalankan perintah '%1' di dalam sistem target.</translation>
    </message>
    <message>
      <location filename="../src/libcalamares/ProcessJob.cpp" line="43"/>
@@ -245,7 +245,7 @@
    <message>
      <location filename="../src/libcalamaresui/viewpages/QmlViewStep.cpp" line="88"/>
      <source>QML Step &lt;i&gt;%1&lt;/i&gt;.</source>
-      <translation>QML Langkah &lt;i&gt;%1&lt;/i&gt;.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/libcalamaresui/viewpages/QmlViewStep.cpp" line="268"/>
@@ -277,7 +277,7 @@
    <message>
      <location filename="../src/libcalamares/modulesystem/RequirementsChecker.cpp" line="121"/>
      <source>System-requirements checking is complete.</source>
-      <translation>Pengecekan kebutuhan sistem telah selesai.</translation>
+      <translation type="unfinished"/>
    </message>
  </context>
  <context>
@@ -295,7 +295,7 @@
    <message>
      <location filename="../src/libcalamaresui/ViewManager.cpp" line="163"/>
      <source>Would you like to paste the install log to the web?</source>
-      <translation>Maukah anda menempelkan log instalasi ke situs?</translation>
+      <translation>Maukah anda untuk menempelkan log instalasi ke situs?</translation>
    </message>
    <message>
      <location filename="../src/libcalamaresui/ViewManager.cpp" line="179"/>
@@ -429,7 +429,7 @@ Link copied to clipboard</source>
    <message>
      <location filename="../src/libcalamaresui/ViewManager.cpp" line="425"/>
      <source>&amp;Done</source>
-      <translation>&amp;Selesai</translation>
+      <translation>&amp;Kelar</translation>
    </message>
    <message>
      <location filename="../src/libcalamaresui/ViewManager.cpp" line="444"/>
@@ -1054,12 +1054,12 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/partition/gui/CreatePartitionDialog.ui" line="231"/>
      <source>Label for the filesystem</source>
-      <translation>Label untuk filesystem</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/gui/CreatePartitionDialog.ui" line="241"/>
      <source>FS Label:</source>
-      <translation>Label FS:</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/gui/CreatePartitionDialog.cpp" line="65"/>
@@ -1418,12 +1418,12 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/partition/gui/EditExistingPartitionDialog.ui" line="186"/>
      <source>Label for the filesystem</source>
-      <translation>Label untuk filesystem</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/gui/EditExistingPartitionDialog.ui" line="196"/>
      <source>FS Label:</source>
-      <translation>Label FS:</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/gui/EditExistingPartitionDialog.cpp" line="291"/>
@@ -1582,7 +1582,7 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/partition/jobs/FormatPartitionJob.cpp" line="36"/>
      <source>Format partition %1 (file system: %2, size: %3 MiB) on %4.</source>
-      <translation>Format partisi %1 (file system: %2, ukuran %3 MiB) pada %4.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/FormatPartitionJob.cpp" line="47"/>
@@ -1645,12 +1645,12 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/welcome/checker/GeneralRequirements.cpp" line="193"/>
      <source>is running the installer as an administrator (root)</source>
-      <translation>menjalankan installer sebagai administrator (root)</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/welcome/checker/GeneralRequirements.cpp" line="196"/>
      <source>The setup program is not running with administrator rights.</source>
-      <translation>Installer tidak dijalankan dengan kewenangan administrator.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/welcome/checker/GeneralRequirements.cpp" line="197"/>
@@ -1699,7 +1699,7 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/oemid/IDJob.cpp" line="53"/>
      <source>Could not open file &lt;code&gt;%1&lt;/code&gt;.</source>
-      <translation>Tidak dapat membuka berkas &lt;code&gt;%1&lt;/code&gt;.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/oemid/IDJob.cpp" line="60"/>
@@ -1712,7 +1712,7 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/initcpio/InitcpioJob.cpp" line="31"/>
      <source>Creating initramfs with mkinitcpio.</source>
-      <translation>Membuat initramfs menggunakan mkinitcpio.</translation>
+      <translation type="unfinished"/>
    </message>
  </context>
  <context>
@@ -1720,7 +1720,7 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/initramfs/InitramfsJob.cpp" line="28"/>
      <source>Creating initramfs.</source>
-      <translation>Membuat initramfs.</translation>
+      <translation type="unfinished"/>
    </message>
  </context>
  <context>
@@ -2031,12 +2031,12 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/netinstall/NetInstallViewStep.cpp" line="52"/>
      <source>Browser software</source>
-      <translation>Perangkat lunak peramban</translation>
+      <translation>Peramban perangkat lunak</translation>
    </message>
    <message>
      <location filename="../src/modules/netinstall/NetInstallViewStep.cpp" line="53"/>
      <source>Browser package</source>
-      <translation>Paket peramban</translation>
+      <translation>Peramban paket</translation>
    </message>
    <message>
      <location filename="../src/modules/netinstall/NetInstallViewStep.cpp" line="54"/>
@@ -2046,12 +2046,12 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
    <message>
      <location filename="../src/modules/netinstall/NetInstallViewStep.cpp" line="55"/>
      <source>Kernel</source>
-      <translation>Kernel</translation>
+      <translation>Inti</translation>
    </message>
    <message>
      <location filename="../src/modules/netinstall/NetInstallViewStep.cpp" line="56"/>
      <source>Services</source>
-      <translation>Servis</translation>
+      <translation>Jasa</translation>
    </message>
    <message>
      <location filename="../src/modules/netinstall/NetInstallViewStep.cpp" line="57"/>
@@ -2587,12 +2587,12 @@ Instalasi dapat dilanjutkan, namun beberapa fitur akan dinonfungsikan.</translat
      <location filename="../src/modules/users/page_usersetup.ui" line="380"/>
      <location filename="../src/modules/users/page_usersetup.ui" line="550"/>
      <source>Repeat Password</source>
-      <translation>Ulangi Kata Sandi</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/users/page_usersetup.ui" line="455"/>
      <source>When this box is checked, password-strength checking is done and you will not be able to use a weak password.</source>
-      <translation>Ketikan kotak ini dicentang, pengecekan kekuatan kata sandi akan dilakukan dan anda tidak akan dapat menggunakan kata sandi yang lemah.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/users/page_usersetup.ui" line="458"/>
@@ -4252,7 +4252,7 @@ Keluaran:
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="136"/>
      <source>root is not allowed as username.</source>
-      <translation>root tidak boleh digunakan sebagai nama pengguna.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="145"/>
@@ -4287,7 +4287,7 @@ Keluaran:
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="234"/>
      <source>Repeat Password</source>
-      <translation>Ulangi Kata Sandi</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="261"/>
@@ -4297,27 +4297,27 @@ Keluaran:
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="406"/>
      <source>Validate passwords quality</source>
-      <translation>Validasi kualitas kata sandi</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="416"/>
      <source>When this box is checked, password-strength checking is done and you will not be able to use a weak password.</source>
-      <translation>Ketikan kotak ini dicentang, pengecekan kekuatan kata sandi akan dilakukan dan anda tidak akan dapat menggunakan kata sandi yang lemah.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="398"/>
      <source>Log in automatically without asking for the password</source>
-      <translation>Masuk ke dalam sesi secara otomatis tanpa menanyakan kata sandi</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="190"/>
      <source>Only letters, numbers, underscore and hyphen are allowed, minimal of two characters.</source>
-      <translation>Hanya huruf, angka, garis bawah, dan tanda hubung yang diperbolehkan, minimal dua karakter.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="293"/>
      <source>Reuse user password as root password</source>
-      <translation>Gunakan kata sandi pengguna sebagai kata sandi root</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="301"/>
@@ -4332,12 +4332,12 @@ Keluaran:
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="324"/>
      <source>Root Password</source>
-      <translation>Kata Sandi Root</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="342"/>
      <source>Repeat Root Password</source>
-      <translation>Ulangi Kata Sandi</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/usersq/usersq.qml" line="368"/>
--- a/lang/calamares_ja-Hira.ts
+++ b/lang/calamares_ja-Hira.ts
--- a/lang/calamares_pt_PT.ts
+++ b/lang/calamares_pt_PT.ts
@@ -2014,7 +2014,7 @@ O instalador será encerrado e todas as alterações serão perdidas.</translati
      <source>Please select your preferred location on the map so the installer can suggest the locale
            and timezone settings for you. You can fine-tune the suggested settings below. Search the map by dragging
            to move and using the +/- buttons to zoom in/out or use mouse scrolling for zooming.</source>
-      <translation>Selecione o seu local preferido no mapa para que o instalador possa sugerir a localização
+      <translation>Por favor selecione o seu local preferido no mapa para que o instalador possa sugerir a localização
            e fuso horário para si. Pode ajustar as definições sugeridas abaixo. Procure no mapa arrastando
            para mover e utilizando os botões +/- para aumentar/diminuir ou utilize a roda do rato para dar zoom.</translation>
    </message>
@@ -4003,7 +4003,7 @@ Saída de Dados:
    <message>
      <location filename="../src/modules/welcome/WelcomePage.cpp" line="238"/>
      <source>&lt;h1&gt;%1&lt;/h1&gt;&lt;br/&gt;&lt;strong&gt;%2&lt;br/&gt;for %3&lt;/strong&gt;&lt;br/&gt;&lt;br/&gt;Copyright 2014-2017 Teo Mrnjavac &amp;lt;teo@kde.org&amp;gt;&lt;br/&gt;Copyright 2017-2020 Adriaan de Groot &amp;lt;groot@kde.org&amp;gt;&lt;br/&gt;Thanks to &lt;a href="https://calamares.io/team/"&gt;the Calamares team&lt;/a&gt; and the &lt;a href="https://www.transifex.com/calamares/calamares/"&gt;Calamares translators team&lt;/a&gt;.&lt;br/&gt;&lt;br/&gt;&lt;a href="https://calamares.io/"&gt;Calamares&lt;/a&gt; development is sponsored by &lt;br/&gt;&lt;a href="http://www.blue-systems.com/"&gt;Blue Systems&lt;/a&gt; - Liberating Software.</source>
-      <translation>&lt;h1&gt;%1&lt;/h1&gt;&lt;br/&gt;&lt;strong&gt;%2&lt;br/&gt;para o %3&lt;/strong&gt;&lt;br/&gt;&lt;br/&gt;Copyright 2014-2017 Teo Mrnjavac &amp;lt;teo@kde.org&amp;gt;&lt;br/&gt;Copyright 2017-2020 Adriaan de Groot &amp;lt;groot@kde.org&amp;gt;&lt;br/&gt;Obrigado à &lt;a href="https://calamares.io/team/"&gt;equipa Calamares&lt;/a&gt; e à &lt;a href="https://www.transifex.com/calamares/calamares/"&gt;equipa de tradutores do Calamares&lt;/a&gt;.&lt;br/&gt;&lt;br/&gt;O desenvolvimento do &lt;a href="https://calamares.io/"&gt;Calamares&lt;/a&gt; é patrocinado pela &lt;br/&gt;&lt;a href="http://www.blue-systems.com/"&gt;Blue Systems&lt;/a&gt; - Liberating Software.</translation>
+      <translation>&lt;h1&gt;%1&lt;/h1&gt;&lt;br/&gt;&lt;strong&gt;%2&lt;br/&gt;para %3&lt;/strong&gt;&lt;br/&gt;&lt;br/&gt;Copyright 2014-2017 Teo Mrnjavac &amp;lt;teo@kde.org&amp;gt;&lt;br/&gt;Copyright 2017-2020 Adriaan de Groot &amp;lt;groot@kde.org&amp;gt;&lt;br/&gt;Obrigado à &lt;a href="https://calamares.io/team/"&gt;equipa Calamares&lt;/a&gt; e à &lt;a href="https://www.transifex.com/calamares/calamares/"&gt;equipa de tradutores do Calamares&lt;/a&gt;.&lt;br/&gt;&lt;br/&gt;O desenvolvimento do &lt;a href="https://calamares.io/"&gt;Calamares&lt;/a&gt; é patrocinado pela &lt;br/&gt;&lt;a href="http://www.blue-systems.com/"&gt;Blue Systems&lt;/a&gt; - Liberating Software.</translation>
    </message>
  </context>
  <context>
--- a/lang/calamares_ro.ts
+++ b/lang/calamares_ro.ts
@@ -104,17 +104,17 @@
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="102"/>
      <source>Crashes Calamares, so that Dr. Konqui can look at it.</source>
-      <translation>Dă crash lui Calamares, pentru ca doctorul Konqui să se uite la el.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="115"/>
      <source>Reloads the stylesheet from the branding directory.</source>
-      <translation>Reîncarcă foaia de stil din directorul branding.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="141"/>
      <source>Uploads the session log to the configured pastebin.</source>
-      <translation>Încarcă jurnalul sesiunii pe pastebin-ul configurat.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="144"/>
@@ -134,7 +134,7 @@
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="131"/>
      <source>Widget Tree</source>
-      <translation>Arborele de widget</translation>
+      <translation>Lista widget</translation>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.cpp" line="221"/>
@@ -1991,7 +1991,7 @@ Programul de instalare va ieși, iar toate modificările vor fi pierdute.</trans
    <message>
      <location filename="../src/modules/machineid/MachineIdJob.cpp" line="53"/>
      <source>Configuration Error</source>
-      <translation>Eroare de configurare</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/machineid/MachineIdJob.cpp" line="54"/>
--- a/lang/calamares_ta_IN.ts
+++ b/lang/calamares_ta_IN.ts
--- a/lang/calamares_tg.ts
+++ b/lang/calamares_tg.ts
@@ -6,7 +6,7 @@
    <message>
      <location filename="../src/modules/partition/jobs/AutoMountManagementJob.cpp" line="22"/>
      <source>Manage auto-mount settings</source>
-      <translation>Идора кардани танзимоти васлкунии худкор</translation>
+      <translation type="unfinished"/>
    </message>
  </context>
  <context>
--- a/lang/calamares_vi.ts
+++ b/lang/calamares_vi.ts
@@ -6,7 +6,7 @@
    <message>
      <location filename="../src/modules/partition/jobs/AutoMountManagementJob.cpp" line="22"/>
      <source>Manage auto-mount settings</source>
-      <translation>Quản lý cài đặt tự động gắn kết(auto-mount)</translation>
+      <translation type="unfinished"/>
    </message>
  </context>
  <context>
@@ -104,22 +104,22 @@
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="102"/>
      <source>Crashes Calamares, so that Dr. Konqui can look at it.</source>
-      <translation>Gây crash Calamares, để Dr. Konqui có thể xem nó.</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="115"/>
      <source>Reloads the stylesheet from the branding directory.</source>
-      <translation>Tải lại stylesheet từ thư mục branding</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="141"/>
      <source>Uploads the session log to the configured pastebin.</source>
-      <translation>Đăng tải log của phiên này lên pastebin đã được cấu hình</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="144"/>
      <source>Send Session Log</source>
-      <translation>Gửi log của phiên này</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="118"/>
@@ -129,7 +129,7 @@
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="128"/>
      <source>Displays the tree of widget names in the log (for stylesheet debugging).</source>
-      <translation>Hiễn thị cây của tên widget trong log(để gỡ lỗi stylesheet)</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/calamares/DebugWindow.ui" line="131"/>
--- a/lang/calamares_zh_CN.ts
+++ b/lang/calamares_zh_CN.ts
@@ -688,27 +688,27 @@ The installer will quit and all changes will be lost.</source>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="259"/>
      <source>Successfully unmounted %1.</source>
-      <translation>成功卸载了 %1。</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="266"/>
      <source>Successfully disabled swap %1.</source>
-      <translation>成功禁用了交换空间 %1。</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="292"/>
      <source>Successfully cleared swap %1.</source>
-      <translation>成功清理了交换空间 %1。</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="306"/>
      <source>Successfully closed mapper device %1.</source>
-      <translation>成功关闭了映射设备 %1。</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="319"/>
      <source>Successfully disabled volume group %1.</source>
-      <translation>成功禁用了卷组  %1。</translation>
+      <translation type="unfinished"/>
    </message>
    <message>
      <location filename="../src/modules/partition/jobs/ClearMountsJob.cpp" line="358"/>
--- a/lang/python/cs_CZ/LC_MESSAGES/python.po
+++ b/lang/python/cs_CZ/LC_MESSAGES/python.po
@@ -6,7 +6,7 @@
 # Translators:
 # pavelrz, 2017
 # LiberteCzech <martin.kriz.czech@gmail.com>, 2020
-# Pavel Borecki <pavel.borecki@gmail.com>, 2022
+# Pavel Borecki <pavel.borecki@gmail.com>, 2021
 # 
 #, fuzzy
 msgid ""
@@ -15,7 +15,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2021-11-02 15:45+0100\n"
 "PO-Revision-Date: 2017-08-09 10:34+0000\n"
-"Last-Translator: Pavel Borecki <pavel.borecki@gmail.com>, 2022\n"
+"Last-Translator: Pavel Borecki <pavel.borecki@gmail.com>, 2021\n"
 "Language-Team: Czech (Czech Republic) (https://www.transifex.com/calamares/teams/20061/cs_CZ/)\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
@@ -331,7 +331,7 @@ msgstr "Nedaří se zapnout systemd službu <code>{name!s}</code>."

 #: src/modules/services-systemd/main.py:67
 msgid "Cannot enable systemd timer <code>{name!s}</code>."
-msgstr "Nedaří se zapnout systemd časovač <code>{name!s}</code>."
+msgstr ""

 #: src/modules/services-systemd/main.py:71
 msgid "Cannot disable systemd target <code>{name!s}</code>."
@@ -413,8 +413,6 @@ msgid ""
 "Failed to find unsquashfs, make sure you have the squashfs-tools package "
 "installed."
 msgstr ""
-"Nepodařilo se nalézt nástroj unsquashfs – ověřte, že je nainstalovaný "
-"balíček squashfs-tools."

 #: src/modules/unpackfs/main.py:479
 msgid "The destination \"{}\" in the target system is not a directory"
--- a/lang/python/en_GB/LC_MESSAGES/python.po
+++ b/lang/python/en_GB/LC_MESSAGES/python.po
@@ -5,7 +5,6 @@
 # 
 # Translators:
 # Jason Collins <JasonPCollins@protonmail.com>, 2018
-# Karthik Balan, 2021
 # 
 #, fuzzy
 msgid ""
@@ -14,7 +13,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2021-11-02 15:45+0100\n"
 "PO-Revision-Date: 2017-08-09 10:34+0000\n"
-"Last-Translator: Karthik Balan, 2021\n"
+"Last-Translator: Jason Collins <JasonPCollins@protonmail.com>, 2018\n"
 "Language-Team: English (United Kingdom) (https://www.transifex.com/calamares/teams/20061/en_GB/)\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
@@ -36,7 +35,7 @@ msgstr ""
 #: src/modules/luksopenswaphookcfg/main.py:86
 #: src/modules/luksopenswaphookcfg/main.py:90
 msgid "Configuration Error"
-msgstr "Configuration  Error "
+msgstr ""

 #: src/modules/initramfscfg/main.py:86 src/modules/fstab/main.py:356
 #: src/modules/initcpiocfg/main.py:228 src/modules/mount/main.py:145
@@ -62,7 +61,7 @@ msgstr ""

 #: src/modules/bootloader/main.py:508
 msgid "Bootloader installation error"
-msgstr "Bootloader installation error"
+msgstr ""

 #: src/modules/bootloader/main.py:509
 msgid ""
@@ -92,7 +91,7 @@ msgstr ""

 #: src/modules/displaymanager/main.py:526
 msgid "Cannot write KDM configuration file"
-msgstr "Cannot write KDM configuration file"
+msgstr ""

 #: src/modules/displaymanager/main.py:527
 msgid "KDM config file {!s} does not exist"
@@ -146,7 +145,7 @@ msgstr ""

 #: src/modules/services-openrc/main.py:29
 msgid "Configure OpenRC services"
-msgstr "Configure OpenRC services"
+msgstr ""

 #: src/modules/services-openrc/main.py:57
 msgid "Cannot add service {name!s} to run-level {level!s}."
@@ -174,7 +173,7 @@ msgstr ""

 #: src/modules/services-openrc/main.py:101
 msgid "Target runlevel does not exist"
-msgstr "Target runlevel does not exist"
+msgstr ""

 #: src/modules/services-openrc/main.py:102
 msgid ""
@@ -194,7 +193,7 @@ msgstr ""

 #: src/modules/networkcfg/main.py:29
 msgid "Saving network configuration."
-msgstr "Saving network configuration "
+msgstr ""

 #: src/modules/packages/main.py:50 src/modules/packages/main.py:59
 #: src/modules/packages/main.py:69
@@ -223,7 +222,7 @@ msgstr[1] "Removing %(num)d packages."
 #: src/modules/packages/main.py:638 src/modules/packages/main.py:650
 #: src/modules/packages/main.py:678
 msgid "Package Manager error"
-msgstr "Package Manager error"
+msgstr ""

 #: src/modules/packages/main.py:639
 msgid ""
--- a/lang/python/hi/LC_MESSAGES/python.po
+++ b/lang/python/hi/LC_MESSAGES/python.po
@@ -319,7 +319,7 @@ msgstr "systemd लक्ष्य <code>{name!s}</code>सक्रिय क

 #: src/modules/services-systemd/main.py:67
 msgid "Cannot enable systemd timer <code>{name!s}</code>."
-msgstr "systemd टाइमर <code>{name!s}</code>सक्रिय करना विफल।"
+msgstr ""

 #: src/modules/services-systemd/main.py:71
 msgid "Cannot disable systemd target <code>{name!s}</code>."
@@ -399,8 +399,6 @@ msgid ""
 "Failed to find unsquashfs, make sure you have the squashfs-tools package "
 "installed."
 msgstr ""
-"unsqaushfs खोजने में विफल, सुनिश्चित करें कि squashfs-tools पैकेज इंस्टॉल "
-"है।"

 #: src/modules/unpackfs/main.py:479
 msgid "The destination \"{}\" in the target system is not a directory"
--- a/lang/python/ja-Hira/LC_MESSAGES/python.po
+++ b/lang/python/ja-Hira/LC_MESSAGES/python.po
@@ -1,385 +0,0 @@
-# SOME DESCRIPTIVE TITLE.
-# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
-# This file is distributed under the same license as the PACKAGE package.
-# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
-# 
-#, fuzzy
-msgid ""
-msgstr ""
-"Project-Id-Version: PACKAGE VERSION\n"
-"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2021-11-02 15:45+0100\n"
-"PO-Revision-Date: 2017-08-09 10:34+0000\n"
-"Language-Team: Japanese (Hiragana) (https://www.transifex.com/calamares/teams/20061/ja-Hira/)\n"
-"MIME-Version: 1.0\n"
-"Content-Type: text/plain; charset=UTF-8\n"
-"Content-Transfer-Encoding: 8bit\n"
-"Language: ja-Hira\n"
-"Plural-Forms: nplurals=1; plural=0;\n"
-
-#: src/modules/initramfscfg/main.py:32
-msgid "Configuring initramfs."
-msgstr ""
-
-#: src/modules/initramfscfg/main.py:85 src/modules/initramfscfg/main.py:89
-#: src/modules/fstab/main.py:355 src/modules/fstab/main.py:361
-#: src/modules/fstab/main.py:388 src/modules/networkcfg/main.py:105
-#: src/modules/initcpiocfg/main.py:227 src/modules/initcpiocfg/main.py:231
-#: src/modules/localecfg/main.py:135 src/modules/mount/main.py:144
-#: src/modules/rawfs/main.py:164 src/modules/openrcdmcryptcfg/main.py:72
-#: src/modules/openrcdmcryptcfg/main.py:76
-#: src/modules/luksopenswaphookcfg/main.py:86
-#: src/modules/luksopenswaphookcfg/main.py:90
-msgid "Configuration Error"
-msgstr ""
-
-#: src/modules/initramfscfg/main.py:86 src/modules/fstab/main.py:356
-#: src/modules/initcpiocfg/main.py:228 src/modules/mount/main.py:145
-#: src/modules/rawfs/main.py:165 src/modules/openrcdmcryptcfg/main.py:73
-#: src/modules/luksopenswaphookcfg/main.py:87
-msgid "No partitions are defined for <pre>{!s}</pre> to use."
-msgstr ""
-
-#: src/modules/initramfscfg/main.py:90 src/modules/fstab/main.py:362
-#: src/modules/networkcfg/main.py:106 src/modules/initcpiocfg/main.py:232
-#: src/modules/localecfg/main.py:136 src/modules/openrcdmcryptcfg/main.py:77
-#: src/modules/luksopenswaphookcfg/main.py:91
-msgid "No root mount point is given for <pre>{!s}</pre> to use."
-msgstr ""
-
-#: src/modules/grubcfg/main.py:28
-msgid "Configure GRUB."
-msgstr ""
-
-#: src/modules/bootloader/main.py:43
-msgid "Install bootloader."
-msgstr ""
-
-#: src/modules/bootloader/main.py:508
-msgid "Bootloader installation error"
-msgstr ""
-
-#: src/modules/bootloader/main.py:509
-msgid ""
-"The bootloader could not be installed. The installation command "
-"<pre>{!s}</pre> returned error code {!s}."
-msgstr ""
-
-#: src/modules/fstab/main.py:29
-msgid "Writing fstab."
-msgstr ""
-
-#: src/modules/fstab/main.py:389
-msgid "No <pre>{!s}</pre> configuration is given for <pre>{!s}</pre> to use."
-msgstr ""
-
-#: src/modules/dracut/main.py:27
-msgid "Creating initramfs with dracut."
-msgstr ""
-
-#: src/modules/dracut/main.py:49
-msgid "Failed to run dracut on the target"
-msgstr ""
-
-#: src/modules/dracut/main.py:50 src/modules/mkinitfs/main.py:50
-msgid "The exit code was {}"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:526
-msgid "Cannot write KDM configuration file"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:527
-msgid "KDM config file {!s} does not exist"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:588
-msgid "Cannot write LXDM configuration file"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:589
-msgid "LXDM config file {!s} does not exist"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:672
-msgid "Cannot write LightDM configuration file"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:673
-msgid "LightDM config file {!s} does not exist"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:747
-msgid "Cannot configure LightDM"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:748
-msgid "No LightDM greeter installed."
-msgstr ""
-
-#: src/modules/displaymanager/main.py:779
-msgid "Cannot write SLIM configuration file"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:780
-msgid "SLIM config file {!s} does not exist"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:906
-msgid "No display managers selected for the displaymanager module."
-msgstr ""
-
-#: src/modules/displaymanager/main.py:907
-msgid ""
-"The displaymanagers list is empty or undefined in both globalstorage and "
-"displaymanager.conf."
-msgstr ""
-
-#: src/modules/displaymanager/main.py:989
-msgid "Display manager configuration was incomplete"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:29
-msgid "Configure OpenRC services"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:57
-msgid "Cannot add service {name!s} to run-level {level!s}."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:59
-msgid "Cannot remove service {name!s} from run-level {level!s}."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:61
-msgid ""
-"Unknown service-action <code>{arg!s}</code> for service {name!s} in run-"
-"level {level!s}."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:93
-#: src/modules/services-systemd/main.py:59
-msgid "Cannot modify service"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:94
-msgid ""
-"<code>rc-update {arg!s}</code> call in chroot returned error code {num!s}."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:101
-msgid "Target runlevel does not exist"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:102
-msgid ""
-"The path for runlevel {level!s} is <code>{path!s}</code>, which does not "
-"exist."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:110
-msgid "Target service does not exist"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:111
-msgid ""
-"The path for service {name!s} is <code>{path!s}</code>, which does not "
-"exist."
-msgstr ""
-
-#: src/modules/networkcfg/main.py:29
-msgid "Saving network configuration."
-msgstr ""
-
-#: src/modules/packages/main.py:50 src/modules/packages/main.py:59
-#: src/modules/packages/main.py:69
-msgid "Install packages."
-msgstr ""
-
-#: src/modules/packages/main.py:57
-#, python-format
-msgid "Processing packages (%(count)d / %(total)d)"
-msgstr ""
-
-#: src/modules/packages/main.py:62
-#, python-format
-msgid "Installing one package."
-msgid_plural "Installing %(num)d packages."
-msgstr[0] ""
-
-#: src/modules/packages/main.py:65
-#, python-format
-msgid "Removing one package."
-msgid_plural "Removing %(num)d packages."
-msgstr[0] ""
-
-#: src/modules/packages/main.py:638 src/modules/packages/main.py:650
-#: src/modules/packages/main.py:678
-msgid "Package Manager error"
-msgstr ""
-
-#: src/modules/packages/main.py:639
-msgid ""
-"The package manager could not prepare updates. The command <pre>{!s}</pre> "
-"returned error code {!s}."
-msgstr ""
-
-#: src/modules/packages/main.py:651
-msgid ""
-"The package manager could not update the system. The command <pre>{!s}</pre>"
-" returned error code {!s}."
-msgstr ""
-
-#: src/modules/packages/main.py:679
-msgid ""
-"The package manager could not make changes to the installed system. The "
-"command <pre>{!s}</pre> returned error code {!s}."
-msgstr ""
-
-#: src/modules/plymouthcfg/main.py:27
-msgid "Configure Plymouth theme"
-msgstr ""
-
-#: src/modules/initcpiocfg/main.py:28
-msgid "Configuring mkinitcpio."
-msgstr ""
-
-#: src/modules/localecfg/main.py:30
-msgid "Configuring locales."
-msgstr ""
-
-#: src/modules/mount/main.py:30
-msgid "Mounting partitions."
-msgstr ""
-
-#: src/modules/rawfs/main.py:26
-msgid "Installing data."
-msgstr ""
-
-#: src/modules/dummypython/main.py:35
-msgid "Dummy python job."
-msgstr ""
-
-#: src/modules/dummypython/main.py:37 src/modules/dummypython/main.py:93
-#: src/modules/dummypython/main.py:94
-msgid "Dummy python step {}"
-msgstr ""
-
-#: src/modules/hwclock/main.py:26
-msgid "Setting hardware clock."
-msgstr ""
-
-#: src/modules/umount/main.py:31
-msgid "Unmount file systems."
-msgstr ""
-
-#: src/modules/openrcdmcryptcfg/main.py:26
-msgid "Configuring OpenRC dmcrypt service."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:26
-msgid "Configure systemd services"
-msgstr ""
-
-#: src/modules/services-systemd/main.py:60
-msgid ""
-"<code>systemctl {arg!s}</code> call in chroot returned error code {num!s}."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:63
-#: src/modules/services-systemd/main.py:69
-msgid "Cannot enable systemd service <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:65
-msgid "Cannot enable systemd target <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:67
-msgid "Cannot enable systemd timer <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:71
-msgid "Cannot disable systemd target <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:73
-msgid "Cannot mask systemd unit <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:75
-msgid ""
-"Unknown systemd commands <code>{command!s}</code> and "
-"<code>{suffix!s}</code> for unit {name!s}."
-msgstr ""
-
-#: src/modules/mkinitfs/main.py:27
-msgid "Creating initramfs with mkinitfs."
-msgstr ""
-
-#: src/modules/mkinitfs/main.py:49
-msgid "Failed to run mkinitfs on the target"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:34
-msgid "Filling up filesystems."
-msgstr ""
-
-#: src/modules/unpackfs/main.py:254
-msgid "rsync failed with error code {}."
-msgstr ""
-
-#: src/modules/unpackfs/main.py:299
-msgid "Unpacking image {}/{}, file {}/{}"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:314
-msgid "Starting to unpack {}"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:323 src/modules/unpackfs/main.py:465
-msgid "Failed to unpack image \"{}\""
-msgstr ""
-
-#: src/modules/unpackfs/main.py:430
-msgid "No mount point for root partition"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:431
-msgid "globalstorage does not contain a \"rootMountPoint\" key, doing nothing"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:436
-msgid "Bad mount point for root partition"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:437
-msgid "rootMountPoint is \"{}\", which does not exist, doing nothing"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:453 src/modules/unpackfs/main.py:457
-#: src/modules/unpackfs/main.py:463 src/modules/unpackfs/main.py:478
-msgid "Bad unsquash configuration"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:454
-msgid "The filesystem for \"{}\" ({}) is not supported by your current kernel"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:458
-msgid "The source filesystem \"{}\" does not exist"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:464
-msgid ""
-"Failed to find unsquashfs, make sure you have the squashfs-tools package "
-"installed."
-msgstr ""
-
-#: src/modules/unpackfs/main.py:479
-msgid "The destination \"{}\" in the target system is not a directory"
-msgstr ""
-
-#: src/modules/luksopenswaphookcfg/main.py:26
-msgid "Configuring encrypted swap."
-msgstr ""
--- a/lang/python/pl/LC_MESSAGES/python.po
+++ b/lang/python/pl/LC_MESSAGES/python.po
@@ -4,7 +4,7 @@
 # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
 # 
 # Translators:
-# marcin mikołajczak <me@mkljczk.pl>, 2017
+# Marcin Mikołajczak <me@mkljczk.pl>, 2017
 # KagiSame, 2018
 # Piotr Strębski <strebski@gmail.com>, 2020
 # Jacob B. <brickminerplyt@gmail.com>, 2021
--- a/lang/python/ro/LC_MESSAGES/python.po
+++ b/lang/python/ro/LC_MESSAGES/python.po
@@ -6,7 +6,6 @@
 # Translators:
 # Jobava Jobava <jobaval10n@gmail.com>, 2018
 # Sebastian Brici <bricisebastian@gmail.com>, 2018
-# Chele Ion <krovyoll@gmail.com>, 2021
 # 
 #, fuzzy
 msgid ""
@@ -15,7 +14,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2021-11-02 15:45+0100\n"
 "PO-Revision-Date: 2017-08-09 10:34+0000\n"
-"Last-Translator: Chele Ion <krovyoll@gmail.com>, 2021\n"
+"Last-Translator: Sebastian Brici <bricisebastian@gmail.com>, 2018\n"
 "Language-Team: Romanian (https://www.transifex.com/calamares/teams/20061/ro/)\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
@@ -25,7 +24,7 @@ msgstr ""

 #: src/modules/initramfscfg/main.py:32
 msgid "Configuring initramfs."
-msgstr "Configurare initramfs"
+msgstr ""

 #: src/modules/initramfscfg/main.py:85 src/modules/initramfscfg/main.py:89
 #: src/modules/fstab/main.py:355 src/modules/fstab/main.py:361
@@ -37,21 +36,21 @@ msgstr "Configurare initramfs"
 #: src/modules/luksopenswaphookcfg/main.py:86
 #: src/modules/luksopenswaphookcfg/main.py:90
 msgid "Configuration Error"
-msgstr "Eroare de configurare"
+msgstr ""

 #: src/modules/initramfscfg/main.py:86 src/modules/fstab/main.py:356
 #: src/modules/initcpiocfg/main.py:228 src/modules/mount/main.py:145
 #: src/modules/rawfs/main.py:165 src/modules/openrcdmcryptcfg/main.py:73
 #: src/modules/luksopenswaphookcfg/main.py:87
 msgid "No partitions are defined for <pre>{!s}</pre> to use."
-msgstr "Nu sunt partiţii  definite ca  1{!s}1 ."
+msgstr ""

 #: src/modules/initramfscfg/main.py:90 src/modules/fstab/main.py:362
 #: src/modules/networkcfg/main.py:106 src/modules/initcpiocfg/main.py:232
 #: src/modules/localecfg/main.py:136 src/modules/openrcdmcryptcfg/main.py:77
 #: src/modules/luksopenswaphookcfg/main.py:91
 msgid "No root mount point is given for <pre>{!s}</pre> to use."
-msgstr "Nu este definită o partiţie rădăcină pentru 1{!s}1 ."
+msgstr ""

 #: src/modules/grubcfg/main.py:28
 msgid "Configure GRUB."
--- a/lang/python/ta_IN/LC_MESSAGES/python.po
+++ b/lang/python/ta_IN/LC_MESSAGES/python.po
@@ -1,387 +0,0 @@
-# SOME DESCRIPTIVE TITLE.
-# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
-# This file is distributed under the same license as the PACKAGE package.
-# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
-# 
-#, fuzzy
-msgid ""
-msgstr ""
-"Project-Id-Version: PACKAGE VERSION\n"
-"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2021-11-02 15:45+0100\n"
-"PO-Revision-Date: 2017-08-09 10:34+0000\n"
-"Language-Team: Tamil (India) (https://www.transifex.com/calamares/teams/20061/ta_IN/)\n"
-"MIME-Version: 1.0\n"
-"Content-Type: text/plain; charset=UTF-8\n"
-"Content-Transfer-Encoding: 8bit\n"
-"Language: ta_IN\n"
-"Plural-Forms: nplurals=2; plural=(n != 1);\n"
-
-#: src/modules/initramfscfg/main.py:32
-msgid "Configuring initramfs."
-msgstr ""
-
-#: src/modules/initramfscfg/main.py:85 src/modules/initramfscfg/main.py:89
-#: src/modules/fstab/main.py:355 src/modules/fstab/main.py:361
-#: src/modules/fstab/main.py:388 src/modules/networkcfg/main.py:105
-#: src/modules/initcpiocfg/main.py:227 src/modules/initcpiocfg/main.py:231
-#: src/modules/localecfg/main.py:135 src/modules/mount/main.py:144
-#: src/modules/rawfs/main.py:164 src/modules/openrcdmcryptcfg/main.py:72
-#: src/modules/openrcdmcryptcfg/main.py:76
-#: src/modules/luksopenswaphookcfg/main.py:86
-#: src/modules/luksopenswaphookcfg/main.py:90
-msgid "Configuration Error"
-msgstr ""
-
-#: src/modules/initramfscfg/main.py:86 src/modules/fstab/main.py:356
-#: src/modules/initcpiocfg/main.py:228 src/modules/mount/main.py:145
-#: src/modules/rawfs/main.py:165 src/modules/openrcdmcryptcfg/main.py:73
-#: src/modules/luksopenswaphookcfg/main.py:87
-msgid "No partitions are defined for <pre>{!s}</pre> to use."
-msgstr ""
-
-#: src/modules/initramfscfg/main.py:90 src/modules/fstab/main.py:362
-#: src/modules/networkcfg/main.py:106 src/modules/initcpiocfg/main.py:232
-#: src/modules/localecfg/main.py:136 src/modules/openrcdmcryptcfg/main.py:77
-#: src/modules/luksopenswaphookcfg/main.py:91
-msgid "No root mount point is given for <pre>{!s}</pre> to use."
-msgstr ""
-
-#: src/modules/grubcfg/main.py:28
-msgid "Configure GRUB."
-msgstr ""
-
-#: src/modules/bootloader/main.py:43
-msgid "Install bootloader."
-msgstr ""
-
-#: src/modules/bootloader/main.py:508
-msgid "Bootloader installation error"
-msgstr ""
-
-#: src/modules/bootloader/main.py:509
-msgid ""
-"The bootloader could not be installed. The installation command "
-"<pre>{!s}</pre> returned error code {!s}."
-msgstr ""
-
-#: src/modules/fstab/main.py:29
-msgid "Writing fstab."
-msgstr ""
-
-#: src/modules/fstab/main.py:389
-msgid "No <pre>{!s}</pre> configuration is given for <pre>{!s}</pre> to use."
-msgstr ""
-
-#: src/modules/dracut/main.py:27
-msgid "Creating initramfs with dracut."
-msgstr ""
-
-#: src/modules/dracut/main.py:49
-msgid "Failed to run dracut on the target"
-msgstr ""
-
-#: src/modules/dracut/main.py:50 src/modules/mkinitfs/main.py:50
-msgid "The exit code was {}"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:526
-msgid "Cannot write KDM configuration file"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:527
-msgid "KDM config file {!s} does not exist"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:588
-msgid "Cannot write LXDM configuration file"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:589
-msgid "LXDM config file {!s} does not exist"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:672
-msgid "Cannot write LightDM configuration file"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:673
-msgid "LightDM config file {!s} does not exist"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:747
-msgid "Cannot configure LightDM"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:748
-msgid "No LightDM greeter installed."
-msgstr ""
-
-#: src/modules/displaymanager/main.py:779
-msgid "Cannot write SLIM configuration file"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:780
-msgid "SLIM config file {!s} does not exist"
-msgstr ""
-
-#: src/modules/displaymanager/main.py:906
-msgid "No display managers selected for the displaymanager module."
-msgstr ""
-
-#: src/modules/displaymanager/main.py:907
-msgid ""
-"The displaymanagers list is empty or undefined in both globalstorage and "
-"displaymanager.conf."
-msgstr ""
-
-#: src/modules/displaymanager/main.py:989
-msgid "Display manager configuration was incomplete"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:29
-msgid "Configure OpenRC services"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:57
-msgid "Cannot add service {name!s} to run-level {level!s}."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:59
-msgid "Cannot remove service {name!s} from run-level {level!s}."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:61
-msgid ""
-"Unknown service-action <code>{arg!s}</code> for service {name!s} in run-"
-"level {level!s}."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:93
-#: src/modules/services-systemd/main.py:59
-msgid "Cannot modify service"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:94
-msgid ""
-"<code>rc-update {arg!s}</code> call in chroot returned error code {num!s}."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:101
-msgid "Target runlevel does not exist"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:102
-msgid ""
-"The path for runlevel {level!s} is <code>{path!s}</code>, which does not "
-"exist."
-msgstr ""
-
-#: src/modules/services-openrc/main.py:110
-msgid "Target service does not exist"
-msgstr ""
-
-#: src/modules/services-openrc/main.py:111
-msgid ""
-"The path for service {name!s} is <code>{path!s}</code>, which does not "
-"exist."
-msgstr ""
-
-#: src/modules/networkcfg/main.py:29
-msgid "Saving network configuration."
-msgstr ""
-
-#: src/modules/packages/main.py:50 src/modules/packages/main.py:59
-#: src/modules/packages/main.py:69
-msgid "Install packages."
-msgstr ""
-
-#: src/modules/packages/main.py:57
-#, python-format
-msgid "Processing packages (%(count)d / %(total)d)"
-msgstr ""
-
-#: src/modules/packages/main.py:62
-#, python-format
-msgid "Installing one package."
-msgid_plural "Installing %(num)d packages."
-msgstr[0] ""
-msgstr[1] ""
-
-#: src/modules/packages/main.py:65
-#, python-format
-msgid "Removing one package."
-msgid_plural "Removing %(num)d packages."
-msgstr[0] ""
-msgstr[1] ""
-
-#: src/modules/packages/main.py:638 src/modules/packages/main.py:650
-#: src/modules/packages/main.py:678
-msgid "Package Manager error"
-msgstr ""
-
-#: src/modules/packages/main.py:639
-msgid ""
-"The package manager could not prepare updates. The command <pre>{!s}</pre> "
-"returned error code {!s}."
-msgstr ""
-
-#: src/modules/packages/main.py:651
-msgid ""
-"The package manager could not update the system. The command <pre>{!s}</pre>"
-" returned error code {!s}."
-msgstr ""
-
-#: src/modules/packages/main.py:679
-msgid ""
-"The package manager could not make changes to the installed system. The "
-"command <pre>{!s}</pre> returned error code {!s}."
-msgstr ""
-
-#: src/modules/plymouthcfg/main.py:27
-msgid "Configure Plymouth theme"
-msgstr ""
-
-#: src/modules/initcpiocfg/main.py:28
-msgid "Configuring mkinitcpio."
-msgstr ""
-
-#: src/modules/localecfg/main.py:30
-msgid "Configuring locales."
-msgstr ""
-
-#: src/modules/mount/main.py:30
-msgid "Mounting partitions."
-msgstr ""
-
-#: src/modules/rawfs/main.py:26
-msgid "Installing data."
-msgstr ""
-
-#: src/modules/dummypython/main.py:35
-msgid "Dummy python job."
-msgstr ""
-
-#: src/modules/dummypython/main.py:37 src/modules/dummypython/main.py:93
-#: src/modules/dummypython/main.py:94
-msgid "Dummy python step {}"
-msgstr ""
-
-#: src/modules/hwclock/main.py:26
-msgid "Setting hardware clock."
-msgstr ""
-
-#: src/modules/umount/main.py:31
-msgid "Unmount file systems."
-msgstr ""
-
-#: src/modules/openrcdmcryptcfg/main.py:26
-msgid "Configuring OpenRC dmcrypt service."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:26
-msgid "Configure systemd services"
-msgstr ""
-
-#: src/modules/services-systemd/main.py:60
-msgid ""
-"<code>systemctl {arg!s}</code> call in chroot returned error code {num!s}."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:63
-#: src/modules/services-systemd/main.py:69
-msgid "Cannot enable systemd service <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:65
-msgid "Cannot enable systemd target <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:67
-msgid "Cannot enable systemd timer <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:71
-msgid "Cannot disable systemd target <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:73
-msgid "Cannot mask systemd unit <code>{name!s}</code>."
-msgstr ""
-
-#: src/modules/services-systemd/main.py:75
-msgid ""
-"Unknown systemd commands <code>{command!s}</code> and "
-"<code>{suffix!s}</code> for unit {name!s}."
-msgstr ""
-
-#: src/modules/mkinitfs/main.py:27
-msgid "Creating initramfs with mkinitfs."
-msgstr ""
-
-#: src/modules/mkinitfs/main.py:49
-msgid "Failed to run mkinitfs on the target"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:34
-msgid "Filling up filesystems."
-msgstr ""
-
-#: src/modules/unpackfs/main.py:254
-msgid "rsync failed with error code {}."
-msgstr ""
-
-#: src/modules/unpackfs/main.py:299
-msgid "Unpacking image {}/{}, file {}/{}"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:314
-msgid "Starting to unpack {}"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:323 src/modules/unpackfs/main.py:465
-msgid "Failed to unpack image \"{}\""
-msgstr ""
-
-#: src/modules/unpackfs/main.py:430
-msgid "No mount point for root partition"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:431
-msgid "globalstorage does not contain a \"rootMountPoint\" key, doing nothing"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:436
-msgid "Bad mount point for root partition"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:437
-msgid "rootMountPoint is \"{}\", which does not exist, doing nothing"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:453 src/modules/unpackfs/main.py:457
-#: src/modules/unpackfs/main.py:463 src/modules/unpackfs/main.py:478
-msgid "Bad unsquash configuration"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:454
-msgid "The filesystem for \"{}\" ({}) is not supported by your current kernel"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:458
-msgid "The source filesystem \"{}\" does not exist"
-msgstr ""
-
-#: src/modules/unpackfs/main.py:464
-msgid ""
-"Failed to find unsquashfs, make sure you have the squashfs-tools package "
-"installed."
-msgstr ""
-
-#: src/modules/unpackfs/main.py:479
-msgid "The destination \"{}\" in the target system is not a directory"
-msgstr ""
-
-#: src/modules/luksopenswaphookcfg/main.py:26
-msgid "Configuring encrypted swap."
-msgstr ""
--- a/lang/python/vi/LC_MESSAGES/python.po
+++ b/lang/python/vi/LC_MESSAGES/python.po
@@ -5,7 +5,7 @@
 # 
 # Translators:
 # T. Tran <transifex@emiu.net>, 2020
-# th1nhhdk <th1nhhdk@tutanota.com>, 2021
+# Th1nhhdk, 2021
 # 
 #, fuzzy
 msgid ""
@@ -14,7 +14,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2021-11-02 15:45+0100\n"
 "PO-Revision-Date: 2017-08-09 10:34+0000\n"
-"Last-Translator: th1nhhdk <th1nhhdk@tutanota.com>, 2021\n"
+"Last-Translator: Th1nhhdk, 2021\n"
 "Language-Team: Vietnamese (https://www.transifex.com/calamares/teams/20061/vi/)\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
--- a/lang/python/zh_CN/LC_MESSAGES/python.po
+++ b/lang/python/zh_CN/LC_MESSAGES/python.po
@@ -9,7 +9,6 @@
 # Feng Chao <chaofeng111@qq.com>, 2020
 # Bobby Rong <admin@bobby285271.top>, 2020
 # 玉堂白鹤 <yjwork@qq.com>, 2021
-# Giovanni Schiano-Moriello, 2022
 # 
 #, fuzzy
 msgid ""
@@ -18,7 +17,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2021-11-02 15:45+0100\n"
 "PO-Revision-Date: 2017-08-09 10:34+0000\n"
-"Last-Translator: Giovanni Schiano-Moriello, 2022\n"
+"Last-Translator: 玉堂白鹤 <yjwork@qq.com>, 2021\n"
 "Language-Team: Chinese (China) (https://www.transifex.com/calamares/teams/20061/zh_CN/)\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
@@ -306,7 +305,7 @@ msgstr "无法启用 systemd 目标 <code>{name!s}</code>."

 #: src/modules/services-systemd/main.py:67
 msgid "Cannot enable systemd timer <code>{name!s}</code>."
-msgstr "无法启用 systemd 计时器 <code>{name!s}</code>。"
+msgstr ""

 #: src/modules/services-systemd/main.py:71
 msgid "Cannot disable systemd target <code>{name!s}</code>."
@@ -385,7 +384,7 @@ msgstr "源文件系统 \"{}\" 不存在"
 msgid ""
 "Failed to find unsquashfs, make sure you have the squashfs-tools package "
 "installed."
-msgstr "寻找 unsquashfs 失败，请确定您已安装 squashfs-tools 软体包。"
+msgstr ""

 #: src/modules/unpackfs/main.py:479
 msgid "The destination \"{}\" in the target system is not a directory"
--- a/src/libcalamares/Job.h
+++ b/src/libcalamares/Job.h
@@ -47,7 +47,7 @@ public:

    /** @brief Is this JobResult a success?
     *
-     * Equivalent to errorCode() == 0, see succeeded().
+     * Equivalent to errorCode() == 0, might be named  isValid().
     */
    virtual operator bool() const;

@@ -58,11 +58,6 @@ public:
    virtual void setDetails( const QString& details );

    int errorCode() const { return m_number; }
-    /** @brief Is this JobResult a success?
-     *
-     * Equivalent to errorCode() == 0.
-     */
-    bool succeeded() const { return this->operator bool(); }

    /// @brief an "ok status" result
    static JobResult ok();
--- a/src/libcalamares/PythonJob.cpp
+++ b/src/libcalamares/PythonJob.cpp
@@ -100,7 +100,7 @@ BOOST_PYTHON_MODULE( libcalamares )
             bp::args( "s" ),
             "Writes the given string to the Calamares warning stream." );
    bp::def(
-        "error", &CalamaresPython::error, bp::args( "s" ), "Writes the given string to the Calamares error stream." );
+        "error", &CalamaresPython::warning, bp::args( "s" ), "Writes the given string to the Calamares error stream." );


    // .. YAML functions
--- a/src/modules/README.md
+++ b/src/modules/README.md
@@ -67,7 +67,7 @@ Note that process modules are not recommended.

 Module descriptors **may** have the following keys:
 - *emergency* (a boolean value, set to true to mark the module
-  as an emergency module; see the section *Emergency Modules*, below)
+  as an emergency module)
 - *noconfig* (a boolean value, set to true to state that the module
  has no configuration file; defaults to false)
 - *requiredModules* (a list of modules which are required for this module
@@ -86,30 +86,24 @@ it needs those keys.

 ### Emergency Modules

-If, during an *exec* step in the sequence, a module fails, installation as
-a whole fails and the install is aborted. If there are emergency modules
-in the **same** exec block, those will be executed before the installation
-is aborted. Non-emergency modules are not executed.
+Only C++ modules and job modules may be emergency modules. If, during an
+*exec* step in the sequence, a module fails, installation as a whole fails
+and the install is aborted. If there are emergency modules in the **same**
+exec block, those will be executed before the installation is aborted.
+Non-emergency modules are not executed.

 If an emergency-module fails while processing emergency-modules for
 another failed module, that failure is ignored and emergency-module
 processing continues.

 Use the EMERGENCY keyword in the CMake description of a C++ module
-to generate a suitable `module.desc`.  For Python modules, manually add
-`emergency:  true` to `module.desc`.
+to generate a suitable `module.desc`.

 A module that is marked as an emergency module in its module.desc
 must **also** set the *emergency* key to *true* in its configuration file
 (see below). If it does not, the module is not considered to be an emergency
-module after all. This is so that you can have modules that have several
-instances, only some of which are actually needed for emergencies.
-
-In summary:
- in `module.desc`, write `emergency: true` to make it **possible** to
-  run the module in emergency mode,
- in `<modulename>.conf`, write `emergency: true` to make that specific
-  module run in emergency mode.
+module after all (this is so that you can have modules that have several
+instances, only some of which are actually needed for emergencies).

 ### Module-specific configuration

@@ -118,10 +112,6 @@ named `<modulename>.conf`. If such a file is present in the
 module's directory, it can be shipped as a *default* configuration file.
 This only happens if the CMake-time option `INSTALL_CONFIG` is on.

-The name of the configuration file for a given module can be
-influenced by the `settings.conf` of the overall Calamares configuration.
-By default, though, the module's own name is used.
-
 Modules that have *noconfig* set to true will not attempt to
 read a configuration file, and will not warn that one is missing;
 conversely if *noconfig* is set to false (or is missing, since
--- a/src/modules/initcpio/InitcpioJob.cpp
+++ b/src/modules/initcpio/InitcpioJob.cpp
@@ -1,7 +1,6 @@
 /* === This file is part of Calamares - <https://calamares.io> ===
 *
 *   SPDX-FileCopyrightText: 2019 Adriaan de Groot <groot@kde.org>
- *   SPDX-FileCopyrightText: 2022 Evan James <dalto@fastmail.com>
 *   SPDX-License-Identifier: GPL-3.0-or-later
 *
 *   Calamares is Free Software: see the License-Identifier above.
@@ -32,22 +31,15 @@ InitcpioJob::prettyName() const
    return tr( "Creating initramfs with mkinitcpio." );
 }

-/** @brief Sets secure permissions on each initramfs
- *
- * Iterates over each initramfs contained directly in the directory @p d.
- * For each initramfs found, the permissions are set to owner read/write only.
- *
- */
 void
 fixPermissions( const QDir& d )
 {
-    const auto initramList = d.entryInfoList( { "initramfs*" }, QDir::Files );
-    for ( const auto& fi : initramList )
+    for ( const auto& fi : d.entryInfoList( { "initramfs*" }, QDir::Files ) )
    {
        QFile f( fi.absoluteFilePath() );
        if ( f.exists() )
        {
-            cDebug() << "initcpio setting permissions for" << f.fileName();
+            cDebug() << "initcpio fixing permissions for" << f.fileName();
            f.setPermissions( QFileDevice::ReadOwner | QFileDevice::WriteOwner );
        }
    }
@@ -71,19 +63,9 @@ InitcpioJob::exec()
        }
    }

-    // If the kernel option isn't set to a specific kernel, run mkinitcpio on all kernels
-    QStringList command = { "mkinitcpio" };
-    if ( m_kernel.isEmpty() || m_kernel == "all" )
-    {
-        command.append( "-P" );
-    }
-    else
-    {
-        command.append( { "-p", m_kernel } );
-    }
-
    cDebug() << "Updating initramfs with kernel" << m_kernel;
-    auto r = CalamaresUtils::System::instance()->targetEnvCommand( command, QString(), QString() /* no timeout , 0 */ );
+    auto r = CalamaresUtils::System::instance()->targetEnvCommand(
+        { "mkinitcpio", "-p", m_kernel }, QString(), QString() /* no timeout , 0 */ );
    return r.explainProcess( "mkinitcpio", std::chrono::seconds( 10 ) /* fake timeout */ );
 }

@@ -91,6 +73,28 @@ void
 InitcpioJob::setConfigurationMap( const QVariantMap& configurationMap )
 {
    m_kernel = CalamaresUtils::getString( configurationMap, "kernel" );
+    if ( m_kernel.isEmpty() )
+    {
+        m_kernel = QStringLiteral( "all" );
+    }
+    else if ( m_kernel == "$uname" )
+    {
+        auto r = CalamaresUtils::System::runCommand( CalamaresUtils::System::RunLocation::RunInHost,
+                                                     { "/bin/uname", "-r" },
+                                                     QString(),
+                                                     QString(),
+                                                     std::chrono::seconds( 3 ) );
+        if ( r.getExitCode() == 0 )
+        {
+            m_kernel = r.getOutput();
+            cDebug() << "*initcpio* using running kernel" << m_kernel;
+        }
+        else
+        {
+            cWarning() << "*initcpio* could not determine running kernel, using 'all'." << Logger::Continuation
+                       << r.getExitCode() << r.getOutput();
+        }
+    }

    m_unsafe = CalamaresUtils::getBool( configurationMap, "be_unsafe", false );
 }
--- a/src/modules/initcpio/initcpio.conf
+++ b/src/modules/initcpio/initcpio.conf
@@ -5,22 +5,21 @@
 ---
 # This key defines the kernel to be loaded.
 # It can have the following values:
-#  - the name of a single mkinitcpio preset
-#  - empty or unset
-#  - the literal string "all"
+#  - empty or unset, interpreted as "all"
+#  - the literal string "$uname" (without quotes, with dollar),
+#    which will use the output of `uname -r` to determine the
+#    running kernel, and use that.
+#  - any other string.
 #
-# If kernel is set to "all" or empty/unset then mkinitpio is called for all
-# kernels.  Otherwise it is called with a single preset with the value
-# contained in kernel.
+# Whatever is set, that string is passed as *preset* argument to the
+# `-p` option of *mkinitcpio*. Take care that both "$uname" operates
+# in the host system, and might not be correct if the target system is
+# updated (to a newer kernel) as part of the installation.
 #
-kernel: linux
+# Note that "all" is probably not a good preset to use either.
+kernel: linux312

 # Set this to true to turn off mitigations for lax file
 # permissions on initramfs (which, in turn, can compromise
 # your LUKS encryption keys, CVS-2019-13179).
-#
-# If your initramfs are stored in the EFI partition or another non-POSIX
-# filesystem, this has no effect as the file permissions cannot be changed.
-# In this case, ensure the partition is mounted securely.
-#
 be_unsafe: false
--- a/src/modules/initcpiocfg/main.py
+++ b/src/modules/initcpiocfg/main.py
@@ -173,8 +173,7 @@ def find_initcpio_features(partitions, root_mount_point):
        if partition["fs"] == "btrfs":
            uses_btrfs = True

-        # In addition to checking the filesystem, check to ensure that zfs is enabled
-        if partition["fs"] == "zfs" and libcalamares.globalstorage.contains("zfsPoolInfo"):
+        if partition["fs"] == "zfs":
            uses_zfs = True

        if "lvm2" in partition["fs"]:
--- a/src/modules/initramfs/InitramfsJob.cpp
+++ b/src/modules/initramfs/InitramfsJob.cpp
@@ -81,7 +81,6 @@ InitramfsJob::setConfigurationMap( const QVariantMap& configurationMap )
        }
        else
        {
-            m_kernel = QStringLiteral( "all" );
            cWarning() << "*initramfs* could not determine running kernel, using 'all'." << Logger::Continuation
                       << r.getExitCode() << r.getOutput();
        }
--- a/src/modules/locale/Config.cpp
+++ b/src/modules/locale/Config.cpp
@@ -221,11 +221,6 @@ Config::setCurrentLocation()
    {
        setCurrentLocation( m_startingTimezone.first, m_startingTimezone.second );
    }
-    if ( !m_selectedLocaleConfiguration.explicit_lang )
-    {
-        auto newLocale = automaticLocaleConfiguration();
-        setLanguage( newLocale.language() );
-    }
 }

 void
@@ -257,21 +252,15 @@ Config::setCurrentLocation( const QString& regionName, const QString& zoneName )
 void
 Config::setCurrentLocation( const CalamaresUtils::Locale::TimeZoneData* location )
 {
-    const bool updateLocation = ( location != m_currentLocation );
-    if ( updateLocation )
+    if ( location != m_currentLocation )
    {
        m_currentLocation = location;
-    }
-
-    // lang should be always be updated
-    auto newLocale = automaticLocaleConfiguration();
-    if ( !m_selectedLocaleConfiguration.explicit_lang )
-    {
-        setLanguage( newLocale.language() );
-    }
-
-    if ( updateLocation )
-    {
+        // Overwrite those settings that have not been made explicit.
+        auto newLocale = automaticLocaleConfiguration();
+        if ( !m_selectedLocaleConfiguration.explicit_lang )
+        {
+            setLanguage( newLocale.language() );
+        }
        if ( !m_selectedLocaleConfiguration.explicit_lc )
        {
            m_selectedLocaleConfiguration.lc_numeric = newLocale.lc_numeric;
--- a/src/modules/luksopenswaphookcfg/CMakeLists.txt
+++ b/src/modules/luksopenswaphookcfg/CMakeLists.txt
@@ -1,22 +0,0 @@
-# === This file is part of Calamares - <https://calamares.io> ===
-#
-#   SPDX-FileCopyrightText: 2021 Adriaan de Groot <groot@kde.org>
-#   SPDX-License-Identifier: BSD-2-Clause
-#
-
-# Because LUKS Open Swap Hook (Job) is such a mouthful, we'll
-# use LOSH all over the place as a shorthand.
-calamares_add_plugin( luksopenswaphookcfg
-    TYPE job
-    EXPORT_MACRO PLUGINDLLEXPORT_PRO
-    SOURCES
-        LOSHJob.cpp
-    SHARED_LIB
-)
-
-calamares_add_test(
-    luksopenswaphooktest
-    SOURCES
-        LOSHJob.cpp
-        Tests.cpp
-)
--- a/src/modules/luksopenswaphookcfg/LOSHInfo.h
+++ b/src/modules/luksopenswaphookcfg/LOSHInfo.h
@@ -1,66 +0,0 @@
-/* === This file is part of Calamares - <https://calamares.io> ===
- *
- *  SPDX-FileCopyrightText: 2021 Adriaan de Groot <groot@kde.org>
- *  SPDX-License-Identifier: GPL-3.0-or-later
- *
- */
-#ifndef LUKSOPENSWAPHOOKCFG_LOSHINFO_H
-#define LUKSOPENSWAPHOOKCFG_LOSHINFO_H
-
-#include <QString>
-
-/** @brief Information needed to create a suitable config file
- *
- * The LUKS swap configuration has a handful of keys that need to
- * be written to the config file. This struct holds those keys
- * and can find the key values from Global Storage (where the
- * *partition* module sets them).
- */
-struct LOSHInfo
-{
-    // Member names copied from Python code
-    QString swap_outer_uuid;
-    QString swap_mapper_name;
-    QString mountable_keyfile_device;
-    QString swap_device_path;
-    QString keyfile_device_mount_options;
-
-    bool isValid() const { return !swap_device_path.isEmpty(); }
-
-    /** @brief Helper method for doing key-value replacements
-     *
-     * Given a named @p key (e.g. "duck", or "swap_device"), returns the
-     * value set for that key. Invalid keys (e.g. "duck") return an empty string.
-     */
-    QString replacementFor( const QString& key ) const
-    {
-        if ( key == QStringLiteral( "swap_device" ) )
-        {
-            return swap_device_path;
-        }
-        if ( key == QStringLiteral( "crypt_swap_name" ) )
-        {
-            return swap_mapper_name;
-        }
-        if ( key == QStringLiteral( "keyfile_device" ) )
-        {
-            return mountable_keyfile_device;
-        }
-        if ( key == QStringLiteral( "keyfile_filename" ) )
-        {
-            return QStringLiteral( "crypto_keyfile.bin" );
-        }
-        if ( key == QStringLiteral( "keyfile_device_mount_options" ) )
-        {
-            return keyfile_device_mount_options;
-        }
-        return QString();
-    }
-
-    /** @brief Creates a struct from information already set in GS
-     *
-     */
-    static LOSHInfo fromGlobalStorage();
-};
-
-#endif
--- a/src/modules/luksopenswaphookcfg/LOSHJob.cpp
+++ b/src/modules/luksopenswaphookcfg/LOSHJob.cpp
@@ -1,181 +0,0 @@
-/* === This file is part of Calamares - <https://calamares.io> ===
- *
- *  SPDX-FileCopyrightText: 2021 Adriaan de Groot <groot@kde.org>
- *  SPDX-License-Identifier: GPL-3.0-or-later
- *
- */
-#include "LOSHJob.h"
-
-#include "LOSHInfo.h"
-
-#include "GlobalStorage.h"
-#include "JobQueue.h"
-#include "utils/CalamaresUtilsSystem.h"
-#include "utils/Logger.h"
-#include "utils/Permissions.h"
-#include "utils/PluginFactory.h"
-#include "utils/String.h"
-#include "utils/Variant.h"
-
-#include <QList>
-#include <QObject>
-#include <QRegularExpression>
-#include <QVariantMap>
-
-LOSHJob::LOSHJob( QObject* parent )
-    : Calamares::CppJob( parent )
-{
-}
-
-LOSHJob::~LOSHJob() {}
-
-
-QString
-LOSHJob::prettyName() const
-{
-    return tr( "Configuring encrypted swap." );
-}
-
-STATICTEST QString
-get_assignment_part( const QString& line )
-{
-    static QRegularExpression re( "^[# \\t]*([A-Za-z_]+)[ \\t]*=" );
-    auto m = re.match( line );
-    if ( m.hasMatch() )
-    {
-        return m.captured( 1 );
-    }
-    return QString();
-}
-
-/** Writes the config file at @p path
- *
- * NOTE: @p path is relative to the target system, not an absolute path.
- */
-STATICTEST void
-write_openswap_conf( const QString& path, QStringList& contents, const LOSHInfo& info )
-{
-    if ( info.isValid() )
-    {
-        for ( auto& line : contents )
-        {
-            const QString key = get_assignment_part( line );
-            QString replacement = info.replacementFor( key );
-            if ( !replacement.isEmpty() )
-            {
-                line.clear();
-                line.append( QStringLiteral( "%1=%2" ).arg( key, replacement ) );
-            }
-        }
-        cDebug() << "Writing" << contents.length() << "line configuration to" << path;
-        // \n between each two lines, and a \n at the end
-        CalamaresUtils::System::instance()->createTargetFile(
-            path, contents.join( '\n' ).append( '\n' ).toUtf8(), CalamaresUtils::System::WriteMode::Overwrite );
-    }
-    else
-    {
-        cDebug() << "Will not write an invalid configuration to" << path;
-    }
-}
-
-Calamares::JobResult
-LOSHJob::exec()
-{
-    const auto* sys = CalamaresUtils::System::instance();
-    if ( !sys )
-    {
-        return Calamares::JobResult::internalError(
-            "LuksOpenSwapHook", tr( "No target system available." ), Calamares::JobResult::InvalidConfiguration );
-    }
-
-    Calamares::GlobalStorage* gs
-        = Calamares::JobQueue::instance() ? Calamares::JobQueue::instance()->globalStorage() : nullptr;
-    if ( !gs || gs->value( "rootMountPoint" ).toString().isEmpty() )
-    {
-        return Calamares::JobResult::internalError(
-            "LuksOpenSwapHook", tr( "No rootMountPoint is set." ), Calamares::JobResult::InvalidConfiguration );
-    }
-    if ( m_configFilePath.isEmpty() )
-    {
-        return Calamares::JobResult::internalError(
-            "LuksOpenSwapHook", tr( "No configFilePath is set." ), Calamares::JobResult::InvalidConfiguration );
-    }
-
-    QStringList contents = sys->readTargetFile( m_configFilePath );
-    if ( contents.isEmpty() )
-    {
-        contents << QStringLiteral( "# swap_device=" ) << QStringLiteral( "# crypt_swap_name=" )
-                 << QStringLiteral( "# keyfile_device=" ) << QStringLiteral( "# keyfile_filename=" )
-                 << QStringLiteral( "# keyfile_device_mount_options" );
-    }
-
-    write_openswap_conf( m_configFilePath, contents, LOSHInfo::fromGlobalStorage() );
-    return Calamares::JobResult::ok();
-}
-
-void
-LOSHJob::setConfigurationMap( const QVariantMap& configurationMap )
-{
-    m_configFilePath = CalamaresUtils::getString(
-        configurationMap, QStringLiteral( "configFilePath" ), QStringLiteral( "/etc/openswap.conf" ) );
-}
-
-STATICTEST void
-globalStoragePartitionInfo( Calamares::GlobalStorage* gs, LOSHInfo& info )
-{
-    if ( !gs )
-    {
-        return;
-    }
-    QVariantList l = gs->value( "partitions" ).toList();
-    if ( l.isEmpty() )
-    {
-        return;
-    }
-
-    for ( const auto& pv : l )
-    {
-        const QVariantMap partition = pv.toMap();
-        if ( !partition.isEmpty() )
-        {
-            QString mountPoint = partition.value( "mountPoint" ).toString();
-            QString fileSystem = partition.value( "fs" ).toString();
-            QString luksMapperName = partition.value( "luksMapperName" ).toString();
-            // if partition["fs"] == "linuxswap" and "luksMapperName" in partition:
-            if ( fileSystem == QStringLiteral( "linuxswap" ) && !luksMapperName.isEmpty() )
-            {
-                info.swap_outer_uuid = partition.value( "luksUuid" ).toString();
-                info.swap_mapper_name = luksMapperName;
-            }
-            else if ( mountPoint == QStringLiteral( "/" ) && !luksMapperName.isEmpty() )
-            {
-
-                info.mountable_keyfile_device = QStringLiteral( "/dev/mapper/" ) + luksMapperName;
-            }
-        }
-    }
-
-    if ( !info.mountable_keyfile_device.isEmpty() && !info.swap_outer_uuid.isEmpty() )
-    {
-        info.swap_device_path = QStringLiteral( "/dev/disk/by-uuid/" ) + info.swap_outer_uuid;
-    }
-
-    QString btrfsRootSubvolume = gs->value( "btrfsRootSubvolume" ).toString();
-    if ( !btrfsRootSubvolume.isEmpty() )
-    {
-        CalamaresUtils::removeLeading( btrfsRootSubvolume, '/' );
-        info.keyfile_device_mount_options
-            = QStringLiteral( "keyfile_device_mount_options=--options=subvol=" ) + btrfsRootSubvolume;
-    }
-}
-
-LOSHInfo
-LOSHInfo::fromGlobalStorage()
-{
-    LOSHInfo i {};
-    globalStoragePartitionInfo(
-        Calamares::JobQueue::instance() ? Calamares::JobQueue::instance()->globalStorage() : nullptr, i );
-    return i;
-}
-
-CALAMARES_PLUGIN_FACTORY_DEFINITION( LOSHJobFactory, registerPlugin< LOSHJob >(); )
--- a/src/modules/luksopenswaphookcfg/LOSHJob.h
+++ b/src/modules/luksopenswaphookcfg/LOSHJob.h
@@ -1,37 +0,0 @@
-/* === This file is part of Calamares - <https://calamares.io> ===
- *
- *  SPDX-FileCopyrightText: 2021 Adriaan de Groot <groot@kde.org>
- *  SPDX-License-Identifier: GPL-3.0-or-later
- *
- */
-#ifndef LUKSOPENSWAPHOOKCFG_LOSHJOB_H
-#define LUKSOPENSWAPHOOKCFG_LOSHJOB_H
-
-#include "CppJob.h"
-#include "DllMacro.h"
-#include "utils/PluginFactory.h"
-
-#include <QString>
-#include <QVariantMap>
-
-class PLUGINDLLEXPORT LOSHJob : public Calamares::CppJob
-{
-    Q_OBJECT
-
-public:
-    explicit LOSHJob( QObject* parent = nullptr );
-    ~LOSHJob() override;
-
-    QString prettyName() const override;
-
-    Calamares::JobResult exec() override;
-
-    void setConfigurationMap( const QVariantMap& configurationMap ) override;
-
-private:
-    QString m_configFilePath;
-};
-
-CALAMARES_PLUGIN_FACTORY_DECLARATION( LOSHJobFactory )
-
-#endif
--- a/src/modules/luksopenswaphookcfg/Tests.cpp
+++ b/src/modules/luksopenswaphookcfg/Tests.cpp
@@ -1,253 +0,0 @@
-/* === This file is part of Calamares - <https://calamares.io> ===
- *
- *  SPDX-FileCopyrightText: 2021 Adriaan de Groot <groot@kde.org>
- *  SPDX-License-Identifier: GPL-3.0-or-later
- *
- */
-
-#include "LOSHInfo.h"
-#include "LOSHJob.h"
-
-#include "GlobalStorage.h"
-#include "JobQueue.h"
-#include "utils/CalamaresUtilsSystem.h"
-#include "utils/Logger.h"
-
-#include <QtTest/QtTest>
-
-// LOSH = LUKS Open Swap Hook (Job)
-
-// Implementation details
-extern QString get_assignment_part( const QString& line );
-extern void write_openswap_conf( const QString& path, QStringList& contents, const LOSHInfo& info );
-
-class LOSHTests : public QObject
-{
-    Q_OBJECT
-public:
-    LOSHTests();
-    ~LOSHTests() override {}
-
-private Q_SLOTS:
-    void initTestCase();
-
-    void testAssignmentExtraction_data();
-    void testAssignmentExtraction();
-
-    void testLOSHInfo();
-    void testConfigWriting();
-    void testJob();
-};
-
-LOSHTests::LOSHTests() {}
-
-void
-LOSHTests::initTestCase()
-{
-    Logger::setupLogLevel( Logger::LOGDEBUG );
-    cDebug() << "LOSH test started.";
-}
-
-
-void
-LOSHTests::testAssignmentExtraction_data()
-{
-    QTest::addColumn< QString >( "line" );
-    QTest::addColumn< QString >( "match" );
-
-    QTest::newRow( "empty" ) << QString() << QString();
-    QTest::newRow( "comment-only1" ) << QStringLiteral( "#  " ) << QString();
-    QTest::newRow( "comment-only2" ) << QStringLiteral( "###" ) << QString();
-    QTest::newRow( "comment-only3" ) << QStringLiteral( "# # #" ) << QString();
-
-    QTest::newRow( "comment-text" ) << QStringLiteral( "#   NOTE:" ) << QString();
-    QTest::newRow( "comment-story" ) << QStringLiteral( "# This is a shell comment" ) << QString();
-    // We look for assignments, but only for single-words
-    QTest::newRow( "comment-space-eq" ) << QStringLiteral( "# Check that a = b" ) << QString();
-
-
-    QTest::newRow( "assignment1" ) << QStringLiteral( "a=1" ) << QStringLiteral( "a" );
-    QTest::newRow( "assignment2" ) << QStringLiteral( "a = 1" ) << QStringLiteral( "a" );
-    QTest::newRow( "assignment3" ) << QStringLiteral( "#   a=1" ) << QStringLiteral( "a" );
-    QTest::newRow( "assignment4" ) << QStringLiteral( "cows   = 12" ) << QStringLiteral( "cows" );
-    QTest::newRow( "assignment5" ) << QStringLiteral( "#   # cows=1" ) << QStringLiteral( "cows" );
-    QTest::newRow( "assignment6" ) << QStringLiteral( "# moose='cool'  # not cows" ) << QStringLiteral( "moose" );
-    QTest::newRow( "assignment7" ) << QStringLiteral( " moose=cows=42" ) << QStringLiteral( "moose" );
-    QTest::newRow( "assignment8" ) << QStringLiteral( "#swap_device=/dev/something" )
-                                   << QStringLiteral( "swap_device" );
-    QTest::newRow( "assignment9" ) << QStringLiteral( "# swap_device=/dev/something" )
-                                   << QStringLiteral( "swap_device" );
-    QTest::newRow( "assignment10" ) << QStringLiteral( "swap_device=/dev/something" )
-                                    << QStringLiteral( "swap_device" );
-}
-
-void
-LOSHTests::testAssignmentExtraction()
-{
-    QFETCH( QString, line );
-    QFETCH( QString, match );
-
-    QCOMPARE( get_assignment_part( line ), match );
-}
-
-static CalamaresUtils::System*
-file_setup( const QTemporaryDir& tempRoot )
-{
-    CalamaresUtils::System* ss = CalamaresUtils::System::instance();
-    if ( !ss )
-    {
-        ss = new CalamaresUtils::System( true );
-    }
-
-    Calamares::GlobalStorage* gs
-        = Calamares::JobQueue::instance() ? Calamares::JobQueue::instance()->globalStorage() : nullptr;
-    if ( !gs )
-    {
-        cDebug() << "Creating new JobQueue";
-        (void)new Calamares::JobQueue();
-        gs = Calamares::JobQueue::instance() ? Calamares::JobQueue::instance()->globalStorage() : nullptr;
-    }
-    if ( gs )
-    {
-        // Working with a rootMountPoint set
-        gs->insert( "rootMountPoint", tempRoot.path() );
-    }
-    return ss;
-}
-
-static void
-make_valid_loshinfo( LOSHInfo& i )
-{
-    i.swap_outer_uuid = QStringLiteral( "UUID-0000" );
-    i.swap_mapper_name = QStringLiteral( "/dev/mapper/0000" );
-    i.swap_device_path = QStringLiteral( "/dev/sda0" );
-    i.mountable_keyfile_device = QStringLiteral( "/dev/ada0p0s0" );
-}
-
-void
-LOSHTests::testLOSHInfo()
-{
-    LOSHInfo i {};
-    QVERIFY( !i.isValid() );
-
-    make_valid_loshinfo( i );
-    QVERIFY( i.isValid() );
-    QCOMPARE( i.replacementFor( QStringLiteral( "swap_device" ) ), QStringLiteral( "/dev/sda0" ) );
-    QCOMPARE( i.replacementFor( QStringLiteral( "duck" ) ), QString() );
-}
-
-
-void
-LOSHTests::testConfigWriting()
-{
-    QTemporaryDir tempRoot( QDir::tempPath() + QStringLiteral( "/test-job-XXXXXX" ) );
-    QVERIFY( tempRoot.isValid() );
-    auto* ss = file_setup( tempRoot );
-    QVERIFY( ss );
-    QVERIFY( Calamares::JobQueue::instance()->globalStorage() );
-    QVERIFY( QFile::exists( tempRoot.path() ) );
-    QVERIFY( QFileInfo( tempRoot.path() ).isDir() );
-
-    const QString targetFilePath = QStringLiteral( "losh.conf" );
-    const QString filePath = tempRoot.filePath( targetFilePath );
-    QStringList contents { QStringLiteral( "# Calamares demo" ),
-                           QStringLiteral( "#  swap_device=a thing" ),
-                           QStringLiteral( "#  duck duck swap_device=another" ) };
-
-    // When the information is invalid, file contents are unchanged,
-    // and no file is written either.
-    LOSHInfo i {};
-    QVERIFY( !i.isValid() );
-    QVERIFY( !QFile::exists( filePath ) );
-    write_openswap_conf( targetFilePath, contents, i );  // Invalid i
-    QVERIFY( !QFile::exists( filePath ) );
-    QCOMPARE( contents.length(), 3 );
-    QCOMPARE( contents.at( 1 ).left( 4 ), QStringLiteral( "#  s" ) );
-
-    // Can we write there at all?
-    QFile derp( filePath );
-    QVERIFY( derp.open( QIODevice::WriteOnly ) );
-    QVERIFY( derp.write( "xx", 2 ) );
-    derp.close();
-    QVERIFY( QFile::exists( filePath ) );
-    QVERIFY( QFile::remove( filePath ) );
-
-    // Once the information is valid, though, the file is written
-    make_valid_loshinfo( i );
-    QVERIFY( i.isValid() );
-    QVERIFY( !QFile::exists( filePath ) );
-    write_openswap_conf( targetFilePath, contents, i );  // Now it is valid
-    QVERIFY( QFile::exists( filePath ) );
-    QCOMPARE( contents.length(), 3 );
-    QCOMPARE( i.swap_device_path, QStringLiteral( "/dev/sda0" ) );  // expected key value
-    QCOMPARE( contents.at( 1 ), QStringLiteral( "swap_device=/dev/sda0" ) );  // expected line
-
-    // readLine() returns with newlines-added
-    QFile f( filePath );
-    QVERIFY( f.open( QIODevice::ReadOnly ) );
-    QCOMPARE( f.readLine(), QStringLiteral( "# Calamares demo\n" ) );
-    QCOMPARE( f.readLine(), QStringLiteral( "swap_device=/dev/sda0\n" ) );
-    QCOMPARE( f.readLine(), QStringLiteral( "#  duck duck swap_device=another\n" ) );
-    QCOMPARE( f.readLine(), QString() );
-    QVERIFY( f.atEnd() );
-
-    // Note how the contents is updated on every write_openswap_conf()
-    i.swap_device_path = QStringLiteral( "/dev/zram/0.zram" );
-    write_openswap_conf( targetFilePath, contents, i );  // Still valid
-    QCOMPARE( contents.length(), 3 );
-    QCOMPARE( i.swap_device_path, QStringLiteral( "/dev/zram/0.zram" ) );  // expected key value
-    QCOMPARE( contents.at( 1 ), QStringLiteral( "swap_device=/dev/zram/0.zram" ) );  // expected line
-}
-
-
-void
-LOSHTests::testJob()
-{
-    QTemporaryDir tempRoot( QDir::tempPath() + QStringLiteral( "/test-job-XXXXXX" ) );
-    QVERIFY( tempRoot.isValid() );
-    auto* ss = file_setup( tempRoot );
-    QVERIFY( ss );
-    Calamares::GlobalStorage* gs
-        = Calamares::JobQueue::instance() ? Calamares::JobQueue::instance()->globalStorage() : nullptr;
-    QVERIFY( gs );
-
-    {
-        QDir d( tempRoot.path() );
-        d.mkdir( "etc" );
-    }
-
-    QVERIFY( !LOSHInfo::fromGlobalStorage().isValid() );
-    QVariantList outerPartition;
-    QVariantMap innerPartition;
-    innerPartition.insert( "mountPoint", "/" );
-    innerPartition.insert( "fs", "ext4" );
-    innerPartition.insert( "luksMapperName", "root" );
-    innerPartition.insert( "luksUUID", "0000" );
-    outerPartition.append( innerPartition );
-    innerPartition.remove( "mountPoint" );
-    innerPartition.insert( "fs", "linuxswap" );
-    innerPartition.insert( "luksMapperName", "swap" );
-    innerPartition.insert( "luksUuid", "0001" );
-    outerPartition.append( innerPartition );
-    gs->insert( "partitions", outerPartition );
-    QVERIFY( LOSHInfo::fromGlobalStorage().isValid() );
-
-    LOSHJob j;
-    j.setConfigurationMap( QVariantMap() );
-    auto jobresult = j.exec();
-    QVERIFY( jobresult );
-
-    {
-        QFile f( tempRoot.filePath( "etc/openswap.conf" ) );
-        QVERIFY( f.exists() );
-        QVERIFY( f.open( QIODevice::ReadOnly ) );
-        cDebug() << f.readAll();
-    }
-}
-
-
-QTEST_GUILESS_MAIN( LOSHTests )
-
-#include "utils/moc-warnings.h"
-
-#include "Tests.moc"
--- a/src/modules/luksopenswaphookcfg/main.py
+++ b/src/modules/luksopenswaphookcfg/main.py
@@ -0,0 +1,100 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+#
+# === This file is part of Calamares - <https://calamares.io> ===
+#
+#   SPDX-FileCopyrightText: 2016 Teo Mrnjavac <teo@kde.org>
+#   SPDX-FileCopyrightText: 2017 Alf Gaida <agaida@siduction.org>
+#   SPDX-FileCopyrightText: 2019 Adriaan de Groot <groot@kde.org>
+#   SPDX-License-Identifier: GPL-3.0-or-later
+#
+#   Calamares is Free Software: see the License-Identifier above.
+#
+
+import libcalamares
+import os.path
+
+
+import gettext
+_ = gettext.translation("calamares-python",
+                        localedir=libcalamares.utils.gettext_path(),
+                        languages=libcalamares.utils.gettext_languages(),
+                        fallback=True).gettext
+
+
+def pretty_name():
+    return _("Configuring encrypted swap.")
+
+
+def write_openswap_conf(partitions, root_mount_point, openswap_conf_path):
+    swap_outer_uuid = ""
+    swap_mapper_name = ""
+    mountable_keyfile_device = ""
+
+    for partition in partitions:
+        if partition["fs"] == "linuxswap" and "luksMapperName" in partition:
+            swap_outer_uuid = partition["luksUuid"]
+            swap_mapper_name = partition["luksMapperName"]
+
+        elif partition["mountPoint"] == "/" and "luksMapperName" in partition:
+            mountable_keyfile_device = (
+                "/dev/mapper/{!s}".format(partition["luksMapperName"])
+                )
+
+    if not mountable_keyfile_device or not swap_outer_uuid:
+        return None
+
+    swap_device_path = "/dev/disk/by-uuid/{!s}".format(swap_outer_uuid)
+
+    lines = []
+    with open(os.path.join(root_mount_point,
+                           openswap_conf_path), 'r') as openswap_file:
+        lines = [x.strip() for x in openswap_file.readlines()]
+
+    for i in range(len(lines)):
+        if lines[i].startswith("swap_device"):
+            lines[i] = "swap_device={!s}".format(swap_device_path)
+
+        elif lines[i].startswith("crypt_swap_name"):
+            lines[i] = "crypt_swap_name={!s}".format(swap_mapper_name)
+
+        elif lines[i].startswith("keyfile_device"):
+            lines[i] = "keyfile_device={!s}".format(mountable_keyfile_device)
+
+        elif lines[i].startswith("keyfile_filename"):
+            lines[i] = "keyfile_filename=crypto_keyfile.bin"
+
+        elif lines[i].startswith("#keyfile_device_mount_options"):
+            if libcalamares.globalstorage.contains("btrfsRootSubvolume"):
+                btrfs_root_subvolume = libcalamares.globalstorage.value("btrfsRootSubvolume")
+                lines[i] = "keyfile_device_mount_options=--options=subvol=" + btrfs_root_subvolume.lstrip("/")
+
+    with open(os.path.join(root_mount_point,
+                           openswap_conf_path), 'w') as openswap_file:
+        openswap_file.write("\n".join(lines) + "\n")
+
+    return None
+
+
+def run():
+    """
+    This module sets up the openswap hook for a resumable encrypted swap.
+    :return:
+    """
+
+    root_mount_point = libcalamares.globalstorage.value("rootMountPoint")
+    openswap_conf_path = libcalamares.job.configuration["configFilePath"]
+    partitions = libcalamares.globalstorage.value("partitions")
+
+    if not partitions:
+        libcalamares.utils.warning("partitions is empty, {!s}".format(partitions))
+        return (_("Configuration Error"),
+                _("No partitions are defined for <pre>{!s}</pre> to use.").format("luksopenswaphookcfg"))
+    if not root_mount_point:
+        libcalamares.utils.warning("rootMountPoint is empty, {!s}".format(root_mount_point))
+        return (_("Configuration Error"),
+                _("No root mount point is given for <pre>{!s}</pre> to use.").format("luksopenswaphookcfg"))
+
+    openswap_conf_path = openswap_conf_path.lstrip('/')
+
+    return write_openswap_conf(partitions, root_mount_point, openswap_conf_path)
--- a/src/modules/luksopenswaphookcfg/module.desc
+++ b/src/modules/luksopenswaphookcfg/module.desc
@@ -0,0 +1,7 @@
+# SPDX-FileCopyrightText: no
+# SPDX-License-Identifier: CC0-1.0
+---
+type:       "job"
+name:       "luksopenswaphookcfg"
+interface:  "python"
+script:     "main.py"
--- a/src/modules/packages/main.py
+++ b/src/modules/packages/main.py
@@ -382,7 +382,7 @@ class PMPacman(PackageManager):

        def line_cb(line):
            if line.startswith(":: "):
-                self.in_package_changes = "package" in line or "hooks" in line
+                self.in_package_changes = "package changes" in line
            else:
                if self.in_package_changes and line.endswith("...\n"):
                    # Update the message, untranslated; do not change the
@@ -392,7 +392,7 @@ class PMPacman(PackageManager):
                    global custom_status_message
                    custom_status_message = "pacman: " + line.strip()
                    libcalamares.job.setprogress(self.progress_fraction)
-            libcalamares.utils.debug(line)
+                    libcalamares.utils.debug(line)

        self.in_package_changes = False
        self.line_cb = line_cb
@@ -444,12 +444,8 @@ class PMPacman(PackageManager):
        else:
            command.append("-S")

-        # Don't ask for user intervention, take the default action
        command.append("--noconfirm")

-        # Don't report download progress for each file
-        command.append("--noprogressbar")
-
        if self.pacman_needed_only is True:
            command.append("--needed")

--- a/src/modules/partition/core/DeviceList.cpp
+++ b/src/modules/partition/core/DeviceList.cpp
@@ -41,10 +41,6 @@ hasRootPartition( Device* device )
    return false;
 }

-/** @brief Check if @p path holds an iso9660 filesystem
- *
- * The @p path should point to a device; blkid is used to check the FS type.
- */
 static bool
 blkIdCheckIso9660( const QString& path )
 {
@@ -53,18 +49,6 @@ blkIdCheckIso9660( const QString& path )
    return r.getOutput().contains( "iso9660" );
 }

-/// @brief Convenience to check if @p partition holds an iso9660 filesystem
-static bool
-blkIdCheckIso9660P( const Partition* partition )
-{
-    return blkIdCheckIso9660( partition->partitionPath() );
-}
-
-/** @brief Check if the @p device is an iso9660 device
- *
- * An iso9660 device is **probably** a CD-ROM. If the device holds an
- * iso9660 FS, or any of its partitions do, then we call it an iso9660 device.
- */
 static bool
 isIso9660( const Device* device )
 {
@@ -80,8 +64,13 @@ isIso9660( const Device* device )

    if ( device->partitionTable() && !device->partitionTable()->children().isEmpty() )
    {
-        const auto& p = device->partitionTable()->children();
-        return std::any_of( p.cbegin(), p.cend(), blkIdCheckIso9660P );
+        for ( const Partition* partition : device->partitionTable()->children() )
+        {
+            if ( blkIdCheckIso9660( partition->partitionPath() ) )
+            {
+                return true;
+            }
+        }
    }
    return false;
 }
--- a/src/modules/partition/core/KPMHelpers.h
+++ b/src/modules/partition/core/KPMHelpers.h
@@ -19,6 +19,7 @@
 #include <kpmcore/util/report.h>

 #include <QList>
+#include <QVector>

 #include <functional>

@@ -37,6 +38,8 @@ class PartitionRole;
 #define KPM_PARTITION_FLAG_ESP PartitionTable::FlagEsp
 #endif

+using PartitionVector = QVector< const Partition* >;
+
 /**
 * Helper functions to manipulate partitions
 */
--- a/src/modules/partition/core/PartitionCoreModule.cpp
+++ b/src/modules/partition/core/PartitionCoreModule.cpp
@@ -262,11 +262,9 @@ PartitionCoreModule::doInit()
            // Gives ownership of the Device* to the DeviceInfo object
            auto deviceInfo = new DeviceInfo( device );
            m_deviceInfos << deviceInfo;
-            cDebug() << Logger::SubEntry
-                << device->deviceNode()
-                << device->capacity()
-                << Logger::RedactedName( "DevName", device->name() )
-                << Logger::RedactedName( "DevNamePretty", device->prettyName() );
+            cDebug() << Logger::SubEntry << device->deviceNode() << device->capacity()
+                     << Logger::RedactedName( "DevName", device->name() )
+                     << Logger::RedactedName( "DevNamePretty", device->prettyName() );
        }
        else
        {
@@ -360,7 +358,12 @@ PartitionModel*
 PartitionCoreModule::partitionModelForDevice( const Device* device ) const
 {
    DeviceInfo* info = infoForDevice( device );
-    Q_ASSERT( info );
+    if ( !info )
+    {
+        cWarning() << "No DeviceInfo for" << Logger::Pointer( device )
+                   << ( device ? device->deviceNode() : QStringLiteral( "<null>" ) );
+        return nullptr;
+    }
    return info->partitionModel.data();
 }

@@ -411,15 +414,16 @@ PartitionCoreModule::createPartition( Device* device, Partition* partition, Part
 }

 void
-PartitionCoreModule::createVolumeGroup( QString& vgName, QVector< const Partition* > pvList, qint32 peSize )
+PartitionCoreModule::createVolumeGroup( const QString& vgName, const PartitionVector& pvList, qint32 peSize )
 {
+    QString actualName( vgName );
    // Appending '_' character in case of repeated VG name
-    while ( hasVGwithThisName( vgName ) )
+    while ( hasVGwithThisName( actualName ) )
    {
-        vgName.append( '_' );
+        actualName.append( '_' );
    }

-    LvmDevice* device = new LvmDevice( vgName );
+    LvmDevice* device = new LvmDevice( actualName );
    for ( const Partition* p : pvList )
    {
        device->physicalVolumes() << p;
@@ -430,12 +434,12 @@ PartitionCoreModule::createVolumeGroup( QString& vgName, QVector< const Partitio
    m_deviceModel->addDevice( device );
    m_deviceInfos << deviceInfo;

-    deviceInfo->makeJob< CreateVolumeGroupJob >( vgName, pvList, peSize );
+    deviceInfo->makeJob< CreateVolumeGroupJob >( actualName, pvList, peSize );
    refreshAfterModelChange();
 }

 void
-PartitionCoreModule::resizeVolumeGroup( LvmDevice* device, QVector< const Partition* >& pvList )
+PartitionCoreModule::resizeVolumeGroup( LvmDevice* device, const PartitionVector& pvList )
 {
    auto* deviceInfo = infoForDevice( device );
    Q_ASSERT( deviceInfo );
@@ -676,7 +680,7 @@ PartitionCoreModule::efiSystemPartitions() const
    return m_efiSystemPartitions;
 }

-QVector< const Partition* >
+PartitionVector
 PartitionCoreModule::lvmPVs() const
 {
    return m_lvmPVs;
--- a/src/modules/partition/core/PartitionCoreModule.h
+++ b/src/modules/partition/core/PartitionCoreModule.h
@@ -136,25 +136,18 @@ public:
     */
    void
    createPartition( Device* device, Partition* partition, PartitionTable::Flags flags = KPM_PARTITION_FLAG( None ) );
+    void deletePartition( Device* device, Partition* partition );
+    void formatPartition( Device* device, Partition* partition );
+    void resizePartition( Device* device, Partition* partition, qint64 first, qint64 last );
+    void setPartitionFlags( Device* device, Partition* partition, PartitionTable::Flags flags );

-    void createVolumeGroup( QString& vgName, QVector< const Partition* > pvList, qint32 peSize );
-
-    void resizeVolumeGroup( LvmDevice* device, QVector< const Partition* >& pvList );
-
+    void createVolumeGroup( const QString& vgName, const PartitionVector& pvList, qint32 peSize );
+    void resizeVolumeGroup( LvmDevice* device, const PartitionVector& pvList );
    void deactivateVolumeGroup( LvmDevice* device );
-
    void removeVolumeGroup( LvmDevice* device );

-    void deletePartition( Device* device, Partition* partition );
-
-    void formatPartition( Device* device, Partition* partition );
-
    void setFilesystemLabel( Device* device, Partition* partition, const QString& newLabel );

-    void resizePartition( Device* device, Partition* partition, qint64 first, qint64 last );
-
-    void setPartitionFlags( Device* device, Partition* partition, PartitionTable::Flags flags );
-
    /// @brief Retrieve the path where the bootloader will be installed
    QString bootLoaderInstallPath() const { return m_bootLoaderInstallPath; }
    /// @brief Set the path where the bootloader will be installed
@@ -185,7 +178,7 @@ public:

    QList< Partition* > efiSystemPartitions() const;

-    QVector< const Partition* > lvmPVs() const;
+    PartitionVector lvmPVs() const;

    bool hasVGwithThisName( const QString& name ) const;

@@ -255,7 +248,7 @@ private:

    QList< DeviceInfo* > m_deviceInfos;
    QList< Partition* > m_efiSystemPartitions;
-    QVector< const Partition* > m_lvmPVs;
+    PartitionVector m_lvmPVs;

    DeviceModel* m_deviceModel;
    BootLoaderModel* m_bootLoaderModel;
--- a/src/modules/partition/gui/CreatePartitionDialog.cpp
+++ b/src/modules/partition/gui/CreatePartitionDialog.cpp
@@ -66,19 +66,22 @@ CreatePartitionDialog::CreatePartitionDialog( Device* device,
    m_ui->encryptWidget->setText( tr( "En&crypt" ) );
    m_ui->encryptWidget->hide();

-    if ( m_device->type() != Device::Type::LVM_Device )
-    {
-        m_ui->lvNameLabel->hide();
-        m_ui->lvNameLineEdit->hide();
-    }
    if ( m_device->type() == Device::Type::LVM_Device )
    {
+        m_ui->lvNameLabel->show();
+        m_ui->lvNameLineEdit->show();
        /* LVM logical volume name can consist of: letters numbers _ . - +
         * It cannot start with underscore _ and must not be equal to . or .. or any entry in /dev/
         * QLineEdit accepts QValidator::Intermediate, so we just disable . at the beginning */
        QRegularExpression re( QStringLiteral( R"(^(?!_|\.)[\w\-.+]+)" ) );
        QRegularExpressionValidator* validator = new QRegularExpressionValidator( re, this );
        m_ui->lvNameLineEdit->setValidator( validator );
+        connect( m_ui->lvNameLineEdit, &QLineEdit::textChanged, this, &CreatePartitionDialog::updateOkButton );
+    }
+    else
+    {
+        m_ui->lvNameLabel->hide();
+        m_ui->lvNameLineEdit->hide();
    }

    if ( device->partitionTable()->type() == PartitionTable::msdos
@@ -347,3 +350,13 @@ CreatePartitionDialog::initPartResizerWidget( Partition* partition )
    m_partitionSizeController->setPartResizerWidget( m_ui->partResizerWidget );
    m_partitionSizeController->setSpinBox( m_ui->sizeSpinBox );
 }
+
+void
+CreatePartitionDialog::updateOkButton()
+{
+    if ( m_device->type() == Device::Type::LVM_Device )
+    {
+        QString lvName = m_ui->lvNameLineEdit->text();
+        cDebug() << "LVName" << lvName << m_ui->lvNameLineEdit->hasAcceptableInput();
+    }
+}
--- a/src/modules/partition/gui/CreatePartitionDialog.h
+++ b/src/modules/partition/gui/CreatePartitionDialog.h
@@ -45,10 +45,12 @@ private:
                           QWidget* parentWidget );

 public:
+    /// @brief Tag-type for creating partition from free space
    struct FreeSpace
    {
        Partition* p;
    };
+    /// @brief Tag-type for editing (re-creating) a new partition
    struct FreshPartition
    {
        Partition* p;
@@ -81,6 +83,7 @@ public:
 private Q_SLOTS:
    void updateMountPointUi();
    void checkMountPointSelection();
+    void updateOkButton();  // Check if dialog can be accepted

 private:
    QScopedPointer< Ui_CreatePartitionDialog > m_ui;
--- a/src/modules/partition/gui/CreateVolumeGroupDialog.cpp
+++ b/src/modules/partition/gui/CreateVolumeGroupDialog.cpp
@@ -16,32 +16,13 @@
 #include <QLineEdit>
 #include <QSpinBox>

-CreateVolumeGroupDialog::CreateVolumeGroupDialog( QString& vgName,
-                                                  QVector< const Partition* >& selectedPVs,
-                                                  QVector< const Partition* > pvList,
-                                                  qint64& pSize,
+CreateVolumeGroupDialog::CreateVolumeGroupDialog( const PartitionVector& pvList,
+                                                  qint32 physicalExtentSize,
                                                  QWidget* parent )
-    : VolumeGroupBaseDialog( vgName, pvList, parent )
-    , m_selectedPVs( selectedPVs )
-    , m_peSize( pSize )
+    : VolumeGroupBaseDialog( parent, QString(), pvList )
 {
    setWindowTitle( tr( "Create Volume Group" ) );

-    peSize()->setValue( pSize );
-
-    vgType()->setEnabled( false );
-}
-
-void
-CreateVolumeGroupDialog::accept()
-{
-    QString& name = vgNameValue();
-    name = vgName()->text();
-
-    m_selectedPVs << checkedItems();
-
-    qint64& pe = m_peSize;
-    pe = peSize()->value();
-
-    QDialog::accept();
+    peSizeWidget()->setValue( physicalExtentSize );
+    vgTypeWidget()->setEnabled( false );
 }
--- a/src/modules/partition/gui/CreateVolumeGroupDialog.h
+++ b/src/modules/partition/gui/CreateVolumeGroupDialog.h
@@ -16,18 +16,7 @@ class CreateVolumeGroupDialog : public VolumeGroupBaseDialog
 {
    Q_OBJECT
 public:
-    CreateVolumeGroupDialog( QString& vgName,
-                             QVector< const Partition* >& selectedPVs,
-                             QVector< const Partition* > pvList,
-                             qint64& pSize,
-                             QWidget* parent );
-
-    void accept() override;
-
-private:
-    QVector< const Partition* >& m_selectedPVs;
-
-    qint64& m_peSize;
+    CreateVolumeGroupDialog( const PartitionVector& pvList, qint32 physicalExtentSize, QWidget* parent );
 };

 #endif  // CREATEVOLUMEGROUPDIALOG_H
--- a/src/modules/partition/gui/PartitionPage.cpp
+++ b/src/modules/partition/gui/PartitionPage.cpp
@@ -278,26 +278,30 @@ PartitionPage::checkCanCreate( Device* device )
    }
 }

-void
-PartitionPage::onNewVolumeGroupClicked()
+static inline PartitionVector
+availablePVs( PartitionCoreModule* core )
 {
-    QString vgName;
-    QVector< const Partition* > selectedPVs;
-    qint64 peSize = 4;
+    PartitionVector availablePVs;

-    QVector< const Partition* > availablePVs;
-
-    for ( const Partition* p : m_core->lvmPVs() )
-        if ( !m_core->isInVG( p ) )
+    for ( const Partition* p : core->lvmPVs() )
+    {
+        if ( !core->isInVG( p ) )
        {
            availablePVs << p;
        }
+    }
+    return availablePVs;
+}

-    QPointer< CreateVolumeGroupDialog > dlg
-        = new CreateVolumeGroupDialog( vgName, selectedPVs, availablePVs, peSize, this );
+
+void
+PartitionPage::onNewVolumeGroupClicked()
+{
+    QPointer< CreateVolumeGroupDialog > dlg = new CreateVolumeGroupDialog( availablePVs( m_core ), 4, this );

    if ( dlg->exec() == QDialog::Accepted )
    {
+        const PartitionVector selectedPVs = dlg->selectedPVs();
        QModelIndex partitionIndex = m_ui->partitionTreeView->currentIndex();

        if ( partitionIndex.isValid() )
@@ -321,7 +325,7 @@ PartitionPage::onNewVolumeGroupClicked()
        QVariant previousIndexDeviceData = m_core->deviceModel()->data( deviceIndex, Qt::ToolTipRole );

        // Creating new VG
-        m_core->createVolumeGroup( vgName, selectedPVs, peSize );
+        m_core->createVolumeGroup( dlg->volumeGroupName(), selectedPVs, dlg->physicalExtentSize() );

        // As createVolumeGroup method call resets deviceModel,
        // is needed to set the current index in deviceComboBox as the previous one
@@ -342,20 +346,11 @@ PartitionPage::onResizeVolumeGroupClicked()

    Q_ASSERT( device && device->type() == Device::Type::LVM_Device );

-    QVector< const Partition* > availablePVs;
-    QVector< const Partition* > selectedPVs;
-
-    for ( const Partition* p : m_core->lvmPVs() )
-        if ( !m_core->isInVG( p ) )
-        {
-            availablePVs << p;
-        }
-
-    QPointer< ResizeVolumeGroupDialog > dlg = new ResizeVolumeGroupDialog( device, availablePVs, selectedPVs, this );
+    QPointer< ResizeVolumeGroupDialog > dlg = new ResizeVolumeGroupDialog( device, availablePVs( m_core ), this );

    if ( dlg->exec() == QDialog::Accepted )
    {
-        m_core->resizeVolumeGroup( device, selectedPVs );
+        m_core->resizeVolumeGroup( device, dlg->selectedPVs() );
    }

    delete dlg;
--- a/src/modules/partition/gui/ResizeVolumeGroupDialog.cpp
+++ b/src/modules/partition/gui/ResizeVolumeGroupDialog.cpp
@@ -22,38 +22,28 @@

 ResizeVolumeGroupDialog::ResizeVolumeGroupDialog( LvmDevice* device,
                                                  const PartitionVector& availablePVs,
-                                                  PartitionVector& selectedPVs,
                                                  QWidget* parent )
-    : VolumeGroupBaseDialog( device->name(), device->physicalVolumes(), parent )
-    , m_selectedPVs( selectedPVs )
+    : VolumeGroupBaseDialog( parent, device->name(), device->physicalVolumes() )
 {
    setWindowTitle( tr( "Resize Volume Group" ) );

-    for ( int i = 0; i < pvList()->count(); i++ )
+    for ( int i = 0; i < pvListWidget()->count(); i++ )
    {
-        pvList()->item( i )->setCheckState( Qt::Checked );
+        pvListWidget()->item( i )->setCheckState( Qt::Checked );
    }

    for ( const Partition* p : availablePVs )
    {
-        pvList()->addItem( new ListPhysicalVolumeWidgetItem( p, false ) );
+        pvListWidget()->addItem( new ListPhysicalVolumeWidgetItem( p, false ) );
    }

-    peSize()->setValue(
+    peSizeWidget()->setValue(
        static_cast< int >( device->peSize() / Capacity::unitFactor( Capacity::Unit::Byte, Capacity::Unit::MiB ) ) );

-    vgName()->setEnabled( false );
-    peSize()->setEnabled( false );
-    vgType()->setEnabled( false );
+    vgNameWidget()->setEnabled( false );
+    peSizeWidget()->setEnabled( false );
+    vgTypeWidget()->setEnabled( false );

    setUsedSizeValue( device->allocatedPE() * device->peSize() );
    setLVQuantity( device->partitionTable()->children().count() );
 }
-
-void
-ResizeVolumeGroupDialog::accept()
-{
-    m_selectedPVs << checkedItems();
-
-    QDialog::accept();
-}
--- a/src/modules/partition/gui/ResizeVolumeGroupDialog.h
+++ b/src/modules/partition/gui/ResizeVolumeGroupDialog.h
@@ -19,17 +19,7 @@ class ResizeVolumeGroupDialog : public VolumeGroupBaseDialog
 {
    Q_OBJECT
 public:
-    using PartitionVector = QVector< const Partition* >;
-
-    ResizeVolumeGroupDialog( LvmDevice* device,
-                             const PartitionVector& availablePVs,
-                             PartitionVector& selectedPVs,
-                             QWidget* parent );
-
-    void accept() override;
-
-private:
-    PartitionVector& m_selectedPVs;
+    ResizeVolumeGroupDialog( LvmDevice* device, const PartitionVector& availablePVs, QWidget* parent );
 };

 #endif  // RESIZEVOLUMEGROUPDIALOG_H
--- a/src/modules/partition/gui/VolumeGroupBaseDialog.cpp
+++ b/src/modules/partition/gui/VolumeGroupBaseDialog.cpp
@@ -10,6 +10,7 @@
 #include "VolumeGroupBaseDialog.h"
 #include "ui_VolumeGroupBaseDialog.h"

+#include "core/PartitionCoreModule.h"
 #include "core/SizeUtils.h"
 #include "gui/ListPhysicalVolumeWidgetItem.h"

@@ -20,10 +21,11 @@
 #include <QPushButton>
 #include <QSpinBox>

-VolumeGroupBaseDialog::VolumeGroupBaseDialog( QString& vgName, QVector< const Partition* > pvList, QWidget* parent )
+// Keeping the sources consistent
+VolumeGroupBaseDialog::VolumeGroupBaseDialog( QWidget* parent, const QString& vgName, PartitionVector pvList )
    : QDialog( parent )
    , ui( new Ui::VolumeGroupBaseDialog )
-    , m_vgNameValue( vgName )
+    , m_volumeGroupName( vgName )
    , m_totalSizeValue( 0 )
    , m_usedSizeValue( 0 )
 {
@@ -34,13 +36,12 @@ VolumeGroupBaseDialog::VolumeGroupBaseDialog( QString& vgName, QVector< const Pa
        ui->pvList->addItem( new ListPhysicalVolumeWidgetItem( p, false ) );
    }

-    ui->vgType->addItems( QStringList() << "LVM"
-                                        << "RAID" );
+    ui->vgType->addItems( { "LVM", "RAID" } );
    ui->vgType->setCurrentIndex( 0 );

    QRegularExpression re( R"(^(?!_|\.)[\w\-.+]+)" );
    ui->vgName->setValidator( new QRegularExpressionValidator( re, this ) );
-    ui->vgName->setText( m_vgNameValue );
+    ui->vgName->setText( vgName );

    updateOkButton();
    updateTotalSize();
@@ -55,7 +56,10 @@ VolumeGroupBaseDialog::VolumeGroupBaseDialog( QString& vgName, QVector< const Pa
        updateOkButton();
    } );

-    connect( ui->vgName, &QLineEdit::textChanged, this, [&]( const QString& ) { updateOkButton(); } );
+    connect( ui->vgName, &QLineEdit::textChanged, this, [&]( const QString& s ) {
+        m_volumeGroupName = s;
+        updateOkButton();
+    } );
 }

 VolumeGroupBaseDialog::~VolumeGroupBaseDialog()
@@ -63,10 +67,10 @@ VolumeGroupBaseDialog::~VolumeGroupBaseDialog()
    delete ui;
 }

-QVector< const Partition* >
-VolumeGroupBaseDialog::checkedItems() const
+PartitionVector
+VolumeGroupBaseDialog::selectedPVs() const
 {
-    QVector< const Partition* > items;
+    PartitionVector items;

    for ( int i = 0; i < ui->pvList->count(); i++ )
    {
@@ -90,8 +94,8 @@ VolumeGroupBaseDialog::isSizeValid() const
 void
 VolumeGroupBaseDialog::updateOkButton()
 {
-    okButton()->setEnabled( isSizeValid() && !checkedItems().empty() && !ui->vgName->text().isEmpty()
-                            && ui->peSize->value() > 0 );
+    okButtonWidget()->setEnabled( isSizeValid() && !selectedPVs().empty() && !ui->vgName->text().isEmpty()
+                                  && ui->peSize->value() > 0 );
 }

 void
@@ -111,13 +115,14 @@ VolumeGroupBaseDialog::setLVQuantity( qint32 lvQuantity )
 void
 VolumeGroupBaseDialog::updateTotalSize()
 {
+    m_physicalExtentSize = peSizeWidget()->value();
    m_totalSizeValue = 0;

-    for ( const Partition* p : checkedItems() )
+    for ( const Partition* p : selectedPVs() )
    {
        m_totalSizeValue += p->capacity()
            - p->capacity()
-                % ( ui->peSize->value() * Capacity::unitFactor( Capacity::Unit::Byte, Capacity::Unit::MiB ) );
+                % ( m_physicalExtentSize * Capacity::unitFactor( Capacity::Unit::Byte, Capacity::Unit::MiB ) );
    }

    ui->totalSize->setText( formatByteSize( m_totalSizeValue ) );
@@ -128,9 +133,10 @@ VolumeGroupBaseDialog::updateTotalSize()
 void
 VolumeGroupBaseDialog::updateTotalSectors()
 {
-    qint64 totalSectors = 0;
+    m_physicalExtentSize = peSizeWidget()->value();

-    qint64 extentSize = ui->peSize->value() * Capacity::unitFactor( Capacity::Unit::Byte, Capacity::Unit::MiB );
+    qint64 totalSectors = 0;
+    qint64 extentSize = m_physicalExtentSize * Capacity::unitFactor( Capacity::Unit::Byte, Capacity::Unit::MiB );

    if ( extentSize > 0 )
    {
@@ -140,38 +146,32 @@ VolumeGroupBaseDialog::updateTotalSectors()
    ui->totalSectors->setText( QString::number( totalSectors ) );
 }

-QString&
-VolumeGroupBaseDialog::vgNameValue() const
-{
-    return m_vgNameValue;
-}
-
 QLineEdit*
-VolumeGroupBaseDialog::vgName() const
+VolumeGroupBaseDialog::vgNameWidget() const
 {
    return ui->vgName;
 }

 QComboBox*
-VolumeGroupBaseDialog::vgType() const
+VolumeGroupBaseDialog::vgTypeWidget() const
 {
    return ui->vgType;
 }

 QSpinBox*
-VolumeGroupBaseDialog::peSize() const
+VolumeGroupBaseDialog::peSizeWidget() const
 {
    return ui->peSize;
 }

 QListWidget*
-VolumeGroupBaseDialog::pvList() const
+VolumeGroupBaseDialog::pvListWidget() const
 {
    return ui->pvList;
 }

 QPushButton*
-VolumeGroupBaseDialog::okButton() const
+VolumeGroupBaseDialog::okButtonWidget() const
 {
    return ui->buttonBox->button( QDialogButtonBox::StandardButton::Ok );
 }
--- a/src/modules/partition/gui/VolumeGroupBaseDialog.h
+++ b/src/modules/partition/gui/VolumeGroupBaseDialog.h
@@ -10,7 +10,7 @@
 #ifndef VOLUMEGROUPBASEDIALOG_H
 #define VOLUMEGROUPBASEDIALOG_H

-#include <kpmcore/core/partition.h>
+#include "core/KPMHelpers.h"

 #include <QDialog>

@@ -29,43 +29,46 @@ class VolumeGroupBaseDialog : public QDialog
    Q_OBJECT

 public:
-    explicit VolumeGroupBaseDialog( QString& vgName, QVector< const Partition* > pvList, QWidget* parent = nullptr );
+    explicit VolumeGroupBaseDialog( QWidget* parent, const QString& vgName, PartitionVector pvList );
    ~VolumeGroupBaseDialog() override;

+    qint32 physicalExtentSize() const { return m_physicalExtentSize; }
+    QString volumeGroupName() const { return m_volumeGroupName; }
+    /** @brief Which PVs (partitions) are selected for this VG
+     *
+     * The vector contains non-owned pointers.
+     */
+    PartitionVector selectedPVs() const;
+
 protected:
    virtual void updateOkButton();

    void setUsedSizeValue( qint64 usedSize );
-
    void setLVQuantity( qint32 lvQuantity );
-
-    void updateTotalSize();
-
-    void updateTotalSectors();
-
-    QVector< const Partition* > checkedItems() const;
-
    bool isSizeValid() const;

-    QString& vgNameValue() const;
+    void updateTotalSize();
+    void updateTotalSectors();

-    QLineEdit* vgName() const;

-    QComboBox* vgType() const;
-
-    QSpinBox* peSize() const;
-
-    QListWidget* pvList() const;
-
-    QPushButton* okButton() const;
+    /** @section UI-widget accessors
+     *
+     * These methods get UI internal widgets, so that subclasses
+     * can manipulate the values in those widgets.
+     */
+    QLineEdit* vgNameWidget() const;
+    QComboBox* vgTypeWidget() const;
+    QSpinBox* peSizeWidget() const;
+    QListWidget* pvListWidget() const;
+    QPushButton* okButtonWidget() const;

 private:
    Ui::VolumeGroupBaseDialog* ui;

-    QString& m_vgNameValue;
-
+    QString m_volumeGroupName;
    qint64 m_totalSizeValue;
    qint64 m_usedSizeValue;
+    qint32 m_physicalExtentSize;
 };

 #endif  // VOLUMEGROUPBASEDIALOG_H
--- a/src/modules/partition/jobs/CreateVolumeGroupJob.cpp
+++ b/src/modules/partition/jobs/CreateVolumeGroupJob.cpp
@@ -17,12 +17,12 @@
 #include <kpmcore/util/report.h>

 CreateVolumeGroupJob::CreateVolumeGroupJob( Device*,
-                                            QString& vgName,
-                                            QVector< const Partition* > pvList,
+                                            const QString& vgName,
+                                            const PartitionVector& pvList,
                                            const qint32 peSize )
    : m_vgName( vgName )
    , m_pvList( pvList )
-    , m_peSize( peSize )
+    , m_physicalExtentSize( peSize )
 {
 }

@@ -47,7 +47,7 @@ CreateVolumeGroupJob::prettyStatusMessage() const
 Calamares::JobResult
 CreateVolumeGroupJob::exec()
 {
-    return KPMHelpers::execute( CreateVolumeGroupOperation( m_vgName, m_pvList, m_peSize ),
+    return KPMHelpers::execute( CreateVolumeGroupOperation( m_vgName, m_pvList, m_physicalExtentSize ),
                                tr( "The installer failed to create a volume group named '%1'." ).arg( m_vgName ) );
 }

--- a/src/modules/partition/jobs/CreateVolumeGroupJob.h
+++ b/src/modules/partition/jobs/CreateVolumeGroupJob.h
@@ -10,19 +10,23 @@
 #ifndef CREATEVOLUMEGROUPJOB_H
 #define CREATEVOLUMEGROUPJOB_H

+#include "core/KPMHelpers.h"
+
 #include "Job.h"
 #include "partition/KPMManager.h"

-#include <QVector>
-
-class Device;
-class Partition;
-
 class CreateVolumeGroupJob : public Calamares::Job
 {
    Q_OBJECT
 public:
-    CreateVolumeGroupJob( Device*, QString& vgName, QVector< const Partition* > pvList, const qint32 peSize );
+    /** @brief Make a job that will create a volume group
+     *
+     * The @p physicalExtentSize is given in MiB; typically this is 4 (MiB).
+     */
+    CreateVolumeGroupJob( Device*,
+                          const QString& vgName,
+                          const PartitionVector& pvList,
+                          const qint32 physicalExtentSize );

    QString prettyName() const override;
    QString prettyDescription() const override;
@@ -35,8 +39,8 @@ public:
 private:
    CalamaresUtils::Partition::KPMManager m_kpmcore;
    QString m_vgName;
-    QVector< const Partition* > m_pvList;
-    qint32 m_peSize;
+    PartitionVector m_pvList;
+    qint32 m_physicalExtentSize;
 };

 #endif  // CREATEVOLUMEGROUPJOB_H
--- a/src/modules/partition/jobs/FormatPartitionJob.cpp
+++ b/src/modules/partition/jobs/FormatPartitionJob.cpp
@@ -14,7 +14,6 @@
 #include "core/KPMHelpers.h"

 #include "partition/FileSystem.h"
-#include "utils/CalamaresUtilsSystem.h"
 #include "utils/Logger.h"

 #include <kpmcore/core/device.h>
@@ -68,18 +67,7 @@ FormatPartitionJob::prettyStatusMessage() const
 Calamares::JobResult
 FormatPartitionJob::exec()
 {
-    const auto fsType = m_partition->fileSystem().type();
-    auto r = KPMHelpers::execute( CreateFileSystemOperation( *m_device, *m_partition, fsType ),
-                                  tr( "The installer failed to format partition %1 on disk '%2'." )
-                                      .arg( m_partition->partitionPath(), m_device->name() ) );
-    if ( fsType == FileSystem::Xfs && r.succeeded() )
-    {
-        // We are going to try to set modern timestamps for the filesystem,
-        // (ignoring whether this succeeds). Requires a sufficiently-new
-        // xfs_admin and xfs_repair and might be made obsolete by newer
-        // kpmcore releases.
-        CalamaresUtils::System::runCommand( { "xfs_admin", "-O", "bigtime=1", m_partition->partitionPath() },
-                                            std::chrono::seconds( 60 ) );
-    }
-    return r;
+    return KPMHelpers::execute( CreateFileSystemOperation( *m_device, *m_partition, m_partition->fileSystem().type() ),
+                                tr( "The installer failed to format partition %1 on disk '%2'." )
+                                    .arg( m_partition->partitionPath(), m_device->name() ) );
 }
--- a/src/modules/partition/jobs/ResizeVolumeGroupJob.cpp
+++ b/src/modules/partition/jobs/ResizeVolumeGroupJob.cpp
@@ -9,14 +9,12 @@

 #include "ResizeVolumeGroupJob.h"

-#include "core/KPMHelpers.h"
-
 #include <kpmcore/core/lvmdevice.h>
 #include <kpmcore/core/partition.h>
 #include <kpmcore/ops/resizevolumegroupoperation.h>
 #include <kpmcore/util/report.h>

-ResizeVolumeGroupJob::ResizeVolumeGroupJob( Device*, LvmDevice* device, QVector< const Partition* >& partitionList )
+ResizeVolumeGroupJob::ResizeVolumeGroupJob( Device*, LvmDevice* device, const PartitionVector& partitionList )
    : m_device( device )
    , m_partitionList( partitionList )
 {
--- a/src/modules/partition/jobs/ResizeVolumeGroupJob.h
+++ b/src/modules/partition/jobs/ResizeVolumeGroupJob.h
@@ -10,20 +10,19 @@
 #ifndef RESIZEVOLUMEGROUPJOB_H
 #define RESIZEVOLUMEGROUPJOB_H

+#include "core/KPMHelpers.h"
+
 #include "Job.h"
 #include "partition/KPMManager.h"

-#include <QVector>
-
 class Device;
 class LvmDevice;
-class Partition;

 class ResizeVolumeGroupJob : public Calamares::Job
 {
    Q_OBJECT
 public:
-    ResizeVolumeGroupJob( Device*, LvmDevice* device, QVector< const Partition* >& partitionList );
+    ResizeVolumeGroupJob( Device*, LvmDevice* device, const PartitionVector& partitionList );

    QString prettyName() const override;
    QString prettyDescription() const override;
@@ -37,7 +36,7 @@ private:
 private:
    CalamaresUtils::Partition::KPMManager m_kpmcore;
    LvmDevice* m_device;
-    QVector< const Partition* > m_partitionList;
+    PartitionVector m_partitionList;
 };

 #endif  // RESIZEVOLUMEGROUPJOB_H
--- a/src/modules/umount/main.py
+++ b/src/modules/umount/main.py
@@ -77,13 +77,10 @@ def run():
    """
    root_mount_point = libcalamares.globalstorage.value("rootMountPoint")

-    if(libcalamares.job.configuration and
-       "srcLog" in libcalamares.job.configuration or
-       "destLog" in libcalamares.job.configuration):
-        libcalamares.utils.error("Log-file preserving is **deprecated** in the *umount* module and removed in the next release")
    if(libcalamares.job.configuration and
       "srcLog" in libcalamares.job.configuration and
       "destLog" in libcalamares.job.configuration):
+        libcalamares.utils.warning("Log-file preserving is **deprecated** in the *umount* module")
        log_source = libcalamares.job.configuration["srcLog"]
        log_destination = libcalamares.job.configuration["destLog"]
        # Relocate log_destination into target system
--- a/src/modules/umount/module.desc
+++ b/src/modules/umount/module.desc
@@ -5,4 +5,3 @@ type:       "job"
 name:       "umount"
 interface:  "python"
 script:     "main.py"
-emergency:  true
--- a/src/modules/umount/umount.conf
+++ b/src/modules/umount/umount.conf
@@ -28,7 +28,3 @@
 #srcLog:      "/home/live/installation.log"
 #destLog:     "/var/log/installation.log"
 srcLog: "/bogus/just/do/not/use/this/anymore.txt"
-
-# Setting emergency to true will make it so this module is still run
-# when a prior module fails
-# emergency: true
--- a/src/modules/unpackfs/main.py
+++ b/src/modules/unpackfs/main.py
@@ -428,16 +428,14 @@ def run():
    if not root_mount_point:
        libcalamares.utils.warning("No mount point for root partition")
        return (_("No mount point for root partition"),
-                _("globalstorage does not contain a \"rootMountPoint\" key."))
+                _("globalstorage does not contain a \"rootMountPoint\" key, "
+                "doing nothing"))
+
    if not os.path.exists(root_mount_point):
        libcalamares.utils.warning("Bad root mount point \"{}\"".format(root_mount_point))
        return (_("Bad mount point for root partition"),
-                _("rootMountPoint is \"{}\", which does not exist.".format(root_mount_point)))
-
-    if libcalamares.job.configuration.get("unpack", None) is None:
-        libcalamares.utils.warning("No *unpack* key in job configuration.")
-        return (_("Bad unpackfs configuration"),
-                _("There is no configuration information."))
+                _("rootMountPoint is \"{}\", which does not "
+                "exist, doing nothing").format(root_mount_point))

    supported_filesystems = get_supported_filesystems()

@@ -452,17 +450,17 @@ def run():
        if sourcefs not in supported_filesystems:
            libcalamares.utils.warning("The filesystem for \"{}\" ({}) is not supported by your current kernel".format(source, sourcefs))
            libcalamares.utils.warning(" ... modprobe {} may solve the problem".format(sourcefs))
-            return (_("Bad unpackfs configuration"),
+            return (_("Bad unsquash configuration"),
                    _("The filesystem for \"{}\" ({}) is not supported by your current kernel").format(source, sourcefs))
        if not os.path.exists(source):
            libcalamares.utils.warning("The source filesystem \"{}\" does not exist".format(source))
-            return (_("Bad unpackfs configuration"),
+            return (_("Bad unsquash configuration"),
                    _("The source filesystem \"{}\" does not exist").format(source))
        if sourcefs == "squashfs":
            if shutil.which("unsquashfs") is None:
                libcalamares.utils.warning("Failed to find unsquashfs")

-                return (_("Bad unpackfs configuration"),
+                return (_("Bad unsquash configuration"),
                        _("Failed to find unsquashfs, make sure you have the squashfs-tools package installed.") +
                        " " + _("Failed to unpack image \"{}\"").format(source))

@@ -477,7 +475,7 @@ def run():
        if not os.path.isdir(destination) and sourcefs != "file":
            libcalamares.utils.warning(("The destination \"{}\" in the target system is not a directory").format(destination))
            if is_first:
-                return (_("Bad unpackfs configuration"),
+                return (_("Bad unsquash configuration"),
                        _("The destination \"{}\" in the target system is not a directory").format(destination))
            else:
                libcalamares.utils.debug(".. assuming that the previous targets will create that directory.")
Author	SHA1	Message	Date
Adriaan de Groot	3aa4b7368c	[partition] Log partition-model lookup failures	2021-12-15 13:57:20 +01:00
Adriaan de Groot	288674a924	[partition] Stub validator for LV name - An empty LV name isn't allowed, but the create-partition-dialog doesn't check for that.	2021-12-15 13:01:58 +01:00
Adriaan de Groot	30b5be0fd4	[partition] Use name PartitionVector consistently - move definition to a central place, - drop per-class definitions and corresponding checks, - use it and add constness as appropriate.	2021-12-15 12:19:59 +01:00
Adriaan de Groot	10334ab14f	[partition] More constness, fixes build	2021-12-15 00:30:23 +01:00
Adriaan de Groot	46d69b04d4	[partition] Make the naming of type PartitionVector consistent - static assert that various names are consistent (in gui, because we can have a dependency gui->core)	2021-12-15 00:20:23 +01:00
Adriaan de Groot	f1185d38d8	[partition] Drop unneeded parameters and stored references - the dialog can return, by value, the selected PVs and doesn't need to hold a reference to external storage. Doesn't compile because the actions in core want a reference.	2021-12-14 17:52:13 +01:00
Adriaan de Groot	2c16d812cd	[partition] Factor out determining which PVs exist	2021-12-14 17:27:15 +01:00
Adriaan de Groot	7a071207a2	[partition] Hit VG code with a hammer until it compiles again	2021-12-14 16:53:33 +01:00
Adriaan de Groot	3edfa5ebb5	[partition] Sanitize the base dialog for VGs - force broken compilation by changing order of parameters to constructor; this is to help identify all the consumers. - improve naming of UI-access-methods.	2021-12-14 16:28:25 +01:00
Adriaan de Groot	898f4498e8	[partition] document UI-accessors as such	2021-12-14 16:02:26 +01:00
Adriaan de Groot	e2d5f01aa1	[partition] Group partition- and VG-methods	2021-12-14 15:53:50 +01:00
Adriaan de Groot	8d7c08612f	[partition] Conventional const-ness	2021-12-14 15:52:41 +01:00
Adriaan de Groot	febc5f5b41	[partition] Conventional const-ness	2021-12-14 15:50:04 +01:00
Adriaan de Groot	35a4273127	[partition] Avoid storing references; provide getter for dialog.	2021-12-14 15:43:58 +01:00
Adriaan de Groot	4402ebd8e8	[partition] Clarify name peSize	2021-12-14 15:24:58 +01:00