version 0.41.2

The do_openrc() function was not waiting properly for the child process
which started the runlevel to return. We need to repeatedly call
waitpid() until its return value matches the pid of the child process or
the child process does not exist.

This fixes #216.
This fixes #300.

.cirrus.yml

@@ -4,9 +4,8 @@
 test_task:
   freebsd_instance:
     matrix:
-      image: freebsd-13-0-release-amd64
-      image: freebsd-12-2-release-amd64
-      image: freebsd-11-4-release-amd64
+      image: freebsd-12-0-release-amd64
+      image: freebsd-11-2-release-amd64
   env:
     OS: FreeBSD
   procfs_script: >

.github/workflows/ci-alpine-linux.yml

@@ -1,26 +0,0 @@
-name: ci_alpine_linux
-
-on: [push, pull_request]
-
-jobs:
-
-  gcc-musl:
-    runs-on: ubuntu-latest
-    container: alpine:latest
-    steps:
-      - name: install deps
-        run: >-
-          apk --no-cache add \
-            build-base \
-            meson \
-            pkgconf \
-            linux-pam \
-            linux-pam-dev
-      - name: checkout
-        uses: actions/checkout@v2
-      - run: meson setup builddir/
-        env:
-          CC: gcc
-      - run: ninja -C builddir
-        env:
-          CC: gcc

.github/workflows/ci-ubuntu.yml

@@ -1,32 +0,0 @@
-name: ci_ubuntu
-
-on: [push, pull_request]
-
-jobs:
-
-  gcc-glibc:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v2
-    - run: sudo apt-get update -q
-    - run: sudo apt-get install -q -y build-essential libpam-dev meson
-    - run: meson setup builddir/
-      env:
-        CC: gcc
-    - run: ninja -C builddir
-      env:
-        CC: gcc
-
-
-  clang-glibc:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v2
-    - run: sudo apt-get update -q
-    - run: sudo apt-get install -q -y build-essential clang libpam-dev meson
-    - run: meson setup builddir/
-      env:
-        CC: clang
-    - run: ninja -C builddir
-      env:
-        CC: clang

.travis.yml

@@ -19,14 +19,10 @@ addons:
 notifications:
   irc:
     channels:
-      - "irc.libera.chat#openrc"
-    on_success: always  # options: [always|never|change] default: always
+      - "irc.freenode.org#openrc"
+    on_success: change  # options: [always|never|change] default: always
     on_failure: always  # options: [always|never|change] default: always
     on_start: false     # default: false
 
-before_install:
-  - sudo apt-get update
-  - sudo apt-get install -y shellcheck
-
 script:
   - ./ci/travis.sh

AUTHORS

@@ -82,7 +82,6 @@ Semen Maryasin <marsoft@ya.ru>
 Sergei Trofimovich <slyfox@gentoo.org>
 Seth Robertson <in-gentoo@baka.org>
 S. Gilles <sgilles@umd.edu>
-Sony Interactive Entertainment, llc.
 Stefan Knoblich <s.knoblich@axsentis.de>
 Stef Simoens <stef.simoens@scarlet.be>
 Steve L <slong@rathaus.eclipse.co.uk>

Makefile.inc

@@ -1,3 +1,3 @@
 NAME=		openrc
-VERSION=	0.44.10
+VERSION=	0.41.2
 PKG=		${NAME}-${VERSION}

NEWS.md

@@ -4,37 +4,6 @@ OpenRC NEWS
 This file will contain a list of notable changes for each release. Note
 the information in this file is in reverse order.
 
-## OpenRC 0.44
-
-This version is the first to use a meson-based build system.
-The gnu make build system should now be considered deprecated; it will
-be removed sometime after 0.44.x.
-
-I have opened a [discussion](https://github.com/OpenRC/openrc/discussions/441)
-where you can voice concerns about removing it.
-
-## OpenRC 0.43
-
-This version changes the behavior of the checkpath helper to address
-CVE-2018-21269. on Linux systems, We require  non-terminal symbolic links
-to be owned by root. Since we can't do this on non-linux systems, we do
-not dereference non-terminal symbolic links by default. If you need them
-dereferenced, you should add the "-s" switch to the appropriate
-checkpath calls.
-For more information, see http://github.com/openrc/openrc/issues/201.
-
-The SHLIBDIR variable has been removed from the makefiles to make them
-more consistent with most common makefiles. All libraries are now in
-LIBDIR, so if you need to put them in /, override the LIBDIR variable
-when you run make.
-
-## OpenRC 0.42
-
-openrc-shutdown now has the ability to shut down sysvinit-based systems.
-
-A guide has been added for migrating systems using another init system
-to openrc-init.
-
 ## OpenRC 0.41.
 
 This version adds the ability to format the output of rc-status when

README.md

@@ -2,27 +2,19 @@ OpenRC README
 =============
 
 OpenRC is a dependency-based init system that works with the
-system-provided init program, normally `/sbin/init`.
+system-provided init program, normally `/sbin/init`. Currently, it does
+not have an init program of its own.
 
-## building and installing
-
-OpenRC uses the  [meson](http://mesonbuild.com) build system, so use the
-usual methods for this build system to build and install.
-
-The old build system is still available for the 0.44.x branch, but it is
-considered deprecated and will be removed. The previous documentation is
-below.
-
-## Installation (historical)
+## Installation
 
 OpenRC requires GNU make.
 
 Once you have GNU Make installed, the default OpenRC installation can be
 executed using this command:
 
-`make install`
+make install
 
-## Configuration (historical)
+## Configuration
 
 You may wish to configure the installation by passing one or more of the
 below arguments to the make command
@@ -53,15 +45,13 @@ SH=/bin/sh
 
 We don't support building a static OpenRC with PAM.
 
-You may need to use `PROGLDFLAGS=-Wl,-Bstatic` on glibc instead of just `-static`
-(This is now handled by the meson build system).
+You may need to use `PROGLDFLAGS=-Wl,-Bstatic` on glibc instead of just `-static`.
 
-If you are building OpenRC for a Gentoo Prefix installation, add `MKPREFIX=yes`
-(this is not supported in the meson build currently, but patches are welcome).
+If you are building OpenRC for a Gentoo Prefix installation, add `MKPREFIX=yes`.
 
 `PKG_PREFIX` should be set to where packages install to by default.
 
-`LOCAL_PREFIX` should be set to where user maintained packages are.
+`LOCAL_PREFIX` should be set when to where user maintained packages are.
 Only set `LOCAL_PREFIX` if different from `PKG_PREFIX`.
 
 `PREFIX` should be set when OpenRC is not installed to /.
@@ -87,21 +77,20 @@ Obviously, if you're installing this onto a system that does not use
 OpenRC by default then you may wish to backup the above listed files,
 remove them and then install so that the OS hooks into OpenRC.
 
-## Discussions
-
-We are testing [discussions](https://github.com/OpenRC/openrc/discussions), so
-feel free to open topics there.
-
 ## Reporting Bugs
 
-Please report bugs on our [bug tracker](http://github.com/OpenRC/openrc/issues).
+If you are using Gentoo Linux, bugs can be filed on their bugzilla under
+the `gentoo hosted projects` product and the `openrc` component [1].
+Otherwise, you can report issues on our github [2].
 
-If you can contribute code , please feel free to do so by opening
-[pull requests](https://github.com/OpenRC/openrc/pulls).
+Better yet, if you can contribute code, please feel free to submit pull
+requests [3].
 
 ## IRC Channel
 
-We have an official irc channel, #openrc on the libera network.
-Please connect your irc client to irc.libera.chat and join #openrc on
-that network.
+We have an official irc channel, #openrc on freenode, feel free to join
+us there.
 
+[1]	https://bugs.gentoo.org/
+[2]	https://github.com/openrc/openrc/issues
+[3]	https://github.com/openrc/openrc/pulls

README.newnet

@@ -1,5 +1,5 @@
 OpenRC Network Ideals
-=====================
+---------------------
 
 The new style networking for OpenRC is very simplistic - provide a basic means
 of configuring static interface address and routes whilst allowing the

bash-completion/meson.build

@@ -1,10 +0,0 @@
-bash_completions = [
-  'openrc',
-  'openrc-service-script',
-  'rc-service',
-  'rc-status',
-  'rc-update',
-  ]
-
-install_data(bash_completions,
-  install_dir : get_option('datadir') / 'bash-completion/completions')

ci/travis.sh

@@ -16,23 +16,6 @@ set -x
 # These are steps to run on TravisCI under a containerized Ubuntu system.
 # See $TOP/.travis.yml for more info about the TravisCI setup.
 
-# Run shellcheck, but don't fail (yet):
-shellcheck --version
-for shellscript in $(git ls-files); do
-	case $shellscript in
-		init.d/*.in) ;;
-		sh/*.in) ;;
-		sh/*.sh) ;;
-		support/init.d.examples/*.in) ;;
-		support/openvpn/*.sh) ;;
-		support/sysvinit/halt.sh) ;;
-		test/*.sh) ;;
-		*) continue ;;
-	esac
-	echo "Checking ${shellscript} with shellcheck:"
-	shellcheck -s sh "${shellscript}" || true
-done
-
 cpus=$(getconf _NPROCESSORS_CONF || echo 1)
 # make on TravisCI doesn't support -O yet
 make -j"${cpus}"

conf.d/hostname

@@ -1,2 +1,2 @@
-# Hostname fallback if /etc/hostname does not exist
+# Set to the hostname of this machine
 hostname="localhost"

conf.d/meson.build

@@ -1,59 +0,0 @@
-conf_d_dir = get_option('sysconfdir') / 'conf.d'
-
-conf_common = [
-  'bootmisc',
-  'fsck',
-  'hostname',
-  'localmount',
-  'netmount',
-  'swap',
-  'urandom',
-  ]
-
-conf_net = [
-  'network',
-  'staticroute',
-  ]
-
-conf_FreeBSD = [
-  'ipfw',
-  'modules',
-  'moused',
-  'powerd',
-  'rarpd',
-  'savecore',
-  'syscons',
-  ]
-
-conf_Linux = [
-  'agetty',
-  'consolefont',
-  'devfs',
-  'dmesg',
-  'hwclock',
-  'keymaps',
-  'killprocs',
-  'modules',
-  'mtab',
-  'net-online',
-  ]
-
-conf_NetBSD =  [
-  'moused',
-  'rarpd',
-  'savecore',
-  ]
-
-conf_data = conf_common
-if get_option('newnet')
-  conf_data = conf_data + conf_net
-endif
-if os == 'FreeBSD'
-  conf_data = conf_data + conf_FreeBSD
-elif os == 'Linux'
-  conf_data = conf_data + conf_Linux
-elif os == 'NetBSD'
-  conf_data = conf_data + conf_NetBSD
-endif
-
-install_data(conf_data, install_dir : conf_d_dir)

etc/meson.build

@@ -1,44 +0,0 @@
-etc_conf_data = configuration_data()
-if os == 'FreeBSD'
-  etc_conf_data.set('TERM', 'cons25')
-elif os == 'Linux'
-  etc_conf_data.set('TERM', 'wsvt25')
-endif
-
-etc_conf_common = [
-  'rc.conf',
-  ]
-
-etc_bin_FreeBSD = [
-  'rc.devd',
-  ]
-
-etc_conf_FreeBSD = [
-  'devd.conf',
-  ]
-
-etc_bin_NetBSD =  [
-  'rc.in',
-  'rc.shutdown.in',
-  ]
-
-install_data(etc_conf_common,
-  install_dir : get_option('sysconfdir'))
-
-  if os == 'FreeBSD'
-  install_data(etc_bin_FreeBSD,
-    install_dir : get_option('sysconfdir'),
-    install_mode: 'rwxr-xr-x')
-  install_data(etc_conf_FreeBSD,
-    install_dir : get_option('sysconfdir'))
-endif
-
-if os == 'FreeBSD' or os == 'NetBSD'
-  foreach file : etc_bin_NetBSD
-    configure_file(input : file,
-      output : '@BASENAME@',
-      configuration : etc_conf_data,
-      install_dir: get_option('sysconfdir'),
-      install_mode: 'rwxr-xr-x')
-  endforeach
-endif

etc/rc.conf

@@ -198,9 +198,10 @@ rc_tty_number=12
 # "unified" mounts cgroups version 2 on /sys/fs/cgroup
 #rc_cgroup_mode="hybrid"
 
-# This is a list of controllers which should be enabled for cgroups version 2
-# when hybrid mode is being used.
-# Controllers listed here will not be available for cgroups version 1.
+# This is a list of controllers which should be enabled for cgroups version 2.
+# If hybrid mode is being used, controllers listed here will not be
+# available for cgroups version 1.
+# This is a global setting.
 #rc_cgroup_controllers=""
 
 # This variable contains the cgroups version 2 settings for your services.

init-guide.md

@@ -1,47 +0,0 @@
-# OpenRC init process guide
-
-OpenRC now includes an init process which can be used on Linux systems
-in place of sysvinit.
-
-## migrating a live system to openrc-init
-
-Configuring a live system to use this init process is very
-straight-forward, but the steps must be completed in this order.
-
-* have your boot loader add "init=/sbin/openrc-init" to the kernel command line
-
-The details of how to do this will vary from distro to distro, so they are
-out of scope for this document.
-
-* Install gettys into the runlevels where you need them.
-
-If you are using the provided /etc/init.d/agetty script,, you should
-first create symlinks in /etc/init.d to it for the ports where you
-want gettys to run, e.g. the following will work if you want gettys on
-tty1-tty6.
-
-```
-# cd /etc/init.d
-# for x in tty1 tty2 tty3 tty4 tty5 tty6; do
-  ln -snf agetty agetty.$x
-  done
-```
-
-Once this is done, use ```rc-update``` as normal to install the agetty
-services in the appropriate runlevels.
-
-* Reboot your system.
-
-At this point you are running under openrc-init, and you should use
-openrc-shutdown to handle shutting down, powering off, rebooting etc.
-
-## optional sysvinit compatibility
-
-If you build and install OpenRC with MKSYSVINIT=yes, you will build and install
-wrappers that make openrc-init compatible with sysvinit -- you will have
-commands like "halt" "shutdown" "reboot" and "poweroff".
-
-If you want this functionality on a live system, you should first
-migrate the system to openrc-init, remove sysvinit, then rebuild and
-install this package with MKSYSVINIT=yes.
-

init.d/agetty.in

@@ -21,7 +21,6 @@ pidfile="/run/${RC_SVCNAME}.pid"
 depend() {
 	after local
 	keyword -prefix
-	provide getty
 }
 
 start_pre() {

init.d/bootmisc.in

@@ -113,10 +113,8 @@ migrate_to_run()
  		rm $src
  	elif [ ! -L $src -a -d $src ]; then
  		ebegin "Migrating $src to $dst"
- 		if ! rmdir $src 2>/dev/null; then
- 			cp -a $src/* $dst/
- 			rm -rf $src
- 		fi
+ 		cp -a $src/* $dst/
+ 		rm -rf $src
  		eend $?
  	fi
  	# If $src doesn't exist at all, just run this
@@ -243,13 +241,7 @@ stop()
 {
 	# Write a halt record if we're shutting down
 	if [ "$RC_RUNLEVEL" = shutdown ]; then
-		if [ "$RC_UNAME" = Linux ]; then
-			if [ -x /sbin/halt ]; then
-				halt -w
-			else
-				openrc-shutdown -w
-			fi
-		fi
+		[ "$RC_UNAME" = Linux ] && openrc-shutdown -w
 		if [ "$RC_SYS" = OPENVZ ]; then
 			yesno $RC_REBOOT && printf "" >/reboot
 		fi

init.d/cgroups.in

@@ -83,22 +83,14 @@ cgroup2_controllers()
 	local active cgroup_path x y
 	cgroup_path="$(cgroup2_find_path)"
 	[ -z "${cgroup_path}" ] && return 0
-	[ ! -e "${cgroup_path}/cgroup.controllers" ] && return 0
-	[ ! -e "${cgroup_path}/cgroup.subtree_control" ]&& return 0
+	[ -e "${cgroup_path}/cgroup.controllers" ] &&
 	read -r active < "${cgroup_path}/cgroup.controllers"
-	for x in ${active}; do
-	case "$rc_cgroup_mode" in
-		unified)
+	for x in ${rc_cgroup_controllers}; do
+		for y in ${active}; do
+		[ "$x" = "$y" ] &&
+			[ -e "${cgroup_path}/cgroup.subtree_control" ]&&
 			echo "+${x}"  > "${cgroup_path}/cgroup.subtree_control"
-			;;
-		hybrid)
-			for y in ${rc_cgroup_controllers}; do
-				if [ "$x" = "$y" ]; then
-					echo "+${x}"  > "${cgroup_path}/cgroup.subtree_control"
-				fi
-			done
-			;;
-		esac
+		done
 	done
 	return 0
 }

init.d/devfs.in

@@ -15,7 +15,7 @@ depend()
 {
 	provide dev-mount
 	before dev
-	keyword -docker -prefix -systemd-nspawn -vserver
+	keyword -docker -lxc -prefix -systemd-nspawn -vserver
 }
 
 mount_dev()
@@ -66,20 +66,18 @@ seed_dev()
 {
 	# Seed /dev with some things that we know we need
 
-	if [ "${RC_SYS}" != LXC ]; then
-		# creating /dev/console, /dev/tty and /dev/tty1 to be able to write
-		# to $CONSOLE with/without bootsplash before udevd creates it
-		[ -c /dev/console ] || mknod -m 600 /dev/console c 5 1
-		[ -c /dev/tty1 ] || mknod -m 620 /dev/tty1 c 4 1
-		[ -c /dev/tty ] || mknod -m 666 /dev/tty c 5 0
+	# creating /dev/console, /dev/tty and /dev/tty1 to be able to write
+	# to $CONSOLE with/without bootsplash before udevd creates it
+	[ -c /dev/console ] || mknod -m 600 /dev/console c 5 1
+	[ -c /dev/tty1 ] || mknod -m 620 /dev/tty1 c 4 1
+	[ -c /dev/tty ] || mknod -m 666 /dev/tty c 5 0
 
-		# udevd will dup its stdin/stdout/stderr to /dev/null
-		# and we do not want a file which gets buffered in ram
-		[ -c /dev/null ] || mknod -m 666 /dev/null c 1 3
+	# udevd will dup its stdin/stdout/stderr to /dev/null
+	# and we do not want a file which gets buffered in ram
+	[ -c /dev/null ] || mknod -m 666 /dev/null c 1 3
 
-		# so udev can add its start-message to dmesg
-		[ -c /dev/kmsg ] || mknod -m 660 /dev/kmsg c 1 11
-	fi
+	# so udev can add its start-message to dmesg
+	[ -c /dev/kmsg ] || mknod -m 660 /dev/kmsg c 1 11
 
 	# extra symbolic links not provided by default
 	[ -e /dev/fd ] || ln -snf /proc/self/fd /dev/fd

init.d/localmount.in

@@ -13,9 +13,9 @@ description="Mounts disks and swap according to /etc/fstab."
 
 depend()
 {
-	need fsck root
-	use lvm modules
-	after clock lvm modules
+	need fsck
+	use lvm modules root
+	after clock lvm modules root
 	keyword -docker -jail -lxc -prefix -systemd-nspawn -vserver
 }
 

init.d/meson.build

@@ -1,100 +0,0 @@
-init_d_dir = get_option('sysconfdir') / 'init.d'
-
-init_common =  [
-  'bootmisc.in',
-  'fsck.in',
-  'hostname.in',
-  'local.in',
-  'localmount.in',
-  'loopback.in',
-  'netmount.in',
-  'osclock.in',
-  'root.in',
-  'savecache.in',
-  'swap.in',
-  'swclock.in',
-  'sysctl.in',
-  'runsvdir.in',
-  'urandom.in',
-  's6-svscan.in',
-  ]
-
-if get_option('newnet')
-  init_common = init_common + [
-    'network.in',
-    'staticroute.in',
-    ]
-endif
-
-init_Linux =  [
-  'agetty.in',
-  'binfmt.in',
-  'cgroups.in',
-  'consolefont.in',
-  'devfs.in',
-  'dmesg.in',
-  'hwclock.in',
-  'keymaps.in',
-  'killprocs.in',
-  'modules.in',
-  'mount-ro.in',
-  'mtab.in',
-  'numlock.in',
-  'procfs.in',
-  'net-online.in',
-  'save-keymaps.in',
-  'save-termencoding.in',
-  'sysfs.in',
-  'termencoding.in',
-  ]
-
-init_BSD =  [
-  'hostid.in',
-  'moused.in',
-  'newsyslog.in',
-  'pf.in',
-  'rarpd.in',
-  'rc-enabled.in',
-  'rpcbind.in',
-  'savecore.in',
-  'syslogd.in',
-  ]
-
-init_FreeBSD =  [
-  'adjkerntz.in',
-  'devd .in',
-  'dumpon.in',
-  'encswap.in',
-  'ipfw.in',
-  'modules.in',
-  'mixer.in',
-  'nscd.in',
-  'powerd.in',
-  'syscons.in',
-  ]
-
-init_NetBSD =  [
-  'devdb.in',
-  'swap-blk.in',
-  'ttys.in',
-  'wscons.in',
-  ]
-
-init_data = init_common
-if os == 'Dragonfly'
-  init_data = init_data + init_BSD
-elif os == 'FreeBSD' or os == 'Gnu-kFreeBSD'
-  init_data = init_data + init_BSD + init_FreeBSD
-elif os == 'Linux'
-  init_data = init_data + init_Linux
-elif os == 'NetBSD'
-  init_data = init_data + init_BSD + init_NetBSD
-  endif
-
-foreach init_d_file : init_data
-  configure_file(input : init_d_file,
-    output : '@BASENAME@',
-    configuration : init_d_conf_data,
-    install_dir: init_d_dir,
-    install_mode: 'rwxr-xr-x')
-endforeach

init.d/modules.in

@@ -41,18 +41,18 @@ find_modfiles()
 
 load_modules()
 {
-	local file m _modules rc x
+	local file m modules rc x
 	file=$1
 	[ -z "$file" ] && return 0
 	while read m x; do
 		case $m in
 			\;*) continue ;;
 			\#*) continue ;;
-			*) _modules="$_modules $m"
+			*) modules="$modules $m"
 			;;
 		esac
 	done < $file
-	for x in $_modules; do
+	for x in $modules; do
 		ebegin "Loading module $x"
 		case "$RC_UNAME" in
 			FreeBSD) kldload "$x"; rc=$? ;;

init.d/net-online.in

@@ -23,7 +23,7 @@ get_interfaces()
 {
 	local ifname iftype
 	for ifname in /sys/class/net/*; do
-		[ -h "${ifname}" ] || continue
+		[ -h "${ifname}" ] && continue
 		read iftype < ${ifname}/type
 		[ "$iftype" = "1" ] && printf "%s " ${ifname##*/}
 	done

init.d/numlock.in

@@ -42,8 +42,6 @@ start()
 
 stop()
 {
-	yesno $RC_GOINGDOWN && return 0
-
 	ebegin "Disabling numlock on ttys"
 	_setleds -
 	eend $? "Failed to disable numlock"

init.d/osclock.in

@@ -17,15 +17,3 @@ depend()
 {
 	provide clock
 }
-
-start()
-{
-	# This stub function is required to avoid OpenRC warning at boot:
-	#
-	#  * The command variable is undefined.
-	#  * There is nothing for osclock to start.
-	#  * If this is what you intend, please write a start function.
-	#  * This will become a failure in a future release.
-	#
-	return 0
-}

init.d/s6-svscan.in

@@ -21,13 +21,9 @@ depend()
 
 start_pre()
 {
-	if [ ! -e "$command" ]; then
-		eerror "$command is missing (please install s6)"
-	else
-		einfo "Creating s6 scan directory"
-		checkpath -d -m 0755 "$RC_SVCDIR"/s6-scan
-	fi
-	return
+	einfo "Creating s6 scan directory"
+	checkpath -d -m 0755 "$RC_SVCDIR"/s6-scan
+	return $?
 }
 
 stop_post()

local.d/meson.build

@@ -1,7 +0,0 @@
-local_d_dir = get_option('sysconfdir') / 'local.d'
-
-local_data =  [
-  'README'
-  ]
-
-install_data(local_data, install_dir : local_d_dir)

man/meson.build

@@ -1,34 +0,0 @@
-man3 = [
-  'einfo.3',
-  'rc_config.3',
-  'rc_deptree.3',
-  'rc_find_pids.3',
-  'rc_plugin_hook.3',
-  'rc_runlevel.3',
-  'rc_service.3',
-  'rc_stringlist.3',
-  ]
-
-man8 = [
-  'openrc.8',
-  'openrc-run.8',
-  'rc-service.8',
-  'rc-status.8',
-  'rc-update.8',
-  'start-stop-daemon.8',
-  'supervise-daemon.8',
-  ]
-
-if os == 'Linux'
-  man8 = man8 + [
-    'rc-sstat.8',
-    'openrc-init.8',
-    'openrc-shutdown.8',
-    ]
-endif
-
-install_data(man3,
-  install_dir : get_option('mandir') / 'man3')
-install_data(man8,
-  install_dir : get_option('mandir') / 'man8')
-meson.add_install_script('meson_man_links.sh', get_option('mandir'), man3 + man8)

man/meson_man_links.sh

@@ -1,20 +0,0 @@
-#!/bin/sh
-
-get_links() {
-	sed -e 's/ ,//g' \
-		-e '/^\.Sh NAME$/,/\.Sh/ s/\.Nm //p' \
-		-n ${MESON_SOURCE_ROOT}/man/${1}
-}
-
-MANDIR="$1"
-shift
-for man in $@; do
-	prefix=${man%%.*}
-	suffix=${man#*.}
-	links=$(get_links ${man})
-	for link in ${links}; do
-		if [ "${link}" != "${prefix}" ]; then
-			ln -sf ${man} ${MESON_INSTALL_DESTDIR_PREFIX}/${MANDIR}/man${suffix}/${link}.${suffix}
-		fi
-	done
-done

man/openrc-run.8

@@ -104,6 +104,8 @@ supervisor=s6.
 or set
 supervisor=supervise-daemon
 to use supervise-daemon.
+Note that supervise-daemon is still in early development, so it is
+considered experimental.
 .It Ar s6_service_path
 The path to the s6 service directory if you are monitoring this service
 with S6. The default is /var/svc.d/${RC_SVCNAME}.
@@ -330,7 +332,7 @@ section below.
 .Sh _pre AND _post FUNCTIONS
 Any command defined in extra_commands, extra_started_commands or
 extra_stopped_commands can have _pre and _post functions in the service
-script. If the command function is called foo, the _pre and _post
+script. If the command function is called foo, the_pre and _post
 functions for it should be called foo_pre and foo_post.
 .Pp
 These functions should be used to perform preparation before the
@@ -459,7 +461,6 @@ Mark the service as inactive.
 .Op Fl p , -pipe
 .Op Fl m , -mode Ar mode
 .Op Fl o , -owner Ar owner
-.Op Fl s , -symlinks
 .Op Fl W , -writable
 .Op Fl q , -quiet
 .Ar path ...
@@ -480,11 +481,6 @@ or with names, and are separated by a colon.
 The truncate options (-D and -F) cause the directory or file to be
 cleared of all contents.
 .Pp
-If -s is not specified on a non-linux platform, checkpath will refuse to
-allow non-terminal symbolic links to exist in the path. This is for
-security reasons so that a non-root user can't create a symbolic link to
-a root-owned file and take ownership of that file.
-.Pp
 If -W is specified, checkpath checks to see if the first path given on
 the command line is writable.  This is different from how the test
 command in the shell works, because it also checks to make sure the file

man/openrc.8

@@ -65,29 +65,6 @@ Instead you should use
 and
 .Xr shutdown 8
 and let them call these special runlevels.
-.Sh OPTIONS
-.Pp
-.Bl -tag -width "-o , --override"
-.It Fl n , -no-stop
-Do not stop any services.
-.It Fl o , -override
-Override the next runlevel to change into when leaving single user or boot
-runlevels
-.It Fl s , -service
-Run the service specified with the rest of the arguments.
-.It Fl S , -sys
-Output the RC system type, if any.
-.It Fl h , -help
-Display usage information and exit.
-.It Fl C , -nocolor
-Disable color output.
-.It Fl V , -version
-Display software version.
-.It Fl v , -verbose
-Run verbosely.
-.It Fl q , -quiet
-Run quietly (repeat to suppress errors).
-.El
 .Sh SEE ALSO
 .Xr openrc-run 8 ,
 .Xr rc-status 8 ,

man/start-stop-daemon.8

@@ -120,7 +120,7 @@ Saves the pid of the daemon in the file specified by the
 .Fl p , -pidfile
 option. Only useful when used with daemons that run in the foreground and
 forced into the background with the
-.Fl b , -background
+.Fl -b , -background
 option.
 .It Fl I , -ionice Ar class Ns Op : Ns Ar data
 Modifies the IO scheduling priority of the daemon.

man/supervise-daemon.8

@@ -37,8 +37,6 @@ servicename
 .Ar count
 .Fl N , -nicelevel
 .Ar level
-.Fl p , -pidfile
-.Ar supervisorpidfile
 .Fl P , -respawn-period
 .Ar seconds
 .Fl R , -retry
@@ -124,9 +122,6 @@ If respawn-period is also set, more than respawn-max crashes must occur
 during respawn-period seconds to cause
 .Nm
 to give up and exit.
-.It Fl p , -pidfile Ar supervisorpidfile
-Sets a path for the supervisor's pid file. Note that this is not the pid
-file of the process that is being supervised.
 .It Fl N , -nicelevel Ar level
 Modifies the scheduling priority of the daemon.
 .It Fl P , -respawn-period Ar seconds
@@ -156,10 +151,6 @@ The same thing as
 but with the standard error output.
 .El
 .Sh ENVIRONMENT
-.Va SSD_IONICELEVEL
-can also set the IO scheduling priority of the daemon, but the command line
-option takes precedence.
-.Pp
 .Va SSD_NICELEVEL
 can also set the scheduling priority of the daemon, but the command line
 option takes precedence.

meson.build

@@ -1,212 +0,0 @@
-project('OpenRC', 'c',
-  version : '0.44.10',
-  license: 'BSD-2',
-  default_options : [
-    'c_std=c99',
-	'prefix=/usr',
-    'warning_level=3',
-    ],
-  meson_version : '>=0.49.0')
-
-cc = meson.get_compiler('c')
-
-audit_dep = dependency('audit', required : get_option('audit'))
-if audit_dep.found()
-  cc_audit_flags = '-DHAVE_AUDIT'
-  else
-  cc_audit_flags = []
-  endif
-
-if get_option('branding') != ''
-  cc_branding_flags = '-DBRANDING=' + get_option('branding')
-else
-  cc_branding_flags = []
-endif
-
-libname = get_option('libdir').split('/')[-1]
-
-option_local_prefix = get_option('local_prefix')
-if option_local_prefix == ''
-  local_prefix = get_option('prefix') / 'usr' / 'local'
-else
-  local_prefix = option_local_prefix
-endif
-
-option_os = get_option('os')
-if option_os == ''
-  uname = find_program('uname')
-  r = run_command(uname, '-s')
-  os = r.stdout().strip()
-  os = '-'.join(os.split('/'))
-else
-  os = option_os
-endif
-
-pam_dep = dependency('pam', required: false)
-if not pam_dep.found()
-  pam_dep = cc.find_library('pam', required: false)
-endif
-if pam_dep.found() and get_option('pam')
-  cc_pam_flags = '-DHAVE_PAM'
-else
-  cc_pam_flags = []
-endif
-
-if not pam_dep.found() and get_option('pam')
-  error('Pam was requested but could not be located')
-  endif
-
-option_pkg_prefix = get_option('pkg_prefix')
-if option_pkg_prefix == ''
-  if os == 'Dragonfly' or os == 'FreeBSD'
-    pkg_prefix = '/usr/local'
-  elif os == 'GNU' or os == 'GNU-kFreeBSD' or os == 'Linux'
-    pkg_prefix = '/usr'
-  elif os == 'NetBSD'
-    pkg_prefix = '/usr/pkg'
-  endif
-else
-  pkg_prefix = option_pkg_prefix
-endif
-
-if get_option('split-usr') == 'auto'
-  split_usr = run_command('test', '-L', '/bin').returncode() != 0
-else
-  split_usr = get_option('split-usr') == 'true'
-endif
-
-rootprefix = get_option('rootprefix')
-rootprefix_default = '/'
-if rootprefix == ''
-rootprefix = rootprefix_default
-endif
-
-bindir = rootprefix / get_option('bindir')
-libdir = rootprefix / get_option('libdir')
-libexecdir = get_option('libexecdir')
-if os == 'Linux' and libexecdir == 'libexec'
-  libexecdir = 'lib'
-endif
-libexecdir = rootprefix / libexecdir
-rc_libexecdir = libexecdir / 'rc'
-rc_bindir = rc_libexecdir / 'bin'
-rc_sbindir = rc_libexecdir / 'sbin'
-sbindir = rootprefix / get_option('sbindir')
-
-crypt_dep = []
-
-selinux_dep = dependency('libselinux', required : get_option('selinux'))
-pam_misc_dep = []
-if selinux_dep.found()
-  cc_selinux_flags = '-DHAVE_SELINUX'
-  if pam_dep.found() and get_option('pam')
-    pam_misc_dep = dependency('pam_misc', required: false)
-    if not pam_misc_dep.found()
-      pam_misc_dep = cc.find_library('pam_misc', required: false)
-    endif
-    if not pam_misc_dep.found() and get_option('pam')
-      error('Pam was requested but could not be located')
-    endif
-  else
-    crypt_dep = dependency('libcrypt', required : false)
-    if not crypt_dep.found()
-      crypt_dep = cc.find_library('crypt', required : true)
-    endif
-  endif
-else
-  cc_selinux_flags = []
-endif
-
-termcap = get_option('termcap')
-if termcap != ''
-  termcap_dep = dependency(termcap)
-  termcap_flags = '-DHAVE_TERMCAP'
-  else
-  termcap_dep = []
-  termcap_flags = []
-endif
-
-if get_option('buildtype').startswith('debug')
-  cc_debug_flags = ['-DRC_DEBUG']
-else
-  cc_debug_flags = []
-endif
-
-if os == 'Linux' or os == 'GNU-kFreeBSD'
-  cc_os_flags = ['-D_DEFAULT_SOURCE']
-elif os == 'FreeBSD'
-  cc_os_flags = ['-D_BSD_SOURCE']
-elif os == 'GNU'
-  cc_os_flags = ['-D_DEFAULT_SOURCE', '-DMAXPATHLEN=4096', '-DPATH_MAX=4096']
-  endif
-
-# Try and use some good cc flags if we're building from git. We don't use
-# -pedantic as it will warn about our perfectly valid use of %m in our logger.
-# We should be using -Wredundant-decls, but our library hidden proto stuff gives
-# loads of warnings. I don't fully understand it (the hidden proto, not the
-# warning) so we just silence the warning.
-cc_warning_flags_test = [
-  '-Wcast-align',
-  '-Wcast-qual',
-  '-Wdeclaration-after-statement',
-  '-Wformat=2',
-  '-Winline',
-  '-Wmissing-declarations',
-  '-Wmissing-format-attribute',
-  '-Wmissing-noreturn',
-  '-Wmissing-prototypes',
-  '-Wnested-externs',
-  '-Wpointer-arith',
-  '-Wsequence-point',
-  '-Wshadow',
-  '-Wwrite-strings',
-  '-Werror=implicit-function-declaration',
-  ]
-cc_warning_flags = cc.get_supported_arguments(cc_warning_flags_test)
-cc_flags = [cc_debug_flags, cc_os_flags, cc_warning_flags]
-add_project_arguments(cc_flags, language : 'c')
-
-incdir = include_directories('src/includes')
-einfo_incdir = include_directories('src/libeinfo')
-rc_incdir = include_directories('src/librc')
-
-init_d_conf_data = configuration_data()
-init_d_conf_data.set('SBINDIR', sbindir)
-init_d_conf_data.set('PKG_PREFIX', pkg_prefix)
-init_d_conf_data.set('SYSCONFDIR', get_option('sysconfdir'))
-
-dl_dep = cc.find_library('dl', required: false)
-util_dep = cc.find_library('util', required: false)
-
-if get_option('bash-completions')
-  subdir('bash-completion')
-endif
-subdir('conf.d')
-subdir('etc')
-subdir('init.d')
-subdir('local.d')
-subdir('man')
-if get_option('pam')
-subdir('pam')
-  endif
-if get_option('pkgconfig')
-subdir('pkgconfig')
-  endif
-subdir('scripts')
-subdir('sh')
-subdir('src')
-subdir('support')
-subdir('sysctl.d')
-if get_option('zsh-completions')
-  subdir('zsh-completion')
-endif
-
-meson.add_install_script('tools/meson_runlevels.sh',
-  os,
-  get_option('newnet') ? 'yes' : 'no',
-  rc_libexecdir,
-  get_option('sysconfdir'),
-  get_option('sysvinit') ? 'yes' : 'no')
-meson.add_install_script('tools/meson_final.sh',
-  rc_libexecdir,
-  os)

meson_options.txt

@@ -1,37 +0,0 @@
-option('audit', type : 'feature', value : 'auto',
-  description : 'enable libaudit support')
-option('bash-completions', type : 'boolean',
-  description : 'install bash completions')
-option('branding', type : 'string',
-  description : 'Add branding to OpenRC')
-option('local_prefix', type : 'string', value : '/usr/local',
-  description : 'default location of user maintained packages')
-option('newnet', type : 'boolean',
-  description : 'build and install our networking scripts')
-option('os', type : 'combo',
-  choices :
-    [ '', 'DragonFly', 'FreeBSD', 'GNU', 'GNU-kFreeBSD', 'Linux', 'NetBSD' ],
-  description : 'Operating System (autodetected if not specified)')
-option('pam', type : 'boolean',
-  description : 'enable PAM support')
-option('pkg_prefix', type : 'string',
-  description : 'default location where packages are installed')
-option('pkgconfig', type : 'boolean',
-  description : 'build PKGConfig files')
-option('rootprefix', type : 'string',
-  description : 'override the root prefix')
-option('selinux', type : 'feature', value : 'auto',
-  description : 'enable SELinux support')
-option('shell', type : 'string', value : '/bin/sh',
-  description : 'Default posix compatible shell')
-option('split-usr', type : 'combo',
-  choices : ['auto', 'true', 'false'],
-  description : '''/bin, /sbin aren't symlinks into /usr''')
-option('sysvinit', type : 'boolean', value : false,
-  description : 'enable SysVinit compatibility (linux only)')
-option('termcap', type : 'combo',
-  choices :
-    [ '', 'ncurses', 'termcap' ],
-  description : 'the termcap library to use')
-option('zsh-completions', type : 'boolean',
-  description : 'install zsh completions')

mk/lib.mk

@@ -52,12 +52,13 @@ ${SHLIB_NAME}:	${SOBJS}
 	${SOBJS} ${LDADD}
 
 install: all
-	${INSTALL} -d ${DESTDIR}${LIBDIR}
 ifeq (${MKSTATICLIBS},yes)
+	${INSTALL} -d ${DESTDIR}${LIBDIR}
 	${INSTALL} -m ${LIBMODE} lib${LIB}.a ${DESTDIR}${LIBDIR}
 endif
-	${INSTALL} -m ${LIBMODE} ${SHLIB_NAME} ${DESTDIR}${LIBDIR}
-	ln -fs ${SHLIB_NAME} ${DESTDIR}${LIBDIR}/${SHLIB_LINK}
+	${INSTALL} -d ${DESTDIR}${SHLIBDIR}
+	${INSTALL} -m ${LIBMODE} ${SHLIB_NAME} ${DESTDIR}${SHLIBDIR}
+	ln -fs ${SHLIB_NAME} ${DESTDIR}${SHLIBDIR}/${SHLIB_LINK}
 	${INSTALL} -d ${DESTDIR}${INCDIR}
 	for x in ${INCS}; do ${INSTALL} -m ${INCMODE} $$x ${DESTDIR}${INCDIR}; done
 

mk/sys.mk

@@ -52,9 +52,9 @@ _LIBNAME:=		$(shell ${_LIBNAME_SH})
 LIBNAME?=		${_LIBNAME}
 LIBDIR?=		${UPREFIX}/${LIBNAME}
 LIBMODE?=		0644
+SHLIBDIR?=		${PREFIX}/${LIBNAME}
 
 LIBEXECDIR?=		${PREFIX}/libexec/rc
-PKGCONFIGDIR?= ${UPREFIX}/${LIBNAME}/pkgconfig
 
 MANPREFIX?=		${UPREFIX}/share
 MANDIR?=		${MANPREFIX}/man

pam/meson.build

@@ -1,9 +0,0 @@
-pam_dir =	get_option('sysconfdir') / 'pam.d'
-
-pam_files = [
-  'start-stop-daemon',
-  'supervise-daemon',
-  ]
-
-install_data(pam_files,
-  install_dir : pam_dir)

pam/start-stop-daemon

@@ -1,6 +0,0 @@
-#%PAM-1.0
-
-auth            required        pam_permit.so
-account         required        pam_permit.so
-password        required        pam_deny.so
-session         optional        pam_limits.so

pam/supervise-daemon

@@ -1,6 +0,0 @@
-#%PAM-1.0
-
-auth            required        pam_permit.so
-account         required        pam_permit.so
-password        required        pam_deny.so
-session         optional        pam_limits.so

pkgconfig/Makefile

@@ -1,4 +1,4 @@
-DIR=	${PKGCONFIGDIR}
+DIR=	${LIBDIR}/pkgconfig
 SRCS=	einfo.pc.in openrc.pc.in
 INC=	einfo.pc openrc.pc
 

pkgconfig/meson.build

@@ -1,22 +0,0 @@
-pkgconfig_dir =	get_option('libdir') / 'pkgconfig'
-
-pkgconfig_conf_data = configuration_data()
-if rootprefix != '/'
-  pkgconfig_conf_data.set('PREFIX', rootprefix)
-else
-  pkgconfig_conf_data.set('PREFIX', '')
-endif
-pkgconfig_conf_data.set('LIB', get_option('libdir'))
-pkgconfig_conf_data.set('VERSION', meson.project_version())
-
-pkgconfig_files = [
-  'einfo.pc.in',
-  'openrc.pc.in',
-  ]
-
-foreach file : pkgconfig_files
-  configure_file(input : file,
-    output : '@BASENAME@',
-    configuration : pkgconfig_conf_data,
-    install_dir : pkgconfig_dir)
-endforeach

runlevels/Makefile

@@ -90,12 +90,6 @@ install:
 			fi; \
 			ln -snf ${INITDIR}/"$$x" ${SHUTDOWNDIR}/"$$x" || exit $$?; done \
 	fi
-	if test "${MKSYSVINIT}" = yes && test "${OS}" = Linux; then \
-		for x in tty1 tty2 tty3 tty4 tty5 tty6; do \
-			ln -snf ${INITDIR}/agetty ${DESTDIR}/${INITDIR}/"agetty.$$x" || exit $$?; \
-			ln -snf ${INITDIR}/agetty.$$x ${DEFAULTDIR}/"agetty.$$x" || exit $$?; \
-		done; \
-	fi
 
 check test::
 

scripts/meson.build

@@ -1,45 +0,0 @@
-script_conf_data = configuration_data()
-script_conf_data.set('SBINDIR', sbindir)
-
-script_dir = rc_libexecdir / 'bin'
-
-scripts_internal = [
-  'on_ac_power',
-  ]
-  
-scripts_Linux = [
-  'rc-sstat.in',
-  ]
-
-scripts_sysvinit = [
-  'halt.in',
-  'poweroff.in',
-  'shutdown.in',
-  'reboot.in',
-  ]
-
-install_data(scripts_internal,
-  install_dir : script_dir,
-  install_mode: 'rwxr-xr-x')
-
-if os == 'Linux'
-  foreach file : scripts_Linux
-    configure_file(input : file,
-      output : '@BASENAME@',
-      configuration : script_conf_data,
-      install_dir: script_dir,
-      install_mode: 'rwxr-xr-x')
-  endforeach
-  if get_option('sysvinit')
-    foreach file : scripts_sysvinit
-      configure_file(input : file,
-        output : '@BASENAME@',
-        configuration : script_conf_data,
-	    install_dir: script_dir,
-        install_mode: 'rwxr-xr-x')
-    endforeach
-  endif
-endif
-
-meson.add_install_script('meson_script_links.sh', rc_libexecdir,
-	sbindir)

scripts/meson_script_links.sh

@@ -1,19 +0,0 @@
-#!/bin/sh
-
-set -e
-set -u
-
-rc_libexecdir="$1"
-sbindir="$2"
-binaries=" halt poweroff rc-sstat reboot shutdown"
-for f in $binaries; do
-	if [ -x "${DESTDIR}${rc_libexecdir}/bin/${f}"  ]; then
-		ln -snf "${rc_libexecdir}/bin/${f}" \
-			"${DESTDIR}${sbindir}/${f}"
-	fi
-done
-# sysvinit is active when halt exits
-if [ -x "${DESTDIR}${rc_libexecdir}/bin/halt"  ]; then
-	ln -snf "${sbindir}/openrc-init" \
-		"${DESTDIR}${sbindir}/init"
-fi

scripts/on_ac_power

@@ -18,10 +18,9 @@ if [ -f /proc/acpi/ac_adapter/*/state ]; then
 		"state:"*"off-line") exit 128;;
 		esac
 	done
-elif [ -d /sys/class/power_supply ]; then
-	for dir in /sys/class/power_supply/*/; do
-		[ "$(cat "${dir}/type")" != "Mains" ] && continue
-		[ "$(cat "${dir}/online")" = 0 ] && exit 128
+elif [ -f /sys/class/power_supply/*/online ]; then
+	cat /sys/class/power_supply/*/online | while read line; do
+		[ "${line}" = 0 ] && exit 128
 	done
 elif [ -f /proc/pmu/info ]; then
 	cat /proc/pmu/info | while read line; do

scripts/shutdown.in

@@ -1,31 +1,14 @@
 #!/bin/sh
 
-do_halt=false
+shutdown_arg=
 while getopts :akrhPHfFnct: opt; do
 	case "$opt" in
 		a) ;;
 		k) ;;
-		r)
-			shutdown_arg=--reboot
-			;;
-		h)
-			do_halt=true
-			shutdown_arg=--poweroff
-			;;
-		P)
-			if ! ${do_halt}; then
-				printf "%s\n" "The -P flag requires the -h flag" >&2
-				exit 1
-			fi
-			shutdown_arg=--poweroff
-			;;
-		H)
-			if ! ${do_halt}; then
-				printf "%s\n" "The -H flag requires the -h flag" >&2
-				exit 1
-			fi
-			shutdown_arg=--halt
-			;;
+		r) shutdown_arg=--reboot ;;
+		h) shutdown_arg=--halt ;;
+		P) shutdown_arg=--poweroff ;;
+		H) shutdown_arg=--halt ;;
 		f) ;;
 		F) ;;
 		n) ;;
@@ -42,5 +25,5 @@ if [ -z "${shutdown_arg}" ]; then
 	shutdown_arg=--single
 fi
 
-printf "%s %s\n" "@SBINDIR@/openrc-shutdown ${shutdown_arg}" "$@"
+echo @SBINDIR@/openrc-shutdown ${shutdown_arg} "$@"
 exec @SBINDIR@/openrc-shutdown ${shutdown_arg} "$@"

sh/binfmt.sh.in

@@ -29,9 +29,6 @@ apply_file() {
 			\;*) continue ;;
 		esac
 
-		local reg=${line#*:}
-		[ -e /proc/sys/fs/binfmt_misc/${reg%%:*} ] && echo -1 > /proc/sys/fs/binfmt_misc/${reg%%:*}
-
 		echo "${line}" > /proc/sys/fs/binfmt_misc/register
 		rc=$?
 		if [ $rc -ne 0 ]; then

sh/init-early.sh.Linux.in

@@ -20,7 +20,7 @@ service_present()
 	# succeed if $RC_SYS empty, can't check further, assume script will run
 	[ -z "$RC_SYS" ] && return 0
 	# fail if file contains "-$RC_SYS", because then it won't run
-	grep -Eqi "^[[:space:]]*keyword[[:space:]].*-$RC_SYS([[:space:]]|$)" "$p" && return 1
+	egrep -qi "^[[:space:]]*keyword[[:space:]].*-$RC_SYS\>" "$p" && return 1
 	# succeed otherwise
 	return 0
 }

sh/init.sh.Linux.in

@@ -71,17 +71,20 @@ if [ "$sys" = VSERVER ]; then
 	rm -rf /run/*
 elif ! mountinfo -q /run; then
 	ebegin "Mounting /run"
-	run_mount_opts="mode=0755,nosuid,nodev,nr_inodes=800k,size=20%,strictatime"
+	rc=0
 	if ! fstabinfo --mount /run; then
-		if ! mount -t tmpfs -o ${run_mount_opts} tmpfs /run; then
-			eerror "Unable to mount tmpfs on /run."
-			eerror "Can't continue."
-			exit 1
-		fi
+		mount -t tmpfs -o mode=0755,nodev,size=10% tmpfs /run
+		rc=$?
+	fi
+	if [ $rc != 0 ]; then
+		eerror "Unable to mount tmpfs on /run."
+		eerror "Can't continue."
+		exit 1
 	fi
 fi
 
-checkpath -d "$RC_SVCDIR"
+[ -x /sbin/restorecon ] && /sbin/restorecon -rF /run
+checkpath -d $RC_SVCDIR
 checkpath -d -m 0775 -o root:uucp /run/lock
 
 # Try to mount xenfs as early as possible, otherwise rc_sys() will always
@@ -99,5 +102,4 @@ if [ -e "$RC_LIBEXECDIR"/cache/softlevel ]; then
 fi
 
 echo sysinit >"$RC_SVCDIR"/softlevel
-[ -x /sbin/restorecon ] && /sbin/restorecon -rF /run
 exit 0

sh/meson.build

@@ -1,84 +0,0 @@
-sh_conf_data = configuration_data()
-if rootprefix == '/'
-  sh_conf_data.set('PREFIX', '')
-  else
-  sh_conf_data.set('PREFIX', rootprefix)
-endif
-sh_conf_data.set('BINDIR', bindir)
-sh_conf_data.set('LIBEXECDIR', rc_libexecdir)
-sh_conf_data.set('LOCAL_PREFIX', local_prefix)
-sh_conf_data.set('PKG_PREFIX', pkg_prefix)
-sh_conf_data.set('SBINDIR', sbindir)
-sh_conf_data.set('SHELL', get_option('shell'))
-sh_conf_data.set('SYSCONFDIR', get_option('sysconfdir'))
-
-sh_dir = rc_libexecdir / 'sh'
-
-sh = [
-  'rc-functions.sh',
-  'rc-mount.sh',
-  'runit.sh',
-  's6.sh',
-  'start-stop-daemon.sh',
-  'supervise-daemon.sh',
-  ]
-
-sh_config = [
-  'functions.sh.in',
-  ]
-
-scripts_config = [
-  'gendepends.sh.in',
-  'openrc-run.sh.in',
-  ]
-
-if os == 'Linux'
-  sh += [
-    'rc-cgroup.sh',
-    ]
-  scripts_config += [
-    'binfmt.sh.in',
-    'cgroup-release-agent.sh.in',
-   ]
-  scripts_config_os = [
-    ['init-early.sh.Linux.in', 'init-early.sh'],
-    ['init.sh.Linux.in', 'init.sh'],
-    ]
-elif os == 'GNU'
-  scripts_config_os = [
-    ['init.sh.GNU.in', 'init.sh'],
-    ]
-elif os == 'Gnu-KFreeBSD'
-  scripts_config_os = [
-    ['init.sh.GNU-kFreeBSD.in', 'init.sh'],
-    ]
-else
-  scripts_config_os = [
-    ['init.sh.BSD.in', 'init.sh'],
-    ]
-endif
-
-install_data(sh,
-  install_dir : sh_dir)
-foreach file : sh_config
-  configure_file(input : file,
-    output : '@BASENAME@',
-    configuration : sh_conf_data,
-    install_dir : sh_dir)
-endforeach
-
-foreach file : scripts_config
-  configure_file(input : file,
-    output : '@BASENAME@',
-    configuration : sh_conf_data,
-    install_dir : sh_dir,
-    install_mode : 'rwxr-xr-x')
-endforeach
-
-foreach file : scripts_config_os
-  configure_file(input : file.get(0),
-    output : file.get(1),
-    configuration : sh_conf_data,
-    install_dir : sh_dir,
-    install_mode : 'rwxr-xr-x')
-endforeach

sh/openrc-run.sh.in

@@ -254,11 +254,8 @@ fi
 for _cmd; do
 	if [ "$_cmd" != status -a "$_cmd" != describe ]; then
 		# Apply any ulimit defined
-		if [ -n "${rc_ulimit:-$RC_ULIMIT}" ]; then
-			if ! ulimit ${rc_ulimit:-$RC_ULIMIT}; then
-				eerror "${RC_SVCNAME}: unable to apply RC_ULIMIT settings"
-			fi
-		fi
+		[ -n "${rc_ulimit:-$RC_ULIMIT}" ] && \
+			ulimit ${rc_ulimit:-$RC_ULIMIT}
 		# Apply cgroups settings if defined
 		if [ "$(command -v cgroup_add_service)" = "cgroup_add_service" ]
 		then

sh/rc-cgroup.sh

@@ -24,26 +24,18 @@ cgroup_find_path()
 	printf "%s" "${result}"
 }
 
-# This extracts all pids in a cgroup and puts them in the cgroup_pids
-# variable.
-# It is done this way to avoid subshells so we don't have to worry about
-# locating the pid of the subshell in the cgroup.
-# https://github.com/openrc/openrc/issues/396
 cgroup_get_pids()
 {
-	local cgroup_procs p
-	cgroup_pids=
+	local cgroup_procs p pids
 	cgroup_procs="$(cgroup2_find_path)"
-	if [ -n "${cgroup_procs}" ]; then
-		cgroup_procs="${cgroup_procs}/${RC_SVCNAME}/cgroup.procs"
-	else
+	[ -n "${cgroup_procs}" ] &&
+		cgroup_procs="${cgroup_procs}/${RC_SVCNAME}/cgroup.procs" ||
 		cgroup_procs="/sys/fs/cgroup/openrc/${RC_SVCNAME}/tasks"
-	fi
 	[ -f "${cgroup_procs}" ] || return 0
 	while read -r p; do
-		[ "$p" -eq $$ ] && continue
-		cgroup_pids="${cgroup_pids} ${p}"
+		[ "$p" -eq $$ ] || pids="${pids} ${p}"
 	done < "${cgroup_procs}"
+	printf "%s" "${pids}"
 	return 0
 }
 
@@ -189,8 +181,7 @@ cgroup2_set_limits()
 {
 	local cgroup_path
 	cgroup_path="$(cgroup2_find_path)"
-	[ -z "${cgroup_path}" ] && return 0
-	mountinfo -q "${cgroup_path}"|| return 0
+	[ -d "${cgroup_path}" ] || return 0
 	rc_cgroup_path="${cgroup_path}/${RC_SVCNAME}"
 	[ ! -d "${rc_cgroup_path}" ] && mkdir "${rc_cgroup_path}"
 	[ -f "${rc_cgroup_path}"/cgroup.procs ] &&
@@ -201,7 +192,7 @@ cgroup2_set_limits()
 		[ -z "${value}" ] && continue
 		[ ! -f "${rc_cgroup_path}/${key}" ] && continue
 		veinfo "${RC_SVCNAME}: cgroups: setting ${key} to ${value}"
-		printf "%s" "${value}" > "${rc_cgroup_path}/${key}"
+		printf "%s\n" "${value}" > "${rc_cgroup_path}/${key}"
 	done
 	return 0
 }
@@ -209,29 +200,26 @@ cgroup2_set_limits()
 cgroup_cleanup()
 {
 	cgroup_running || return 0
-	ebegin "Starting cgroups cleanup"
-	local loops=0
-	cgroup_get_pids
-	if [ -n "${cgroup_pids}" ]; then
-		kill -s CONT ${cgroup_pids} 2> /dev/null
-		kill -s "${stopsig:-TERM}" ${cgroup_pids} 2> /dev/null
+	ebegin "starting cgroups cleanup"
+	local pids loops=0
+	pids="$(cgroup_get_pids)"
+	if [ -n "${pids}" ]; then
+		kill -s CONT ${pids} 2> /dev/null
+		kill -s "${stopsig:-TERM}" ${pids} 2> /dev/null
 		yesno "${rc_send_sighup:-no}" &&
-			kill -s HUP ${cgroup_pids} 2> /dev/null
-		kill -s "${stopsig:-TERM}" ${cgroup_pids} 2> /dev/null
-		cgroup_get_pids
-		while [ -n "${cgroup_pids}" ] &&
+			kill -s HUP ${pids} 2> /dev/null
+		kill -s "${stopsig:-TERM}" ${pids} 2> /dev/null
+		while [ -n "$(cgroup_get_pids)" ] &&
 			[ "${loops}" -lt "${rc_timeout_stopsec:-90}" ]; do
 			loops=$((loops+1))
 			sleep 1
-			cgroup_get_pids
 		done
-		if [ -n "${cgroup_pids}" ] && yesno "${rc_send_sigkill:-yes}"; then
-			kill -s KILL ${cgroup_pids} 2> /dev/null
-		fi
+		pids="$(cgroup_get_pids)"
+		[ -n "${pids}" ] && yesno "${rc_send_sigkill:-yes}" &&
+			kill -s KILL ${pids} 2> /dev/null
 	fi
 	cgroup2_remove
-	cgroup_get_pids
-	[ -z "${cgroup_pids}" ]
+	[ -z "$(cgroup_get_pids)" ]
 	eend $? "Unable to stop all processes"
 	return 0
 }

sh/rc-mount.sh

@@ -48,7 +48,7 @@ do_unmount()
 		retry=4 # Effectively TERM, sleep 1, TERM, sleep 1, KILL, sleep 1
 		while ! LC_ALL=C $cmd "$mnt" 2>/dev/null; do
 			if command -v fuser >/dev/null 2>&1; then
-				pids="$(timeout -s KILL "${rc_fuser_timeout:-60}" \
+				pids="$(timeout -k 10 -s KILL "${rc_fuser_timeout:-60}" \
 					fuser $f_opts "$mnt" 2>/dev/null)"
 			fi
 			case " $pids " in

sh/runit.sh

@@ -20,20 +20,8 @@ runit_start()
 	service_link="${RC_SVCDIR}/sv/${service_path##*/}"
 	ebegin "Starting ${name:-$RC_SVCNAME}"
 	ln -snf "${service_path}" "${service_link}"
-	local i=0 retval=1
-	# it can take upto 5 seconds for runsv to start
-	while [ $i -lt 6 ] ; do
-		if sv start "${service_link}" > /dev/null 2>&1; then
-			retval=0
-			break
-		fi
-		sleep 1 && i=$(expr $i + 1)
-	done
-	if [ $retval -eq 1 ]; then
-		# clean up the link else sv will keep on trying
-		rm "${service_link}"
-	fi
-	eend $retval "Failed to start ${name:-$RC_SVCNAME}"
+	sv start "${service_link}" > /dev/null 2>&1
+	eend $? "Failed to start ${name:-$RC_SVCNAME}"
 }
 
 runit_stop()

src/common/meson.build

@@ -1,6 +0,0 @@
-version_h = vcs_tag(
-  input : 'version.h.in',
-  output : 'version.h')
-version_f = vcs_tag(
-  input : 'version.in',
-  output : 'version')

src/common/version.h.in

@@ -1,18 +0,0 @@
-/*
- * Copyright (c) 2007-2015 The OpenRC Authors.
- * See the Authors file at the top-level directory of this distribution and
- * https://github.com/OpenRC/openrc/blob/master/AUTHORS
- *
- * This file is part of OpenRC. It is subject to the license terms in
- * the LICENSE file found in the top-level directory of this
- * distribution and at https://github.com/OpenRC/openrc/blob/master/LICENSE
- * This file may not be copied, modified, propagated, or distributed
- *    except according to the terms contained in the LICENSE file.
- */
-
-#ifndef _VERSION_H_
-#define _VERSION_H_
-
-#define VERSION "@VCS_TAG@"
-
-#endif

src/common/version.in

@@ -1 +0,0 @@
-@VCS_TAG@

src/includes/hidden-visibility.h

@@ -0,0 +1,26 @@
+/*
+ * Written by Mike Frysinger
+ * Placed in the Public Domain
+ */
+
+#ifndef _HIDDEN_VISIBILITY_H_
+#define _HIDDEN_VISIBILITY_H_
+
+#if defined(__ELF__) && defined(__GNUC__)
+# define __hidden_asmname(name) __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
+# define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)
+# define __hidden_asmname2(prefix, name) #prefix name
+# define __hidden_proto(name, internal) \
+	extern __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
+	__attribute__ ((visibility ("hidden")));
+# define __hidden_ver(local, internal, name) \
+   extern __typeof (name) __EI_##name __asm__(__hidden_asmname (#internal)); \
+   extern __typeof (name) __EI_##name __attribute__((alias (__hidden_asmname1 (,#local))))
+# define hidden_proto(name) __hidden_proto(name, __RC_##name)
+# define hidden_def(name) __hidden_ver(__RC_##name, name, name);
+#else
+# define hidden_proto(name)
+# define hidden_def(name)
+#endif
+
+#endif

src/libeinfo/libeinfo.c

@@ -15,7 +15,7 @@
  *    except according to the terms contained in the LICENSE file.
  */
 
-static const char libeinfo_copyright[] = "Copyright (c) 2007-2008 Roy Marples";
+const char libeinfo_copyright[] = "Copyright (c) 2007-2008 Roy Marples";
 
 #include <sys/types.h>
 #include <sys/ioctl.h>
@@ -39,6 +39,34 @@ static const char libeinfo_copyright[] = "Copyright (c) 2007-2008 Roy Marples";
 
 #include "einfo.h"
 #include "helpers.h"
+#include "hidden-visibility.h"
+
+hidden_proto(ecolor)
+hidden_proto(ebegin)
+hidden_proto(ebeginv)
+hidden_proto(ebracket)
+hidden_proto(eend)
+hidden_proto(eendv)
+hidden_proto(eerror)
+hidden_proto(eerrorn)
+hidden_proto(eerrorx)
+hidden_proto(eindent)
+hidden_proto(eindentv)
+hidden_proto(einfo)
+hidden_proto(einfon)
+hidden_proto(einfov)
+hidden_proto(einfovn)
+hidden_proto(elog)
+hidden_proto(eoutdent)
+hidden_proto(eoutdentv)
+hidden_proto(eprefix)
+hidden_proto(ewarn)
+hidden_proto(ewarnn)
+hidden_proto(ewarnv)
+hidden_proto(ewarnvn)
+hidden_proto(ewarnx)
+hidden_proto(ewend)
+hidden_proto(ewendv)
 
 /* Incase we cannot work out how many columns from ioctl, supply a default */
 #define DEFAULT_COLS		 80
@@ -482,6 +510,7 @@ eprefix(const char *EINFO_RESTRICT prefix)
 {
 	_eprefix = prefix;
 }
+hidden_def(eprefix)
 
 static void EINFO_PRINTF(2, 0)
 elogv(int level, const char *EINFO_RESTRICT fmt, va_list ap)
@@ -508,6 +537,7 @@ elog(int level, const char *EINFO_RESTRICT fmt, ...)
 	elogv(level, fmt, ap);
 	va_end(ap);
 }
+hidden_def(elog)
 
 static int
 _eindent(FILE * EINFO_RESTRICT stream)
@@ -546,6 +576,7 @@ _ecolor(FILE * EINFO_RESTRICT f, ECOLOR color)
 			return ecolors_str[i];
 	return "";
 }
+hidden_def(ecolor)
 
 const char *
 ecolor(ECOLOR color)
@@ -612,6 +643,7 @@ einfon(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("einfon");
 	return retval;
 }
+hidden_def(einfon)
 
 int
 ewarnn(const char *EINFO_RESTRICT fmt, ...)
@@ -627,6 +659,7 @@ ewarnn(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("ewarnn");
 	return retval;
 }
+hidden_def(ewarnn)
 
 int
 eerrorn(const char *EINFO_RESTRICT fmt, ...)
@@ -642,6 +675,7 @@ eerrorn(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("errorn");
 	return retval;
 }
+hidden_def(eerrorn)
 
 int
 einfo(const char *EINFO_RESTRICT fmt, ...)
@@ -658,6 +692,7 @@ einfo(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("einfo");
 	return retval;
 }
+hidden_def(einfo)
 
 int
 ewarn(const char *EINFO_RESTRICT fmt, ...)
@@ -675,6 +710,7 @@ ewarn(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("ewarn");
 	return retval;
 }
+hidden_def(ewarn)
 
 void
 ewarnx(const char *EINFO_RESTRICT fmt, ...)
@@ -691,6 +727,7 @@ ewarnx(const char *EINFO_RESTRICT fmt, ...)
 	}
 	exit(EXIT_FAILURE);
 }
+hidden_def(ewarnx)
 
 int
 eerror(const char *EINFO_RESTRICT fmt, ...)
@@ -708,6 +745,7 @@ eerror(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("eerror");
 	return retval;
 }
+hidden_def(eerror)
 
 void
 eerrorx(const char *EINFO_RESTRICT fmt, ...)
@@ -723,6 +761,7 @@ eerrorx(const char *EINFO_RESTRICT fmt, ...)
 	}
 	exit(EXIT_FAILURE);
 }
+hidden_def(eerrorx)
 
 int
 ebegin(const char *EINFO_RESTRICT fmt, ...)
@@ -741,6 +780,7 @@ ebegin(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("ebegin");
 	return retval;
 }
+hidden_def(ebegin)
 
 static void
 _eend(FILE * EINFO_RESTRICT fp, int col, ECOLOR color, const char *msg)
@@ -814,6 +854,7 @@ eend(int retval, const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("eend");
 	return retval;
 }
+hidden_def(eend)
 
 int
 ewend(int retval, const char *EINFO_RESTRICT fmt, ...)
@@ -828,12 +869,14 @@ ewend(int retval, const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("ewend");
 	return retval;
 }
+hidden_def(ewend)
 
 void
 ebracket(int col, ECOLOR color, const char *msg)
 {
 	_eend(stdout, col, color, msg);
 }
+hidden_def(ebracket)
 
 void
 eindent(void)
@@ -855,6 +898,7 @@ eindent(void)
 	setenv("EINFO_INDENT", num, 1);
 	free(num);
 }
+hidden_def(eindent)
 
 void eoutdent(void)
 {
@@ -880,6 +924,7 @@ void eoutdent(void)
 	}
 	errno = serrno;
 }
+hidden_def(eoutdent)
 
 int
 einfovn(const char *EINFO_RESTRICT fmt, ...)
@@ -895,6 +940,7 @@ einfovn(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("einfovn");
 	return retval;
 }
+hidden_def(einfovn)
 
 int
 ewarnvn(const char *EINFO_RESTRICT fmt, ...)
@@ -910,6 +956,7 @@ ewarnvn(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("ewarnvn");
 	return retval;
 }
+hidden_def(ewarnvn)
 
 int
 einfov(const char *EINFO_RESTRICT fmt, ...)
@@ -926,6 +973,7 @@ einfov(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("einfov");
 	return retval;
 }
+hidden_def(einfov)
 
 int
 ewarnv(const char *EINFO_RESTRICT fmt, ...)
@@ -942,6 +990,7 @@ ewarnv(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("ewarnv");
 	return retval;
 }
+hidden_def(ewarnv)
 
 int
 ebeginv(const char *EINFO_RESTRICT fmt, ...)
@@ -961,6 +1010,7 @@ ebeginv(const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("ebeginv");
 	return retval;
 }
+hidden_def(ebeginv)
 
 int
 eendv(int retval, const char *EINFO_RESTRICT fmt, ...)
@@ -975,6 +1025,7 @@ eendv(int retval, const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("eendv");
 	return retval;
 }
+hidden_def(eendv)
 
 int
 ewendv(int retval, const char *EINFO_RESTRICT fmt, ...)
@@ -989,6 +1040,7 @@ ewendv(int retval, const char *EINFO_RESTRICT fmt, ...)
 	LASTCMD("ewendv");
 	return retval;
 }
+hidden_def(ewendv)
 
 void
 eindentv(void)
@@ -996,6 +1048,7 @@ eindentv(void)
 	if (is_verbose())
 		eindent();
 }
+hidden_def(eindentv)
 
 void
 eoutdentv(void)
@@ -1003,3 +1056,4 @@ eoutdentv(void)
 	if (is_verbose())
 		eoutdent();
 }
+hidden_def(eoutdentv)

src/libeinfo/meson.build

@@ -1,12 +0,0 @@
-libeinfo_version = '1'
-
-libeinfo = library('einfo', ['libeinfo.c'],
-  c_args : termcap_flags,
-  include_directories : incdir,
-  dependencies : termcap_dep,
-  link_depends : 'einfo.map',
-  version : libeinfo_version,
-  install : true,
-  install_dir : libdir)
-
-install_headers('einfo.h')

src/librc/librc-daemon.c

@@ -15,8 +15,6 @@
  *    except according to the terms contained in the LICENSE file.
  */
 
-#include <signal.h>
-
 #include "queue.h"
 #include "librc.h"
 
@@ -162,7 +160,7 @@ rc_find_pids(const char *exec, const char *const *argv, uid_t uid, pid_t pid)
 				proc_ns[0] = '\0';
 		}
 		free(buffer);
-		if (pid == 0 && strlen(my_ns) && strlen (proc_ns) && strcmp(my_ns, proc_ns))
+		if (strlen(my_ns) && strlen (proc_ns) && strcmp(my_ns, proc_ns))
 			continue;
 		if (uid) {
 			xasprintf(&buffer, "/proc/%d", p);
@@ -210,6 +208,7 @@ rc_find_pids(const char *exec, const char *const *argv, uid_t uid, pid_t pid)
 	closedir(procdir);
 	return pids;
 }
+librc_hidden_def(rc_find_pids)
 
 #elif BSD
 
@@ -314,6 +313,7 @@ rc_find_pids(const char *exec, const char *const *argv, uid_t uid, pid_t pid)
 
 	return pids;
 }
+librc_hidden_def(rc_find_pids)
 
 #else
 #  error "Platform not supported!"
@@ -455,6 +455,7 @@ rc_service_daemon_set(const char *service, const char *exec,
 	free(dirpath);
 	return retval;
 }
+librc_hidden_def(rc_service_daemon_set)
 
 bool
 rc_service_started_daemon(const char *service,
@@ -494,6 +495,7 @@ rc_service_started_daemon(const char *service,
 	free(dirpath);
 	return retval;
 }
+librc_hidden_def(rc_service_started_daemon)
 
 bool
 rc_service_daemons_crashed(const char *service)
@@ -613,7 +615,7 @@ rc_service_daemons_crashed(const char *service)
 				i = 0;
 				TAILQ_FOREACH(s, list, entries)
 				    argv[i++] = s->value;
-				argv[i] = NULL;
+				argv[i] = '\0';
 			}
 		}
 
@@ -651,3 +653,4 @@ rc_service_daemons_crashed(const char *service)
 
 	return retval;
 }
+librc_hidden_def(rc_service_daemons_crashed)

src/librc/librc-depend.c

@@ -78,6 +78,7 @@ rc_deptree_free(RC_DEPTREE *deptree)
 	}
 	free(deptree);
 }
+librc_hidden_def(rc_deptree_free)
 
 static RC_DEPINFO *
 get_depinfo(const RC_DEPTREE *deptree, const char *service)
@@ -108,6 +109,7 @@ RC_DEPTREE *
 rc_deptree_load(void) {
 	return rc_deptree_load_file(RC_DEPTREE_CACHE);
 }
+librc_hidden_def(rc_deptree_load)
 
 RC_DEPTREE *
 rc_deptree_load_file(const char *deptree_file)
@@ -171,6 +173,7 @@ rc_deptree_load_file(const char *deptree_file)
 
 	return deptree;
 }
+librc_hidden_def(rc_deptree_load_file)
 
 static bool
 valid_service(const char *runlevel, const char *service, const char *type)
@@ -456,6 +459,7 @@ rc_deptree_depend(const RC_DEPTREE *deptree,
 		rc_stringlist_add(svcs, svc->value);
 	return svcs;
 }
+librc_hidden_def(rc_deptree_depend)
 
 RC_STRINGLIST *
 rc_deptree_depends(const RC_DEPTREE *deptree,
@@ -483,6 +487,7 @@ rc_deptree_depends(const RC_DEPTREE *deptree,
 	rc_stringlist_free(visited);
 	return sorted;
 }
+librc_hidden_def(rc_deptree_depends)
 
 RC_STRINGLIST *
 rc_deptree_order(const RC_DEPTREE *deptree, const char *runlevel, int options)
@@ -538,6 +543,7 @@ rc_deptree_order(const RC_DEPTREE *deptree, const char *runlevel, int options)
 	rc_stringlist_free(types);
 	return services;
 }
+librc_hidden_def(rc_deptree_order)
 
 
 /* Given a time, recurse the target path to find out if there are
@@ -627,6 +633,7 @@ rc_newer_than(const char *source, const char *target,
 
 	return mtime_check(source, target, true, newest, file);
 }
+librc_hidden_def(rc_newer_than)
 
 bool
 rc_older_than(const char *source, const char *target,
@@ -634,6 +641,7 @@ rc_older_than(const char *source, const char *target,
 {
 	return mtime_check(source, target, false, oldest, file);
 }
+librc_hidden_def(rc_older_than)
 
 typedef struct deppair
 {
@@ -729,6 +737,7 @@ rc_deptree_update_needed(time_t *newest, char *file)
 
 	return newer;
 }
+librc_hidden_def(rc_deptree_update_needed)
 
 /* This is a 7 phase operation
    Phase 1 is a shell script which loads each init script and config in turn
@@ -1075,3 +1084,4 @@ rc_deptree_update(void)
 	rc_deptree_free(deptree);
 	return retval;
 }
+librc_hidden_def(rc_deptree_update)

src/librc/librc-misc.c

@@ -16,7 +16,6 @@
  */
 
 #include <fnmatch.h>
-#include <stdio.h>
 
 #include "queue.h"
 #include "librc.h"
@@ -44,6 +43,7 @@ rc_yesno(const char *value)
 
 	return false;
 }
+librc_hidden_def(rc_yesno)
 
 
 /**
@@ -91,6 +91,7 @@ rc_getfile(const char *file, char **buffer, size_t *len)
 	fclose(fp);
 	return ret;
 }
+librc_hidden_def(rc_getfile)
 
 ssize_t
 rc_getline(char **line, size_t *len, FILE *fp)
@@ -115,6 +116,7 @@ rc_getline(char **line, size_t *len, FILE *fp)
 	}
 	return last;
 }
+librc_hidden_def(rc_getline)
 
 char *
 rc_proc_getent(const char *ent _unused)
@@ -161,6 +163,7 @@ rc_proc_getent(const char *ent _unused)
 	return NULL;
 #endif
 }
+librc_hidden_def(rc_proc_getent)
 
 RC_STRINGLIST *
 rc_config_list(const char *file)
@@ -199,6 +202,7 @@ rc_config_list(const char *file)
 
 	return list;
 }
+librc_hidden_def(rc_config_list)
 
 static void rc_config_set_value(RC_STRINGLIST *config, char *value)
 {
@@ -369,6 +373,7 @@ rc_config_load(const char *file)
 
 	return config;
 }
+librc_hidden_def(rc_config_load)
 
 char *
 rc_config_value(RC_STRINGLIST *list, const char *entry)
@@ -387,6 +392,7 @@ rc_config_value(RC_STRINGLIST *list, const char *entry)
 	}
 	return NULL;
 }
+librc_hidden_def(rc_config_value)
 
 /* Global for caching the strings loaded from rc.conf to avoid reparsing for
  * each rc_conf_value call */
@@ -432,3 +438,4 @@ rc_conf_value(const char *setting)
 
 	return rc_config_value(rc_conf, setting);
 }
+librc_hidden_def(rc_conf_value)

src/librc/librc-stringlist.c

@@ -25,6 +25,7 @@ rc_stringlist_new(void)
 	TAILQ_INIT(l);
 	return l;
 }
+librc_hidden_def(rc_stringlist_new)
 
 RC_STRING *
 rc_stringlist_add(RC_STRINGLIST *list, const char *value)
@@ -35,6 +36,7 @@ rc_stringlist_add(RC_STRINGLIST *list, const char *value)
 	TAILQ_INSERT_TAIL(list, s, entries);
 	return s;
 }
+librc_hidden_def(rc_stringlist_add)
 
 RC_STRING *
 rc_stringlist_addu(RC_STRINGLIST *list, const char *value)
@@ -49,6 +51,7 @@ rc_stringlist_addu(RC_STRINGLIST *list, const char *value)
 
 	return rc_stringlist_add(list, value);
 }
+librc_hidden_def(rc_stringlist_addu)
 
 bool
 rc_stringlist_delete(RC_STRINGLIST *list, const char *value)
@@ -66,6 +69,7 @@ rc_stringlist_delete(RC_STRINGLIST *list, const char *value)
 	errno = EEXIST;
 	return false;
 }
+librc_hidden_def(rc_stringlist_delete)
 
 RC_STRING *
 rc_stringlist_find(RC_STRINGLIST *list, const char *value)
@@ -79,6 +83,7 @@ rc_stringlist_find(RC_STRINGLIST *list, const char *value)
 	}
 	return NULL;
 }
+librc_hidden_def(rc_stringlist_find)
 
 RC_STRINGLIST *
 rc_stringlist_split(const char *value, const char *sep)
@@ -93,6 +98,7 @@ rc_stringlist_split(const char *value, const char *sep)
 
 	return list;
 }
+librc_hidden_def(rc_stringlist_split)
 
 void
 rc_stringlist_sort(RC_STRINGLIST **list)
@@ -122,6 +128,7 @@ rc_stringlist_sort(RC_STRINGLIST **list)
 	free(l);
 	*list = new;
 }
+librc_hidden_def(rc_stringlist_sort)
 
 void
 rc_stringlist_free(RC_STRINGLIST *list)
@@ -141,3 +148,4 @@ rc_stringlist_free(RC_STRINGLIST *list)
 	}
 	free(list);
 }
+librc_hidden_def(rc_stringlist_free)

src/librc/librc.c

@@ -15,7 +15,7 @@
  *    except according to the terms contained in the LICENSE file.
  */
 
-static const char librc_copyright[] = "Copyright (c) 2007-2008 Roy Marples";
+const char librc_copyright[] = "Copyright (c) 2007-2008 Roy Marples";
 
 #include "queue.h"
 #include "librc.h"
@@ -351,6 +351,7 @@ rc_sys(void)
 
 	return sys;
 }
+librc_hidden_def(rc_sys)
 
 static const char *
 rc_parse_service_state(RC_SERVICE state)
@@ -425,17 +426,20 @@ rc_runlevel_starting(void)
 {
 	return exists(RC_STARTING);
 }
+librc_hidden_def(rc_runlevel_starting)
 
 bool
 rc_runlevel_stopping(void)
 {
 	return exists(RC_STOPPING);
 }
+librc_hidden_def(rc_runlevel_stopping)
 
 RC_STRINGLIST *rc_runlevel_list(void)
 {
 	return ls_dir(RC_RUNLEVELDIR, LS_DIR);
 }
+librc_hidden_def(rc_runlevel_list)
 
 char *
 rc_runlevel_get(void)
@@ -462,6 +466,7 @@ rc_runlevel_get(void)
 
 	return runlevel;
 }
+librc_hidden_def(rc_runlevel_get)
 
 bool
 rc_runlevel_set(const char *runlevel)
@@ -474,6 +479,7 @@ rc_runlevel_set(const char *runlevel)
 	fclose(fp);
 	return true;
 }
+librc_hidden_def(rc_runlevel_set)
 
 bool
 rc_runlevel_exists(const char *runlevel)
@@ -481,14 +487,14 @@ rc_runlevel_exists(const char *runlevel)
 	char path[PATH_MAX];
 	struct stat buf;
 
-	if (!runlevel || strcmp(runlevel, "") == 0 || strcmp(runlevel, ".") == 0 ||
-		strcmp(runlevel, "..") == 0)
+	if (!runlevel || strcmp(runlevel, ".") == 0 || strcmp(runlevel, "..") == 0)
 		return false;
 	snprintf(path, sizeof(path), "%s/%s", RC_RUNLEVELDIR, runlevel);
 	if (stat(path, &buf) == 0 && S_ISDIR(buf.st_mode))
 		return true;
 	return false;
 }
+librc_hidden_def(rc_runlevel_exists)
 
 bool
 rc_runlevel_stack(const char *dst, const char *src)
@@ -501,6 +507,7 @@ rc_runlevel_stack(const char *dst, const char *src)
 	snprintf(d, sizeof(s), "%s/%s/%s", RC_RUNLEVELDIR, dst, src);
 	return (symlink(s, d) == 0 ? true : false);
 }
+librc_hidden_def(rc_runlevel_stack)
 
 bool
 rc_runlevel_unstack(const char *dst, const char *src)
@@ -510,6 +517,7 @@ rc_runlevel_unstack(const char *dst, const char *src)
 	snprintf(path, sizeof(path), "%s/%s/%s", RC_RUNLEVELDIR, dst, src);
 	return (unlink(path) == 0 ? true : false);
 }
+librc_hidden_def(rc_runlevel_unstack)
 
 RC_STRINGLIST *
 rc_runlevel_stacks(const char *runlevel)
@@ -522,6 +530,7 @@ rc_runlevel_stacks(const char *runlevel)
 	rc_stringlist_free(ancestor_list);
 	return stack;
 }
+librc_hidden_def(rc_runlevel_stacks)
 
 /* Resolve a service name to its full path */
 char *
@@ -575,6 +584,7 @@ rc_service_resolve(const char *service)
 
 	return NULL;
 }
+librc_hidden_def(rc_service_resolve)
 
 bool
 rc_service_exists(const char *service)
@@ -613,6 +623,7 @@ rc_service_exists(const char *service)
 	free(file);
 	return retval;
 }
+librc_hidden_def(rc_service_exists)
 
 #define OPTSTR \
 ". '%s'; echo $extra_commands $extra_started_commands $extra_stopped_commands"
@@ -654,6 +665,7 @@ rc_service_extra_commands(const char *service)
 	free(cmd);
 	return commands;
 }
+librc_hidden_def(rc_service_extra_commands)
 
 #define DESCSTR ". '%s'; echo \"${description%s%s}\""
 char *
@@ -683,6 +695,7 @@ rc_service_description(const char *service, const char *option)
 	free(cmd);
 	return desc;
 }
+librc_hidden_def(rc_service_description)
 
 bool
 rc_service_in_runlevel(const char *service, const char *runlevel)
@@ -693,6 +706,7 @@ rc_service_in_runlevel(const char *service, const char *runlevel)
 	    runlevel, basename_c(service));
 	return exists(file);
 }
+librc_hidden_def(rc_service_in_runlevel)
 
 bool
 rc_service_mark(const char *service, const RC_SERVICE state)
@@ -812,6 +826,7 @@ rc_service_mark(const char *service, const RC_SERVICE state)
 	free(init);
 	return true;
 }
+librc_hidden_def(rc_service_mark)
 
 RC_SERVICE
 rc_service_state(const char *service)
@@ -854,6 +869,7 @@ rc_service_state(const char *service)
 
 	return state;
 }
+librc_hidden_def(rc_service_state)
 
 char *
 rc_service_value_get(const char *service, const char *option)
@@ -868,6 +884,7 @@ rc_service_value_get(const char *service, const char *option)
 
 	return buffer;
 }
+librc_hidden_def(rc_service_value_get)
 
 bool
 rc_service_value_set(const char *service, const char *option,
@@ -892,6 +909,7 @@ rc_service_value_set(const char *service, const char *option,
 	}
 		return true;
 }
+librc_hidden_def(rc_service_value_set)
 
 
 bool
@@ -918,6 +936,7 @@ rc_service_schedule_start(const char *service, const char *service_to_start)
 	free(init);
 	return retval;
 }
+librc_hidden_def(rc_service_schedule_start)
 
 bool
 rc_service_schedule_clear(const char *service)
@@ -930,6 +949,7 @@ rc_service_schedule_clear(const char *service)
 		return true;
 	return false;
 }
+librc_hidden_def(rc_service_schedule_clear)
 
 RC_STRINGLIST *
 rc_services_in_runlevel(const char *runlevel)
@@ -967,6 +987,7 @@ rc_services_in_runlevel(const char *runlevel)
 		list = rc_stringlist_new();
 	return list;
 }
+librc_hidden_def(rc_services_in_runlevel)
 
 RC_STRINGLIST *
 rc_services_in_runlevel_stacked(const char *runlevel)
@@ -983,6 +1004,7 @@ rc_services_in_runlevel_stacked(const char *runlevel)
 	}
 	return list;
 }
+librc_hidden_def(rc_services_in_runlevel_stacked)
 
 RC_STRINGLIST *
 rc_services_in_state(RC_SERVICE state)
@@ -1016,6 +1038,7 @@ rc_services_in_state(RC_SERVICE state)
 	rc_stringlist_free(dirs);
 	return list;
 }
+librc_hidden_def(rc_services_in_state)
 
 bool
 rc_service_add(const char *runlevel, const char *service)
@@ -1061,6 +1084,7 @@ rc_service_add(const char *runlevel, const char *service)
 	free(init);
 	return retval;
 }
+librc_hidden_def(rc_service_add)
 
 bool
 rc_service_delete(const char *runlevel, const char *service)
@@ -1073,6 +1097,7 @@ rc_service_delete(const char *runlevel, const char *service)
 		return true;
 	return false;
 }
+librc_hidden_def(rc_service_delete)
 
 RC_STRINGLIST *
 rc_services_scheduled_by(const char *service)
@@ -1091,6 +1116,7 @@ rc_services_scheduled_by(const char *service)
 	rc_stringlist_free(dirs);
 	return list;
 }
+librc_hidden_def(rc_services_scheduled_by)
 
 RC_STRINGLIST *
 rc_services_scheduled(const char *service)
@@ -1101,3 +1127,4 @@ rc_services_scheduled(const char *service)
 	    basename_c(service));
 	return ls_dir(dir, LS_INITD);
 }
+librc_hidden_def(rc_services_scheduled)

src/librc/librc.h

@@ -56,4 +56,67 @@
 #include "rc.h"
 #include "rc-misc.h"
 
+#include "hidden-visibility.h"
+#define librc_hidden_proto(x) hidden_proto(x)
+#define librc_hidden_def(x) hidden_def(x)
+
+librc_hidden_proto(rc_conf_value)
+librc_hidden_proto(rc_config_list)
+librc_hidden_proto(rc_config_load)
+librc_hidden_proto(rc_config_value)
+librc_hidden_proto(rc_deptree_depend)
+librc_hidden_proto(rc_deptree_depends)
+librc_hidden_proto(rc_deptree_free)
+librc_hidden_proto(rc_deptree_load)
+librc_hidden_proto(rc_deptree_load_file)
+librc_hidden_proto(rc_deptree_order)
+librc_hidden_proto(rc_deptree_update)
+librc_hidden_proto(rc_deptree_update_needed)
+librc_hidden_proto(rc_find_pids)
+librc_hidden_proto(rc_getfile)
+librc_hidden_proto(rc_getline)
+librc_hidden_proto(rc_newer_than)
+librc_hidden_proto(rc_proc_getent)
+librc_hidden_proto(rc_older_than)
+librc_hidden_proto(rc_runlevel_exists)
+librc_hidden_proto(rc_runlevel_get)
+librc_hidden_proto(rc_runlevel_list)
+librc_hidden_proto(rc_runlevel_set)
+librc_hidden_proto(rc_runlevel_stack)
+librc_hidden_proto(rc_runlevel_stacks)
+librc_hidden_proto(rc_runlevel_starting)
+librc_hidden_proto(rc_runlevel_stopping)
+librc_hidden_proto(rc_runlevel_unstack)
+librc_hidden_proto(rc_service_add)
+librc_hidden_proto(rc_service_daemons_crashed)
+librc_hidden_proto(rc_service_daemon_set)
+librc_hidden_proto(rc_service_delete)
+librc_hidden_proto(rc_service_description)
+librc_hidden_proto(rc_service_exists)
+librc_hidden_proto(rc_service_extra_commands)
+librc_hidden_proto(rc_service_in_runlevel)
+librc_hidden_proto(rc_service_mark)
+librc_hidden_proto(rc_service_resolve)
+librc_hidden_proto(rc_service_schedule_clear)
+librc_hidden_proto(rc_service_schedule_start)
+librc_hidden_proto(rc_services_in_runlevel)
+librc_hidden_proto(rc_services_in_runlevel_stacked)
+librc_hidden_proto(rc_services_in_state)
+librc_hidden_proto(rc_services_scheduled)
+librc_hidden_proto(rc_services_scheduled_by)
+librc_hidden_proto(rc_service_started_daemon)
+librc_hidden_proto(rc_service_state)
+librc_hidden_proto(rc_service_value_get)
+librc_hidden_proto(rc_service_value_set)
+librc_hidden_proto(rc_stringlist_add)
+librc_hidden_proto(rc_stringlist_addu)
+librc_hidden_proto(rc_stringlist_delete)
+librc_hidden_proto(rc_stringlist_find)
+librc_hidden_proto(rc_stringlist_free)
+librc_hidden_proto(rc_stringlist_new)
+librc_hidden_proto(rc_stringlist_split)
+librc_hidden_proto(rc_stringlist_sort)
+librc_hidden_proto(rc_sys)
+librc_hidden_proto(rc_yesno)
+
 #endif

src/librc/meson.build

@@ -1,33 +0,0 @@
-rc_h_conf_data = configuration_data()
-if rootprefix == '/'
-  rc_h_conf_data.set('PREFIX', '')
-  else
-  rc_h_conf_data.set('PREFIX', rootprefix)
-	endif
-rc_h_conf_data.set('LIB', libname)
-rc_h_conf_data.set('LIBEXECDIR', rc_libexecdir)
-rc_h_conf_data.set('LOCAL_PREFIX', local_prefix)
-rc_h_conf_data.set('PKG_PREFIX', pkg_prefix)
-rc_h_conf_data.set('SYSCONFDIR', get_option('sysconfdir'))
-
-librc_version = '1'
-
-librc_sources = [
-  'librc.c',
-  'librc-daemon.c',
-  'librc-depend.c',
-  'librc-misc.c',
-  'librc-stringlist.c',
-  ]
-
-rc_h = configure_file(input : 'rc.h.in', output : 'rc.h',
-  configuration : rc_h_conf_data)
-
-librc = library('rc', librc_sources,
-  include_directories : [incdir, einfo_incdir],
-  link_depends : 'rc.map',
-  version : librc_version,
-  install : true,
-  install_dir : libdir)
-
-install_headers(rc_h)

src/meson.build

@@ -1,4 +0,0 @@
-subdir('common')
-subdir('libeinfo')
-subdir('librc')
-subdir('rc')

src/rc/Makefile

@@ -14,8 +14,7 @@ SRCS+=		rc-selinux.c
 endif
 
 ifeq (${OS},Linux)
-SRCS+=		kill_all.c openrc-init.c openrc-shutdown.c rc-sysvinit.c broadcast.c \
-			rc-wtmp.c
+SRCS+=		kill_all.c openrc-init.c openrc-shutdown.c broadcast.c rc-wtmp.c
 endif
 
 CLEANFILES=	version.h rc-selinux.o
@@ -113,7 +112,7 @@ veinfo vewarn vebegin veend vewend veindent veoutdent: do_e.o rc-misc.o
 fstabinfo: fstabinfo.o _usage.o rc-misc.o
 	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
 
-openrc-init: openrc-init.o rc-plugin.o rc-wtmp.o
+openrc-init: openrc-init.o rc-wtmp.o
 	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
 
 is_newer_than: is_newer_than.o rc-misc.o
@@ -135,7 +134,7 @@ mountinfo: mountinfo.o _usage.o rc-misc.o
 openrc rc: rc.o rc-logger.o rc-misc.o rc-plugin.o _usage.o
 	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
 
-openrc-shutdown: openrc-shutdown.o rc-misc.o _usage.o broadcast.o rc-wtmp.o rc-sysvinit.o
+openrc-shutdown: openrc-shutdown.o rc-misc.o _usage.o broadcast.o rc-wtmp.o
 	${CC} ${LOCAL_CFLAGS} ${LOCAL_LDFLAGS} ${CFLAGS} ${LDFLAGS} -o $@ $^ ${LDADD}
 
 openrc-run runscript: openrc-run.o _usage.o rc-misc.o rc-plugin.o

src/rc/broadcast.c

@@ -22,7 +22,6 @@
 #include <time.h>
 #include <unistd.h>
 #include <stdio.h>
-#include <utmp.h>
 #include <utmpx.h>
 #include <pwd.h>
 #include <fcntl.h>

src/rc/checkpath.c

@@ -16,7 +16,6 @@
  *    except according to the terms contained in the LICENSE file.
  */
 
-#define _GNU_SOURCE
 #include <sys/types.h>
 #include <sys/stat.h>
 
@@ -24,7 +23,6 @@
 #include <fcntl.h>
 #include <getopt.h>
 #include <grp.h>
-#include <libgen.h>
 #include <pwd.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -46,7 +44,7 @@ typedef enum {
 
 const char *applet = NULL;
 const char *extraopts ="path1 [path2] [...]";
-const char *getoptstring = "dDfFpm:o:sW" getoptstring_COMMON;
+const char *getoptstring = "dDfFpm:o:W" getoptstring_COMMON;
 const struct option longopts[] = {
 	{ "directory",          0, NULL, 'd'},
 	{ "directory-truncate", 0, NULL, 'D'},
@@ -55,7 +53,6 @@ const struct option longopts[] = {
 	{ "pipe",               0, NULL, 'p'},
 	{ "mode",               1, NULL, 'm'},
 	{ "owner",              1, NULL, 'o'},
-	{ "symlinks",           0, NULL, 's'},
 	{ "writable",           0, NULL, 'W'},
 	longopts_COMMON
 };
@@ -67,120 +64,15 @@ const char * const longopts_help[] = {
 	"Create a named pipe (FIFO) if not exists",
 	"Mode to check",
 	"Owner to check (user:group)",
-	"follow symbolic links (irrelivent on linux)",
 	"Check whether the path is writable or not",
 	longopts_help_COMMON
 };
 const char *usagestring = NULL;
 
-static int get_dirfd(char *path, bool symlinks)
-{
-	char *ch;
-	char *item;
-	char *linkpath = NULL;
-	char *path_dupe;
-	char *str;
-	int components = 0;
-	int dirfd;
-	int flags = 0;
-	int new_dirfd;
-	struct stat st;
-	ssize_t linksize;
-
-	if (!path || *path != '/')
-		eerrorx("%s: empty or relative path", applet);
-	dirfd = openat(dirfd, "/", O_RDONLY);
-	if (dirfd == -1)
-		eerrorx("%s: unable to open the root directory: %s",
-				applet, strerror(errno));
-	ch = path;
-	while (*ch) {
-		if (*ch == '/')
-			components++;
-		ch++;
-	}
-	path_dupe = xstrdup(path);
-	item = strtok(path_dupe, "/");
-#ifdef O_PATH
-	flags |= O_PATH;
-#endif
-	if (!symlinks)
-		flags |= O_NOFOLLOW;
-	flags |= O_RDONLY;
-	while (dirfd > 0 && item && components > 1) {
-		str = xstrdup(linkpath ? linkpath : item);
-		new_dirfd = openat(dirfd, str, flags);
-		if (new_dirfd == -1)
-			eerrorx("%s: %s: could not open %s: %s", applet, path, str,
-					strerror(errno));
-		if (fstat(new_dirfd, &st) == -1)
-			eerrorx("%s: %s: unable to stat %s: %s", applet, path, item,
-					strerror(errno));
-		if (S_ISLNK(st.st_mode) ) {
-			if (st.st_uid != 0)
-				eerrorx("%s: %s: symbolic link %s not owned by root",
-						applet, path, str);
-			linksize = st.st_size+1;
-			if (linkpath)
-				free(linkpath);
-			linkpath = xmalloc(linksize);
-			memset(linkpath, 0, linksize);
-			if (readlinkat(new_dirfd, "", linkpath, linksize) != st.st_size)
-				eerrorx("%s: symbolic link destination changed", applet);
-			/*
-			 * now follow the symlink.
-			 */
-			close(new_dirfd);
-		} else {
-			/* now walk down the directory path */
-			close(dirfd);
-			dirfd = new_dirfd;
-			free(linkpath);
-			linkpath = NULL;
-			item = strtok(NULL, "/");
-			components--;
-		}
-	}
-	free(path_dupe);
-	free(linkpath);
-	return dirfd;
-}
-
-static char *clean_path(char *path)
-{
-	char *ch;
-	char *ch2;
-	char *str;
-	str = xmalloc(strlen(path) + 1);
-	ch = path;
-	ch2 = str;
-	while (true) {
-		*ch2 = *ch;
-		ch++;
-		ch2++;
-		if (!*(ch-1))
-			break;
-		while (*(ch - 1) == '/' && *ch == '/')
-			ch++;
-	}
-	/* get rid of trailing / characters */
-	while ((ch = strrchr(str, '/'))) {
-		if (ch == str)
-			break;
-		if (!*(ch+1))
-			*ch = 0;
-		else
-			break;
-	}
-	return str;
-}
-
 static int do_check(char *path, uid_t uid, gid_t gid, mode_t mode,
-	inode_t type, bool trunc, bool chowner, bool symlinks, bool selinux_on)
+	inode_t type, bool trunc, bool chowner, bool selinux_on)
 {
 	struct stat st;
-	char *name = NULL;
-	int dirfd;
 	int fd;
 	int flags;
 	int r;
@@ -201,16 +93,14 @@ static int do_check(char *path, uid_t uid, gid_t gid, mode_t mode,
 #endif
 	if (trunc)
 		flags |= O_TRUNC;
-	xasprintf(&name, "%s", basename_c(path));
-	dirfd = get_dirfd(path, symlinks);
-	readfd = openat(dirfd, name, readflags);
+	readfd = open(path, readflags);
 	if (readfd == -1 || (type == inode_file && trunc)) {
 		if (type == inode_file) {
 			einfo("%s: creating file", path);
 			if (!mode) /* 664 */
 				mode = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH;
 			u = umask(0);
-			fd = openat(dirfd, name, flags, mode);
+			fd = open(path, flags, mode);
 			umask(u);
 			if (fd == -1) {
 				eerror("%s: open: %s", applet, strerror(errno));
@@ -225,14 +115,14 @@ static int do_check(char *path, uid_t uid, gid_t gid, mode_t mode,
 				mode = S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH;
 			u = umask(0);
 			/* We do not recursively create parents */
-			r = mkdirat(dirfd, name, mode);
+			r = mkdir(path, mode);
 			umask(u);
 			if (r == -1 && errno != EEXIST) {
-				eerror("%s: mkdirat: %s", applet,
+				eerror("%s: mkdir: %s", applet,
 				    strerror (errno));
 				return -1;
 			}
-			readfd = openat(dirfd, name, readflags);
+			readfd = open(path, readflags);
 			if (readfd == -1) {
 				eerror("%s: unable to open directory: %s", applet,
 						strerror(errno));
@@ -250,7 +140,7 @@ static int do_check(char *path, uid_t uid, gid_t gid, mode_t mode,
 				    strerror (errno));
 				return -1;
 			}
-			readfd = openat(dirfd, name, readflags);
+			readfd = open(path, readflags);
 			if (readfd == -1) {
 				eerror("%s: unable to open fifo: %s", applet,
 						strerror(errno));
@@ -277,7 +167,7 @@ static int do_check(char *path, uid_t uid, gid_t gid, mode_t mode,
 
 		if (mode && (st.st_mode & 0777) != mode) {
 			if ((type != inode_dir) && (st.st_nlink > 1)) {
-				eerror("%s: chmod: Too many hard links to %s", applet, path);
+				eerror("%s: chmod: %s %s", applet, "Too many hard links to", path);
 				close(readfd);
 				return -1;
 			}
@@ -369,10 +259,8 @@ int main(int argc, char **argv)
 	int retval = EXIT_SUCCESS;
 	bool trunc = false;
 	bool chowner = false;
-	bool symlinks = false;
 	bool writable = false;
 	bool selinux_on = false;
-	char *path = NULL;
 
 	applet = basename_c(argv[0]);
 	while ((opt = getopt_long(argc, argv, getoptstring,
@@ -405,11 +293,6 @@ int main(int argc, char **argv)
 				eerrorx("%s: owner `%s' not found",
 				    applet, optarg);
 			break;
-		case 's':
-#ifndef O_PATH
-			symlinks = true;
-#endif
-			break;
 		case 'W':
 			writable = true;
 			break;
@@ -435,14 +318,11 @@ int main(int argc, char **argv)
 		selinux_on = true;
 
 	while (optind < argc) {
-		path = clean_path(argv[optind]);
 		if (writable)
-			exit(!is_writable(path));
-		if (do_check(path, uid, gid, mode, type, trunc, chowner,
-					symlinks, selinux_on))
+			exit(!is_writable(argv[optind]));
+		if (do_check(argv[optind], uid, gid, mode, type, trunc, chowner, selinux_on))
 			retval = EXIT_FAILURE;
 		optind++;
-		free(path);
 	}
 
 	if (selinux_on)

src/rc/do_e.c

@@ -35,9 +35,9 @@
 
 const char *applet = NULL;
 
-static int syslog_decode(char *name, const CODE *codetab)
+static int syslog_decode(char *name, CODE *codetab)
 {
-	const CODE *c;
+	CODE *c;
 
 	if (isdigit((unsigned char)*name))
 		return atoi(name);

src/rc/meson.build

@@ -1,300 +0,0 @@
-rc_misc_c = files([
-  'rc-misc.c',
-  ])
-
-rc_plugin_c = files([
-  'rc-plugin.c',
-  ])
-
-rc_schedules_c = files([
-  'rc-schedules.c',
-  ])
-
-usage_c = files([
-  '_usage.c',
-  ])
-
-if selinux_dep.found()
-  rc_selinux_c = files([
-    'rc-selinux.c',
-    ])
-else
-  rc_selinux_c = []
-endif
-
-rc_wtmp_c = files([
-  'rc-wtmp.c',
-  ])
-
-executable('rc-status',
-  ['rc-status.c', rc_misc_c, usage_c, version_h],
-  c_args : cc_branding_flags,
-  link_with: [libeinfo, librc],
-  dependencies: [util_dep],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: bindir)
-
-executable('openrc',
-  ['rc.c', 'rc-logger.c', rc_misc_c, rc_plugin_c, usage_c,
-    version_h],
-  c_args : cc_branding_flags,
-  link_with: [libeinfo, librc],
-  dependencies: [dl_dep, util_dep],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: sbindir)
-
-executable('openrc-run',
-  ['openrc-run.c', rc_misc_c, rc_plugin_c, usage_c, 
-  rc_selinux_c, version_h],
-  c_args : [cc_audit_flags, cc_branding_flags, cc_pam_flags, cc_selinux_flags],
-  link_with: [libeinfo, librc],
-  dependencies: [audit_dep, dl_dep, pam_dep, pam_misc_dep, selinux_dep, util_dep, crypt_dep],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: sbindir)
-
-executable('rc',
-  ['rc.c', 'rc-logger.c', rc_misc_c, rc_plugin_c, usage_c, version_h],
-  c_args : cc_branding_flags,
-  link_with: [libeinfo, librc],
-  dependencies: [dl_dep, util_dep],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: sbindir)
-
-executable('rc-service',
-  ['rc-service.c', rc_misc_c, usage_c, version_h],
-  c_args : cc_branding_flags,
-  link_with: [libeinfo, librc],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: sbindir)
-
-executable('rc-update',
-  ['rc-update.c', rc_misc_c, usage_c, version_h],
-  c_args : cc_branding_flags,
-  link_with: [libeinfo, librc],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: sbindir)
-
-executable('runscript',
-  ['openrc-run.c', rc_misc_c, usage_c, 'rc-plugin.c',
-    rc_selinux_c, version_h],
-  c_args : [cc_audit_flags, cc_branding_flags, cc_pam_flags, cc_selinux_flags],
-  link_with: [libeinfo, librc],
-  dependencies: [audit_dep, dl_dep, pam_dep, pam_misc_dep, util_dep, selinux_dep, crypt_dep],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: sbindir)
-
-executable('start-stop-daemon',
-  ['start-stop-daemon.c', 'rc-pipes.c', rc_misc_c, rc_schedules_c,
-	rc_selinux_c, usage_c, version_h],
-  c_args : [cc_audit_flags, cc_branding_flags, cc_pam_flags, cc_selinux_flags],
-  link_with: [libeinfo, librc],
-  dependencies: [audit_dep, dl_dep, pam_dep, pam_misc_dep, util_dep, selinux_dep, crypt_dep],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: sbindir)
-
-executable('supervise-daemon',
-  ['supervise-daemon.c', rc_misc_c, rc_plugin_c, rc_schedules_c,
-    usage_c, version_h],
-  c_args : [cc_branding_flags, cc_pam_flags, cc_selinux_flags],
-  link_with: [libeinfo, librc],
-  dependencies: [dl_dep, pam_dep, util_dep, selinux_dep],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  install: true,
-  install_dir: sbindir)
-
-if os == 'Linux'
-  executable('openrc-init',
-    ['openrc-init.c', rc_plugin_c, rc_wtmp_c, version_h],
-  c_args : cc_selinux_flags,
-    include_directories: [incdir, einfo_incdir, rc_incdir],
-    link_with: [libeinfo, librc],
-    dependencies: [dl_dep, selinux_dep],
-    install: true,
-    install_dir: sbindir)
-
-  executable('openrc-shutdown',
-    ['openrc-shutdown.c', 'broadcast.c', 'rc-sysvinit.c', rc_misc_c,
-		usage_c, rc_wtmp_c, version_h],
-    c_args : cc_branding_flags,
-    include_directories: [incdir, einfo_incdir, rc_incdir],
-    link_with: [libeinfo, librc],
-    install: true,
-    install_dir: sbindir)
-endif
-
-einfo_execs = [
-  'einfon',
-  'einfo',
-  'ewarnn',
-  'ewarn',
-  'eerrorn',
-  'eerror',
-  'ebegin',
-  'eend',
-  'ewend',
-  'eindent',
-  'eoutdent',
-  'esyslog',
-  'eval_ecolors',
-  'ewaitfile',
-  'veinfo',
-  'vewarn',
-  'vebegin',
-  'veend',
-  'vewend',
-  'veindent',
-  'veoutdent',
-  ]
-
-foreach exec: einfo_execs
-  executable(exec,
-    ['do_e.c', rc_misc_c, version_h],
-    include_directories: [incdir, einfo_incdir, rc_incdir],
-    link_with: [libeinfo, librc],
-    install: true,
-    install_dir: rc_bindir)
-endforeach
-
-executable('checkpath',
-  ['checkpath.c', rc_misc_c, usage_c, rc_selinux_c,
-    version_h],
-  c_args : [cc_audit_flags, cc_branding_flags, cc_pam_flags, cc_selinux_flags],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  link_with: [libeinfo, librc],
-  dependencies: [audit_dep, pam_dep, pam_misc_dep, selinux_dep, crypt_dep],
-  install: true,
-  install_dir: rc_bindir)
-
-executable('fstabinfo',
-  ['fstabinfo.c', rc_misc_c, usage_c, version_h],
-  c_args : cc_branding_flags,
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  link_with: [libeinfo, librc],
-  install: true,
-  install_dir: rc_bindir)
-
-executable('mountinfo',
-  ['mountinfo.c', rc_misc_c, usage_c, version_h],
-  c_args : cc_branding_flags,
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  link_with: [libeinfo, librc],
-  install: true,
-  install_dir: rc_bindir)
-
-executable('rc-depend',
-  ['rc-depend.c', rc_misc_c, usage_c, version_h],
-  c_args : cc_branding_flags,
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  link_with: [libeinfo, librc],
-  install: true,
-  install_dir: rc_bindir)
-
-executable('is_newer_than',
-  ['is_newer_than.c', rc_misc_c, version_h],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  link_with: [libeinfo, librc],
-  install: true,
-  install_dir: rc_bindir)
-
-executable('is_older_than',
-  ['is_older_than.c', rc_misc_c, version_h],
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  link_with: [libeinfo, librc],
-  install: true,
-  install_dir: rc_bindir)
-
-service_execs = [
-  'service_starting',
-  'service_started',
-  'service_stopping',
-  'service_stopped',
-  'service_inactive',
-  'service_wasinactive',
-  'service_hotplugged',
-  'service_started_daemon',
-  'service_crashed',
-  ]
-
-foreach exec : service_execs
-  executable(exec,
-    ['do_service.c', rc_misc_c, version_h],
-    include_directories: [incdir, einfo_incdir, rc_incdir],
-    link_with: [libeinfo, librc],
-    install: true,
-    install_dir: rc_bindir)
-endforeach
-
-value_execs = [
-  'service_get_value',
-  'service_set_value',
-  'get_options',
-  'save_options',
-  ]
-
-foreach exec : value_execs
-  executable(exec,
-    ['do_value.c', rc_misc_c, version_h],
-    include_directories: [incdir, einfo_incdir, rc_incdir],
-    link_with: [libeinfo, librc],
-    install: true,
-    install_dir: rc_bindir)
-endforeach
-
-if os == 'Linux'
-  executable('kill_all',
-	  ['kill_all.c', usage_c, version_h],
-    c_args : cc_branding_flags,
-    include_directories: [incdir, einfo_incdir, rc_incdir],
-    link_with: [libeinfo,librc],
-    install: true,
-    install_dir: rc_bindir)
-  endif
-
-executable('shell_var',
-  ['shell_var.c'],
-  install: true,
-  install_dir: rc_bindir)
-
-mark_service_execs =	[
-  'mark_service_starting',
-  'mark_service_started',
-  'mark_service_stopping',
-  'mark_service_stopped',
-  'mark_service_inactive',
-  'mark_service_wasinactive',
-  'mark_service_hotplugged',
-  'mark_service_failed',
-  'mark_service_crashed',
-  ]
-
-foreach exec : mark_service_execs
-  executable(exec,
-    ['do_mark_service.c', rc_misc_c, version_h],
-    include_directories: [incdir, einfo_incdir, rc_incdir],
-    link_with: [libeinfo,librc],
-    install: true,
-    install_dir: rc_sbindir)
-endforeach
-
-executable('rc-abort',
-  'rc-abort.c',
-  include_directories: [einfo_incdir],
-  link_with: [libeinfo],
-  install: true,
-  install_dir: rc_sbindir)
-
-executable('swclock',
-  ['swclock.c', rc_misc_c, usage_c, version_h],
-  c_args : cc_branding_flags,
-  include_directories: [incdir, einfo_incdir, rc_incdir],
-  link_with: [libeinfo,librc],
-  install: true,
-  install_dir: rc_sbindir)

src/rc/openrc-init.c

@@ -19,7 +19,6 @@
  */
 
 #include <errno.h>
-#include <pwd.h>
 #include <signal.h>
 #include <stdbool.h>
 #include <stdio.h>
@@ -38,7 +37,6 @@
 
 #include "helpers.h"
 #include "rc.h"
-#include "rc-plugin.h"
 #include "rc-wtmp.h"
 #include "version.h"
 
@@ -120,65 +118,6 @@ static void handle_shutdown(const char *runlevel, int cmd)
 	reboot(cmd);
 }
 
-static void run_program(const char *prog)
-{
-	sigset_t full;
-	sigset_t old;
-	pid_t pid;
-
-	/* We need to block signals until we have forked */
-	sigfillset(&full);
-	sigprocmask(SIG_SETMASK, &full, &old);
-	pid = fork();
-	if (pid == -1) {
-		perror("init");
-		return;
-	}
-	if (pid == 0) {
-		/* Unmask signals */
-		sigprocmask(SIG_SETMASK, &old, NULL);
-		execl(prog, prog, (char *)NULL);
-		perror("init");
-		exit(1);
-	}
-	/* Unmask signals and wait for child */
-	sigprocmask(SIG_SETMASK, &old, NULL);
-	if (rc_waitpid(pid) == -1)
-		perror("init");
-}
-
-static void open_shell(void)
-{
-	const char *shell;
-	struct passwd *pw;
-
-#ifdef __linux__
-	const char *sys = rc_sys();
-
-	/* VSERVER systems cannot really drop to shells */
-	if (sys && strcmp(sys, RC_SYS_VSERVER) == 0)
-	{
-		execlp("halt", "halt", "-f", (char *) NULL);
-		perror("init");
-		return;
-	}
-#endif
-
-	shell = rc_conf_value("rc_shell");
-	/* No shell set, so obey env, then passwd, then default to /bin/sh */
-	if (!shell) {
-		shell = getenv("SHELL");
-		if (!shell) {
-			pw = getpwuid(getuid());
-			if (pw)
-				shell = pw->pw_shell;
-			if (!shell)
-				shell = "/bin/sh";
-		}
-	}
-	run_program(shell);
-}
-
 static void handle_single(void)
 {
 	do_openrc("single");
@@ -207,12 +146,6 @@ static void signal_handler(int sig)
 		case SIGINT:
 			handle_shutdown("reboot", RB_AUTOBOOT);
 			break;
-		case SIGTERM:
-#ifdef SIGPWR
-		case SIGPWR:
-#endif
-			handle_shutdown("shutdown", RB_HALT_SYSTEM);
-			break;
 		case SIGCHLD:
 			reap_zombies();
 			break;
@@ -275,10 +208,6 @@ int main(int argc, char **argv)
 	sigfillset(&signals);
 	sigdelset(&signals, SIGCHLD);
 	sigdelset(&signals, SIGINT);
-	sigdelset(&signals, SIGTERM);
-#ifdef SIGPWR
-	sigdelset(&signals, SIGPWR);
-#endif
 	sigprocmask(SIG_SETMASK, &signals, NULL);
 
 	/* install signal  handler */
@@ -286,10 +215,6 @@ int main(int argc, char **argv)
 	sa.sa_handler = signal_handler;
 	sigaction(SIGCHLD, &sa, NULL);
 	sigaction(SIGINT, &sa, NULL);
-	sigaction(SIGTERM, &sa, NULL);
-#ifdef SIGPWR
-	sigaction(SIGPWR, &sa, NULL);
-#endif
 	reboot(RB_DISABLE_CAD);
 
 	/* set default path */
@@ -323,11 +248,8 @@ int main(int argc, char **argv)
 			handle_shutdown("reboot", RB_AUTOBOOT);
 		else if (strcmp(buf, "reexec") == 0)
 			handle_reexec(argv[0]);
-		else if (strcmp(buf, "single") == 0) {
+		else if (strcmp(buf, "single") == 0)
 			handle_single();
-			open_shell();
-			init(default_runlevel);
-		}
 	}
 	return 0;
 }

src/rc/openrc-shutdown.c

@@ -35,9 +35,8 @@
 #include "rc.h"
 #include "helpers.h"
 #include "rc-misc.h"
-#include "rc-sysvinit.h"
-#include "rc-wtmp.h"
 #include "_usage.h"
+#include "rc-wtmp.h"
 
 const char *applet = NULL;
 const char *extraopts = NULL;
@@ -72,7 +71,7 @@ const char *usagestring = "" \
 						   "Usage: openrc-shutdown -c | --cancel\n" \
 						   "   or: openrc-shutdown -R | --reexec\n" \
 						   "   or: openrc-shutdown -w | --write-only\n" \
-						   "   or: openrc-shutdown -H | --halt time\n" \
+						   "   or: openmrc-shutdown -H | --halt time\n" \
 						   "   or: openrc-shutdown -K | --kexec time\n" \
 						   "   or: openrc-shutdown -p | --poweroff time\n" \
 						   "   or: openrc-shutdown -r | --reboot time\n" \
@@ -329,30 +328,15 @@ int main(int argc, char **argv)
 	syslog(LOG_NOTICE, "The system will %s now", state);
 	unlink(nologin_file);
 	unlink(shutdown_pid);
-	if (do_halt) {
-		if (exists("/run/initctl")) {
-			sysvinit_setenv("INIT_HALT", "HALT");
-			sysvinit_runlevel('0');
-		} else
-			send_cmd("halt");
-	} else if (do_kexec)
+	if (do_halt)
+		send_cmd("halt");
+	else if (do_kexec)
 		send_cmd("kexec");
-	else if (do_poweroff) {
-		if (exists("/run/initctl")) {
-			sysvinit_setenv("INIT_HALT", "POWEROFF");
-			sysvinit_runlevel('0');
-		} else
-			send_cmd("poweroff");
-	} else if (do_reboot) {
-		if (exists("/run/initctl"))
-			sysvinit_runlevel('6');
-		else
-			send_cmd("reboot");
-	} else if (do_single) {
-		if (exists("/run/initctl"))
-			sysvinit_runlevel('S');
-		else
-			send_cmd("single");
-	}
+	else if (do_poweroff)
+		send_cmd("poweroff");
+	else if (do_reboot)
+		send_cmd("reboot");
+	else if (do_single)
+		send_cmd("single");
 	return 0;
 }

src/rc/rc-logger.h

@@ -13,8 +13,8 @@
 #ifndef RC_LOGGER_H
 #define RC_LOGGER_H
 
-extern pid_t rc_logger_pid;
-extern int rc_logger_tty;
+pid_t rc_logger_pid;
+int rc_logger_tty;
 extern bool rc_in_logger;
 
 void rc_logger_open(const char *runlevel);

src/rc/rc-selinux.c

@@ -66,7 +66,7 @@ int selinux_util_label(const char *path)
 	int retval = 0;
 	int enforce;
 	struct stat st;
-	char *con;
+	security_context_t con;
 
 	enforce = security_getenforce();
 	if (retval < 0)

src/rc/rc-status.c

@@ -20,7 +20,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
-#include <inttypes.h>
 
 #include "einfo.h"
 #include "queue.h"
@@ -97,12 +96,14 @@ static char *get_uptime(const char *service)
 {
 	RC_SERVICE state = rc_service_state(service);
 	char *start_count;
+	time_t now;
 	char *start_time_string;
 	time_t start_time;
-	int64_t diff_days;
-	int64_t diff_hours;
-	int64_t diff_mins;
-	int64_t diff_secs;
+	time_t time_diff;
+	time_t diff_days = (time_t) 0;
+	time_t diff_hours = (time_t) 0;
+	time_t diff_mins = (time_t) 0;
+	time_t diff_secs = (time_t) 0;
 	char *uptime = NULL;
 
 	if (state & RC_SERVICE_STARTED) {
@@ -110,21 +111,29 @@ static char *get_uptime(const char *service)
 		start_time_string = rc_service_value_get(service, "start_time");
 		if (start_count && start_time_string) {
 			start_time = to_time_t(start_time_string);
-			diff_secs = (int64_t) difftime(time(NULL), start_time);
-			diff_days = diff_secs / 86400;
-			diff_secs = diff_secs % 86400;
-			diff_hours = diff_secs / 3600;
-			diff_secs = diff_secs % 3600;
-			diff_mins = diff_secs / 60;
-			diff_secs = diff_secs % 60;
+			now = time(NULL);
+			time_diff = (time_t) difftime(now, start_time);
+			diff_secs = time_diff;
+			if (diff_secs > (time_t) 86400) {
+				diff_days = diff_secs / (time_t) 86400;
+				diff_secs %= diff_days * (time_t) 86400;
+			}
+			if (diff_secs > (time_t) 3600) {
+				diff_hours = diff_secs / (time_t) 3600;
+				diff_secs %= diff_hours * (time_t) 3600;
+			}
+			if (diff_secs > (time_t) 60) {
+				diff_mins = diff_secs / (time_t) 60;
+				diff_secs %= diff_mins * (time_t) 60;
+			}
 			if (diff_days > 0)
 				xasprintf(&uptime,
-						"%"PRId64" day(s) %02"PRId64":%02"PRId64":%02"PRId64" (%s)",
+						"%ld day(s) %02ld:%02ld:%02ld (%s)",
 						diff_days, diff_hours, diff_mins, diff_secs,
 						start_count);
 			else
 				xasprintf(&uptime,
-						"%02"PRId64":%02"PRId64":%02"PRId64" (%s)",
+						"%02ld:%02ld:%02ld (%s)",
 						diff_hours, diff_mins, diff_secs, start_count);
 		}
 	}
@@ -282,10 +291,9 @@ int main(int argc, char **argv)
 			goto exit;
 			/* NOTREACHED */
 		case 'f':
-			if (strcasecmp(optarg, "ini") == 0) {
+			if (strcasecmp(optarg, "ini") == 0)
 				format = FORMAT_INI;
-				setenv("EINFO_QUIET", "YES", 1);
-			} else
+			else
 				eerrorx("%s: invalid argument to --format switch\n", applet);
 			break;
 		case 'l':

src/rc/rc-sysvinit.c

@@ -1,102 +0,0 @@
-/*
- * rc-sysvinit.c
- * Helper to send a runlevel change to sysvinit
- */
-
-/*
- * Copyright (c) 2019 The OpenRC Authors.
- * See the Authors file at the top-level directory of this distribution and
- * https://github.com/OpenRC/openrc/blob/master/AUTHORS
- *
- * This file is part of OpenRC. It is subject to the license terms in
- * the LICENSE file found in the top-level directory of this
- * distribution and at https://github.com/OpenRC/openrc/blob/master/LICENSE
- * This file may not be copied, modified, propagated, or distributed
- *    except according to the terms contained in the LICENSE file.
- */
-
-#include <errno.h>
-#include <fcntl.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-#include <sys/stat.h>
-#include <sys/types.h>
-
-#include "einfo.h"
-#include "rc-sysvinit.h"
-
-static void sysvinit_send_cmd(struct init_request *request)
-{
-	int fd;
-	char *p;
-	size_t bytes;
-	ssize_t r;
-
-	fd = open("/run/initctl", O_WRONLY|O_NONBLOCK|O_CLOEXEC|O_NOCTTY);
-	if (fd < 0) {
-		if (errno != ENOENT)
-			eerror("Failed to open initctl fifo: %s", strerror(errno));
-		return;
-	}
-	p = (char *) request;
-	bytes = sizeof(*request);
-	do {
-		r = write(fd, p, bytes);
-		if (r < 0) {
-			if ((errno == EAGAIN) || (errno == EINTR))
-				continue;
-			eerror("Failed to write to /run/initctl: %s", strerror(errno));
-			return;
-		}
-		p += r;
-		bytes -= r;
-	} while (bytes > 0);
-}
-
-void sysvinit_runlevel(char rl)
-{
-	struct init_request request;
-
-	if (!rl)
-		return;
-
-	request = (struct init_request) {
-		.magic = INIT_MAGIC,
-		.sleeptime = 0,
-		.cmd = INIT_CMD_RUNLVL,
-		.runlevel = rl,
-	};
-	sysvinit_send_cmd(&request);
-		return;
-}
-
-/*
- *	Set environment variables in the init process.
- */
-void sysvinit_setenv(const char *name, const char *value)
-{
-	struct init_request	request;
-	size_t nl;
-	size_t vl;
-
-	memset(&request, 0, sizeof(request));
-	request.magic = INIT_MAGIC;
-	request.cmd = INIT_CMD_SETENV;
-	nl = strlen(name);
-	if (value)
-		vl = strlen(value);
-else
-		vl = 0;
-
-	if (nl + vl + 3 >= (int)sizeof(request.i.data))
-		return;
-
-	memcpy(request.i.data, name, nl);
-	if (value) {
-		request.i.data[nl] = '=';
-		memcpy(request.i.data + nl + 1, value, vl);
-	}
-	sysvinit_send_cmd(&request);
-	return;
-}

src/rc/rc-sysvinit.h

@@ -1,72 +0,0 @@
-/*
- * rc-sysvinit.h	- Interface to communicate with sysvinit via /run/initctl.
- */
-
-/*
- * Copyright (c) 2019 The OpenRC Authors.
- * See the Authors file at the top-level directory of this distribution and
- * https://github.com/OpenRC/openrc/blob/master/AUTHORS
- *
- * This file is part of OpenRC. It is subject to the license terms in
- * the LICENSE file found in the top-level directory of this
- * distribution and at https://github.com/OpenRC/openrc/blob/master/LICENSE
- * This file may not be copied, modified, propagated, or distributed
- *    except according to the terms contained in the LICENSE file.
- */
-
-#ifndef _RC_SYSVINIT_H
-#define _RC_SYSVINIT_H
-
-/*
- * The #defines and structures below are taken from initreq.h in
- * sysvinit and must be used by any program wishing to communicate with
- * it.
- */
-
-#define INIT_MAGIC 0x03091969
-#define INIT_CMD_START		0
-#define INIT_CMD_RUNLVL		1
-#define INIT_CMD_POWERFAIL	2
-#define INIT_CMD_POWERFAILNOW	3
-#define INIT_CMD_POWEROK	4
-#define INIT_CMD_BSD		5
-#define INIT_CMD_SETENV		6
-#define INIT_CMD_UNSETENV	7
-
-/*
- *	This is what BSD 4.4 uses when talking to init.
- *	Linux doesn't use this right now.
- */
-struct init_request_bsd {
-	char	gen_id[8];		/* Beats me.. telnetd uses "fe" */
-	char	tty_id[16];		/* Tty name minus /dev/tty      */
-	char	host[64];	/* Hostname                     */
-	char	term_type[16];		/* Terminal type                */
-	int	signal;			/* Signal to send               */
-	int	pid;			/* Process to send to           */
-	char	exec_name[128];	        /* Program to execute           */
-	char	reserved[128];		/* For future expansion.        */
-};
-
-/*
- *	Because of legacy interfaces, "runlevel" and "sleeptime"
- *	aren't in a seperate struct in the union.
- *
- *	The weird sizes are because init expects the whole
- *	struct to be 384 bytes.
- */
-struct init_request {
-	int	magic;			/* Magic number                 */
-	int	cmd;			/* What kind of request         */
-	int	runlevel;		/* Runlevel to change to        */
-	int	sleeptime;		/* Time between TERM and KILL   */
-	union {
-		struct init_request_bsd	bsd;
-		char			data[368];
-	} i;
-};
-
-void sysvinit_runlevel(char rl);
-void sysvinit_setenv(const char *name, const char *value);
-
-#endif

src/rc/rc.c

@@ -20,7 +20,7 @@
  *    except according to the terms contained in the LICENSE file.
  */
 
-static const char rc_copyright[] = "Copyright (c) 2007-2008 Roy Marples";
+const char rc_copyright[] = "Copyright (c) 2007-2008 Roy Marples";
 
 #include <sys/types.h>
 #include <sys/ioctl.h>

src/rc/start-stop-daemon.c

@@ -389,11 +389,10 @@ int main(int argc, char **argv)
 			/* falls through */
 		case 'u':  /* --user <username>|<uid> */
 		{
-			char dummy[2];
 			p = optarg;
 			tmp = strsep(&p, ":");
 			changeuser = xstrdup(tmp);
-			if (sscanf(tmp, "%d%1s", &tid, dummy) != 1)
+			if (sscanf(tmp, "%d", &tid) != 1)
 				pw = getpwnam(tmp);
 			else
 				pw = getpwuid((uid_t)tid);
@@ -414,7 +413,7 @@ int main(int argc, char **argv)
 
 			if (p) {
 				tmp = strsep (&p, ":");
-				if (sscanf(tmp, "%d%1s", &tid, dummy) != 1)
+				if (sscanf(tmp, "%d", &tid) != 1)
 					gr = getgrnam(tmp);
 				else
 					gr = getgrgid((gid_t) tid);
@@ -629,7 +628,7 @@ int main(int argc, char **argv)
 	}
 	if (start && !exists(exec_file)) {
 		eerror("%s: %s does not exist", applet,
-		    exec_file ? exec_file : exec);
+		    *exec_file ? exec_file : exec);
 		free(exec_file);
 		exit(EXIT_FAILURE);
 	}
@@ -670,7 +669,7 @@ int main(int argc, char **argv)
 					nav[len++] = p;
 				for (i = 0; i < opt; i++)
 					nav[i + len] = argv[i];
-				nav[i + len] = NULL;
+				nav[i + len] = '\0';
 			}
 		}
 	}
@@ -864,8 +863,8 @@ int main(int argc, char **argv)
 
 		TAILQ_FOREACH(env, env_list, entries) {
 			if ((strncmp(env->value, "RC_", 3) == 0 &&
-				strncmp(env->value, "RC_SERVICE=", 11) != 0 &&
-				strncmp(env->value, "RC_SVCNAME=", 11) != 0) ||
+				strncmp(env->value, "RC_SERVICE=", 10) != 0 &&
+				strncmp(env->value, "RC_SVCNAME=", 10) != 0) ||
 				strncmp(env->value, "SSD_NICELEVEL=", 14) == 0 ||
 				strncmp(env->value, "SSD_IONICELEVEL=", 16) == 0)
 			{

src/rc/supervise-daemon.c

@@ -1,6 +1,6 @@
 /*
  * supervise-daemon
- * This is a supervisor for daemons.
+ * This is an experimental supervisor for daemons.
  * It will start a deamon and make sure it restarts if it crashes.
  */
 
@@ -148,7 +148,6 @@ static char *fifopath = NULL;
 static int fifo_fd = 0;
 static char *pidfile = NULL;
 static char *svcname = NULL;
-static bool verbose = false;
 
 extern char **environ;
 
@@ -421,10 +420,9 @@ static void child_process(char *exec, char **argv)
 
 	TAILQ_FOREACH(env, env_list, entries) {
 		if ((strncmp(env->value, "RC_", 3) == 0 &&
-			strncmp(env->value, "RC_SERVICE=", 11) != 0 &&
-			strncmp(env->value, "RC_SVCNAME=", 11) != 0) ||
-		    strncmp(env->value, "SSD_NICELEVEL=", 14) == 0 ||
-		    strncmp(env->value, "SSD_IONICELEVEL=", 16) == 0)
+			strncmp(env->value, "RC_SERVICE=", 10) != 0 &&
+			strncmp(env->value, "RC_SVCNAME=", 10) != 0) ||
+		    strncmp(env->value, "SSD_NICELEVEL=", 14) == 0)
 		{
 			p = strchr(env->value, '=');
 			*p = '\0';
@@ -571,8 +569,7 @@ static void supervisor(char *exec, char **argv)
 				buf[count] = 0;
 			if (count == 0)
 				continue;
-			if (verbose)
-				syslog(LOG_DEBUG, "Received %s from fifo", buf);
+			syslog(LOG_DEBUG, "Received %s from fifo", buf);
 			if (strncasecmp(buf, "sig", 3) == 0) {
 				if ((sscanf(buf, "%s %d", cmd, &sig_send) == 2)
 						&& (sig_send >= 0 && sig_send < NSIG)) {
@@ -588,8 +585,7 @@ static void supervisor(char *exec, char **argv)
 		if (do_healthcheck) {
 			do_healthcheck = 0;
 			alarm(0);
-			if (verbose)
-				syslog(LOG_DEBUG, "running health check for %s", svcname);
+			syslog(LOG_DEBUG, "running health check for %s", svcname);
 			health_pid = exec_command("healthcheck");
 			health_status = rc_waitpid(health_pid);
 			if (WIFEXITED(health_status) && WEXITSTATUS(health_status) == 0)
@@ -649,8 +645,6 @@ static void supervisor(char *exec, char **argv)
 			ts.tv_sec = respawn_delay;
 			ts.tv_nsec = 0;
 			nanosleep(&ts, NULL);
-			if (exiting)
-				continue;
 			child_pid = fork();
 			if (child_pid == -1) {
 				syslog(LOG_ERR, "%s: fork: %s", applet, strerror(errno));
@@ -734,17 +728,6 @@ int main(int argc, char **argv)
 		if (sscanf(tmp, "%d", &nicelevel) != 1)
 			eerror("%s: invalid nice level `%s' (SSD_NICELEVEL)",
 			    applet, tmp);
-	if ((tmp = getenv("SSD_IONICELEVEL"))) {
-		int n = sscanf(tmp, "%d:%d", &ionicec, &ioniced);
-		if (n != 1 && n != 2)
-			eerror("%s: invalid ionice level `%s' (SSD_IONICELEVEL)",
-			    applet, tmp);
-		if (ionicec == 0)
-			ioniced = 0;
-		else if (ionicec == 3)
-			ioniced = 7;
-		ionicec <<= 13; /* class shift */
-	}
 
 	/* Get our user name and initial dir */
 	p = getenv("USER");
@@ -852,7 +835,7 @@ int main(int argc, char **argv)
 
 		case 'm':  /* --respawn-max count */
 			n = sscanf(optarg, "%d", &respawn_max);
-			if (n	!= 1 || respawn_max < 0)
+			if (n	!= 1 || respawn_max < 1)
 				eerrorx("Invalid respawn-max value '%s'", optarg);
 			break;
 
@@ -869,11 +852,10 @@ int main(int argc, char **argv)
 
 		case 'u':  /* --user <username>|<uid> */
 		{
-			char dummy[2];
 			p = optarg;
 			tmp = strsep(&p, ":");
 			changeuser = xstrdup(tmp);
-			if (sscanf(tmp, "%d%1s", &tid, dummy) != 1)
+			if (sscanf(tmp, "%d", &tid) != 1)
 				pw = getpwnam(tmp);
 			else
 				pw = getpwuid((uid_t)tid);
@@ -894,7 +876,7 @@ int main(int argc, char **argv)
 
 			if (p) {
 				tmp = strsep (&p, ":");
-				if (sscanf(tmp, "%d%1s", &tid, dummy) != 1)
+				if (sscanf(tmp, "%d", &tid) != 1)
 					gr = getgrnam(tmp);
 				else
 					gr = getgrgid((gid_t) tid);
@@ -922,7 +904,6 @@ int main(int argc, char **argv)
 		case_RC_COMMON_GETOPT
 		}
 
-	verbose = rc_yesno(getenv ("EINFO_VERBOSE"));
 	endpwent();
 	argc -= optind;
 	argv += optind;
@@ -1002,7 +983,7 @@ int main(int argc, char **argv)
 			}
 			if (!exists(exec_file)) {
 				eerror("%s: %s does not exist", applet,
-				    exec_file ? exec_file : exec);
+				    *exec_file ? exec_file : exec);
 				free(exec_file);
 				exit(EXIT_FAILURE);
 			}

supervise-daemon-guide.md

@@ -92,8 +92,7 @@ respawn_max=x
 ```
 
 This is the maximum number of times to respawn a supervised process
-during the given respawn period.
-The default is 10. 0 means unlimited.
+during the given respawn period. The default is unlimited.
 
 ``` sh
 respawn_period=seconds
@@ -102,10 +101,6 @@ respawn_period=seconds
 This works in conjunction with respawn_max and respawn_delay above to
 decide if a process should not be respawned for some reason.
 
-For example, if respawn period is 10 and respawn_max is 2, the process
-would need to die 3 times within 10 seconds to no longer be respawned.
-Note that respawn_delay will delay all of this, so in the above scenario
-a respawn_delay of greater than 5 will cause infinite respawns.
-
-By default, this is unset and respawn_max applies to the entire lifetime
-of the service.
+For example, if respawn_period is 60, respawn_max is 2 and respawn_delay
+is 3 and a process dies more than 4 times, the process will not be
+respawned and the supervisor will terminate.

support/deptree2dot/meson.build

@@ -1,11 +0,0 @@
-deptree2dot_dir =	support_dir / 'deptree2dot'
-
-deptree2dot_bin =	['deptree2dot']
-deptree2dot_data =	['README.md']
-
-install_data(deptree2dot_bin,
-  install_dir : deptree2dot_dir,
-  install_mode : 'rwxr-xr-x')
-
-install_data(deptree2dot_data,
-  install_dir : deptree2dot_dir)

support/init.d.examples/avahi-dnsconfd.in

@@ -9,7 +9,7 @@
 # This file may not be copied, modified, propagated, or distributed
 # except according to the terms contained in the LICENSE file.
 
-command=/sbin/avahi-dnsconfd
+command=@PKG_PREFIX@/sbin/avahi-dnsconfd
 command_args="$avahi_dnsconfd_args -D"
 pidfile=/var/run/avahi-dnsconfd.pid
 name="Avahi DNS Configuration Daemon"

support/init.d.examples/avahid.in

@@ -9,7 +9,7 @@
 # This file may not be copied, modified, propagated, or distributed
 # except according to the terms contained in the LICENSE file.
 
-command=/sbin/avahi-daemon
+command=@PKG_PREFIX@/sbin/avahi-daemon
 command_args="$avahid_args -D"
 pidfile=/var/run/avahi-daemon/pid
 name="Avahi Service Advertisement Daemon"

support/init.d.examples/dbus.in

@@ -9,7 +9,7 @@
 # This file may not be copied, modified, propagated, or distributed
 # except according to the terms contained in the LICENSE file.
 
-command=/bin/dbus-daemon
+command=@PKG_PREFIX@/bin/dbus-daemon
 pidfile=/var/run/dbus/pid
 command_args="${dbusd_args---system}"
 name="Message Bus Daemon"

support/init.d.examples/dnsmasq.in

@@ -9,7 +9,7 @@
 # This file may not be copied, modified, propagated, or distributed
 # except according to the terms contained in the LICENSE file.
 
-command=/sbin/dnsmasq
+command=@PKG_PREFIX@/sbin/dnsmasq
 command_args=$dnsmasq_args
 pidfile=/var/run/dnsmasq.pid
 required_files=/etc/dnsmasq.conf

support/init.d.examples/hald.in

@@ -9,7 +9,7 @@
 # This file may not be copied, modified, propagated, or distributed
 # except according to the terms contained in the LICENSE file.
 
-command=/sbin/hald
+command=@PKG_PREFIX@/sbin/hald
 pidfile=/var/run/hald/hald.pid
 command_args=$hald_args
 name="Hardware Abstraction Layer Daemon"

support/init.d.examples/meson.build

@@ -1,30 +0,0 @@
-init_d_examples_dir = support_dir / 'init.d.examples'
-
-init_d_examples =  [
-  'avahi-dnsconfd.in',
-  'avahid.in',
-  'dhcpcd.in',
-  'dbus.in',
-  'hald.in',
-  'named.in',
-  'ntpd.in',
-  'openvpn.in',
-  'polkitd.in',
-  'sshd.in',
-  'wpa_supplicant.in',
-  ]
-
-init_d_examples_data = [
-  'README.md',
-  ]
-
-foreach init_d_example: init_d_examples
-  configure_file(input : init_d_example,
-    output : '@BASENAME@',
-    configuration : init_d_conf_data,
-    install_dir : init_d_examples_dir,
-    install_mode : 'rwxr-xr-x')
-endforeach
-
-install_data(init_d_examples_data,
-  install_dir : init_d_examples_dir)

support/init.d.examples/openvpn.in

@@ -12,10 +12,10 @@
 vpn=${RC_SVCNAME#*.}
 name="OpenVPN"
 [ "$vpn" != openvpn ] && name="$name ($vpn)"
-command=/sbin/openvpn
+command=@PKG_PREFIX@/sbin/openvpn
 
 pidfile=/var/run/"$RC_SVCNAME".pid
-: ${openvpn_dir:=/etc/openvpn}
+: ${openvpn_dir:=@PKG_PREFIX@/etc/openvpn}
 : ${openvpn_config:=$openvpn_dir/$vpn.conf}
 command_args="$openvpn_args --daemon --config $openvpn_config"
 command_args="$command_args --writepid $pidfile"

support/init.d.examples/polkitd.in

@@ -9,7 +9,7 @@
 # This file may not be copied, modified, propagated, or distributed
 # except according to the terms contained in the LICENSE file.
 
-command=/sbin/polkitd
+command=@PKG_PREFIX@/sbin/polkitd
 pidfile=/var/run/polkitd/polkitd.pid
 command_args="$polkitd_args"
 name="PolicyKit Daemon"

support/meson.build

@@ -1,7 +0,0 @@
-support_dir = get_option('datadir') / meson.project_name().to_lower()
-support_dir = support_dir / 'support'
-
-subdir('deptree2dot')
-subdir('init.d.examples')
-subdir('openvpn')
-subdir('sysvinit')

support/openvpn/meson.build

@@ -1,10 +0,0 @@
-openvpn_dir = support_dir / 'openvpn'
-
-openvpn_bin =  ['down.sh', 'up.sh']
-openvpn_data =  ['README.md']
-
-install_data(openvpn_bin,
-  install_dir : openvpn_dir,
-  install_mode : 'rwxr-xr-x')
-install_data(openvpn_data,
-  install_dir : openvpn_dir)

support/sysvinit/Makefile

@@ -2,7 +2,7 @@ MK=	../../mk
 include ${MK}/os.mk
 
 DIR=	${DATADIR}/support/sysvinit
-INC=	halt.sh inittab README.md
+INC=	inittab README.md
 
 
 include ${MK}/scripts.mk

support/sysvinit/halt.sh

@@ -1,6 +0,0 @@
-#!/bin/sh
-if [ "$INIT_HALT" = HALT ]; then
-	exec /sbin/halt -dhn
-else
-	exec /sbin/poweroff -dhn
-fi