commitpkg: revert git add package only

Reviewed-on: artix/artools#49
Co-authored-by: artoo <artoo@artixlinux.org>
Co-committed-by: artoo <artoo@artixlinux.org>

Makefile

@@ -1,4 +1,4 @@
-VERSION=0.22
+VERSION=0.23
 
 TOOLS = artools
 PREFIX ?= /usr
@@ -87,6 +87,9 @@ PKG_DATA = \
 	data/pacman/makepkg.conf \
 	data/valid-names.conf
 
+PROTO = \
+	$(wildcard data/proto/*.proto)
+
 PATCHES = \
 	$(wildcard data/patches/*.patch)
 
@@ -160,6 +163,9 @@ install_pkg:
 	install $(DIRMODE) $(DESTDIR)$(DATADIR)/$(TOOLS)/patches
 	install $(FILEMODE) $(PATCHES) $(DESTDIR)$(DATADIR)/$(TOOLS)/patches
 
+	install $(DIRMODE) $(DESTDIR)$(DATADIR)/$(TOOLS)/proto
+	install $(FILEMODE) $(PROTO) $(DESTDIR)$(DATADIR)/$(TOOLS)/proto
+
 install_cpio:
 	+make CPIODIR=$(CPIODIR) DESTDIR=$(DESTDIR) -C initcpio install
 

bin/base/fstabgen.in

@@ -364,23 +364,19 @@ while read -r src target fstype opts fsroot; do
         pass=0
     fi
 
-    if [[ $fsroot != / ]]; then
-        if [[ $fstype = btrfs ]]; then
-            opts+=,subvol=${fsroot#/}
-        else
-            # it's a bind mount
-            src=$(findmnt -funcevo TARGET "$src")$fsroot
-            if [[ $src -ef $target ]]; then
-                # hrmm, this is weird. we're probably looking at a file or directory
-                # that was bound into a chroot from the host machine. Ignore it,
-                # because this won't actually be a valid mount. Worst case, the user
-                # just re-adds it.
-                continue
-            fi
-            fstype=none
-            opts+=,bind
-            pass=0
+    if [[ $fsroot != / && $fstype != btrfs ]]; then
+        # it's a bind mount
+        src=$(findmnt -funcevo TARGET "$src")$fsroot
+        if [[ $src -ef $target ]]; then
+            # hrmm, this is weird. we're probably looking at a file or directory
+            # that was bound into a chroot from the host machine. Ignore it,
+            # because this won't actually be a valid mount. Worst case, the user
+            # just re-adds it.
+            continue
         fi
+        fstype=none
+        opts+=,bind
+        pass=0
     fi
 
     # filesystem quirks

bin/iso/buildiso.in

@@ -86,9 +86,9 @@ make_rootfs() {
 
         basestrap "${basestrap_args[@]}" "${rootfs}" "${packages[@]}"
 
-        copy_overlay "${ROOT_OVERLAY}" "${rootfs}"
+        copy_overlay "${root_overlay}" "${rootfs}"
 
-        [[ -z ${LIVE_LIST} ]] && configure_chroot "${rootfs}"
+        [[ -z ${live_list} ]] && configure_chroot "${rootfs}"
 
         clean_up_chroot "${rootfs}"
 
@@ -109,7 +109,7 @@ make_livefs() {
 
         basestrap "${basestrap_args[@]}" "${livefs}" "${packages[@]}"
 
-        copy_overlay "${LIVE_OVERLAY}" "${livefs}"
+        copy_overlay "${live_overlay}" "${livefs}"
 
         configure_chroot "${livefs}"
 
@@ -154,7 +154,7 @@ make_grub(){
         msg "Prepare [/iso/boot/grub]"
 
         local layer=${work_dir}/rootfs
-        [[ -n ${LIVE_LIST} ]] && layer=${work_dir}/livefs
+        [[ -n ${live_list} ]] && layer=${work_dir}/livefs
 
         prepare_grub "${work_dir}/rootfs" "$layer"
 
@@ -248,10 +248,10 @@ mk_boot(){
 }
 
 mk_chroots(){
-    load_pkgs "${ROOT_LIST}" "${INITSYS}"
+    load_pkgs "${root_list}"
     run_safe "make_rootfs"
-    if [[ -n ${LIVE_LIST} ]]; then
-        load_pkgs "${LIVE_LIST}" "${INITSYS}"
+    if [[ -n ${live_list} ]]; then
+        load_pkgs "${live_list}"
         run_safe "make_livefs"
     fi
 }

bin/pkg/checkrepo.in

@@ -64,7 +64,7 @@ check_db(){
 
         for name in "${pkgname[@]}"; do
             if ! is_db_entry "$name-$artixver" "$repo"; then
-                msg_row_upgrade "${tableU}" "$repo" "$name" "$artixver" "false"
+                msg_row_red "${tableU}" "$repo" "$name" "$artixver" "false"
             else
                 ${all_db} && msg_row "${tableU}" "$repo" "$name" "$artixver" "true"
             fi

bin/pkg/comparepkg.in

@@ -34,11 +34,17 @@ write_list(){
 compare_m(){
     case ${artixrepo} in
         *testing*|*staging*|*rebuild)
-            if [[ "${a}" == "${b}" ]] || [[ "${a}" == 'staging' && "${b}" == 'rebuild' ]]; then
+            if [[ "${a}" == "${b}" ]]; then
                 msg_row "${table}" "${a}" "${b}" "$pkg" "$archver" "$artixver" "${group#*-}"
+            elif [[ "${a}" == 'staging' && "${b}" == 'rebuild' ]]; then
+                msg_row_yellow "${table}" "${a}" "${b}" "$pkg" "$archver" "$artixver" "${group#*-}"
             else
-                msg_row_notify "${table}" "${a}" "${b}" "$pkg" "$archver" "$artixver" "${group#*-}"
-                [[ -n "$archrepo" ]] && write_list "${a}:${b}:$pkg" pkg_moves
+                msg_row_green "${table}" "${a}" "${b}" "$pkg" "$archver" "$artixver" "${group#*-}"
+                if [[ -n "$archrepo" ]]; then
+                    write_list "${a}:${b}:$pkg" pkg_moves
+                else
+                    write_list "@repo@:${b}:$pkg" artix
+                fi
             fi
         ;;
     esac
@@ -46,7 +52,7 @@ compare_m(){
 
 compare_u(){
     if [ "$result" -eq -1 ];then
-        msg_row_upgrade "${table}" "${a}" "${b}" "$pkg" "$archver" "$artixver" "${group#*-}"
+        msg_row_red "${table}" "${a}" "${b}" "$pkg" "$archver" "$artixver" "${group#*-}"
         write_list "${a}:$pkg" pkg_upgrades
     fi
 }
@@ -54,7 +60,7 @@ compare_u(){
 compare_d(){
     if [ "$result" -eq 1 ];then
         if [[ -n "$archver" ]] && [[ -n "$archrepo" ]];then
-            msg_row_downgrade "${table}" "${a}" "${b}" "$pkg" "$archver" "$artixver" "${group#*-}"
+            msg_row_yellow "${table}" "${a}" "${b}" "$pkg" "$archver" "$artixver" "${group#*-}"
         fi
     fi
 }
@@ -140,6 +146,7 @@ show_downgrades_table(){
 show_move_table(){
     show_compare_header
     remove_list pkg_moves
+    remove_list artix
     tree_loop compare_move
 }
 

bin/pkg/deploypkg.in

@@ -92,6 +92,10 @@ passfiles=("$@")
 repo_path=${REPOS_ROOT}/${dest_repo}/os/${CARCH}
 
 if [[ -n "${passfiles[*]}" ]]; then
-    ${add_pkg} && repo_action add
-    ${rm_pkg} && repo_action remove
+    if ${add_pkg}; then
+        repo_action add
+    fi
+    if ${rm_pkg}; then
+        repo_action remove
+    fi
 fi

bin/pkg/mkchrootpkg.in

@@ -247,6 +247,15 @@ download_sources() {
         die "Could not download sources."
 }
 
+move_logfiles() {
+    local l
+    for l in "$copydir"/logdest/*; do
+        [[ $l == */logpipe.* ]] && continue
+        chown "$src_owner" "$l"
+        mv "$l" "$LOGDEST"
+    done
+}
+
 move_products() {
     local pkgfile
     for pkgfile in "$copydir"/pkgdest/*; do
@@ -259,12 +268,7 @@ move_products() {
         fi
     done
 
-    local l
-    for l in "$copydir"/logdest/*; do
-        [[ $l == */logpipe.* ]] && continue
-        chown "$src_owner" "$l"
-        mv "$l" "$LOGDEST"
-    done
+    move_logfiles
 
     for s in "$copydir"/srcpkgdest/*; do
         chown "$src_owner" "$s"
@@ -379,6 +383,7 @@ then
     move_products
 else
     (( ret += 1 ))
+    move_logfiles
 fi
 
 (( temp_chroot )) && delete_chroot "$copydir" "$copy"

data/conf/artools-iso.conf

@@ -8,7 +8,7 @@
 # the dist release; default: auto
 # ISO_VERSION=$(date +%Y%m%d)
 
-# possible values: openrc, runit, s6
+# possible values: openrc, runit, s6, 66
 # INITSYS="openrc"
 
 # gpg key; leave empty or commented to skip img signing

data/conf/artools-pkg.conf

@@ -13,6 +13,7 @@
 #         packages-openrc
 #         packages-runit
 #         packages-s6
+#         packages-66
 #         packages-python
 #         packages-perl
 #         packages-java

data/pacman/makepkg.conf

@@ -15,7 +15,7 @@ DLAGENTS=('file::/usr/bin/curl -gqC - -o %o %u'
           'ftp::/usr/bin/curl -gqfC - --ftp-pasv --retry 3 --retry-delay 3 -o %o %u'
           'http::/usr/bin/curl -gqb "" -fLC - --retry 3 --retry-delay 3 -o %o %u'
           'https::/usr/bin/curl -gqb "" -fLC - --retry 3 --retry-delay 3 -o %o %u'
-          'rsync::/usr/bin/rsync --no-motd -z %u %o'
+          'rsync::/usr/bin/rsync --no-motd -zz %u %o'
           'scp::/usr/bin/scp -C %u %o')
 
 # Other common tools:

data/proto/PKGBUILD.openrc.proto

@@ -0,0 +1,38 @@
+# Maintainer: Your Name <youremail@domain.com>
+
+pkgname=NAME-openrc
+pkgver=VERSION
+pkgrel=1
+epoch=
+pkgdesc="Openrc NAME init script"
+arch=('any')
+url="https://gitea.artixlinux.org/artixlinux/packages-openrc"
+license=('GPL2')
+groups=()
+depends=("openrc" "NAME")
+makedepends=()
+checkdepends=()
+optdepends=()
+provides=("init-NAME")
+conflicts=("init-NAME")
+replaces=()
+backup=()
+options=()
+install=
+changelog=
+source=(NAME.{confd,initd})
+sha256sums=()
+
+_inst_openrc() {
+    local sv="$1"
+    if [ -f "${srcdir}/$sv".confd ]; then
+        install -Dm644 "${srcdir}/$sv".confd "${pkgdir}"/etc/conf.d/"$sv"
+    fi
+    if [ -f "${srcdir}/$sv".initd ]; then
+        install -Dm755 "${srcdir}/$sv".initd "${pkgdir}"/etc/init.d/"$sv"
+    fi
+}
+
+package() {
+    _inst_openrc "NAME"
+}

data/proto/PKGBUILD.runit.proto

@@ -0,0 +1,41 @@
+# Maintainer: Your Name <youremail@domain.com>
+
+pkgname=NAME-runit
+pkgver=VERSION
+pkgrel=1
+epoch=
+pkgdesc="Runit NAME init script"
+arch=('any')
+url="https://gitea.artixlinux.org/artixlinux/packages-runit"
+license=('GPL2')
+groups=()
+depends=("runit" "NAME")
+makedepends=()
+checkdepends=()
+optdepends=()
+provides=("init-NAME")
+conflicts=("init-NAME")
+replaces=()
+backup=()
+options=()
+install=
+changelog=
+source=(NAME.{run,finish,check})
+sha256sums=()
+
+_inst_runit() {
+    local sv="$1"
+    if [ -f "${srcdir}/$sv".conf ]; then
+        install -Dm644 "${srcdir}/$sv".conf "${pkgdir}"/etc/runit/sv/"$sv"/conf
+    fi
+
+    for f in run finish check; do
+        if [ -f "${srcdir}/$sv.$f" ]; then
+            install -Dm755 "${srcdir}/$sv.$f" "${pkgdir}"/etc/runit/sv/"$sv/$f"
+        fi
+    done
+}
+
+package() {
+    _inst_runit "NAME"
+}

data/proto/PKGBUILD.s6.proto

@@ -0,0 +1,39 @@
+# Maintainer: Your Name <youremail@domain.com>
+
+pkgname=NAME-s6
+pkgver=VERSION
+pkgrel=1
+epoch=
+pkgdesc="S6 NAME init script"
+arch=('any')
+url="https://gitea.artixlinux.org/artixlinux/packages-s6"
+license=('GPL2')
+groups=()
+depends=("s6-base" "NAME")
+makedepends=()
+checkdepends=()
+optdepends=()
+provides=("init-NAME")
+conflicts=("init-NAME")
+replaces=()
+backup=()
+options=()
+install=
+changelog=
+source=(NAME.{dependencies,down,up,type})
+sha256sums=()
+
+
+_inst_s6(){
+    local sv="$1"
+    for f in dependencies down type up; do
+        if [ -f "${srcdir}/$sv.$f" ]; then
+            install -Dm644 "${srcdir}/$sv.$f" "${pkgdir}"/etc/s6/sv/"$sv/$f"
+        fi
+    done
+}
+
+package() {
+    _inst_s6 "NAME"
+}
+

data/proto/PKGBUILD.suite66.proto

@@ -0,0 +1,34 @@
+# Maintainer: Your Name <youremail@domain.com>
+
+pkgname=NAME-66
+pkgver=VERSION
+pkgrel=1
+epoch=
+pkgdesc="Suite66 NAME init script"
+arch=('any')
+url="https://gitea.artixlinux.org/artixlinux/packages-66"
+license=('GPL2')
+groups=()
+depends=("suite66-base" "NAME")
+makedepends=()
+checkdepends=()
+optdepends=()
+provides=("init-NAME")
+conflicts=("init-NAME")
+replaces=()
+backup=()
+options=()
+install=
+changelog=
+source=(NAME)
+sha256sums=()
+
+_inst_66() {
+    local sv="$1"
+    install -Dm644 "$sv" -t "${pkgdir}"/etc/66/service
+}
+
+package() {
+    _inst_66 "NAME"
+}
+

lib/iso/calamares.sh

@@ -31,6 +31,11 @@ write_services_s6_conf(){
     write_services_conf 'svDir' '/etc/s6/sv' 'dbDir' '/etc/s6/rc/compiled' > "$conf"
 }
 
+write_services_66_conf(){
+    local conf="$1"/services-66.conf
+    write_services_conf 'svDir' '/etc/66/service' 'runsvDir' '/var/lib/66/system' > "$conf"
+}
+
 write_postcfg(){
     local yaml
     yaml=$(write_yaml_header)
@@ -46,13 +51,10 @@ write_unpackfs() {
     local yaml
     yaml=$(write_yaml_header)
     yaml+=$(write_yaml_map 0 'unpack')
-#     if ${persist}; then
-#         yaml+=$(write_yaml_seq_map 2 'source' '"/run/artix/bootmnt/LiveOS/rootfs.img"')
-#         yaml+=$(write_yaml_map 4 'sourcefs' '"ext4"')
-#     else
+    local fs="squashfs"
+#     ${persist} && fs="ext4"
     yaml+=$(write_yaml_seq_map 2 'source' '"/run/artix/bootmnt/LiveOS/rootfs.img"')
-    yaml+=$(write_yaml_map 4 'sourcefs' '"squashfs"')
-#     fi
+    yaml+=$(write_yaml_map 4 'sourcefs' \'"$fs"\')
     yaml+=$(write_yaml_map 4 'destination' '""')
     yaml+=$(write_empty_line)
     printf '%s' "${yaml}"

lib/iso/profile.sh

@@ -11,13 +11,16 @@ show_profile(){
 
 load_profile(){
     local profile_dir="${DATADIR}/iso-profiles"
-    [[ -d ${WORKSPACE_DIR}/iso-profiles ]] && profile_dir=${WORKSPACE_DIR}/iso-profiles
+    [[ -d "${WORKSPACE_DIR}"/iso-profiles ]] && profile_dir="${WORKSPACE_DIR}"/iso-profiles
 
-    ROOT_LIST="$profile_dir/${profile}/Packages-Root"
-    ROOT_OVERLAY="$profile_dir/${profile}/root-overlay"
+    root_list="$profile_dir/${profile}/Packages-Root"
+    root_overlay="$profile_dir/${profile}/root-overlay"
 
-    [[ -f "$profile_dir/${profile}/Packages-Live" ]] && LIVE_LIST="$profile_dir/${profile}/Packages-Live"
-    [[ -d "$profile_dir/${profile}/live-overlay" ]] && LIVE_OVERLAY="$profile_dir/${profile}/live-overlay"
+    [[ -f "$profile_dir/${profile}/Packages-Live" ]] && live_list="$profile_dir/${profile}/Packages-Live"
+    [[ -d "$profile_dir/${profile}/live-overlay" ]] && live_overlay="$profile_dir/${profile}/live-overlay"
+
+    common_dir="${DATADIR}/iso-profiles/common"
+    [[ -d "$profile_dir"/common ]] && common_dir="${profile_dir}"/common
 
     [[ -f $profile_dir/${profile}/profile.conf ]] || return 1
 
@@ -35,28 +38,48 @@ load_profile(){
     return 0
 }
 
-load_pkgs(){
-    local pkglist="$1" init="$2"
-    msg2 "Loading Packages: [%s] ..." "${pkglist##*/}"
+read_from_list() {
+    local list="$1"
+    local _space="s| ||g"
+    local _clean=':a;N;$!ba;s/\n/ /g'
+    local _com_rm="s|#.*||g"
 
-    local _init="s|@$init||g" _init_rm1 _init_rm2
-    case "$init" in
-        'openrc') _init_rm1="s|@runit.*||g"; _init_rm2="s|@s6.*||g" ;;
-        's6') _init_rm1="s|@runit.*||g"; _init_rm2="s|@openrc.*||g" ;;
-        'runit') _init_rm1="s|@s6.*||g"; _init_rm2="s|@openrc.*||g" ;;
-    esac
+    local _init="s|@initsys@|${INITSYS}|g"
 
-    local _space="s| ||g" \
-        _clean=':a;N;$!ba;s/\n/ /g' \
-        _com_rm="s|#.*||g"
-
-    packages=($(sed "$_com_rm" "$pkglist" \
+    msg2 "Loading Packages: [%s] ..." "${list##*/}"
+    packages+=($(sed "$_com_rm" "$list" \
             | sed "$_space" \
-            | sed "$_purge" \
             | sed "$_init" \
-            | sed "$_init_rm1" \
-            | sed "$_init_rm2" \
             | sed "$_clean"))
 }
 
+read_from_services() {
+    for svc in "${SERVICES[@]}"; do
+        case "$svc" in
+            sddm|gdm|lightdm|mdm|greetd|lxdm|xdm) packages+=("$svc-${INITSYS}") ;;
+            NetworkManager) packages+=("networkmanager-${INITSYS}") ;;
+            connmand) packages+=("connman-${INITSYS}") ;;
+            cupsd) packages+=("cups-${INITSYS}") ;;
+            bluetoothd) packages+=("bluez-${INITSYS}") ;;
+            syslog-ng|metalog) packages+=("$svc-${INITSYS}") ;;
+        esac
+    done
+}
+
+load_pkgs(){
+    local pkglist="$1"
+    packages=()
+
+    if [[ "${pkglist##*/}" == "Packages-Root" ]]; then
+        read_from_list "${common_dir}/Packages-base"
+        read_from_list "${common_dir}/Packages-apps"
+        read_from_list "${common_dir}/Packages-${INITSYS}"
+        [[ -n "${live_list}" ]] && read_from_list "${common_dir}/Packages-xorg"
+        read_from_list "$pkglist"
+        read_from_services
+    else
+        read_from_list "$pkglist"
+    fi
+}
+
 #}}}

lib/iso/services.sh

@@ -24,29 +24,34 @@ add_svc_runit(){
 
 add_svc_s6(){
     local mnt="$1" names="$2" rlvl="${3:-default}" error ret
+    local db=/etc/s6/rc/compiled
     for svc in $names; do
         error=false
-        chroot "$mnt" s6-rc-db -c /etc/s6/rc/compiled type "$svc" &> /dev/null || error=true
+        chroot "$mnt" s6-rc-db -c "$db" type "$svc" &> /dev/null || error=true
         ret="$?"
         if [ $ret -eq 0 ] && [[ "$error" == false ]]; then
             msg2 "Setting %s: [%s]" "${INITSYS}" "$svc"
-            chroot "$mnt" s6-rc-bundle-update -c /etc/s6/rc/compiled add "$rlvl" "$svc"
+            chroot "$mnt" s6-rc-bundle-update -c "$db" add "$rlvl" "$svc"
         fi
     done
 
-    # force artix-live as a dependency if these display managers exist
-#     for displaymanager in gdm lightdm-srv lxdm sddm; do
-#         if [ -f "${work_dir}"/rootfs/etc/s6/sv/$displaymanager/dependencies ]; then
-#             echo "artix-live" >> "${work_dir}"rootfs/etc/s6/sv/$displaymanager/dependencies
-#         fi
-#     done
-#     chroot "$mnt" sh /usr/share/libalpm/scripts/s6-rc-db-update-hook
-
+    local rlvl=/etc/s6/current
     # rebuild s6-linux-init binaries
-    chroot "$mnt" rm -r /etc/s6/current
-    chroot "$mnt" s6-linux-init-maker -1 -N -f /etc/s6/skel -G "/usr/bin/agetty -L -8 tty1 115200" -c /etc/s6/current /etc/s6/current
-    chroot "$mnt" mv /etc/s6/current/bin/init /etc/s6/current/bin/s6-init
-    chroot "$mnt" cp -a /etc/s6/current/bin /usr
+    chroot "$mnt" rm -r "$rlvl"
+    chroot "$mnt" s6-linux-init-maker -1 -N -f /etc/s6/skel -G "/usr/bin/agetty -L -8 tty1 115200" -c "$rlvl" "$rlvl"
+    chroot "$mnt" mv "$rlvl"/bin/init "$rlvl"/bin/s6-init
+    chroot "$mnt" cp -a "$rlvl"/bin /usr
+}
+
+add_svc_66(){
+    local mnt="$1" names="$2"
+    chroot "$mnt" 66-tree -cnE root &>/dev/null
+    for svc in $names; do
+        if [[ -f "$mnt"/etc/66/service/"$svc" ]]; then
+            msg2 "Setting %s: [%s]" "${INITSYS}" "$svc"
+            chroot "$mnt" 66-enable -t root "$svc" &>/dev/null
+        fi
+    done
 }
 
 #}}}

lib/pkg/repo.sh

@@ -41,7 +41,7 @@ find_pkg(){
 tree_loop(){
     local func="$1" pkgs
     for tree in "${ARTIX_TREE[@]}"; do
-        pkgs=$(find "${TREE_DIR_ARTIX}/$tree" -name repos -o -name "$CARCH")
+        pkgs=$(find "${TREE_DIR_ARTIX}/$tree" -name repos -o -name "$CARCH" | sort)
         for _package in ${pkgs}; do
             "$func" "$_package"
         done

lib/pkg/table.sh

@@ -8,13 +8,13 @@ msg_table_header(){
     printf "${BLUE} ${mesg} ${ALL_OFF}\n" "$@" >&2
 }
 
-msg_row_downgrade(){
+msg_row_yellow(){
     local mesg=$1; shift
     # shellcheck disable=2059
     printf "${YELLOW} ${mesg}${ALL_OFF}\n" "$@" >&2
 }
 
-msg_row_notify(){
+msg_row_green(){
     local mesg=$1; shift
     # shellcheck disable=2059
     printf "${GREEN} ${mesg}${ALL_OFF}\n" "$@" >&2
@@ -27,7 +27,7 @@ msg_row(){
     printf "${WHITE} ${mesg}${ALL_OFF}\n" "$@" >&2
 }
 
-msg_row_upgrade(){
+msg_row_red(){
     local mesg=$1; shift
     # shellcheck disable=2059
     printf "${RED} ${mesg} ${ALL_OFF}\n" "$@" >&2

lib/util-pkg.sh

@@ -31,7 +31,7 @@ load_pkg_config(){
         python-{world,galaxy}
     )
 
-    local init_tree=(packages-{openrc,runit,s6})
+    local init_tree=(packages-{openrc,runit,s6,66})
 
     local desktop_tree=(
         packages-{kf5,plasma,kde,qt6}