feat(commitpkg): Change warning to hard error when licensing information is absent

We originally had this as a warning to allow packagers some time for transitioning.
However, now the gloves come off and we will require all packages to have proper licensing
information.

src/commitpkg.in

@@ -123,10 +123,9 @@ fi
 needsversioning=()
 
 if [[ ! -e REUSE.toml || ! -e LICENSE || ! -d LICENSES ]]; then
-	# TODO: Make this a hard failure in the future after packagers have had
-	# some time to add licenses to all packages.
-	warning "package doesn't have proper licensing information, set it up using:"
+	error "package doesn't have proper licensing information, set it up using:"
 	msg2 'pkgctl license setup'
+	exit 1
 else
 	pkgctl license check
 	needsversioning+=(REUSE.toml LICENSE LICENSES/*)

src/lib/util/pkgbuild.sh

@@ -14,11 +14,6 @@ source /usr/share/makepkg/util/schema.sh
 
 set -eo pipefail
 
-# escapes regex metacharacters in a given string
-_escape_pkgver() {
-	# shellcheck disable=SC2001
-	sed 's:[\^.\[$()|*+?{\\]:\\&:g' <<<"$1"
-}
 
 # set the pkgver variable in a PKGBUILD
 # assumes that the pkgbuild is sourced to detect the presence of a pkgver function
@@ -26,8 +21,6 @@ pkgbuild_set_pkgver() {
 	local new_pkgver=$1
 	local pkgver=${pkgver}
 
-	pkgver="$(_escape_pkgver "${pkgver}")"
-
 	if [[ $(type -t pkgver) == function ]]; then
 		# TODO: check if die or warn, if we provide _commit _gitcommit setter maybe?
 		warning 'setting pkgver variable has no effect if the PKGBUILD has a pkgver() function'