libalpm: add new errno for download initialization

The error string "failed to retrieve some files" implies that the download may have begun and some files may have been partially downloaded. If we know no download actually took place we can be more clear about this.
libalpm: set errno and log when setting up temp download dir
2025-11-08 03:24:40 +01:00 · 2025-05-20 13:54:05 +01:00 · 2025-05-20 13:54:01 +01:00 · 2025-05-20 13:53:58 +01:00 · 2025-05-20 13:53:45 +01:00 · 2025-05-17 13:20:16 +10:00
218 changed files with 773 additions and 541 deletions
--- a/.mailmap
+++ b/.mailmap
@@ -12,7 +12,7 @@ Daenyth Blank <Daenyth+arch@gmail.com> <Daenyth+git@gmail.com>
 Dave Reisner <dreisner@archlinux.org> <d@falconindy.com>
 甘露(Gan Lu) <rhythm.gan@gmail.com>
 Giovanni Scafora <giovanni@archlinux.org> <linuxmania@gmail.com>
-Jan Steffens <jan.steffens@gmail.com>
+Jan Alexander Steffens (heftig) <heftig@archlinux.org> <jan.steffens@gmail.com>
 Jaroslaw Swierczynski <swiergot@gmail.com> <swiergot@juvepoland.com>
 Jonathan Conder <j@skurvy.no-ip.org> <jonno.conder@gmail.com>
 Juan Pablo González Tognarelli <lord_jotape@yahoo.com.ar>
--- a/10
+++ b/10
@@ -1,6 +1,6 @@
 VERSION         DESCRIPTION
 -----------------------------------------------------------------------------
-7.0.0         - Add DownloadUser configuation option used to drop-privileges
+7.0.0         - Add DownloadUser configuration option used to drop-privileges
                when downloading files.
              - Download files to a temporary directory owned by DownloadUser
              - On Linux systems, ensure the download process does not write
@@ -649,7 +649,7 @@ VERSION         DESCRIPTION
                file overwrites from malicious databases
              - makepkg:
                - restrict package name from starting with a dot
-                - fix BZR source revision support (FS#35281)
+                - fix Bazaar source revision support (FS#35281)
                - Use LOGDEST for log pipe
                - fix distcc disabling (FS#35741)
                - correct stat usage on BSD/Darwin (FS#35469)
@@ -665,7 +665,7 @@ VERSION         DESCRIPTION
                FS#34716, FS#35097)
              - makepkg:
                - improve SVN VCS PKGBUILD handling (FS#34675, FS#34636)
-                - allow "lp:" URLs for BZR sources (FS#34650)
+                - allow "lp:" URLs for Bazaar sources (FS#34650)
                - prevent pkgver() capturing stderr (FS#34974)
                - fix attempt to remove package twice on failure (FS#34672)
              - contrib:
@@ -1338,7 +1338,7 @@ VERSION         DESCRIPTION
                - add source package creation option
              - rankmirrors- allow reading from stdin (FS#8043)
              - and many other updates: 198 bugs/FRs closed since 3.0.0 release
-              - switch to GIT for source code management
+              - switch to Git for source code management
 3.0.6         - config files updated to reflect current -> core change
              - fix symlink overwriting issue (FS#7484)
              - fix config parsing with tr_TR locale (FS#7235)
@@ -1490,7 +1490,7 @@ VERSION         DESCRIPTION
                - Cleanup db_loadpkgs(), add list_add_sorted()
              - Fixed a memory leak in db_find_conflicts()
 2.8.3         - Fixed a little makepkg bug with bash 3.0
-              - Fixed resolvedeps to always prefer literals over provisios
+              - Fixed resolvedeps to always prefer literals over providers
              - Added --config option to specify an alternate config file
              - Added "Include" directive to include repositories from
                config files (inspired by Michael Baehr's patch)
--- a/11
+++ b/11
@@ -352,7 +352,7 @@ API CHANGES BETWEEN 3.4 AND 3.5
     - alpm_db_get_pkg() for normal targets
     - alpm_find_dbs_satisfier() for versioned provisions
     - alpm_find_grp_pkgs() for groups
- alpm_deptest() is replaced by the more flexibile alpm_find_satisfier()
+- alpm_deptest() is replaced by the more flexible alpm_find_satisfier()
 - size_t used for alpm_list_t sizes
  - return type for alpm_list_count()
  - parameter type in alpm_list_msort() and alpm_list_nth()
@@ -724,6 +724,7 @@ API CHANGES BETWEEN 6.0 AND 6.1
 - alpm_db_set_cache_servers()
 - alpm_db_add_cache_server()

+
 API CHANGES BETWEEN 6.1 AND 7.0
 ===============================

@@ -733,3 +734,11 @@ API CHANGES BETWEEN 6.1 AND 7.0
 - alpm_option_set_sandboxuser()
 - alpm_option_set_disable_sandbox()
 - alpm_sandbox_setup_child()
+
+
+API CHANGES BETWEEN 7.0 AND 7.1
+===============================
+
+[CHANGED]
+- error codes:
+    PM_ERR_TRANS_COMMITING renamed to PM_ERR_TRANS_COMMITTING
--- a/2
+++ b/2
@@ -3,7 +3,7 @@ currently. Our translations are currently maintained in Transifex; please read
 doc/translation-help.txt for more details.

 Below is a list of past translators before we switched to Transifex; more can
-be found by looking in the GIT history.
+be found by looking in the Git history.

 If your language is not already in the various po/ subdirectories and you wish
 it was, set up a team in Transifex for your language and we will be happy to
--- a/doc/BUILDINFO.5.asciidoc
+++ b/doc/BUILDINFO.5.asciidoc
@@ -11,8 +11,8 @@ Synopsis
 This manual page describes the format of a BUILDINFO file found in the root of
 a package created by makepkg. The file contains a description of the package's
 build environment. The information is formatted in key-value pairs separated by
-a '=', one value per line. Arrays are represented multiple keys with the same
-value.
+a '=', one value per line. Arrays are represented as multiple key-value pairs
+having the same key.


 Description
--- a/doc/asciidoc.conf
+++ b/doc/asciidoc.conf
@@ -1,5 +1,5 @@
 ## linkman: macro
-# Inspired by/borrowed from the GIT source tree at Documentation/asciidoc.conf
+# Inspired by/borrowed from the Git source tree at Documentation/asciidoc.conf
 #
 # Usage: linkman:command[manpage-section]
 #
--- a/doc/index.asciidoc
+++ b/doc/index.asciidoc
@@ -252,7 +252,7 @@ the package database if it helps.

 Copyright
 ---------
-pacman is Copyright (C) 2006-2024 Pacman Development Team
+pacman is Copyright (C) 2006-2025 Pacman Development Team
 <pacman-dev@lists.archlinux.org> and Copyright (C) 2002-2006 Judd Vinet
 <jvinet@zeroflux.org> and is licensed through the GNU General Public License,
 version 2 or later.
--- a/doc/makepkg.8.asciidoc
+++ b/doc/makepkg.8.asciidoc
@@ -247,6 +247,11 @@ Environment Variables
 	Use an alternate config file instead of the +{sysconfdir}/makepkg.conf+
 	default.

+**MAKEPKG_GIT_CONFIG=**"/path/to/file"::
+	Use an alternate config file for Git instead of the
+	+{sysconfdir}/makepkg.d/gitconfig+ default. makepkg always prevents Git
+	from loading any other config files.
+
 **PKGDEST=**"/path/to/directory"::
 	Directory where the resulting packages will be stored. Overrides the
 	corresponding value defined in linkman:makepkg.conf[5].
@@ -297,7 +302,7 @@ Environment Variables
 **BUILDTOOLVER=**"<version>"::
 	The version of the '$BUILDTOOL' used.

-**MAKEPKG_LINT_PKGBUILD=**0
+**MAKEPKG_LINT_PKGBUILD=**0::
 	Setting to 0 disables PKGBUILD linting within makepkg. Useful on systems
 	with slow bash subshell operations, or on PKGBUILDs with extreme amounts of
 	package splitting.
--- a/doc/makepkg.conf.5.asciidoc
+++ b/doc/makepkg.conf.5.asciidoc
@@ -62,6 +62,11 @@ Options
 	A string such as ``i686-pc-linux-gnu''; do not touch this unless you know what
 	you are doing. This can be commented out by most users if desired.

+**NPROC=**""::
+	Sets the number of processors to use for parallel jobs in makepkg.
+	Note: this does not affect parallelization of tasks during ``build()`` and
+	related functions.
+
 **CPPFLAGS=**"cppflags"::
 	Flags used for the C preprocessor; see CFLAGS for more information.

--- a/doc/pacman.8.asciidoc
+++ b/doc/pacman.8.asciidoc
@@ -151,7 +151,8 @@ Options
 	+{localstatedir}/cache/pacman/pkg+). Multiple cache directories can be
 	specified, and they are tried in the order they are passed to pacman.
 	*NOTE*: This is an absolute path, and the root path is not automatically
-	prepended.
+	prepended. If DownloadUser is set in linkman:pacman.conf[5], then the
+	specified user must have permission to access the cache directory.

 *\--color* <when>::
 	Specify when to enable coloring. Valid options are 'always', 'never', or
--- a/doc/pacman.conf.5.asciidoc
+++ b/doc/pacman.conf.5.asciidoc
@@ -235,7 +235,7 @@ contain a file that lists the servers for that repository.
 # use this server first
 Server = ftp://ftp.archlinux.org/$repo/os/$arch
 # next use servers as defined in the mirrorlist below
-Include = {sysconfdir}/pacman.d/mirrorlist
+Include = /etc/pacman.d/mirrorlist
 --------

 The order of repositories in the configuration files matters; repositories
--- a/doc/repo-add.8.asciidoc
+++ b/doc/repo-add.8.asciidoc
@@ -29,9 +29,10 @@ specified on the command line. Multiple packages to remove can be specified
 on the command line.

 A package database is a tar file, optionally compressed. Valid extensions are
-``.db'' followed by an archive extension of ``.tar'', ``.tar.gz'', ``.tar.bz2'',
-``.tar.xz'', or ``.tar.Z''. The file does not need to exist, but all parent
-directories must exist.
+``.db'' followed by an archive extension of ``.tar'', ``.tar.bz2'',
+``.tar.gz'', ``.tar.lrz'', ``.tar.lz'', ``.tar.lz4'', ``.tar.lzo'',
+``.tar.xz'', ``.tar.zst'' or ``.tar.Z''. The file does not need to exist, but
+all parent directories must exist.


 Common Options
@@ -59,6 +60,14 @@ Common Options
 *\--nocolor*::
 	Remove color from 'repo-add' and 'repo-remove' output.

+*-R, \--remove*::
+	Remove old package files from the disk when updating or removing their
+	entry in the database.
+
+*-w, \--wait-for-lock*::
+	Wait for the lock file to be acquired. If unset, command will fail with
+	exit code 2 if acquiring the lock fails. If set, it will retry to acquire
+	lock until success.

 repo-add Options
 ----------------
@@ -66,10 +75,6 @@ repo-add Options
 	Only add packages that are not already in the database.  Warnings will be
 	printed upon detection of existing packages, but they will not be re-added.

-*-R, \--remove*::
-	Remove old package files from the disk when updating their entry in the
-	database.
-
 *\--include-sigs*::
 	Include package PGP signatures in the repository database (if available)

--- a/doc/submitting-patches.asciidoc
+++ b/doc/submitting-patches.asciidoc
@@ -11,9 +11,9 @@ NOTE: Some of this is paraphrased from the kernel documentation's

 Getting the most recent source
 ------------------------------
-Patches need to be submitted in GIT format and are best if they are against the
+Patches need to be submitted in Git format and are best if they are against the
 latest version of the code. There are several helpful tutorials for getting
-started with GIT if you have not worked with it before.
+started with Git if you have not worked with it before.

 * https://www.kernel.org/pub/software/scm/git/docs/gittutorial.html
 * https://wiki.archlinux.org/index.php/Super_Quick_Git_Guide
--- a/doc/translation-help.asciidoc
+++ b/doc/translation-help.asciidoc
@@ -4,10 +4,10 @@ Pacman - Translating
 This document is here to guide you in helping translate pacman messages,
 libalpm messages, and the manual pages for the entire pacman package.

-We are currently using https://www.transifex.com/[Transifex] as the translation
+We are currently using https://app.transifex.com/[Transifex] as the translation
 platform for pacman and libalpm. You will need to sign up for an account there
 and then register with a translation team on the
-https://www.transifex.com/projects/p/archlinux-pacman/[pacman project page].
+https://explore.transifex.com/toofishes/archlinux-pacman/[pacman project page].

 NOTE: This may be old information due to our switch to Transifex, but the
 gettext website is a very useful guide to read before embarking on translation
@@ -31,7 +31,7 @@ either be hand-edited, or modified with a tool such as poedit, gtranslator or
 kbabel. Using a translation tool tends to make the job easier.

 Please read up on Transifex usage using the
-https://docs.transifex.com/[Transifex Help] if you are not familiar.
+https://help.transifex.com/[Transifex Help] if you are not familiar.

 Transifex provides a command-line client to help with translations.  Here is
 an example set of commands if you have a source code checkout and are not
@@ -56,19 +56,19 @@ Pre-release Updates

 A week or two before each release, the codebase will go into a string freeze
 and an email will be sent to the mailto:pacman-dev@lists.archlinux.org[pacman-dev]
-mailing list asking for translations. This email will have a prefix of
-*[translation]* for anyone looking to set up an email filter.
+mailing list asking for translations. An announcement in Transifex is also made,
+which reaches everyone that is member of the translation team.

 At this time, the latest `.po` language files will be made available at the
-Transifex project page.  Each language will have two files available (back-end
-and front-end). Translators interested in helping are encouraged to use the
+Transifex project page.  Each language will have three files available (libalpm,
+pacman and pacman-scripts). Translators interested in helping are encouraged to use the
 features of Transifex to let others know they are currently translating their
 language.

-Once a translator has completed the translation (*OR* realizes they do not have
+Once a translator has completed the translation offline (*OR* realizes they do not have
 time to finish), please upload your progress back to the Transifex site.

-NOTE: Please upload your translations as soon as possible- this will give other
+NOTE: Please upload your translations as soon as possible - this will give other
 speakers of your language time to review your translations and update them as
 necessary.

@@ -80,21 +80,25 @@ repository.

 	git clone https://gitlab.archlinux.org/pacman/pacman.git

-Next, you will need to run `./autogen.sh` and `./configure` in the base
-directory to generate the correct Makefiles. At this point, all necessary
-make targets will be generated and we can begin updating the translation
-files.
+Next, you will need to configure the build environment. From the base directory,
+run:

-We need to first update the main message catalog file. Navigate into either the
-`lib/libalpm/po` or `po` directory depending on which translation you wish to
-work on first, and execute the following command.  If you are working in the
-`po/` tree, replace 'libalpm.pot' with 'pacman.pot':
+	meson setup . build

-	make libalpm.pot-update
+If any required dependencies are missing, please install. After that,
+update the template translation (.pot) files to the latest state of
+the source code by running:
+	
+	meson compile -C build pacman-scripts-pot pacman-pot libalpm-pot
+	
+We need to first update the main message catalog file. Navigate into either
+the `lib/libalpm/po`, `scripts/po` or `src/pacman/po` directory depending
+on which translation you wish to work on first, and execute the following
+command to update your specific language's translation file
+(replace `lang_code` with your language code e.g. 'pt_BR', and `pot_file`
+with `libalpm.pot`, `pacman.pot` or `pacman-scripts.pot`):

-Next, update your specific language's translation file:
-
-	make <po file>-update
+	msgmerge --update --previous <lang_code>.po  <pot_filename>.pot

 At this point, you can do the translation. To submit your changes, either email
 the new `.po` file to the mailing-list with *[translation]* in the subject, or
@@ -103,7 +107,7 @@ submit a Git-formatted patch (please do not include any `.pot` file changes).
 As a shortcut, all translation files (including `.pot` files) can be updated
 with the following command:

-	make update-po
+	./build-aux/update-po

 Adding a New Language
 ~~~~~~~~~~~~~~~~~~~~~
@@ -112,10 +116,10 @@ Making a new language is not too hard, but be sure to follow all the steps.
 You will have to do the following steps in both the `lib/libalpm/po/` and `po/`
 directories, substituting where appropriate. First, edit the `LINGUAS` file and
 add your new language code at the bottom. Next, run the following command,
-substituting 'libalpm.pot' or 'pacman.pot' for potfile depending on which
+substituting `libalpm.pot` or `pacman.pot` for potfile depending on which
 directory you are currently working in:

-	msginit -l <lang code> -o <lang code>.po -i <potfile>
+	msginit -l <lang_code> -o <lang_code>.po -i <potfile>

 You can then also add your language code to the end of the `LINGUAS` file
 located in each po directory.
@@ -137,11 +141,13 @@ following two translations are equivalent:
 	msgstr ""
 	"This is a test translation"

-If you want to test the translation (for example, the front-end one):
+If you want to test the translation (copy the .po file you want to test,
+you may ignore the rest), replacing `<lang_code>` accordingly:

-	rm *.gmo stamp-po
-	make
-	cp <lang code>.gmo /usr/share/locale/<lang code>/LC_MESSAGES/pacman.mo
+	meson compile -C build pacman-scripts-gmo pacman-gmo libalpm-gmo
+	cp ./build/lib/libalpm/po/<lang_code>/LC_MESSAGES/libalpm.mo    /usr/share/locale/<lang_code>/LC_MESSAGES/libalpm.mo
+	cp ./build/scripts/po/<lang_code>/LC_MESSAGES/pacman-scripts.mo /usr/share/locale/<lang_code>/LC_MESSAGES/pacman-scripts.mo
+	cp ./build/src/pacman/po/<lang_code>/LC_MESSAGES/pacman.mo      /usr/share/locale/<lang_code>/LC_MESSAGES/pacman.mo


 Translating Manpages
--- a/etc/makepkg.conf.in
+++ b/etc/makepkg.conf.in
@@ -36,6 +36,8 @@ VCSCLIENTS=('bzr::breezy'
 CARCH="@CARCH@"
 CHOST="@CHOST@"

+#NPROC=2
+
 #-- Compiler and Linker Flags
 #CPPFLAGS=""
 #CFLAGS="-O2 -pipe"
--- a/lib/libalpm/add.c
+++ b/lib/libalpm/add.c
@@ -1,7 +1,7 @@
 /*
 *  add.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/add.h
+++ b/lib/libalpm/add.h
@@ -1,7 +1,7 @@
 /*
 *  add.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/alpm.c
+++ b/lib/libalpm/alpm.c
@@ -1,7 +1,7 @@
 /*
 *  alpm.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
@@ -25,6 +25,9 @@
 #include <curl/curl.h>
 #endif

+#include <errno.h>
+#include <pwd.h>
+
 /* libalpm */
 #include "alpm.h"
 #include "alpm_list.h"
@@ -39,6 +42,7 @@ alpm_handle_t SYMEXPORT *alpm_initialize(const char *root, const char *dbpath,
 	const char *lf = "db.lck";
 	char *hookdir;
 	size_t hookdirlen, lockfilelen;
+	struct passwd const *pw = NULL;
 	alpm_handle_t *myhandle = _alpm_handle_new();

 	if(myhandle == NULL) {
@@ -78,6 +82,10 @@ alpm_handle_t SYMEXPORT *alpm_initialize(const char *root, const char *dbpath,

 	myhandle->parallel_downloads = 1;

+	/* set default sandboxuser */
+	ASSERT((pw = getpwuid(0)) != NULL, myerr = errno; goto cleanup);
+	STRDUP(myhandle->sandboxuser, pw->pw_name, goto nomem);
+	
 #ifdef ENABLE_NLS
 	bindtextdomain("libalpm", LOCALEDIR);
 #endif
--- a/lib/libalpm/alpm.h
+++ b/lib/libalpm/alpm.h
@@ -1,7 +1,7 @@
 /*
 * alpm.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
@@ -308,6 +308,8 @@ typedef enum _alpm_errno_t {
 	/** Files conflict */
 	ALPM_ERR_FILE_CONFLICTS,
 	/* Misc */
+	/** Download setup failed */
+	ALPM_ERR_RETRIEVE_PREPARE,
 	/** Download failed */
 	ALPM_ERR_RETRIEVE,
 	/** Invalid Regex */
@@ -451,14 +453,6 @@ typedef struct _alpm_pgpkey_t {
 	unsigned int length;
 	/** has the key been revoked */
 	unsigned int revoked;
-	/** A character representing the  encryption algorithm used by the public key
-	 *
-	 * ? = unknown
-	 * R = RSA
-	 * D = DSA
-	 * E = EDDSA
-	 */
-	char pubkey_algo;
 } alpm_pgpkey_t;

 /**
@@ -2265,6 +2259,12 @@ int alpm_option_set_remote_file_siglevel(alpm_handle_t *handle, int level);
 * @{
 */

+/** Get the download timeout state
+ * @param handle the context handle
+ * @return 0 for enabled, 1 for disabled
+*/
+int alpm_option_get_disable_dl_timeout(alpm_handle_t *handle);
+
 /** Enables/disables the download timeout.
 * @param handle the context handle
 * @param disable_dl_timeout 0 for enabled, 1 for disabled
@@ -2307,6 +2307,12 @@ int alpm_option_set_parallel_downloads(alpm_handle_t *handle, unsigned int num_s
 * @{
 */

+/** Get the sandbox state
+ * @param handle the context handle
+ * @return 0 for enabled, 1 for disabled
+ */
+int alpm_option_get_disable_sandbox(alpm_handle_t *handle);
+
 /** Enables/disables the sandbox.
 * @param handle the context handle
 * @param disable_sandbox 0 for enabled, 1 for disabled
--- a/lib/libalpm/alpm_list.c
+++ b/lib/libalpm/alpm_list.c
@@ -1,7 +1,7 @@
 /*
 *  alpm_list.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/alpm_list.h
+++ b/lib/libalpm/alpm_list.h
@@ -1,7 +1,7 @@
 /*
 *  alpm_list.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/backup.c
+++ b/lib/libalpm/backup.c
@@ -1,7 +1,7 @@
 /*
 *  backup.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2005 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
--- a/lib/libalpm/backup.h
+++ b/lib/libalpm/backup.h
@@ -1,7 +1,7 @@
 /*
 *  backup.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/be_local.c
+++ b/lib/libalpm/be_local.c
@@ -1,7 +1,7 @@
 /*
 *  be_local.c : backend for the local database
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/be_package.c
+++ b/lib/libalpm/be_package.c
@@ -1,7 +1,7 @@
 /*
 *  be_package.c : backend for packages
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/be_sync.c
+++ b/lib/libalpm/be_sync.c
@@ -1,7 +1,7 @@
 /*
 *  be_sync.c : backend for sync databases
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
@@ -153,7 +153,7 @@ int SYMEXPORT alpm_db_update(alpm_handle_t *handle, alpm_list_t *dbs, int force)

 	syncpath = get_sync_dir(handle);
 	ASSERT(syncpath != NULL, return -1);
-	temporary_syncpath = _alpm_temporary_download_dir_setup(syncpath, handle->sandboxuser);
+	temporary_syncpath = _alpm_temporary_download_dir_setup(handle, syncpath);
 	ASSERT(temporary_syncpath != NULL, FREE(syncpath); return -1);

 	/* make sure we have a sane umask */
@@ -309,11 +309,11 @@ static int _sync_get_validation(alpm_pkg_t *pkg)
 static const struct pkg_operations *get_sync_pkg_ops(void)
 {
 	static struct pkg_operations sync_pkg_ops;
-	static int sync_pkg_ops_initalized = 0;
-	if(!sync_pkg_ops_initalized) {
+	static int sync_pkg_ops_initialized = 0;
+	if(!sync_pkg_ops_initialized) {
 		sync_pkg_ops = default_pkg_ops;
 		sync_pkg_ops.get_validation = _sync_get_validation;
-		sync_pkg_ops_initalized = 1;
+		sync_pkg_ops_initialized = 1;
 	}
 	return &sync_pkg_ops;
 }
--- a/lib/libalpm/conflict.c
+++ b/lib/libalpm/conflict.c
@@ -1,7 +1,7 @@
 /*
 *  conflict.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2006 by David Kimpe <dnaku@frugalware.org>
--- a/lib/libalpm/conflict.h
+++ b/lib/libalpm/conflict.h
@@ -1,7 +1,7 @@
 /*
 *  conflict.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/db.c
+++ b/lib/libalpm/db.c
@@ -1,7 +1,7 @@
 /*
 *  db.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
--- a/lib/libalpm/db.h
+++ b/lib/libalpm/db.h
@@ -1,7 +1,7 @@
 /*
 *  db.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2006 by Miklos Vajna <vmiklos@frugalware.org>
--- a/lib/libalpm/deps.c
+++ b/lib/libalpm/deps.c
@@ -1,7 +1,7 @@
 /*
 *  deps.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005, 2006 by Miklos Vajna <vmiklos@frugalware.org>
@@ -181,13 +181,13 @@ static void _alpm_warn_dep_cycle(alpm_handle_t *handle, alpm_list_t *targets,
 	} else {
 		alpm_pkg_t *ancestorpkg = ancestor->data;
 		alpm_pkg_t *childpkg = vertex->data;
-		_alpm_log(handle, ALPM_LOG_WARNING, _("dependency cycle detected:\n"));
+		_alpm_log(handle, ALPM_LOG_DEBUG, _("dependency cycle detected:\n"));
 		if(reverse) {
-			_alpm_log(handle, ALPM_LOG_WARNING,
+			_alpm_log(handle, ALPM_LOG_DEBUG,
 					_("%s will be removed after its %s dependency\n"),
 					ancestorpkg->name, childpkg->name);
 		} else {
-			_alpm_log(handle, ALPM_LOG_WARNING,
+			_alpm_log(handle, ALPM_LOG_DEBUG,
 					_("%s will be installed before its %s dependency\n"),
 					ancestorpkg->name, childpkg->name);
 		}
--- a/lib/libalpm/deps.h
+++ b/lib/libalpm/deps.h
@@ -1,7 +1,7 @@
 /*
 *  deps.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2006 by Miklos Vajna <vmiklos@frugalware.org>
--- a/lib/libalpm/diskspace.c
+++ b/lib/libalpm/diskspace.c
@@ -1,7 +1,7 @@
 /*
 *  diskspace.c
 *
- *  Copyright (c) 2010-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2010-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/diskspace.h
+++ b/lib/libalpm/diskspace.h
@@ -1,7 +1,7 @@
 /*
 *  diskspace.h
 *
- *  Copyright (c) 2010-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2010-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/dload.c
+++ b/lib/libalpm/dload.c
@@ -1,7 +1,7 @@
 /*
 *  dload.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
@@ -76,13 +76,16 @@ static mode_t _getumask(void)
 static int finalize_download_file(const char *filename)
 {
 	struct stat st;
+	uid_t myuid = getuid();
 	ASSERT(filename != NULL, return -1);
 	ASSERT(stat(filename, &st) == 0, return -1);
 	if(st.st_size == 0) {
 		unlink(filename);
                return 1;
 	}
-	ASSERT(chown(filename, 0, 0) != -1, return -1);
+	if(myuid == 0) {
+		ASSERT(chown(filename, 0, 0) != -1, return -1);
+	}
 	ASSERT(chmod(filename, ~(_getumask()) & 0666) != -1, return -1);
 	return 0;
 }
@@ -695,9 +698,9 @@ cleanup:
 	 * only applies to FTP transfers. */
 	curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 1L);
 	curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, (char *)NULL);
-
 	if(payload->localf != NULL) {
 		fclose(payload->localf);
+		payload->localf = NULL;
 		utimes_long(payload->tempfile_name, remote_time);
 	}

@@ -877,7 +880,6 @@ static int curl_download_internal(alpm_handle_t *handle,
 			p = NULL;
 			err = -1;
 		}
-
 		while(true) {
 			int msgs_left = 0;
 			CURLMsg *msg = curl_multi_info_read(curlm, &msgs_left);
@@ -901,7 +903,6 @@ static int curl_download_internal(alpm_handle_t *handle,
 			}
 		}
 	}
-
 	int ret = err ? -1 : updated ? 0 : 1;
 	_alpm_log(handle, ALPM_LOG_DEBUG, "curl_download_internal return code is %d\n", ret);
 	alpm_list_free(payloads);
@@ -919,12 +920,10 @@ static int curl_download_internal_sandboxed(alpm_handle_t *handle,
 {
 	int pid, err = 0, ret = -1, callbacks_fd[2];
 	sigset_t oldblock;
-	struct sigaction sa_ign, oldint, oldquit;
+	struct sigaction sa_ign = { .sa_handler = SIG_IGN }, oldint, oldquit;
 	_alpm_sandbox_callback_context callbacks_ctx;

 	sigemptyset(&sa_ign.sa_mask);
-	sa_ign.sa_handler = SIG_IGN;
-	sa_ign.sa_flags=0;

 	if(pipe(callbacks_fd) != 0) {
 		return -1;
@@ -1105,29 +1104,34 @@ static int finalize_download_locations(alpm_list_t *payloads, const char *localp
 	int returnvalue = 0;
 	for(p = payloads; p; p = p->next) {
 		struct dload_payload *payload = p->data;
-		if(payload->tempfile_name) {
-			move_file(payload->tempfile_name, localpath);
-		}
+		const char *filename;
+
 		if(payload->destfile_name) {
-			int ret = move_file(payload->destfile_name, localpath);
+			filename = payload->destfile_name;
+		} else {
+			filename = payload->tempfile_name;
+		}

-			if(ret == -1) {
-				/* ignore error if the file already existed - only signature file was downloaded */
-				if(payload->mtime_existing_file == 0) {
-					returnvalue = -1;
-				}
-			}
+		int ret = move_file(filename, localpath);

-			if (payload->download_signature) {
-				const char sig_suffix[] = ".sig";
-				char *sig_filename = NULL;
-				size_t sig_filename_len = strlen(payload->destfile_name) + sizeof(sig_suffix);
-				MALLOC(sig_filename, sig_filename_len, continue);
-				snprintf(sig_filename, sig_filename_len, "%s%s", payload->destfile_name, sig_suffix);
-				move_file(sig_filename, localpath);
-				FREE(sig_filename);
+		if(ret == -1) {
+			/* ignore error if the file already existed - only signature file was downloaded */
+			if(payload->mtime_existing_file == 0) {
+				_alpm_log(payload->handle, ALPM_LOG_ERROR, _("could not move %s into %s (%s)\n"),
+						filename, localpath, strerror(errno));
+				returnvalue = -1;
 			}
 		}
+
+		if (payload->download_signature) {
+			const char sig_suffix[] = ".sig";
+			char *sig_filename = NULL;
+			size_t sig_filename_len = strlen(filename) + sizeof(sig_suffix);
+			MALLOC(sig_filename, sig_filename_len, continue);
+			snprintf(sig_filename, sig_filename_len, "%s%s", filename, sig_suffix);
+			move_file(sig_filename, localpath);
+			FREE(sig_filename);
+		}
 	}
 	return returnvalue;
 }
@@ -1265,7 +1269,7 @@ download_signature:
 	}

 	if (finalize_download_locations(payloads, localpath) != 0 && ret == 0) {
-		return -1;
+		RET_ERR(handle, ALPM_ERR_RETRIEVE, -1);
 	}
 	return ret;
 }
@@ -1300,7 +1304,7 @@ int SYMEXPORT alpm_fetch_pkgurl(alpm_handle_t *handle, const alpm_list_t *urls,

 	/* find a valid cache dir to download to */
 	cachedir = _alpm_filecache_setup(handle);
-	temporary_cachedir = _alpm_temporary_download_dir_setup(cachedir, handle->sandboxuser);
+	temporary_cachedir = _alpm_temporary_download_dir_setup(handle, cachedir);
 	ASSERT(temporary_cachedir != NULL, return -1);

 	for(i = urls; i; i = i->next) {
@@ -1356,12 +1360,12 @@ int SYMEXPORT alpm_fetch_pkgurl(alpm_handle_t *handle, const alpm_list_t *urls,
 	if(payloads) {
 		event.type = ALPM_EVENT_PKG_RETRIEVE_START;
 		event.pkg_retrieve.num = alpm_list_count(payloads);
+		event.pkg_retrieve.total_size = 0;
 		EVENT(handle, &event);
 		if(_alpm_download(handle, payloads, cachedir, temporary_cachedir) == -1) {
 			_alpm_log(handle, ALPM_LOG_WARNING, _("failed to retrieve some files\n"));
 			event.type = ALPM_EVENT_PKG_RETRIEVE_FAILED;
 			EVENT(handle, &event);
-
 			GOTO_ERR(handle, ALPM_ERR_RETRIEVE, err);
 		} else {
 			event.type = ALPM_EVENT_PKG_RETRIEVE_DONE;
@@ -1376,7 +1380,8 @@ int SYMEXPORT alpm_fetch_pkgurl(alpm_handle_t *handle, const alpm_list_t *urls,
 				const char *filename = mbasename(payload->destfile_name);
 				filepath = _alpm_filecache_find(handle, filename);
 			} else {
-				STRDUP(filepath, payload->tempfile_name, GOTO_ERR(handle, ALPM_ERR_MEMORY, err));
+				const char *filename = mbasename(payload->tempfile_name);
+				filepath = _alpm_filecache_find(handle, filename);
 			}
 			if(filepath) {
 				alpm_list_append(fetched, filepath);
@@ -1408,6 +1413,11 @@ void _alpm_dload_payload_reset(struct dload_payload *payload)
 {
 	ASSERT(payload, return);

+	if(payload->localf != NULL) {
+		fclose(payload->localf);
+		payload->localf = NULL;
+	}
+
 	FREE(payload->remote_name);
 	FREE(payload->tempfile_name);
 	FREE(payload->destfile_name);
--- a/lib/libalpm/dload.h
+++ b/lib/libalpm/dload.h
@@ -1,7 +1,7 @@
 /*
 *  dload.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/error.c
+++ b/lib/libalpm/error.c
@@ -1,7 +1,7 @@
 /*
 *  error.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
@@ -137,7 +137,9 @@ const char SYMEXPORT *alpm_strerror(alpm_errno_t err)
 			return _("conflicting dependencies");
 		case ALPM_ERR_FILE_CONFLICTS:
 			return _("conflicting files");
-		/* Miscellaenous */
+		/* Miscellaneous */
+		case ALPM_ERR_RETRIEVE_PREPARE:
+			return _("failed to initialize download");
 		case ALPM_ERR_RETRIEVE:
 			return _("failed to retrieve some files");
 		case ALPM_ERR_INVALID_REGEX:
--- a/lib/libalpm/filelist.c
+++ b/lib/libalpm/filelist.c
@@ -1,7 +1,7 @@
 /*
 *  filelist.c
 *
- *  Copyright (c) 2012-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2012-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/filelist.h
+++ b/lib/libalpm/filelist.h
@@ -1,7 +1,7 @@
 /*
 *  filelist.h
 *
- *  Copyright (c) 2012-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2012-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/graph.c
+++ b/lib/libalpm/graph.c
@@ -1,7 +1,7 @@
 /*
 *  graph.c - helpful graph structure and setup/teardown methods
 *
- *  Copyright (c) 2007-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2007-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/graph.h
+++ b/lib/libalpm/graph.h
@@ -1,7 +1,7 @@
 /*
 *  graph.h - helpful graph structure and setup/teardown methods
 *
- *  Copyright (c) 2007-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2007-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/group.c
+++ b/lib/libalpm/group.c
@@ -1,7 +1,7 @@
 /*
 *  group.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/group.h
+++ b/lib/libalpm/group.h
@@ -1,7 +1,7 @@
 /*
 *  group.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/handle.c
+++ b/lib/libalpm/handle.c
@@ -1,7 +1,7 @@
 /*
 *  handle.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005, 2006 by Miklos Vajna <vmiklos@frugalware.org>
@@ -935,6 +935,12 @@ int SYMEXPORT alpm_option_get_remote_file_siglevel(alpm_handle_t *handle)
 	}
 }

+int SYMEXPORT alpm_option_get_disable_dl_timeout(alpm_handle_t *handle)
+{
+	CHECK_HANDLE(handle, return -1);
+	return handle->disable_dl_timeout;
+}
+
 int SYMEXPORT alpm_option_set_disable_dl_timeout(alpm_handle_t *handle,
 		unsigned short disable_dl_timeout)
 {
@@ -952,6 +958,12 @@ int SYMEXPORT alpm_option_set_parallel_downloads(alpm_handle_t *handle,
 	return 0;
 }

+int SYMEXPORT alpm_option_get_disable_sandbox(alpm_handle_t *handle)
+{
+	CHECK_HANDLE(handle, return -1);
+	return handle->disable_sandbox;
+}
+
 int SYMEXPORT alpm_option_set_disable_sandbox(alpm_handle_t *handle,
 		unsigned short disable_sandbox)
 {
--- a/lib/libalpm/handle.h
+++ b/lib/libalpm/handle.h
@@ -1,7 +1,7 @@
 /*
 *  handle.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/hook.c
+++ b/lib/libalpm/hook.c
@@ -1,7 +1,7 @@
 /*
 *  hook.c
 *
- *  Copyright (c) 2015-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2015-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/hook.h
+++ b/lib/libalpm/hook.h
@@ -1,7 +1,7 @@
 /*
 *  hook.h
 *
- *  Copyright (c) 2015-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2015-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/libarchive-compat.h
+++ b/lib/libalpm/libarchive-compat.h
@@ -4,7 +4,7 @@
 /*
 * libarchive-compat.h
 *
- *  Copyright (c) 2013-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2013-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/log.c
+++ b/lib/libalpm/log.c
@@ -1,7 +1,7 @@
 /*
 *  log.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/log.h
+++ b/lib/libalpm/log.h
@@ -1,7 +1,7 @@
 /*
 *  log.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/package.c
+++ b/lib/libalpm/package.c
@@ -1,7 +1,7 @@
 /*
 *  package.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005, 2006 by Christian Hamar <krics@linuxforum.hu>
--- a/lib/libalpm/package.h
+++ b/lib/libalpm/package.h
@@ -1,7 +1,7 @@
 /*
 *  package.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2006 by David Kimpe <dnaku@frugalware.org>
--- a/lib/libalpm/pkghash.c
+++ b/lib/libalpm/pkghash.c
@@ -1,7 +1,7 @@
 /*
 *  pkghash.c
 *
- *  Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/pkghash.h
+++ b/lib/libalpm/pkghash.h
@@ -1,7 +1,7 @@
 /*
 *  pkghash.h
 *
- *  Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/remove.c
+++ b/lib/libalpm/remove.c
@@ -1,7 +1,7 @@
 /*
 *  remove.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
--- a/lib/libalpm/remove.h
+++ b/lib/libalpm/remove.h
@@ -1,7 +1,7 @@
 /*
 *  remove.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
--- a/lib/libalpm/sandbox.c
+++ b/lib/libalpm/sandbox.c
@@ -1,7 +1,7 @@
 /*
 *  sandbox.c
 *
- *  Copyright (c) 2021-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2021-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
@@ -235,7 +235,9 @@ bool _alpm_sandbox_process_cb_download(alpm_handle_t *handle, int callback_pipe)
 	ASSERT(read_from_pipe(callback_pipe, filename, filename_size) != -1, FREE(filename); return false);
 	filename[filename_size] = '\0';

-	handle->dlcb(handle->dlcb_ctx, filename, type, &cb_data);
+	if(handle->dlcb) {
+		handle->dlcb(handle->dlcb_ctx, filename, type, &cb_data);
+	}
 	FREE(filename);
 	return true;
 }
--- a/lib/libalpm/sandbox_fs.c
+++ b/lib/libalpm/sandbox_fs.c
@@ -1,7 +1,7 @@
 /*
 *  sandbox_fs.c
 *
- *  Copyright (c) 2021-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2021-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
@@ -150,6 +150,9 @@ bool _alpm_sandbox_fs_restrict_writes_to(alpm_handle_t *handle, const char *path
 	path_beneath.parent_fd = open(path, O_PATH | O_CLOEXEC | O_DIRECTORY);
 	path_beneath.allowed_access = _LANDLOCK_ACCESS_FS_READ | _LANDLOCK_ACCESS_FS_WRITE | _LANDLOCK_ACCESS_FS_TRUNCATE;

+	/* make sure allowed_access is a subset of handled_access_fs, which may change for older landlock ABI */
+	path_beneath.allowed_access &= ruleset_attr.handled_access_fs;
+
 	if(landlock_add_rule(ruleset_fd, LANDLOCK_RULE_PATH_BENEATH, &path_beneath, 0) == 0) {
 		if(landlock_restrict_self(ruleset_fd, 0)) {
 			_alpm_log(handle, ALPM_LOG_ERROR, _("restricting filesystem access failed because the landlock ruleset could not be applied!\n"));
--- a/lib/libalpm/sandbox_fs.h
+++ b/lib/libalpm/sandbox_fs.h
@@ -1,7 +1,7 @@
 /*
 *  sandbox_fs.h
 *
- *  Copyright (c) 2021-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2021-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/signing.c
+++ b/lib/libalpm/signing.c
@@ -1,7 +1,7 @@
 /*
 *  signing.c
 *
- *  Copyright (c) 2008-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2008-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
@@ -371,46 +371,6 @@ static int key_search_keyserver(alpm_handle_t *handle, const char *fpr,
 	pgpkey->expires = key->subkeys->expires;
 	pgpkey->length = key->subkeys->length;
 	pgpkey->revoked = key->subkeys->revoked;
-	/* Initialize with '?', this is overwritten unless public key
-	 * algorithm is unknown. */
-	pgpkey->pubkey_algo = '?';
-
-	switch(key->subkeys->pubkey_algo) {
-		case GPGME_PK_RSA:
-		case GPGME_PK_RSA_E:
-		case GPGME_PK_RSA_S:
-			pgpkey->pubkey_algo = 'R';
-			break;
-
-		case GPGME_PK_DSA:
-			pgpkey->pubkey_algo = 'D';
-			break;
-
-		case GPGME_PK_ELG_E:
-		case GPGME_PK_ELG:
-		case GPGME_PK_ECDSA:
-		case GPGME_PK_ECDH:
-/* value added in gpgme 1.5.0 */
-#if GPGME_VERSION_NUMBER >= 0x010500
-		case GPGME_PK_ECC:
-#endif
-/* value added in gpgme 1.7.0 */
-#if GPGME_VERSION_NUMBER >= 0x010700
-		case GPGME_PK_EDDSA:
-#endif
-			pgpkey->pubkey_algo = 'E';
-			break;
-	}
-
-	ret = 1;
-
-	/* We do not want to add a default switch case above to receive
-	 * compiler error on new public key algorithm in gpgme. So check
-	 * here if we have a valid pubkey_algo. */
-	if (pgpkey->pubkey_algo == '?') {
-		_alpm_log(handle, ALPM_LOG_DEBUG,
-			"unknown public key algorithm: %d\n", key->subkeys->pubkey_algo);
-	}

 gpg_error:
 	if(ret != 1) {
--- a/lib/libalpm/signing.h
+++ b/lib/libalpm/signing.h
@@ -1,7 +1,7 @@
 /*
 *  signing.h
 *
- *  Copyright (c) 2008-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2008-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/lib/libalpm/sync.c
+++ b/lib/libalpm/sync.c
@@ -1,7 +1,7 @@
 /*
 *  sync.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
@@ -780,7 +780,7 @@ static int download_files(alpm_handle_t *handle)
 	alpm_list_t *payloads = NULL;

 	cachedir = _alpm_filecache_setup(handle);
-	temporary_cachedir = _alpm_temporary_download_dir_setup(cachedir, handle->sandboxuser);
+	temporary_cachedir = _alpm_temporary_download_dir_setup(handle, cachedir);
 	if(temporary_cachedir == NULL) {
 		ret = -1;
 		goto finish;
@@ -817,6 +817,8 @@ static int download_files(alpm_handle_t *handle)
 		}

 		event.type = ALPM_EVENT_PKG_RETRIEVE_START;
+		event.pkg_retrieve.total_size = 0;
+		event.pkg_retrieve.num = 0;

 		/* sum up the number of packages to download and its total size */
 		for(i = files; i; i = i->next) {
--- a/lib/libalpm/sync.h
+++ b/lib/libalpm/sync.h
@@ -1,7 +1,7 @@
 /*
 *  sync.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005, 2006 by Miklos Vajna <vmiklos@frugalware.org>
--- a/lib/libalpm/trans.c
+++ b/lib/libalpm/trans.c
@@ -1,7 +1,7 @@
 /*
 *  trans.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
@@ -203,7 +203,7 @@ int SYMEXPORT alpm_trans_commit(alpm_handle_t *handle, alpm_list_t **data)
 		RET_ERR(handle, ALPM_ERR_TRANS_HOOK_FAILED, -1);
 	}

-	trans->state = STATE_COMMITING;
+	trans->state = STATE_COMMITTING;

 	alpm_logaction(handle, ALPM_CALLER_PREFIX, "transaction started\n");
 	event.type = ALPM_EVENT_TRANSACTION_START;
@@ -239,7 +239,7 @@ int SYMEXPORT alpm_trans_commit(alpm_handle_t *handle, alpm_list_t **data)
 		}
 	}

-	trans->state = STATE_COMMITED;
+	trans->state = STATE_COMMITTED;

 	return 0;
 }
@@ -253,7 +253,7 @@ int SYMEXPORT alpm_trans_interrupt(alpm_handle_t *handle)

 	trans = handle->trans;
 	ASSERT(trans != NULL, RET_ERR_ASYNC_SAFE(handle, ALPM_ERR_TRANS_NULL, -1));
-	ASSERT(trans->state == STATE_COMMITING || trans->state == STATE_INTERRUPTED,
+	ASSERT(trans->state == STATE_COMMITTING || trans->state == STATE_INTERRUPTED,
 			RET_ERR_ASYNC_SAFE(handle, ALPM_ERR_TRANS_TYPE, -1));

 	trans->state = STATE_INTERRUPTED;
--- a/lib/libalpm/trans.h
+++ b/lib/libalpm/trans.h
@@ -1,7 +1,7 @@
 /*
 *  trans.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
@@ -30,8 +30,8 @@ typedef enum _alpm_transstate_t {
 	STATE_INITIALIZED,
 	STATE_PREPARED,
 	STATE_DOWNLOADING,
-	STATE_COMMITING,
-	STATE_COMMITED,
+	STATE_COMMITTING,
+	STATE_COMMITTED,
 	STATE_INTERRUPTED
 } alpm_transstate_t;

--- a/lib/libalpm/util.c
+++ b/lib/libalpm/util.c
@@ -1,7 +1,7 @@
 /*
 *  util.c
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
@@ -23,6 +23,7 @@
 */

 #include <stdlib.h>
+#include <string.h>
 #include <unistd.h>
 #include <ctype.h>
 #include <dirent.h>
@@ -590,9 +591,7 @@ void _alpm_reset_signals(void)
 #endif
 		0
 	};
-	struct sigaction def;
-	def.sa_flags = 0;
-	def.sa_handler = SIG_DFL;
+	struct sigaction def = { .sa_handler = SIG_DFL };
 	sigemptyset(&def.sa_mask);
 	for(i = signals; *i; i++) {
 		sigaction(*i, &def, NULL);
@@ -951,33 +950,53 @@ const char *_alpm_filecache_setup(alpm_handle_t *handle)
 /** Create a temporary directory under the supplied directory.
 * The new directory is writable by the download user, and will be
 * removed after the download operation has completed.
+ * @param handle an alpm handle
 * @param dir existing sync or cache directory
- * @param user download user name
 * @return pointer to a sub-directory writable by the download user inside the existing directory.
 */
-char *_alpm_temporary_download_dir_setup(const char *dir, const char *user)
+char *_alpm_temporary_download_dir_setup(alpm_handle_t *handle, const char *dir)
 {
+	const char *user = handle->sandboxuser;
+	uid_t myuid = getuid();
 	struct passwd const *pw = NULL;

-	ASSERT(dir != NULL, return NULL);
-	if(user != NULL) {
-		ASSERT((pw = getpwnam(user)) != NULL, return NULL);
+	ASSERT(dir != NULL, RET_ERR(handle, ALPM_ERR_WRONG_ARGS, NULL));
+	if(myuid == 0 && user != NULL) {
+		errno = 0;
+		pw = getpwnam(user);
+
+		if(pw == NULL) {
+			if(errno == 0) {
+				_alpm_log(handle, ALPM_LOG_ERROR,
+						_("download user '%s' does not exist\n"), user);
+			} else {
+				_alpm_log(handle, ALPM_LOG_ERROR,
+						_("failed to get download user '%s': %s\n"),
+						user, strerror(errno));
+			}
+			RET_ERR(handle, ALPM_ERR_RETRIEVE_PREPARE, NULL);
+		}
 	}

 	const char template[] = "download-XXXXXX";
 	size_t newdirlen = strlen(dir) + sizeof(template) + 1;
 	char *newdir = NULL;
-	MALLOC(newdir, newdirlen, return NULL);
+	MALLOC(newdir, newdirlen, RET_ERR(handle, ALPM_ERR_MEMORY, NULL));
 	snprintf(newdir, newdirlen - 1, "%s%s", dir, template);
-	newdir = mkdtemp(newdir);
-	if(newdir == NULL) {
+	if(mkdtemp(newdir) == NULL) {
+		_alpm_log(handle, ALPM_LOG_ERROR,
+				_("failed to create temporary download directory %s: %s\n"),
+				newdir, strerror(errno));
 		free(newdir);
-		return NULL;
+		RET_ERR(handle, ALPM_ERR_RETRIEVE_PREPARE, NULL);
 	}
 	if(pw != NULL) {
 		if(chown(newdir, pw->pw_uid, pw->pw_gid) == -1) {
+			_alpm_log(handle, ALPM_LOG_ERROR,
+					_("failed to chown temporary download directory %s: %s\n"),
+					newdir, strerror(errno));
 			free(newdir);
-			return NULL;
+			RET_ERR(handle, ALPM_ERR_RETRIEVE_PREPARE, NULL);
 		}
 	}
 	newdir[newdirlen-2] = '/';
--- a/lib/libalpm/util.h
+++ b/lib/libalpm/util.h
@@ -1,7 +1,7 @@
 /*
 *  util.h
 *
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2005 by Christian Hamar <krics@linuxforum.hu>
@@ -139,7 +139,7 @@ char *_alpm_filecache_find(alpm_handle_t *handle, const char *filename);
 /* Checks whether a file exists in cache */
 int _alpm_filecache_exists(alpm_handle_t *handle, const char *filename);
 const char *_alpm_filecache_setup(alpm_handle_t *handle);
-char *_alpm_temporary_download_dir_setup(const char *dir, const char *user);
+char *_alpm_temporary_download_dir_setup(alpm_handle_t *handle, const char *dir);
 void _alpm_remove_temporary_download_dir(const char *dir);

 /* Unlike many uses of alpm_pkgvalidation_t, _alpm_test_checksum expects
--- a/lib/libalpm/version.c
+++ b/lib/libalpm/version.c
@@ -1,5 +1,5 @@
 /*
- *  Copyright (c) 2006-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+ *  Copyright (c) 2006-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
--- a/meson.build
+++ b/meson.build
@@ -433,6 +433,8 @@ configure_file(
  configuration : substs,
  install_dir : join_paths(SYSCONFDIR, 'makepkg.conf.d/'))

+install_emptydir(join_paths(SYSCONFDIR, 'makepkg.d/'))
+
 configure_file(
  input : 'etc/pacman.conf.in',
  output : 'pacman.conf',
--- a/proto/PKGBUILD-vcs.proto
+++ b/proto/PKGBUILD-vcs.proto
@@ -3,7 +3,7 @@
 # NOTE: Please fill out the license field for your package! If it is unknown,
 # then please put 'unknown'.

-# The following guidelines are specific to BZR, GIT, HG and SVN packages.
+# Guidelines specific to Bazaar, Git, Mercurial and Subversion packages.
 # Other VCS sources are not natively supported by makepkg yet.

 # Maintainer: Your Name <youremail@domain.com>
--- a/scripts/libmakepkg/autodep.sh.in
+++ b/scripts/libmakepkg/autodep.sh.in
@@ -2,7 +2,7 @@
 #
 #   autodep.sh - functions for automatically adding depends/provides
 #
-#   Copyright (c) 2021-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2021-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/autodep/library_depends.sh.in
+++ b/scripts/libmakepkg/autodep/library_depends.sh.in
@@ -2,7 +2,7 @@
 #
 #   library_depends.sh - Automatically add library requirements to depends
 #
-#   Copyright (c) 2021-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2021-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
@@ -51,8 +51,8 @@ library_depends() {

 				unset prefix
 				for libdir in ${LIB_DIRS[@]}; do
-					if [[ ${libdir/*:} == ${libpath} ]]; then
-						prefix=${libdir/:*}
+					if [[ ${libdir#*:} == ${libpath} ]]; then
+						prefix=${libdir%%:*}
 					fi
 				done

--- a/scripts/libmakepkg/autodep/library_provides.sh.in
+++ b/scripts/libmakepkg/autodep/library_provides.sh.in
@@ -2,7 +2,7 @@
 #
 #   library_provides.sh - Automatically add a packages libraries to provides
 #
-#   Copyright (c) 2021-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2021-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
@@ -28,8 +28,8 @@ autodep_functions+=('library_provides')
 library_provides() {
 	if check_option "autodeps" "y"; then
 		for lib in ${LIB_DIRS[@]}; do
-			dir=${lib/*:}
-			prefix=${lib/:*}
+			dir=${lib#*:}
+			prefix=${lib%%:*}

 			if [[ ! -d "$pkgdir/$dir" ]]; then
 				continue;
--- a/scripts/libmakepkg/buildenv.sh.in
+++ b/scripts/libmakepkg/buildenv.sh.in
@@ -3,7 +3,7 @@
 #   buildenv.sh - functions for altering the build environment before
 #   compilation
 #
-#   Copyright (c) 2015-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2015-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/buildenv/buildflags.sh.in
+++ b/scripts/libmakepkg/buildenv/buildflags.sh.in
@@ -2,7 +2,7 @@
 #
 #   buildflags.sh - Clear user-specified buildflags if requested
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/buildenv/compiler.sh.in
+++ b/scripts/libmakepkg/buildenv/compiler.sh.in
@@ -4,7 +4,7 @@
 #   ccache - Cache compilations and reuse them to save time on repetitions
 #   distcc - Distribute compilation of C and C++ across machines
 #
-#   Copyright (c) 2007-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2007-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
@@ -44,8 +44,9 @@ buildenv_ccache() {
 buildenv_distcc() {
 	if check_buildoption "distcc" "y"; then
 		if (( using_ccache )); then
-			if [[ " $CCACHE_PREFIX " != *" distcc "* ]]; then
-				export CCACHE_PREFIX="${CCACHE_PREFIX:+$CCACHE_PREFIX }distcc"
+			local distcc=$(type -p distcc)
+			if [[ " $CCACHE_PREFIX " != *" ${distcc} "* ]]; then
+				export CCACHE_PREFIX="${CCACHE_PREFIX:+$CCACHE_PREFIX }${distcc}"
 			fi
 			export CCACHE_BASEDIR="$srcdir"
 		elif [[ -d /usr/lib/distcc/bin ]]; then
--- a/scripts/libmakepkg/buildenv/debugflags.sh.in
+++ b/scripts/libmakepkg/buildenv/debugflags.sh.in
@@ -3,7 +3,7 @@
 #   debugflags.sh - Specify flags for building a package with debugging
 #   symbols
 #
-#   Copyright (c) 2012-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2012-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/buildenv/fortran.sh.in
+++ b/scripts/libmakepkg/buildenv/fortran.sh.in
@@ -2,7 +2,7 @@
 #
 #   fortran.sh - Specify flags for building a package with Fortran
 #
-#   Copyright (c) 2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2024-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/buildenv/lto.sh.in
+++ b/scripts/libmakepkg/buildenv/lto.sh.in
@@ -3,7 +3,7 @@
 #   lto.sh - Specify flags for building a package with link-time
 #            optimisation
 #
-#   Copyright (c) 2021-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2021-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/buildenv/makeflags.sh.in
+++ b/scripts/libmakepkg/buildenv/makeflags.sh.in
@@ -2,7 +2,7 @@
 #
 #   makeflags.sh - Clear user-specified makeflags if requested
 #
-#   Copyright (c) 2007-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2007-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/buildenv/rust.sh.in
+++ b/scripts/libmakepkg/buildenv/rust.sh.in
@@ -2,7 +2,7 @@
 #
 #   rust.sh - Specify flags for building a package with rust
 #
-#   Copyright (c) 2022-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2022-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable.sh.in
+++ b/scripts/libmakepkg/executable.sh.in
@@ -2,7 +2,7 @@
 #
 #   executable.sh - confirm presence of dependent executables
 #
-#   Copyright (c) 2018-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2018-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/ccache.sh.in
+++ b/scripts/libmakepkg/executable/ccache.sh.in
@@ -2,7 +2,7 @@
 #
 #   ccache.sh - Confirm presence of ccache binary
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/checksum.sh.in
+++ b/scripts/libmakepkg/executable/checksum.sh.in
@@ -2,7 +2,7 @@
 #
 #   checksum.sh - Confirm presence of binaries for checksum operations
 #
-#   Copyright (c) 2016-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2016-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/debugedit.sh.in
+++ b/scripts/libmakepkg/executable/debugedit.sh.in
@@ -2,7 +2,7 @@
 #
 #   debugedit.sh - Confirm presence of debugedit binary
 #
-#   Copyright (c) 2022-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2022-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/distcc.sh.in
+++ b/scripts/libmakepkg/executable/distcc.sh.in
@@ -2,7 +2,7 @@
 #
 #   distcc.sh - Confirm presence of distcc binary
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/fakeroot.sh.in
+++ b/scripts/libmakepkg/executable/fakeroot.sh.in
@@ -2,7 +2,7 @@
 #
 #   fakeroot.sh - Confirm presence of fakeroot binary
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/gpg.sh.in
+++ b/scripts/libmakepkg/executable/gpg.sh.in
@@ -2,7 +2,7 @@
 #
 #   gpg.sh - Confirm presence of gpg binary
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/gzip.sh.in
+++ b/scripts/libmakepkg/executable/gzip.sh.in
@@ -2,7 +2,7 @@
 #
 #   gzip.sh - Confirm presence of gzip binary
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/pacman.sh.in
+++ b/scripts/libmakepkg/executable/pacman.sh.in
@@ -2,7 +2,7 @@
 #
 #   pacman.sh - Confirm presence of pacman binary
 #
-#   Copyright (c) 2012-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2012-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/strip.sh.in
+++ b/scripts/libmakepkg/executable/strip.sh.in
@@ -2,7 +2,7 @@
 #
 #   strip.sh - Confirm presence of strip binary
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/sudo.sh.in
+++ b/scripts/libmakepkg/executable/sudo.sh.in
@@ -2,7 +2,7 @@
 #
 #   sudo.sh - Confirm presence of sudo binary
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/executable/vcs.sh.in
+++ b/scripts/libmakepkg/executable/vcs.sh.in
@@ -2,7 +2,7 @@
 #
 #   vcs.sh - Confirm presence of binaries for VCS operations
 #
-#   Copyright (c) 2014-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2014-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/integrity.sh.in
+++ b/scripts/libmakepkg/integrity.sh.in
@@ -2,7 +2,7 @@
 #
 #   integrity.sh - functions relating to source integrity checking
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/integrity/generate_checksum.sh.in
+++ b/scripts/libmakepkg/integrity/generate_checksum.sh.in
@@ -2,7 +2,7 @@
 #
 #   generate_checksum.sh - functions for generating source checksums
 #
-#   Copyright (c) 2014-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2014-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/integrity/generate_signature.sh.in
+++ b/scripts/libmakepkg/integrity/generate_signature.sh.in
@@ -2,7 +2,7 @@
 #
 #   generate_signature.sh - functions for generating PGP signatures
 #
-#   Copyright (c) 2008-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2008-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/integrity/verify_checksum.sh.in
+++ b/scripts/libmakepkg/integrity/verify_checksum.sh.in
@@ -2,7 +2,7 @@
 #
 #   verify_checksum.sh - functions for checking source checksums
 #
-#   Copyright (c) 2014-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2014-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/integrity/verify_signature.sh.in
+++ b/scripts/libmakepkg/integrity/verify_signature.sh.in
@@ -2,7 +2,7 @@
 #
 #   verify_signature.sh - functions for checking PGP signatures
 #
-#   Copyright (c) 2011-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2011-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/lint_config.sh.in
+++ b/scripts/libmakepkg/lint_config.sh.in
@@ -2,7 +2,7 @@
 #
 #   lint_config.sh - functions for checking for makepkg.conf errors
 #
-#   Copyright (c) 2018-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2018-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/scripts/libmakepkg/lint_config/ext.sh.in
+++ b/scripts/libmakepkg/lint_config/ext.sh.in
@@ -2,7 +2,7 @@
 #
 #   ext.sh - Check that source/package extensions have valid prefixes
 #
-#   Copyright (c) 2019-2024 Pacman Development Team <pacman-dev@lists.archlinux.org>
+#   Copyright (c) 2019-2025 Pacman Development Team <pacman-dev@lists.archlinux.org>
 #
 #   This program is free software; you can redistribute it and/or modify
 #   it under the terms of the GNU General Public License as published by
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
morganamilo	3612510ee0	libalpm: add new errno for download initialization The error string "failed to retrieve some files" implies that the download may have begun and some files may have been partially downloaded. If we know no download actually took place we can be more clear about this.	2025-05-20 13:54:05 +01:00
morganamilo	a1ff7d8c72	libalpm: set errno and log when setting up temp download dir Before: % pacman -Syy :: Synchronising package databases... error: failed to synchronize all databases (unexpected error) After: % pacman -Syy :: Synchronising package databases... error: failed to create temporary download directory /var/lib/pacman/sync/download-P77oXs: Permission denied error: failed to synchronize all databases (failed to retrieve some files)	2025-05-20 13:54:01 +01:00
morganamilo	f6aa79c10a	libalpm: pass handle to alpm_temporary_download_dir_setup	2025-05-20 13:53:58 +01:00
morganamilo	3370dd586a	libalpm: don't chown download dir if not root Commit `7bc5d55b56` disbaled the chown after downloading if the current user is not root. It only makes sense for us to do the same on this side otherwise files would end up stuck as the download user. This is also important for other alpm tools that configure themselves via pacman.conf but download to user directories.	2025-05-20 13:53:45 +01:00
Rudy	af54cd4ee1	libmakepkg/tidy: give scripts a priority order This ensures (e.g.) that the "emptydirs" script runs last after unneeded files have been deleted. Fixes #184. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-05-17 13:20:16 +10:00
morganamilo	e392f01a94	libalpm: move sig files when download is unnamed	2025-05-17 12:03:42 +10:00
morganamilo	f722b86990	libalpm: return final final temp path in pkgurl When downloading unnamed files via alpm_fetch_pkgurl the returned path would point to the temp pkgcache instead of the final download location.	2025-05-17 12:03:42 +10:00
Aidan Epstein	4ddc642398	Add remove option for repo-remove to remove old package files. Also update documentation.	2025-05-17 10:43:58 +10:00
Allan McRae	53b1db84ef	Fix memory leak in download payload The file stream associated with downloads without a filename is not being freed when downloading using the sandbox user. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-05-17 10:40:09 +10:00
Allan McRae	571c13236f	pacman.8: document interaction between --cachedir and DownloadUser Note that the user provided in the DownloadUser configuration option (if set) needs to be able to access the directory specified with the --cachedir argument. Fixes #216. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-05-17 10:37:30 +10:00
Felix Yan	64299ccfbb	makepkg.sh: skip checking buildtime deps when runtime check already failed This could help locate the real failure (instead of scrolling through the whole possibly-successful buildtime dep installation section) and also saves time on the operation.	2025-05-09 08:55:42 +10:00
Allan McRae	692f7a2cfe	Do not overwrite default download user when option is unset Commit `7ccf316c` provided "root" (or the user name for UID 0) as a default download user. However, when DownloadUser is unset in pacman.conf, pacman was overwriting the default with null. Rectify this. Fixes #248 Signed-off-by: Allan McRae <allan@archlinux.org>	2025-05-08 21:49:56 +10:00
morganamilo	b104b95423	log and set errno when failing to rename download	2025-05-07 18:22:55 +10:00
Samuel Dionne-Riel	2bcdbc6a87	makepkg: Use sorted inputs for source tarballs too	2025-05-07 13:46:18 +10:00
Samuel Dionne-Riel	46f7f6e9ac	makepkg: Use SOURCE_DATE_EPOCH for more reproducible source tarballs	2025-05-07 13:46:07 +10:00
Patrick Northon	38394d54f0	repo-add: add --wait-for-lock option Using the --wait-for-lock option will result in repo-add retrying to acquire the database lock file after 3 seconds. If the option is not set, exit with code 2 on lock failure.	2025-05-07 12:23:45 +10:00
Allan McRae	267a0cc912	makepkg: ensure OPTIONS is not directly altered Signed-off-by: Allan McRae <allan@archlinux.org>	2025-05-06 17:04:32 +10:00
Allan McRae	d0c10a795e	Free memory on failure to create temporary directory Signed-off-by: Allan McRae <allan@archlinux.org>	2025-05-06 17:02:35 +10:00
Allan McRae	0d37c1daa0	Initialise callback event fields While the event is already globally initialised, initialising the fields prevents a valgrind warning (since the gcc-15 update). Signed-off-by: Allan McRae <allan@archlinux.org>	2025-05-06 17:00:06 +10:00
Diego Viola	24fc50269d	Fix typos	2025-05-04 21:42:34 +10:00
Rafael Fontenelle	08070e9abe	Update and improve translation-help.asciidoc	2025-05-04 20:13:44 +10:00
Allan McRae	f13d7d480c	Update copyright years ./build-aux/update-copyright 2024 2025 Signed-off-by: Allan McRae <allan@archlinux.org>	2025-04-02 11:35:34 +10:00
LevitatingBusinessMan (Rein Fernhout)	007261ade5	makepkg: do not fail if makepkg.conf.d is empty fixes #230	2025-03-22 05:23:23 +00:00
Jan Alexander Steffens (heftig)	bbe3f614b2	Update my .mailmap entry	2025-03-22 05:21:36 +00:00
Jan Alexander Steffens (heftig)	f07d547cf1	libmakepkg: Use only /etc/makepkg.d/gitconfig Globally set `GIT_CONFIG_GLOBAL` and `GIT_CONFIG_SYSTEM` so that we're only loading `/etc/makepkg.d/gitconfig` (if it exists) and no other Git config files. Allow injecting another value via `MAKEPKG_GIT_CONFIG`. Fixes: https://gitlab.archlinux.org/pacman/pacman/-/issues/193	2025-03-19 21:15:55 +01:00
Christian Heusel	34f09204fa	repo-add.8: Mention missing compression algorithms The manpage was lacking the database endings for various compression algorithms that one can validly use, therefore we add these to the list. Signed-off-by: Christian Heusel <christian@heusel.eu>	2025-03-02 14:55:57 +01:00
Allan McRae	0f6b4f4fab	autodeps: parse LIB_DIRS with more specificity Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-31 15:56:51 +10:00
Allan McRae	bc7b8e2eb2	lint_pkgbuild/arch: always perform some checks When using --ignorearch or options that imply it (e.g. --printsrcinfo), all checks of the arch array were skipped. Instead, perform all checks apart from confirming that the package can be built on that architecture. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-30 01:17:40 +00:00
Allan McRae	faea473550	Add a .gdb_index section before splitting debug info Using gdb-add-index to add a .gdb_index section before splitting debug info (together with enabling "maintenance set debuginfod download-sections" in GDB) can dramatically reduce the amount of data GDB has to download. Fixes #205. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-19 04:27:42 +00:00
Guoxin Pu	680169fb61	libmakepkg: set CCACHE_PREFIX to absolute path of distcc when using both The current logic sets CCACHE_PREFIX to distcc when both distcc and ccache are enabled. However, according to the source of ccache, it would execute the command with execv, which would not look up arg0 from PATH, unlike those exec functions with _p suffix. This would result in the following error, when building a package with both ccache and distcc enabled: ``` ccache: error: execute_noreturn of distcc failed: No such file or directory ``` This breaks package builds in different ways: packages that use make/cc directly would yield the actual error which is the same as the above line, packages that rely on other build systems wouldn't go through compiler check and complain on a bad compiler. To reproduce the problem, try to build a simple package: ``` git clone https://gitlab.archlinux.org/archlinux/packaging/packages/abc.git cd abc cp /etc/makepkg.conf . echo 'BUILDENV=(distcc color ccache check !sign)' >> makepkg.conf makepkg --config makepkg.conf ``` refs: `f887434d35/src/ccache/execute.cpp (L348)` https://man.archlinux.org/man/exec.3.en#v_-_execv(),_execvp(),_execvpe() Signed-off-by: Guoxin Pu <pugokushin@gmail.com>	2025-01-18 05:08:44 +00:00
Allan McRae	e767cf9a54	Detect repeated values in the arch array Repeated values in the arch array can result in architecture specific fields being repeated when using --printsrcinfo. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-16 23:14:22 +00:00
Allan McRae	e65b7d421c	Add accessor for handle->disable_dl_timeout Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-10 04:36:49 +00:00
Allan McRae	e6b3eb2570	Add accessor for handle->disable_sandbox Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-10 04:36:49 +00:00
Allan McRae	7ccf316ceb	Provide a default sandboxuser If sandboxuser is not set, pacman/libalpm does not handle moving incomplete download files out of the temporary download directories and into the cache. This leave download_XXXXXX directories in the cache that cause warnings on -Sc operations. Initialise the sandboxuser with the username of UID 0 (root on most systems). Fixes #209. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-09 12:14:25 +10:00
Allan McRae	ae603e35d7	pacman.conf.5: replace {sysconfdir} with /etc in code block Variable replacements are not performed on code blocks leaving the example Include usage with '{sysconfdir}/pacman.d/mirrorlist'. Replace this with '/etc' consistent with other example blocks in the man page. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-08 14:25:09 +10:00
Allan McRae	4908eed57d	Remove executable permissions from source file Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-08 03:08:18 +00:00
Allan McRae	286e776eda	lint_config: move PACKAGER check into its own function The check for the format of the PACKAGER variable did not align with the rest of the function where it was located. Move to its own function. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-08 03:06:37 +00:00
Allan McRae	cc87999d6d	lint_config: ensure NPROC is set to something usable We use NPROC for managing the number of parallel jobs to run, so it is essentially that this is a valid number. Add a lint pass, and move the setting of the default value to this location. Signed-off-by: Allan McRae <allan@archlinux.org>	2025-01-08 03:06:37 +00:00
Johan Förberg	425ff046ed	doc/BUILDINFO: Fix description of arrays Signed-off-by: Johan Förberg <johan@forberg.se>	2025-01-03 16:12:30 +01:00
Allan McRae	5f4c7e3ddc	libmakepkg: strip - disguard error messages when copying source files Parallel processing of file stripping is causing a TOC/TOU race when copying source files into the debug location resulting in error messages from cp. While hiding this error is not the ideal solution, it is currently the only one we have. Given this is a error of our own making, and we understand the cause and have determined there is zero actual downside to ignoring the error, we will accept this approach until something better is found. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-28 13:54:27 +00:00
Vasiliy Stelmachenok	02b35b9155	libmakepkg: strip - parallelize stripping of files Perform file stripping in parallel where possible. Hardlinks remain processed one at a time due to reproducibility issues. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-28 13:54:27 +00:00
Vasiliy Stelmachenok	dbde37aafb	libmakepkg: strip - split handling of hardlinks Handle singly and muptiply hard-linked files separately. Also collect information on hard linked files to avoid searching the entire package to check for hard links. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-28 13:54:27 +00:00
Allan McRae	0c136ecc8a	libmakepkg: strip - add "safe_" prefix to stripping functions Add a "safe_" prefix to strip_file() and strip_lto() to indicate that these functions are taking extra steps to ensure permissions remain unchanged. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-28 13:54:27 +00:00
Allan McRae	5e2a763e4a	libmakepkg: improve validity checking of arch array Only a subset of checks were being performed on the overridden arch arrays in package functions. Refactor checking such that all checks are perform on all arch arrays. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-20 14:21:32 +10:00
Diego Viola	62d3192126	makepkg.conf.5: fix typo	2024-12-18 05:24:40 +00:00
Allan McRae	3e557af72f	makepkg.conf: add NPROC configuration value Useful for controlling (future) parallel jobs within makepkg. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-12 13:31:36 +00:00
Allan McRae	fa7a9f748d	libmakepkg: remove python hashseed handling The decision to set the PYTHONHASHSEED variable and its value is outside the domain of makepkg and should be handled by a distribution. Move this file to the libalpm-dropins project. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-12 13:28:55 +00:00
Allan McRae	870eae26dc	makepkg: move SOURCE_DATE_EPOCH handling to libmakepkg Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-12 13:27:28 +00:00
Integral	cb940620bc	fix: make dependency cycle a debug message	2024-12-10 21:10:35 +08:00
Integral	dd55afad68	refactor: use c99 struct initializers to enhance readability	2024-12-10 10:18:40 +00:00
Allan McRae	775db50538	Remove pubkey_algo from alpm_pgpkey_t This field is no longer used and requires updating with gpgme changes. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-07 22:13:49 +10:00
Allan McRae	95a7d416ce	Do not identify the public key algorithm When the import key message was pushed to the pacman frontend, we no longer displayed the length or algorithm used for the key, sticking to just the user ID and the key ID. Remove this code given this field is no longer used, and the code requires updating for any now algorithm added. Note: removal of the field from the alpm_pgpkey_t will happen in a separate commit so that this commit can be readily backported. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-12-07 22:07:29 +10:00
Jan Alexander Steffens (heftig)	9154600490	strip: Treat bare object files like static libs, not shared libs Debug symbols should only be split from finally linked ELFs, not bare object files. We're already excluding static libraries from splitting for a similar reason. The `.gnu_debuglink` sections are also mishandled by LLVM's LLD, which copies them to its output. For example, this affects Arch Linux's `/usr/lib/Scrt1.o`. While we're here (and it changes the code less), also strip GNU LTO data from bare objects, again for the same reason we're removing it from static libraries, and apply static library stripping instead of shared library stripping. See: https://bugs.gentoo.org/787623	2024-11-27 19:50:57 +10:00
Jan Alexander Steffens (heftig)	e0162a6868	strip: Overwrite debuglink when it's already present When objcopy encounters an already-present section, adding the new debuglink will fail with a warning. Remove any existing `.gnu_debuglink` section to work around this problem. Arch Linux's `rust` package is affected by this. Apparently when LLVM's LLD links in `/usr/lib/Scrt1.o` it will also copy the `.gnu_debuglink` section. See: https://bugs.gentoo.org/787623	2024-11-27 19:50:46 +10:00
Allan McRae	71afd4d88f	libmakepkg - add wrapper function for objcopy Using objcopy can result in file permission changes. We work around this by using "cat" to copy the temporary output file into the target. Extract this code into a utility function. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-11-27 19:46:48 +10:00
Guillaume	a2d029388c	fix a segfault in sandbox.c if handle->dlcb is null	2024-09-28 08:10:46 +00:00
Jelle van der Waa	8a60361949	pactest: drop trailing spaces from README	2024-09-28 01:44:17 +00:00
Chih-Hsuan Yen	e80569f5da	Correctly configure landlock for older ABIs For example, with landlock ABI < 3, LANDLOCK_ACCESS_FS_TRUNCATE is not set in ruleset_attr.handled_access_fs, so it should not be set in path_beneath.allowed_access either. Otherwise, landlock_add_rule fails with -EINVAL, and pacman complains: > error: restricting filesystem access failed because the landlock rule for the temporary download directory could not be added! The change is tested on Debian Bookworm kernel linux-image-6.1.0-25-cloud-amd64 6.1.106-3.	2024-09-28 00:35:10 +00:00
Rafael Fontenelle	60ec268458	Add double colon for newline after MAKEPKG_LINT_PKGBUILD in makepkg.8.asciidoc	2024-09-25 15:11:51 -03:00
Allan McRae	7bc5d55b56	libalpm: only chown downloaded files when running as root Some libaplm utilities sync databases as a non-root user for use in actvities other than system updates. The ability to download as a non-root user was broken as part of the download sandboxing. Applying a minimial fix by preventing the chown of the downloaded file if the user is non-root. A larger change increasing the robustness and error checking of this path is warranted in the future. Signed-off-by: Allan McRae <allan@archlinux.org>	2024-09-08 11:49:21 +10:00